March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Compact annotation style
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: Compact annotation style ...................................................................... engine: Compact annotation style Remove redundant array declaration from compact annotation definitions, and add a checkstyle check to ensure this style is preserved. Change-Id: Ia0551fb98b7588cdb529bbc73c87082e82da6b36 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/startup/recovery/RecoveryStartupBean.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Cidr.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/MTU.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/Mask.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/SizeFromConfigValue.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidCluster.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidNetworkConfiguration.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/annotation/ValidTimeZone.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/Actionable.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsoleResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/Mapping.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Logged.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/VmPopupResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmInitWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AssignTagsPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ProviderSecretPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/user/ManageEventsPopupView.java 21 files changed, 22 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia0551fb98b7588cdb529bbc73c87082e82da6b36 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: JUnit annotation parenthesis
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: JUnit annotation parenthesis ...................................................................... core: JUnit annotation parenthesis Remove redundant, empty parenthesis. Change-Id: I0a46ed884b830a4eb68bf97c7d8cfbc78a041c55 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/macpool/MacPoolPerClusterTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/HostedEngineOvfWriterTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/CalculateBaseNicTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/FenceConfigValueHelperTest.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilterTest.java 6 files changed, 11 insertions(+), 11 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74436 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0a46ed884b830a4eb68bf97c7d8cfbc78a041c55 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: NlsCheck file name
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck file name ...................................................................... build: NlsCheck file name Use getFileContents().getFileName() instead of the deprecated getFileContents().getFilename(). Change-Id: I7b9a427c6e20a3c804a88c09ef351884f48f7bcf Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74435 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b9a427c6e20a3c804a88c09ef351884f48f7bcf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: NlsCheck boolean expression
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck boolean expression ...................................................................... build: NlsCheck boolean expression Use the boolean expression startAnnotation directly instead of comparing it to true, as per Java's best practices. Change-Id: I737b156c253e1f2ad5b5467130ac78936b85df7b Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74434 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I737b156c253e1f2ad5b5467130ac78936b85df7b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: NlsCheck variables' scope
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck variables' scope ...................................................................... build: NlsCheck variables' scope Reduce the variabels' scope to where they are actually needed to increase memory efficiency. Change-Id: I1a122503b4f4e3dd58941c799ab2054c55cc82cc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a122503b4f4e3dd58941c799ab2054c55cc82cc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Remove DiamondOperatorCheck#isSameTypeArgsInVariableDef
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: Remove DiamondOperatorCheck#isSameTypeArgsInVariableDef ...................................................................... build: Remove DiamondOperatorCheck#isSameTypeArgsInVariableDef isSameTypeArgsInVariableDef was part of DiamondOperatorCheck when it was adapted to the oVirt project, but the adaptation removed the usage of this method. It's thus redundant, and should just be removed, as this patch does. Change-Id: I519281ea361ca4f72178c8c052d5e1a7cbdf7d6a Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java 1 file changed, 0 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I519281ea361ca4f72178c8c052d5e1a7cbdf7d6a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: NlsCheck#patternString modifiers
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: NlsCheck#patternString modifiers ...................................................................... build: NlsCheck#patternString modifiers Declare the constant as private static final, as per Java's best practices. If Maven's Checkstyle plugin creates multiple instances of the checks it uses this change should also offer some performance improvement, as the various instances would share the same compiled pattern instead of having to compile it anew each time an instance is created. Change-Id: Id42b2db8ca8ccc6000ff24705c6d7b806fa1117f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id42b2db8ca8ccc6000ff24705c6d7b806fa1117f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Enforce CovariantEquals
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Enforce CovariantEquals ...................................................................... core: Enforce CovariantEquals Added the CovariantEquals check to future-proof the project against such mistakes. Change-Id: Ie7265f294bc27cf34c60638e9bc072c78109d322 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie7265f294bc27cf34c60638e9bc072c78109d322 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Unique Properties enforcement
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: Unique Properties enforcement ...................................................................... engine: Unique Properties enforcement This patch removes AbstractPropertiesTestBase#testDuplicateKeys() and instead uses Checkstyle'e UniqueProperties check to perform this validation. This approach has several benefits: - External code, no maintenance needed on our side - Improved performance, as Checkstyle will only load the file once, instead of each test reloading it as the current code does - No need to explicitly state this test for every properties file - checkstyle will automatically apply it to all files (as eveident, e.g., from the violation found in frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties) Change-Id: I32743f2032b525585b496ff689626c88b4ffb044 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/AbstractPropertiesTestBase.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/DuplicatePropertyException.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/NoDuplicateProperties.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 5 files changed, 1 insertion(+), 39 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I32743f2032b525585b496ff689626c88b4ffb044 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Enforce PackageDeclaration
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: Enforce PackageDeclaration ...................................................................... core: Enforce PackageDeclaration Added the PackageDeclaration to future-proof the project against such mistakes. Change-Id: Ic9b19f6af27ba1ea7748a3081de32ec783550932 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9b19f6af27ba1ea7748a3081de32ec783550932 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0