March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Use TypedData_Get_Struct
by Code Review 22 Mar '17

22 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use TypedData_Get_Struct ...................................................................... Use TypedData_Get_Struct The 'Data_Get_Struct' funtion has been deprecated in version 1.9 of Ruby, and replaced by the safer 'TypedData_Get_Struct'. This patch adapts the SDK to use that new function. Change-Id: I59a3ace09accfea5adcf879062fcbab0734a8d41 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit f39e9e833aa764e2f83cf87c90a2e6b6624520f5) --- M sdk/ext/ovirtsdk4c/ov_http_client.c M sdk/ext/ovirtsdk4c/ov_http_client.h M sdk/ext/ovirtsdk4c/ov_http_request.c M sdk/ext/ovirtsdk4c/ov_http_request.h M sdk/ext/ovirtsdk4c/ov_http_response.c M sdk/ext/ovirtsdk4c/ov_http_response.h M sdk/ext/ovirtsdk4c/ov_xml_reader.c M sdk/ext/ovirtsdk4c/ov_xml_reader.h M sdk/ext/ovirtsdk4c/ov_xml_writer.c M sdk/ext/ovirtsdk4c/ov_xml_writer.h 10 files changed, 497 insertions(+), 367 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59a3ace09accfea5adcf879062fcbab0734a8d41 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add import Glance image example
by Code Review 22 Mar '17

22 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add import Glance image example ...................................................................... Add import Glance image example This patch adds an example that shows how to create a new template from an image available in a Glance storage domain. Change-Id: Icd92a943750195f8ea5af68147e5affa1dc68838 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/import_glance_image.rb 1 file changed, 71 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74500 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd92a943750195f8ea5af68147e5affa1dc68838 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add asynchronous inventory example
by Code Review 22 Mar '17

22 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add asynchronous inventory example ...................................................................... Add asynchronous inventory example This patch adds an example that shows how to download a complete inventory of a large scale system, taking advantage of multiple connections and pipelining. Change-Id: I3af3eb9b0067881a5fb552077333ecea43475dda Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/asynchronous_inventory.rb 1 file changed, 192 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74241 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af3eb9b0067881a5fb552077333ecea43475dda Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add support for asynchronous requests
by Code Review 22 Mar '17

22 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add support for asynchronous requests ...................................................................... Add support for asynchronous requests This patch modifies the SDK so that it uses the 'multi' interface of the 'libcurl' library. This interface supports several advanced HTTP capabilities, like multiple connections and pipelining. The interface of the SDK is preserved, for backwards compatibility. The only new addition is a new 'wait' parameter, for all operations. The default value is 'true'. When the values is 'false' the operation is performed asynchronously, and a 'future' object is returned that can be used to retrieve the result later. For example: # Find the virtual machine and the service that manages it: vm = vms_service.list(search='name=myvm')[0] vm_service = vms_service.vm_service(vm.id) # Find the disk attachments, asynchronously: attachments_service = vm_service.disk_attachments_service attachments_future = attachments_service.list(wait: false) # Do some other tasks, for example sending some more asynchronous # requests, so that they are queued and potentially pipelined. # Later, wait for the result: attachments = attachments_future.wait # Print the details: attachments.each do |attachment| puts attachment.disk.id end Change-Id: I8b004247ea79357eae768535fb3caf871329daf8 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M generator/src/main/java/org/ovirt/sdk/ruby/RubyBuffer.java M generator/src/main/java/org/ovirt/sdk/ruby/RubyNames.java M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java M sdk/ext/ovirtsdk4c/ov_http_client.c M sdk/ext/ovirtsdk4c/ov_http_client.h A sdk/ext/ovirtsdk4c/ov_http_transfer.c A sdk/ext/ovirtsdk4c/ov_http_transfer.h A sdk/ext/ovirtsdk4c/ov_string.c A sdk/ext/ovirtsdk4c/ov_string.h M sdk/ext/ovirtsdk4c/ovirtsdk4c.c M sdk/lib/ovirtsdk4/connection.rb M sdk/lib/ovirtsdk4/probe.rb M sdk/lib/ovirtsdk4/service.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/connection_use_spec.rb M sdk/spec/service_spec.rb 16 files changed, 1,156 insertions(+), 635 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74088 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8b004247ea79357eae768535fb3caf871329daf8 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Use TypedData_Get_Struct
by Code Review 22 Mar '17

22 Mar '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use TypedData_Get_Struct ...................................................................... Use TypedData_Get_Struct The 'Data_Get_Struct' funtion has been deprecated in version 1.9 of Ruby, and replaced by the safer 'TypedData_Get_Struct'. This patch adapts the SDK to use that new function. Change-Id: I59a3ace09accfea5adcf879062fcbab0734a8d41 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/ext/ovirtsdk4c/ov_http_client.c M sdk/ext/ovirtsdk4c/ov_http_client.h M sdk/ext/ovirtsdk4c/ov_http_request.c M sdk/ext/ovirtsdk4c/ov_http_request.h M sdk/ext/ovirtsdk4c/ov_http_response.c M sdk/ext/ovirtsdk4c/ov_http_response.h M sdk/ext/ovirtsdk4c/ov_xml_reader.c M sdk/ext/ovirtsdk4c/ov_xml_reader.h M sdk/ext/ovirtsdk4c/ov_xml_writer.c M sdk/ext/ovirtsdk4c/ov_xml_writer.h 10 files changed, 497 insertions(+), 367 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74240 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59a3ace09accfea5adcf879062fcbab0734a8d41 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Extend AbstractCheck instead of Check
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: Extend AbstractCheck instead of Check ...................................................................... build: Extend AbstractCheck instead of Check Checkstyle 6.16 deprecated the Check class by hollowing it out and converting it to an empty extension of AbstractCheck. This patch consumes this change by making oVirt's checks extend AbstractCheck directly instead of extending the now deprecated Check. Change-Id: I4a6a986aeab11b04e495b00d747eb17a425b905b Related-To: https://bugzilla.redhat.com/1433408 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/DiamondOperatorCheck.java M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NlsCheck.java M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoArgConstructorCheck.java M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoFinalMemberCheck.java M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoMemberInitializationCheck.java 5 files changed, 10 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/74430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a6a986aeab11b04e495b00d747eb17a425b905b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Upgrade checkstyle version
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: build: Upgrade checkstyle version ...................................................................... build: Upgrade checkstyle version This patch upgrades Checkstyle and Maven Checkstyle Plugin the project uses to the latests versions (7.6 and 2.17, respectively). Since the project hasn't upgraded its Checkstyle version for quite some time (the previously used version was 6.8), this upgrade introduces some changes that are not backwards compatible and had to be fixed: - A suppression was added for all the checks on the generated sources, as we can't control their style anyway - A suppression was added for properties files which weren't analyzed with the previous checkstyle version - ScopeUtils was moved from com.puppycrawl.tools.checkstyle to com.puppycrawl.tools.checkstyle.utils - Its method inInterfaceOrAnnotationBlock was renamed to isInInterfaceOrAnnotationBlock Note that the Checkstyle 7 generation deprecated some classes and added some new abilities. Consuming these changes is NOT in the scope of this patch, and will be handled by the following patches in the series. Change-Id: I7eae4cbd726e67f3f1b3542208110d831f38a9b7 Bug-Url: https://bugzilla.redhat.com/1433408 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/extensions-api-root/pom.xml M build-tools-root/checkstyles/src/main/resources/checkstyle-suppressions.xml M build-tools-root/ovirt-checkstyle-extension/src/main/java/org/ovirt/checkstyle/checks/NoMemberInitializationCheck.java M pom.xml 4 files changed, 14 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Sandro Bonazzola: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, but someone else must approve Eyal Edri: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7eae4cbd726e67f3f1b3542208110d831f38a9b7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Disallow empty catch blocks
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: engine: Disallow empty catch blocks ...................................................................... engine: Disallow empty catch blocks Added the EmptyCatchBlock checkstyle check to complete the EmptyBlock check already have, and enforce the project's de-facto standard. Where there's really nothing intelligent to do with the exception, it can be named "ignore" to suppress this check. Change-Id: I558e11a90702668e69b17ed0ea6d9bbb99180fef Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddEventSubscriptionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/OVirtNodeUpgrade.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/StoragePoolStatusHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/AsyncTaskManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmRngDevice.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/pm/FenceProxySourceTypeHelperTest.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/utils/ReflectionHelper.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateUtils.java M backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/RegisterServlet.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFenceOptions.java M backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/StringValueConverter.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHD.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/SSHDialogTest.java M backend/manager/modules/uutils/src/test/java/org/ovirt/engine/core/uutils/ssh/TransferTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/searchbackend/DateUtils.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Configurator.java 21 files changed, 30 insertions(+), 27 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Martin Peřina: Looks good to me, but someone else must approve Ravi Nori: Looks good to me, but someone else must approve Martin Betak: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I558e11a90702668e69b17ed0ea6d9bbb99180fef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: restapi: Remove unused JAXBHelper
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: restapi: Remove unused JAXBHelper ...................................................................... restapi: Remove unused JAXBHelper Commit f47166 removed the last usage of the JAXBHelper class. Since it's no longer used, and there are no plans to use it in the foreseeable future, it should be removed. Change-Id: I9bfae0ffea9d6441d9d535836b9377cae97d29c6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/JAXBHelper.java 1 file changed, 0 insertions(+), 103 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Juan Hernandez: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bfae0ffea9d6441d9d535836b9377cae97d29c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: One annotation per line
by Code Review 22 Mar '17

22 Mar '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: core: One annotation per line ...................................................................... core: One annotation per line Apply the project's de-facto style of having a single annotation per line to all the places that violate this convention and add a checkstyle check to enforce it in order to give the codebase a more streamlined and coherent style. Change-Id: I368005329b9087caef97fad1df8672895f3231e3 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/ManageNetworkClustersCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/arquillian/database/DataSourceFactory.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/SchedulingManagerTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/ImportHostedEngineStorageDomainCommandTest.java M build-tools-root/checkstyles/src/main/resources/checkstyle.xml 8 files changed, 33 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, but someone else must approve Jakub Niedermertl: Looks good to me, but someone else must approve Martin Peřina: Looks good to me, approved Martin Sivák: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/74438 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I368005329b9087caef97fad1df8672895f3231e3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0