Change in ovirt-live[ovirt-live-4.1]: build: oVirt Live 4.1.1 rc3
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged.
Change subject: build: oVirt Live 4.1.1 rc3
......................................................................
build: oVirt Live 4.1.1 rc3
Change-Id: I1c62db286a9076d1b7449c91da2ca1e2fa271804
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved
Sandro Bonazzola: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74055
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1c62db286a9076d1b7449c91da2ca1e2fa271804
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Introducing SealVmTemplateCommand
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Introducing SealVmTemplateCommand
......................................................................
core: Introducing SealVmTemplateCommand
Added SealVmTemplateCommand to execute virt-sysprep on disks connected
to a VM. The command is intended to be run from AddVmTemplateCommand.
Added SealDisksVDSCommand that executes virt-sysprep over collection of
disk images.
virt-sysprep erases all host-specific configuration from the filesystem:
SSH keys, UDEV rules, MAC addresses, system ID, hostname etc., thus
making easy to use a VM as template without manual intervention.
Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1335642
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SealVmTemplateCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SealVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SealDisksVDSCommandParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SealDisksVDSCommand.java
10 files changed, 247 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/68096
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36361d552b02affa63c2f07e64e6e0bcb44187eb
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in jenkins[master]: dropping jobs from master publisher - first patch
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: dropping jobs from master publisher - first patch
......................................................................
dropping jobs from master publisher - first patch
Since there is not real priority for which
jobs we should start dropping, I just removed
all the non-standard CI jobs first.
Next we can target fedora builds and last
el7 ones.
Fixes: https://ovirt-jira.atlassian.net/browse/OVIRT-1073
Change-Id: Icec2cd87329a63f5dba25cebd7cc9aa5d23d4249
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/projects/ovirt/publish-rpms-nightly-master.yaml
1 file changed, 0 insertions(+), 41 deletions(-)
Approvals:
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icec2cd87329a63f5dba25cebd7cc9aa5d23d4249
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: cleanup: Remove commented-out code from AllocateVolumeVDSCom...
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: cleanup: Remove commented-out code from AllocateVolumeVDSCommand
......................................................................
cleanup: Remove commented-out code from AllocateVolumeVDSCommand
Change-Id: I59ae6a8cd9f21f093322281f531bd4c903db229a
Signed-off-by: Ala Hino <ahino(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/AllocateVolumeVDSCommand.java
1 file changed, 0 insertions(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Ala Hino: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/72969
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59ae6a8cd9f21f093322281f531bd4c903db229a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Introducing CreateAllTemplateDisksCommand
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: Introducing CreateAllTemplateDisksCommand
......................................................................
core: Introducing CreateAllTemplateDisksCommand
Adding CreateAllTemplateDisksCommand that creates all disks needed for
creating a template. This command is called from AddVmTemplateCommand
instead of calling CreateImageTemplateCommand and
CloneSingleCinderDiskCommand directly.
AddVmTemplateFromSnapshotCommand runs
CreateAllTemplateDisksFromSnapshotCommand for the same purpose.
CreateAllTemplateDisksCommand incorporates callback that is needed to
poll the child commands that create disk images. The callback in
AddVmTemplateCommand orchestrates the process of template creation,
including post-processing of template disk images, which will be added
in the next patches.
Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateFromSnapshotCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllTemplateDisksParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
6 files changed, 402 insertions(+), 149 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/69323
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc7e46df640a5ec0c0c7bc0e3f512e16d6969ae
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: getting rid of bothering static analysis reports.
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: getting rid of bothering static analysis reports.
......................................................................
core: getting rid of bothering static analysis reports.
Bug-Url: https://bugzilla.redhat.com/1408801
Change-Id: I364513025b7eef0f5c1cd025db976d54311f3a1a
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 19 insertions(+), 9 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70732
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I364513025b7eef0f5c1cd025db976d54311f3a1a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: removed unnecessary flag, extracted method
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: removed unnecessary flag, extracted method
......................................................................
core: removed unnecessary flag, extracted method
• flag plugOfAllMacsSucceeded was unneeded, it's value can be
calculated when needed. (also was wrong in principle, as it was set to
true before any plug happened)
• extracted method doing all replugs for better readability
Change-Id: I196be8190aa5e92d0a8e819d5462b6c3e9e483fe
Bug-Url: https://bugzilla.redhat.com/1408801
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java
1 file changed, 21 insertions(+), 18 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/70733
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I196be8190aa5e92d0a8e819d5462b6c3e9e483fe
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: removed indescriptive and incorrect message
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: removed indescriptive and incorrect message
......................................................................
core: removed indescriptive and incorrect message
• the message says: "The VM status must be Down or Up.", but that's
not correct, since more states are acceptable.
• current state is not reported
Change-Id: I9e4548d837d2a104024a74bf976bc5c28c87bd92
Bug-Url: https://bugzilla.redhat.com/1417217
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 7 insertions(+), 13 deletions(-)
Approvals:
Martin Mucha: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73590
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e4548d837d2a104024a74bf976bc5c28c87bd92
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: added states when nic can be activated or deactivated
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: added states when nic can be activated or deactivated
......................................................................
core: added states when nic can be activated or deactivated
add VMStatus.PoweringDown, VMStatus.PoweringUp as valid states for
ActivateDeactivateVmNicCommand.
added VmStatus.PoweringUP as valid state to call hotplug
Bug-Url: https://bugzilla.redhat.com/1417217
Change-Id: I6617bddfa2710241fc0c2458aa0fdf51a9be2ae1
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
1 file changed, 6 insertions(+), 3 deletions(-)
Approvals:
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73612
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6617bddfa2710241fc0c2458aa0fdf51a9be2ae1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Migration and host refreshes must not mingle
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: core: Migration and host refreshes must not mingle
......................................................................
core: Migration and host refreshes must not mingle
added locking to block possibility of 2 refreshes running at the same
time.
Bug-Url: https://bugzilla.redhat.com/1417217
Change-Id: I116a505cb23cae12b381ec11f54a722fea0117c0
Signed-off-by: Martin Mucha <mmucha(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/RefreshHostCommand.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Michael Burman: Verified
Martin Mucha: Verified
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73009
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I116a505cb23cae12b381ec11f54a722fea0117c0
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Michael Burman <mburman(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months