March 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 7
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 7 ...................................................................... webadmin,userportal: GWT/P upgrade, part 7 - fix pending FindBugs issues Change-Id: I5f73c385acc32e38bb82568a3e7df99b2d9e363b Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelTypeAheadListBox.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/AbstractHeader.java 2 files changed, 4 insertions(+), 14 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/73793 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f73c385acc32e38bb82568a3e7df99b2d9e363b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 2
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 2 ...................................................................... webadmin,userportal: GWT/P upgrade, part 2 - extract AOP stuff (DontPrune aspect) into separate gwt-aop module * gwt-extension now contains custom field serializers (for GWT RPC) and custom (super-sourced) Java classes, a.k.a "uioverrides" * gwt-aop now contains AOP tweaks for GWT compiler * this effectively fixes the "gwt-extension's META-INF/aop.xml gets applied twice during GWT compilation" problem - remove <gwt-maven-plugin.workingRefresh.version> * before: 2.6.1 for GWT compile + 2.4.0 (workingRefresh) for debug * after: use 2.8.0 for both GWT compile and debug * the issue was that gwt-maven-plugin didn't pick up file changes, if we face this issue again (with gwt-maven-plugin:2.8.0), we'll need to solve it in a way that does not involve downgrading the gwt-maven-plugin version - use <superDevMode>false</superDevMode> for GWT debug * this is because GWT 2.7+ makes Super Dev Mode the default debug method, while deprecating the Classic (Java IDE based) Dev Mode * for now, don't disrupt the existing GWT debug workflow - Classic Dev Mode remains the main debug method - Super Dev Mode remains the alternative debug method Change-Id: Ic3ae84779aa3b42aeafea2ebbaa7ebbcb1874d0c Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- A frontend/webadmin/modules/gwt-aop/pom.xml R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/AspectJLogHandler.java R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/DontPrune.java R frontend/webadmin/modules/gwt-aop/src/main/java/org/ovirt/engine/ui/gwtaop/JavaLoggingConfig.java R frontend/webadmin/modules/gwt-aop/src/main/resources/META-INF/aop.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M pom.xml 11 files changed, 51 insertions(+), 61 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/73550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic3ae84779aa3b42aeafea2ebbaa7ebbcb1874d0c Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 8
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 8 ...................................................................... webadmin,userportal: GWT/P upgrade, part 8 - tell GWT compiler not to handle CssResource generation using GSS (Closure Stylesheets) since we want to use standard tools like Less or Sass for better interoperability across different web applications Change-Id: I7cf17bf3396bfab3439ae1e1969efc3396f914aa Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Martin Betak: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/73902 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cf17bf3396bfab3439ae1e1969efc3396f914aa Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 1
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 1 ...................................................................... webadmin,userportal: GWT/P upgrade, part 1 - bump dependency versions in POM files * GWT 2.6.1 -> 2.8.0 * GWT-Platform 1.3.1 -> 1.6 * Guice (DI API) 3.0 -> 4.1.0 * GIN (DI impl) 2.1.2 (no change, no release activity since Nov 2013) Note: GWT-Platform POM effectively determines the versions to be used, including GWT, Guice and GIN. Above version changes therefore reflect what GWT-Platform (1.6) expects. - stop using GinUiBinder: 1, it's basically a hack (override of) GWT UiBinder generator 2, it's not part of GWT-Platform core classes anymore: https://github.com/ArcBees/gwtp-extensions/tree/master/ginuibinder 3, used by two classes, actually needed only by one (IconEditorWidget) 4, oVirt UI devs never got to using @Inject-capable widgets in .ui.xml Change-Id: I8fa315e1f54dca915cde3d3e6edf5055512f0f7a Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/gin/CommonGinUiBinderWidgets.java D frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ElementAwareDecoratedPopupPanel.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/IconEditorWidget.java M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/ClientGinjectorExtension.java D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/gin/UserPortalGinUiBinderWidgets.java M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ClientGinjectorExtension.java D frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/WebAdminGinUiBinderWidgets.java M pom.xml 13 files changed, 85 insertions(+), 160 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/73549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8fa315e1f54dca915cde3d3e6edf5055512f0f7a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 3
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 3 ...................................................................... webadmin,userportal: GWT/P upgrade, part 3 - remove "animal.sniffer.gwt.skip" property across all POM files * GWT 2.8+ supports Java 8 language syntax and expects the source level to be Java 8 by default * GWT 2.8+ has partial support of new Java 8 standard library APIs: http://www.gwtproject.org/release-notes.html#Release_Notes_2_8_0_RC1 * all Engine Maven modules are now Java 8 (src & target) compliant - in root POM, remove "animal-sniffer-maven-plugin:check" execution * no "animal.sniffer.gwt.skip" property means no need for this plugin - org.aspectj:{aspectjrt,aspectjweaver} version bumped to 1.8.10 - update GwtCommon.gwt.xml: * remove GWT log handlers that are disabled by default or got removed * with AOP stuff extracted into gwt-aop module, we no longer need to exclude gwt-extension Java classes from GIN class loading - remove redundant <encoding> config values in frontend modules POM Change-Id: Iaa91972ce41ef9daedb9e795973ee506aa44bc00 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/extensions-api-root/pom.xml M backend/manager/modules/searchbackend/pom.xml M frontend/pom.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/GwtCommon.gwt.xml M frontend/webadmin/modules/pom.xml M pom.xml 8 files changed, 34 insertions(+), 128 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified; Passed CI tests Objections: Jenkins CI: Failed CI tests -- To view, visit https://gerrit.ovirt.org/73551 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa91972ce41ef9daedb9e795973ee506aa44bc00 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin, userportal: GWT/P upgrade, part 9
by Code Review 15 Mar '17

15 Mar '17

>From Vojtech Szocs <vszocs(a)redhat.com>: Vojtech Szocs has submitted this change and it was merged. Change subject: webadmin,userportal: GWT/P upgrade, part 9 ...................................................................... webadmin,userportal: GWT/P upgrade, part 9 - update GWT debug config to reflect changes in GWT SDK tooling and consequently in gwt-maven-plugin configuration - Classic Dev Mode (debug as remote Java application) continues to be the default debug method for oVirt GWT UI - in "frontend" module, remove META-INF/gwt-super-dev.properties file and the associated gwt.superDev.* properties (not needed anymore since RpcRemoteOracleServlet.java got deleted) - moved "gwtsuperdev" mvn profile one level up so that we don't repeat its definition in leaf (actual application) GWT projects Change-Id: I6227a39e6b8ae2f71260486834e24b95fa4ef1db Related-To: https://gerrit.ovirt.org/#/c/50742/ Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M README.adoc M frontend/webadmin/modules/frontend/pom.xml D frontend/webadmin/modules/frontend/src/main/resources/META-INF/gwt-super-dev.properties M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml 8 files changed, 36 insertions(+), 78 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/74134 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6227a39e6b8ae2f71260486834e24b95fa4ef1db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[v2.1.z]: Add EngineMaybeAway state to wait before EngineUnexpectedlyD...
by Code Review 15 Mar '17

15 Mar '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Add EngineMaybeAway state to wait before EngineUnexpectedlyDown state ...................................................................... Add EngineMaybeAway state to wait before EngineUnexpectedlyDown state When the hosted engine VM is migrated quickly, the source agent will miss the migation process and switch to EngineUnexpetedlyDown state. This patch adds an intermediate state, EngineMaybeAway, which waits for the VM to appear on another host. If it does not appear in a certain time, it moves to EngineUnexpetedlyDown. Change-Id: I1a71997bf744666a9b2cb6dd926d034a945d76a0 Bug-Url: https://bugzilla.redhat.com/1419326 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 54 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/74153 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a71997bf744666a9b2cb6dd926d034a945d76a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: v2.1.z Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: Add EngineMaybeAway state to wait before EngineUnexpectedlyD...
by Code Review 15 Mar '17

15 Mar '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Add EngineMaybeAway state to wait before EngineUnexpectedlyDown state ...................................................................... Add EngineMaybeAway state to wait before EngineUnexpectedlyDown state When the hosted engine VM is migrated quickly, the source agent will miss the migation process and switch to EngineUnexpetedlyDown state. This patch adds an intermediate state, EngineMaybeAway, which waits for the VM to appear on another host. If it does not appear in a certain time, it moves to EngineUnexpetedlyDown. Change-Id: I1a71997bf744666a9b2cb6dd926d034a945d76a0 Bug-Url: https://bugzilla.redhat.com/1419326 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M ovirt_hosted_engine_ha/agent/constants.py.in M ovirt_hosted_engine_ha/agent/states.py 2 files changed, 54 insertions(+), 7 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/73863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a71997bf744666a9b2cb6dd926d034a945d76a0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-release: add check-patch for ppc64le
by Code Review 15 Mar '17

15 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: ovirt-release: add check-patch for ppc64le ...................................................................... ovirt-release: add check-patch for ppc64le Added check-patch on ppc64le for 4.1 and master on el7 Change-Id: I72f2f83590f5db218f0cce97bce554bee3e26ae6 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M jobs/confs/projects/ovirt-release/ovirt-release_standard.yaml 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I72f2f83590f5db218f0cce97bce554bee3e26ae6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: automation: Add check-patch.packages.fc25
by Code Review 15 Mar '17

15 Mar '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: automation: Add check-patch.packages.fc25 ...................................................................... automation: Add check-patch.packages.fc25 as a link to check-patch.packages.fc24. So that we run the isort check on master (which is fc25 only). Didn't check other implications. Change-Id: I1a584deb82546f11ab8c2630f35e1c5dad4b94ad Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- A automation/check-patch.packages.fc25 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/73999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a584deb82546f11ab8c2630f35e1c5dad4b94ad Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0