Change in jenkins[master]: remove emails from repo closure jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: remove emails from repo closure jobs
......................................................................
remove emails from repo closure jobs
Change-Id: If55e26eb5802639e3a881c5b6e24e1a2713278d1
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
M jobs/confs/yaml/templates/repos-check-closure.yaml
1 file changed, 0 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me; Ready for review
Eyal Edri: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73724
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If55e26eb5802639e3a881c5b6e24e1a2713278d1
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: packaging: spec: require newer ovirt-host-deploy
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: require newer ovirt-host-deploy
......................................................................
packaging: spec: require newer ovirt-host-deploy
Consume newer ovirt-host-deploy 1.6.3.
Change-Id: Ic1820141c81d6eeb40ccf9f97b9d6d152f354aca
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73680
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1820141c81d6eeb40ccf9f97b9d6d152f354aca
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Rafael Martins <rmartins(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Send direct LUN devices with virtio interface as disk
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Send direct LUN devices with virtio interface as disk
......................................................................
core: Send direct LUN devices with virtio interface as disk
Direct LUNs should only be sent with device="lun" when using virtio-scsi
when they are connected with virtio interface they should be sent with
device="disk" as all the other disks
Change-Id: I96e9604b69136e05b771aa54616810f7d1aee8db
Bug-Url: https://bugzilla.redhat.com/1410506
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
3 files changed, 2 insertions(+), 9 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/73391
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96e9604b69136e05b771aa54616810f7d1aee8db
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Tessun <mtessun(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: packaging: services: Detect JBoss version with log level info
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: services: Detect JBoss version with log level info
......................................................................
packaging: services: Detect JBoss version with log level info
Change-Id: If00a589dac2dd6669eed5982ce82f065f1787e6a
Bug-Url: https://bugzilla.redhat.com/1329119
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/services/ovirt-engine/ovirt-engine.py
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/73686
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If00a589dac2dd6669eed5982ce82f065f1787e6a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: engine: Hide tracebacks in engine.log for non responsive host
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: engine: Hide tracebacks in engine.log for non responsive host
......................................................................
engine: Hide tracebacks in engine.log for non responsive host
When host is unreachable there are
exceptions in the engine log.
Change-Id: If78f69334f5a94fd0f2a9c26aa30581d99fab5f9
Bug-Url: https://bugzilla.redhat.com/1414787
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/VdsDeployBase.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/HostMonitoring.java
2 files changed, 7 insertions(+), 13 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, but someone else must approve
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If78f69334f5a94fd0f2a9c26aa30581d99fab5f9
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: api: add auto_storage_select field to VmPoolMapper
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: api: add auto_storage_select field to VmPoolMapper
......................................................................
api: add auto_storage_select field to VmPoolMapper
'auto storage select' field indicate automatic and
balanced disk distribution for multiple storage.
Change-Id: I5f7407bd7883092ddb599c283ba3cc1a52055879
Bug-Url: https://bugzilla.redhat.com/1425493
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmPoolMapper.java
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73643
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7407bd7883092ddb599c283ba3cc1a52055879
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: Version bump
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: Version bump
......................................................................
Version bump
Bug-Url: https://bugzilla.redhat.com/1425725
Change-Id: Ib23e3ecf9ca4aefcc4fd2bef2bdf692e01e3a40e
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M ovirt-engine.spec.in
M pom.xml
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73619
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c9f9cf3d681beaafcdc203834520c243d094361
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: AbstractDiskModel - setDiskProfilesList()
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: AbstractDiskModel - setDiskProfilesList()
......................................................................
webadmin: AbstractDiskModel - setDiskProfilesList()
When setDiskProfilesList() is executed, the disk profile set on the disk
is considered when updating the disk profile list.
However, for disk models that doesn't represnt disk which were already
actually created the profile set in the model isn't the actual disk
profile - therefore if the domain is changed we can update it to the
newly selected domain profile and not consider it as set profile.
Change-Id: I24d357cdd324817834b8ee2902ec7d3c9add99b6
Bug-Url: https://bugzilla.redhat.com/1360355
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AbstractDiskModel.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73674
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24d357cdd324817834b8ee2902ec7d3c9add99b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: ui: fix few console fields to be greyed out for headless mode
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: ui: fix few console fields to be greyed out for headless mode
......................................................................
ui: fix few console fields to be greyed out for headless mode
when setting a VM / Template / Pool / Instance Type as headless, the
following fields are now greyed out (were not till now):
'Monitors' label
'Single Sign On method' label
In addition, the following fields:
USB Support
Monitors
Enable SPICE file transfer
Enable SPICE clipboard copy and paste
are all left greyed out for headless even when the OS is changed to "Linux"
or "Red Hat Enterprise Linux 6.x x64 (were changed to non greyed out
till this patch).
Change-Id: Ia7f93a77cced74529b3fe194ba8746750d6ef50b
Bug-Url: https://bugzilla.redhat.com/1425124
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
3 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
--
To view, visit https://gerrit.ovirt.org/73457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7f93a77cced74529b3fe194ba8746750d6ef50b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Don't wait for jobs to complete during shutdown
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Don't wait for jobs to complete during shutdown
......................................................................
core: Don't wait for jobs to complete during shutdown
When the user requests a shutdown of the engine with the 'systemctl stop
ovirt-engine' command, systemd sends a TERM signal to the service
start/stop script, which in turn sends it to the application server. The
application server then performs its shutdown process. This includes
undeployment of the data sources. When the data source used by the jobs
scheduler is undeployed and there are still jobs pending, they are
retried for ever, and they always fail because there is no longer data
source that they can use. This blocks the application server shutdown
process. The application server is later killed using the KILL signal,
by the start/stop script, after waiting 10 seconds. The net result is
that the engine is stopped anyhow, but systemd reports it as failed, and
some shutdown tasks may have been skipped, because the process was
blocked. To avoid that this patch changes the scheduler implementation
so that it doesn't wait for jobs to finish during shutdown.
Change-Id: I6fc474324d1dc8551933761c3b729d13243b323a
Bug-Url: https://bugzilla.redhat.com/1394617
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/SchedulerUtilBaseImpl.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Juan Hernandez: Verified
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fc474324d1dc8551933761c3b729d13243b323a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months