Change in ovirt-release[ovirt-4.0]: Enabling imgbase-config-vdsm unit
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Enabling imgbase-config-vdsm unit
......................................................................
Enabling imgbase-config-vdsm unit
Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1429594
Signed-off-by: Yuval Turgeman <yturgema(a)redhat.com>
---
M ovirt-release40.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-release[ovirt-4.1]: Enabling imgbase-config-vdsm unit
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Enabling imgbase-config-vdsm unit
......................................................................
Enabling imgbase-config-vdsm unit
Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1429288
Signed-off-by: Yuval Turgeman <yturgema(a)redhat.com>
---
M ovirt-release41.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73624
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: ovirt-4.1
Gerrit-Owner: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-release[master]: Enabling imgbase-config-vdsm unit
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Enabling imgbase-config-vdsm unit
......................................................................
Enabling imgbase-config-vdsm unit
Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1429288
Signed-off-by: Yuval Turgeman <yturgema(a)redhat.com>
---
M ovirt-release-master.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Passed CI tests
Yuval Turgeman: Verified
--
To view, visit https://gerrit.ovirt.org/73597
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff3b84fc8175eb37a876fb9186a6963bea3d4b3b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.5]: ha: fixing an old workaround
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: ha: fixing an old workaround
......................................................................
ha: fixing an old workaround
Change-Id: I6c1c685dbb1edd49e18a47fbb8e2c379dee0907e
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1420865
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/ovirt-host-common/hosted-engine/configureha.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73610
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c1c685dbb1edd49e18a47fbb8e2c379dee0907e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.5
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: ovirt-engine-phantomjs: configure jobs
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-engine-phantomjs: configure jobs
......................................................................
ovirt-engine-phantomjs: configure jobs
Change-Id: Id526ebdef6ee14fd482860e380ecccd2a2e95c03
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
A jobs/confs/projects/ovirt-engine-phantomjs/ovirt-engine-phantomjs_standard.yaml
A jobs/confs/yaml/scms/ovirt-engine-phantomjs.yaml
2 files changed, 41 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Juan Hernandez: Looks good to me
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73547
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id526ebdef6ee14fd482860e380ecccd2a2e95c03
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Pavel Zhukov <pzhukov(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: core: CloneImageGroupVolumesStructure - determineSourceImage...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: CloneImageGroupVolumesStructure - determineSourceImageGroup()
......................................................................
core: CloneImageGroupVolumesStructure - determineSourceImageGroup()
determineSourceImageGroup() is used to determine the source image group
(which may differ between the first volume and the rest of the volume
chain in case the disk is based on a template).
The method had two issues:
1. It returned the image id instead of the disk id.
2. It used image.getImageTemplateId() to determine if the disk is based
on template. When disk snapshots are created their image template id
field is copied from the parent volume, which means that all the chain
has the same value in tht field - only the first volume needs to be
created as based on the template disk. This patch changes the check to
use the template disk id only when the template volume is the parent of
the volume by checking that getParentId() equals to
getImageTemplateId().
Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a
Bug-Url: https://bugzilla.redhat.com/1429184
Bug-Url: https://bugzilla.redhat.com/1429170
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/73595
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in jenkins[master]: ovirt-wgt: Built master only on fc25
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: ovirt-wgt: Built master only on fc25
......................................................................
ovirt-wgt: Built master only on fc25
Change-Id: Ie6d64632d8ab46942a2cb28a97d963e700ae0ea2
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M jobs/confs/projects/ovirt-wgt/ovirt-wgt_create-rpms.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/73598
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie6d64632d8ab46942a2cb28a97d963e700ae0ea2
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: Allow memory over commitment only if ksm or ballooning...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: core: Allow memory over commitment only if ksm or ballooning are available
......................................................................
core: Allow memory over commitment only if ksm or ballooning are available
Currently we allow memory over commitment even if nothing can
support it on a host (no ksm and no ballooning).
This patch adds verification for that issue so an error is raised
if the configuration is wrong.
Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75
Bug-Url: https://bugzilla.redhat.com/1402838
Signed-off-by: Jenny Tokar <jtokar(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/ClusterValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateClusterCommandTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
A packaging/dbscripts/upgrade/04_02_0180_disable_cluster_over_commitment_if_no_ksm_or_balloning_enabled.sql
11 files changed, 87 insertions(+), 3 deletions(-)
Approvals:
Martin Sivák: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I912285e8d8cd1d55cf58b14bf04f7d2e8bb84e75
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[master]: core: CloneImageGroupVolumesStructure - determineSourceImage...
by Code Review
>From Liron Aravot <laravot(a)redhat.com>:
Liron Aravot has submitted this change and it was merged.
Change subject: core: CloneImageGroupVolumesStructure - determineSourceImageGroup()
......................................................................
core: CloneImageGroupVolumesStructure - determineSourceImageGroup()
determineSourceImageGroup() is used to determine the source image group
(which may differ between the first volume and the rest of the volume
chain in case the disk is based on a template).
The method had two issues:
1. It returned the image id instead of the disk id.
2. It used image.getImageTemplateId() to determine if the disk is based
on template. When disk snapshots are created their image template id
field is copied from the parent volume, which means that all the chain
has the same value in tht field - only the first volume needs to be
created as based on the template disk. This patch changes the check to
use the template disk id only when the template volume is the parent of
the volume by checking that getParentId() equals to
getImageTemplateId().
Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a
Bug-Url: https://bugzilla.redhat.com/1429184
Bug-Url: https://bugzilla.redhat.com/1429170
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CloneImageGroupVolumesStructureCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73587
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf5f6cac89846865bb36e07507390e1a9b21e99a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: detect file read error during upload
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: detect file read error during upload
......................................................................
webadmin: detect file read error during upload
Pause image upload upon detecting file read error
(e.g. file was deleted during upload).
Change-Id: Iefb9cbe60b8b71ae10cfe272093f9eec8f88be69
Bug-Url: https://bugzilla.redhat.com/1365237
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/UploadImageModel.java
3 files changed, 20 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73586
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iefb9cbe60b8b71ae10cfe272093f9eec8f88be69
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 4 months