April 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove redundant init of QCOW compat in import.
by Code Review 05 Apr '17

05 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Remove redundant init of QCOW compat in import. ...................................................................... core: Remove redundant init of QCOW compat in import. Since setQcowCompat is now being done in copyImageGroup, there is no need for setting qcow compat in import command. Change-Id: I6628061ad8ff7b53d73e31300c0d883f871f1f25 Bug-Url: https://bugzilla.redhat.com/1438252 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmTemplateCommand.java 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/75021 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6628061ad8ff7b53d73e31300c0d883f871f1f25 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Support qcow2 compat on live move.
by Code Review 05 Apr '17

05 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Support qcow2 compat on live move. ...................................................................... core: Support qcow2 compat on live move. Set qcow2 compat version on live move. Change-Id: Ic89dce0263180ac85179642b6add63fffaceb62a Bug-Url: https://bugzilla.redhat.com/1438252 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/75067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic89dce0263180ac85179642b6add63fffaceb62a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add try catch block on teardown in images handler.
by Code Review 05 Apr '17

05 Apr '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add try catch block on teardown in images handler. ...................................................................... core: Add try catch block on teardown in images handler. Add try/catch block when calling teardown for image. The engine can still use the data fetched from VDSM even if the teardown fails to execute. Change-Id: I439334241f3156492d17e76dbfb4f2d33109367a Bug-Url: https://bugzilla.redhat.com/1438252 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/75065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I439334241f3156492d17e76dbfb4f2d33109367a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: drop qmeu master merged job
by Code Review 05 Apr '17

05 Apr '17

>From Eyal Edri <eedri(a)redhat.com>: Eyal Edri has submitted this change and it was merged. Change subject: drop qmeu master merged job ...................................................................... drop qmeu master merged job we don't publish qemu-kvm anymore from ovirt repos. Instead we use the centos virt repo. Change-Id: Ief37543be7bc7935b64b6b557e130ad7d14dd4b7 Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M jobs/confs/projects/qemu/qemu_create-rpms.yaml 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Eyal Edri: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief37543be7bc7935b64b6b557e130ad7d14dd4b7 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: fix wrong selection of emulated machine
by Code Review 05 Apr '17

05 Apr '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: fix wrong selection of emulated machine ...................................................................... core: fix wrong selection of emulated machine If the VM is set with custom compatibility version and the cluster's emulated machine is contained within the supported emulated machines for that compatibility version, a different value for the emulated machine will be selected which may prevent the VM from starting. Change-Id: Ib15914c468ad0e2bcaba5bf2916f0a3039a8f342 Bug-Url: https://bugzilla.redhat.com/1436325 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 2 files changed, 35 insertions(+), 8 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Shahar Havivi: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75043 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib15914c468ad0e2bcaba5bf2916f0a3039a8f342 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in otopi[master]: core: log: Add time zone to log records
by Code Review 05 Apr '17

05 Apr '17

>From Yedidyah Bar David <didi(a)redhat.com>: Yedidyah Bar David has submitted this change and it was merged. Change subject: core: log: Add time zone to log records ...................................................................... core: log: Add time zone to log records Change-Id: I41863d0193d34f1a3a328fb8ad3a9e9f0caad70a Bug-Url: https://bugzilla.redhat.com/1411100 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M otopi.spec.in M src/plugins/otopi/core/log.py 2 files changed, 59 insertions(+), 1 deletion(-) Approvals: Lev Veyde: Looks good to me, but someone else must approve Sandro Bonazzola: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Yedidyah Bar David: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/70025 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41863d0193d34f1a3a328fb8ad3a9e9f0caad70a Gerrit-PatchSet: 2 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-ha[master]: env: Added a comment to vm.conf when refreshed
by Code Review 04 Apr '17

04 Apr '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: env: Added a comment to vm.conf when refreshed ...................................................................... env: Added a comment to vm.conf when refreshed Change-Id: Ie84f5cf9d778730255a4aedc20e1b639bb3b1c5a Bug-Url: https://bugzilla.redhat.com/1379250 Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com> --- M ovirt_hosted_engine_ha/env/config.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Ido Rosenzwig: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75123 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie84f5cf9d778730255a4aedc20e1b639bb3b1c5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Add fluent-plugin-collectd-nest and rubygem-fluent-plu...
by Code Review 04 Apr '17

04 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: core: Add fluent-plugin-collectd-nest and rubygem-fluent-plugin-viaq_data_model ...................................................................... core: Add fluent-plugin-collectd-nest and rubygem-fluent-plugin-viaq_data_model fluent-plugin-collectd-nest and rubygem-fluent-plugin-viaq_data_model packages were added to the list of upgraded packages. The plugins are needed for metrics collection. Change-Id: Ie75f6efccd07e70a231f3a21eaf3001b225d922b Bug-Url: https://bugzilla.redhat.com/1426901 Bug-Url: https://bugzilla.redhat.com/1426902 Signed-off-by: Irit Goihman <igoihman(a)redhat.com> --- M packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Shirly Radco: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Irit Goihman: Verified -- To view, visit https://gerrit.ovirt.org/74076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie75f6efccd07e70a231f3a21eaf3001b225d922b Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Sso registration tool should create output dir
by Code Review 04 Apr '17

04 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Sso registration tool should create output dir ...................................................................... aaa: Sso registration tool should create output dir Sso registration tool should create the output directory if it does not exist. The output temp directory is used by the tool to write the conf file with client id and client secret. Bug-Url: https://bugzilla.redhat.com/1416491 Change-Id: I5a7c06bb38cce626aba46db9d455d508e5473d21 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/sso-client-registration-tool/src/main/java/org/ovirt/engine/ssoreg/core/SsoRegistrationToolExecutor.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/75152 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a7c06bb38cce626aba46db9d455d508e5473d21 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: aaa: Add support for OpenId Connect auth
by Code Review 04 Apr '17

04 Apr '17

>From Martin Peřina <mperina(a)redhat.com>: Martin Peřina has submitted this change and it was merged. Change subject: aaa: Add support for OpenId Connect auth ...................................................................... aaa: Add support for OpenId Connect auth SSO does not currently support OpenId Connect which causes issues with integration with openshift. Openshift needs id_token for user identification as defined by OpenId Connect. Change-Id: I68f055c6d8880f8178cff02398734c6180a99715 Bug-Url: https://bugzilla.redhat.com/1416491 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/dependencies/common/pom.xml A backend/manager/dependencies/common/src/main/modules/com/nimbusds/main/module.xml A backend/manager/dependencies/common/src/main/modules/net/minidev/main/module.xml M backend/manager/modules/enginesso/pom.xml M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthAuthorizeServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/OAuthTokenServlet.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoConstants.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoSession.java M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/SsoUtils.java M ear/src/main/application/META-INF/jboss-deployment-structure.xml A packaging/dbscripts/upgrade/04_02_0210_add_openid_scope_to_sso_clients.sql M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/sso.py M pom.xml 13 files changed, 140 insertions(+), 2 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Ravi Nori: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71200 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68f055c6d8880f8178cff02398734c6180a99715 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0