Change in ovirt-engine[master]: core: NPE when sparsifying a non-attached disk
by Code Review
>From Shahar Havivi <shavivi(a)redhat.com>:
Shahar Havivi has submitted this change and it was merged.
Change subject: core: NPE when sparsifying a non-attached disk
......................................................................
core: NPE when sparsifying a non-attached disk
Fix an NPE that occured when SparsifyImageCommand is called on a disk
that is not attached to any VM.
Change-Id: Ia77ff88be9705ecce5080769bbf29861c4a89d4d
Bug-Url: https://bugzilla.redhat.com/1431596
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/SparsifyImageCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Looks good to me, approved
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
--
To view, visit https://gerrit.ovirt.org/74843
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia77ff88be9705ecce5080769bbf29861c4a89d4d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1.1.z]: core: ImagesHandler - computeCowImageNeededSize()
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: ImagesHandler - computeCowImageNeededSize()
......................................................................
core: ImagesHandler - computeCowImageNeededSize()
When vdsm creates a COW volume with provided initial size the size is
multiplied by 1.1 to prevent a case in which we won't have enough space.
If the source is already COW we don't need the additional space.
determineImageInitialSize() is used to calculate the initial size
and in case that source/dest are both COW divides the space by 1.1 as we
know that the source used space already includes the COW header.
in change I9358478d9f the check for the source image format was
mistakenly removed, leading to that even if the source image format is
RAW we'll divide the initial size by 1.1. As some of the space is used
by the QCOW header we may fail during the copy as we run out of space.
Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Bug-Url: https://bugzilla.redhat.com/1438260
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75098
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1.1.z
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: core: ImagesHandler - computeCowImageNeededSize()
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: ImagesHandler - computeCowImageNeededSize()
......................................................................
core: ImagesHandler - computeCowImageNeededSize()
When vdsm creates a COW volume with provided initial size the size is
multiplied by 1.1 to prevent a case in which we won't have enough space.
If the source is already COW we don't need the additional space.
determineImageInitialSize() is used to calculate the initial size
and in case that source/dest are both COW divides the space by 1.1 as we
know that the source used space already includes the COW header.
in change I9358478d9f the check for the source image format was
mistakenly removed, leading to that even if the source image format is
RAW we'll divide the initial size by 1.1. As some of the space is used
by the QCOW header we may fail during the copy as we run out of space.
Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Bug-Url: https://bugzilla.redhat.com/1438260
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/75097
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
7 years
Change in ovirt-engine[master]: core: ImagesHandler - computeCowImageNeededSize()
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: ImagesHandler - computeCowImageNeededSize()
......................................................................
core: ImagesHandler - computeCowImageNeededSize()
When vdsm creates a COW volume with provided initial size the size is
multiplied by 1.1 to prevent a case in which we won't have enough space.
If the source is already COW we don't need the additional space.
determineImageInitialSize() is used to calculate the initial size
and in case that source/dest are both COW divides the space by 1.1 as we
know that the source used space already includes the COW header.
in change I9358478d9f the check for the source image format was
mistakenly removed, leading to that even if the source image format is
RAW we'll divide the initial size by 1.1. As some of the space is used
by the QCOW header we may fail during the copy as we run out of space.
Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Bug-Url: https://bugzilla.redhat.com/1438260
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 10 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/75022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I54923ca1526c39ee793270c28ace6402a558b04a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: packaging: setup: Change package listing when displaying new...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Change package listing when displaying new packages.
......................................................................
packaging: setup: Change package listing when displaying new packages.
Change-Id: I30a3526eb29fd91fbadff5bd238fe93b67aa0c07
Bug-Url: https://bugzilla.redhat.com/1237132
Signed-off-by: Ido Rosenzwig <irosenzw(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-common/distro-rpm/packages.py
1 file changed, 29 insertions(+), 12 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Ido Rosenzwig: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/74559
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I30a3526eb29fd91fbadff5bd238fe93b67aa0c07
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Lukas Svaty
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: packaging: pythonlib: mem.py: Add M unit
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: pythonlib: mem.py: Add M unit
......................................................................
packaging: pythonlib: mem.py: Add M unit
Bug-Url: https://bugzilla.redhat.com/1329119
Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/pythonlib/ovirt_engine/mem.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/75085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: userportal: replace vm actions Composite with separate columns
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: userportal: replace vm actions Composite with separate columns
......................................................................
userportal: replace vm actions Composite with separate columns
In the extended view VM grid, replace vm action Composite with
five separate columns. Additionally, replace the old image-based
icons with new font-awesome versions.
Also reworked the ButtonCell classes to be a little cleaner.
Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd
Bug-Url: https://bugzilla.redhat.com/1413899
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractButtonCell.java
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractIconButtonCell.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java
D frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/table/cell/VmButtonsImageButtonCell.java
M packaging/branding/ovirt.brand/ovirt.css
5 files changed, 209 insertions(+), 152 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Verified
--
To view, visit https://gerrit.ovirt.org/74989
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb36934062b105d66a88dd75af22aadd46c5fcdd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: packaging: Fixing incorrect db update for new provider
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Fixing incorrect db update for new provider
......................................................................
packaging: Fixing incorrect db update for new provider
Change-Id: I323fdb1c11070cb6e6f589c2413b3ac99e986dbb
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1436154
Bug-Url: https://bugzilla.redhat.com/1438467
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
1 file changed, 10 insertions(+), 10 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Marcin Mirecki: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74968
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I323fdb1c11070cb6e6f589c2413b3ac99e986dbb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[master]: packaging: pythonlib: mem.py: Add M unit
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: pythonlib: mem.py: Add M unit
......................................................................
packaging: pythonlib: mem.py: Add M unit
Bug-Url: https://bugzilla.redhat.com/1329119
Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/pythonlib/ovirt_engine/mem.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/75080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I206fe363a18efd821139b258e790f48db6a5bed3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in jenkins[master]: jenkins standard publisher: export nosetests*.xml junit reports
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged.
Change subject: jenkins standard publisher: export nosetests*.xml junit reports
......................................................................
jenkins standard publisher: export nosetests*.xml junit reports
Change-Id: I7bc72602af0d6ef8ff75233794fafeaa4684c0e7
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/yaml/publishers/standard.yaml
M jobs/confs/yaml/publishers/system_tests_publishers.yaml
2 files changed, 13 insertions(+), 5 deletions(-)
Approvals:
Nadav Goldin: Looks good to me
Eyal Edri: Looks good to me, approved; Ready for merge
Daniel Belenky: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/74896
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7bc72602af0d6ef8ff75233794fafeaa4684c0e7
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
7 years