Change in ovirt-engine[master]: engine: Adding commands for network filter parameters
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged.
Change subject: engine: Adding commands for network filter parameters
......................................................................
engine: Adding commands for network filter parameters
To manage parameters for libvirt's network filters,
commands to add, get, update and remove network filter parameters
are added.
Change-Id: I32e4626acb9da7be6568237db27a999648e7eec4
Bug-Url: https://bugzilla.redhat.com/1366905
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmNicFilterParameterCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmNicFilterParameterCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmNicFilterParameterCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmNicFilterParameterValidator.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/AddVmNicFilterParameterCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/RemoveVmNicFilterParameterCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/UpdateVmNicFilterParameterCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/VmNicFilterParameterCommandTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/vm/mac/VmNicFilterParameterAnnotationTest.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicFilterParameterValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmNicFilterParameterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmNicFilterParameterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VmNicFilterParameter.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
24 files changed, 838 insertions(+), 2 deletions(-)
Approvals:
Dominik Holler: Verified
Martin Mucha: Looks good to me, but someone else must approve
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/68448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32e4626acb9da7be6568237db27a999648e7eec4
Gerrit-PatchSet: 36
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: text: Add a trailing space to prompts
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: text: Add a trailing space to prompts
......................................................................
packaging: text: Add a trailing space to prompts
Change-Id: Ic5c6eff7fd0ac4047803920fd2b7e912a738444f
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/notifier.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/configuration.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/76945
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5c6eff7fd0ac4047803920fd2b7e912a738444f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: ErrataData#serialVersionUID
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ErrataData#serialVersionUID
......................................................................
core: ErrataData#serialVersionUID
Generate the missing serialVersionUID for this Serializable class.
Change-Id: I0112d781bf83ab86d93e64705d69a4d0294aecd3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ErrataData.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77273
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0112d781bf83ab86d93e64705d69a4d0294aecd3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: ErrataData type inference
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged.
Change subject: core: ErrataData type inference
......................................................................
core: ErrataData type inference
Change-Id: If0bd3a3fd9c6be1ec32fd8974b1e1eb15f7748e3
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ErrataData.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0bd3a3fd9c6be1ec32fd8974b1e1eb15f7748e3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: core: fix the adjustment of ha vms at restore time
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: fix the adjustment of ha vms at restore time
......................................................................
core: fix the adjustment of ha vms at restore time
When restoring a backup of the database, the adjustment of highly-available
VMs should also clear the run_on_vds and migrating_to_vds fields.
Change-Id: Ib4f7715ec97459efdf25023b91320ed50851ffe9
Bug-Url: https://bugzilla.redhat.com/1446055
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Lev Veyde: Looks good to me, but someone else must approve
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/76867
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4f7715ec97459efdf25023b91320ed50851ffe9
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: storage: call disconnectStorageServer on the bootstrap SD
by Code Review
>From Simone Tiraboschi <stirabos(a)redhat.com>:
Simone Tiraboschi has submitted this change and it was merged.
Change subject: storage: call disconnectStorageServer on the bootstrap SD
......................................................................
storage: call disconnectStorageServer on the bootstrap SD
The bootstrap SD is created just to be used as the master
storage domain to boostrap the hosted-engine VM using
a temporary loopback mounted file.
We were removing the loopback device and removing its file
but we weren't calling disconnectStorageServer to
cleanly unmout it resulting in a temporary (till
reboot) leftover mount point.
Change-Id: Ida4469a9059bc17d3af821f6003ad9dfb28aad43
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1449565
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-setup/storage/storage.py
1 file changed, 22 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, but someone else must approve
Simone Tiraboschi: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77278
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida4469a9059bc17d3af821f6003ad9dfb28aad43
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-hosted-engine-setup[master]: storage: call disconnectStorageServer on the bootstrap SD
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: storage: call disconnectStorageServer on the bootstrap SD
......................................................................
storage: call disconnectStorageServer on the bootstrap SD
The bootstrap SD is created just to be used as the master
storage domain to boostrap the hosted-engine VM using
a temporary loopback mounted file.
We were removing the loopback device and removing its file
but we weren't calling disconnectStorageServer to
cleanly unmout it resulting in a temporary (till
reboot) leftover mount point.
Change-Id: Ida4469a9059bc17d3af821f6003ad9dfb28aad43
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1449565
Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com>
---
M src/plugins/gr-he-setup/storage/storage.py
1 file changed, 22 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Simone Tiraboschi: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77256
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ida4469a9059bc17d3af821f6003ad9dfb28aad43
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[master]: unpackAndPrepareDump: fix typo postgress
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: unpackAndPrepareDump: fix typo postgress
......................................................................
unpackAndPrepareDump: fix typo postgress
Change-Id: I462faa761d8a1e3d632c79968d518a0f2c8b3675
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/unpackAndPrepareDump.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I462faa761d8a1e3d632c79968d518a0f2c8b3675
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: engine-backup: Do not restore packaged pki files
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: engine-backup: Do not restore packaged pki files
......................................................................
packaging: engine-backup: Do not restore packaged pki files
We recently added to cert.template.in stuff to allow adding
SubjectAltName. If engine-backup --mode=restore restores a previous
version's file, engine-setup will fail.
While doing that, add two other files that are packaged and should not
be restored.
Bug-Url: https://bugzilla.redhat.com/1452182
Change-Id: I1fb21e85a4d2b7f0c85807702ecbb72cbe7a6238
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/bin/engine-backup.sh.in
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/76982
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1fb21e85a4d2b7f0c85807702ecbb72cbe7a6238
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[master]: core: added --time-only option
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: core: added --time-only option
......................................................................
core: added --time-only option
Added --time-only option to gather time drift between the engine
and all the specified hosts.
Change-Id: Ie685f55b430d1c077bba51fab86445561c37024b
Bug-Url: https://bugzilla.redhat.com/1404509
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
M src/ovirt-log-collector.8
2 files changed, 47 insertions(+), 32 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved
Yuval Turgeman: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77259
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie685f55b430d1c077bba51fab86445561c37024b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months