Change in jenkins[master]: Default values for 'arch' and 'distro' in STD-CI
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Default values for 'arch' and 'distro' in STD-CI
......................................................................
Default values for 'arch' and 'distro' in STD-CI
Turns out some projects forget to set these in the project YAML, so we
need to set defaults so things behave in an expected manner.
Change-Id: I7e85b19f2f0f7fd0d116757e8cafe7e952eeaa1b
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1398
---
M jobs/confs/projects/defaults.yaml
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved
Barak Korren: Verified; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77145
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e85b19f2f0f7fd0d116757e8cafe7e952eeaa1b
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years
Change in ovirt-engine[master]: engine: remove snapshots table constraints
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: engine: remove snapshots table constraints
......................................................................
engine: remove snapshots table constraints
The RestoreAllSnapshotsCommand is a transactive command.
As part of the flow, first the snapshot entry is locked, then if
needed memory volumes will be deleted.
However, the RemoveDiskCommand is a non-transactive command and when
it will try to delete the memory disk, it will need to update also
the snapshot row that contains the memory disk id.
But since that the snapshot row is already locked by the first
command, the RemoveDiskCommand will fail to get the lock.
This patch remove the constraints between the base_disks and the
snapshots.
A better solution is to make RestoreAllSnapshotsCommand a
non-transactive command, and add compensation logic.
Also, newer version of Postgres will permit better locking, avoiding
this situation.
Bugs:
BZ 1454823:
Restore the constraints after upgrading the Postgres version.
BZ 1454830:
Make RestoreAllSnapshotsCommand non-transactive command and add
compensation logic
Change-Id: Iffc45d2ef28b65894504e49f6e966c81c4a16c3f
Bug-Url: https://bugzilla.redhat.com/1427104
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
A packaging/dbscripts/upgrade/04_02_0270_drop_memory_snapshot_constraints.sql
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved; Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/77195
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iffc45d2ef28b65894504e49f6e966c81c4a16c3f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: rpc: Version bump
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: rpc: Version bump
......................................................................
rpc: Version bump
Bug-Url: https://bugzilla.redhat.com/1112120
Change-Id: Ifb82cae6d57e09cbd9c75363b0c025074030fe7f
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M backend/manager/dependencies/common/src/main/modules/org/ovirt/vdsm-jsonrpc-java/main/module.xml
M ovirt-engine.spec.in
M pom.xml
3 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77203
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb82cae6d57e09cbd9c75363b0c025074030fe7f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: core: SyncLunsInfoForBlockStorageDomain - metadata devices r...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: SyncLunsInfoForBlockStorageDomain - metadata devices refresh
......................................................................
core: SyncLunsInfoForBlockStorageDomain - metadata devices refresh
This patch changes the SyncLunsInfoForBlockStorageDomain command to skip
executing the metadata devices refresh if no vdsId was passed to the
command.
refreshMetadataDevicesInfo() is executes
BlockStorageDomainHelper.fillMetadataDevicesInfo() which currently
doesn't use an api that support randomizing a host for execution.
Currently all the flows the needs that functionallity do pass the vds
id, while the command should obviously not be aware to the parameters
passed by it's callers - as this patch is intended to be backported
to the 4.1 branch the change here is minimal - skips the execution if
no vds id was passed.
In the master branch fillMetadataDevicesInfo() will be updated to
supported randomizing a host which will enable us to remove that check.
If we want to skip the metadata devices refresh it should be done
using a specific parameter.
Change-Id: I35bdcbe4d5ff55e2fbe39ca4ab28b05b4802454b
Bug-Url: https://bugzilla.redhat.com/1452984
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
1 file changed, 18 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/77207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35bdcbe4d5ff55e2fbe39ca4ab28b05b4802454b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: core: SyncLunsInfoForBlockStorageDomain - domain md devices
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: SyncLunsInfoForBlockStorageDomain - domain md devices
......................................................................
core: SyncLunsInfoForBlockStorageDomain - domain md devices
When a domain is created it has a vg metadata device and a metadata lv
which may be created on multiple devices. On a regular basis, those
devices should be never changing.
However, in some user envs in case of disaster the block sd may be
resotored manually in a way that will change its metadata devices.
The SyncLunsInfoForBlockStorageDomain is executed when a block domain
moves to Active status, it synchronizes the domain luns info persisted
in the db with the actual info retrieved from the storage - this patch
adds to it the code that'll update the info on the domain metadata
devices as well as it may changed.
Change-Id: Id65dad542fee6f1a55625f5e5730b112f8149e0e
Bug-Url: https://bugzilla.redhat.com/1452984
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/BlockStorageDomainHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 47 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/77085
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id65dad542fee6f1a55625f5e5730b112f8149e0e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in gerrit-admin[master]: Fix missing patchset
by Code Review
>From Shlomo Ben David <sbendavi(a)redhat.com>:
Shlomo Ben David has submitted this change and it was merged.
Change subject: Fix missing patchset
......................................................................
Fix missing patchset
If someone press the 'rebase' button or add a comment it will run the
hook dispatcher and it will take some time (few seconds) to finish,
while during that time the 'rebase' button remains available
and allows to press on it again.
This behaviour cause patches to disappear.
Example:
current patch: #5 ==> clicked on the rebase button
(you should be moved to patch #6) ==> clicked on the rebase button again
(you are now on patch #7) while patch #6 isn't exist.
Added code to catch the 'rebase' or added comments action and skip
the rest of the checks.
In Addition:
- Rewrite the logging logic
- Fixed some pep8 errors
- Removed/Added some function doc strings
Change-Id: Ie797a8dd8e7b5aa1415e668bb430ff65ed62ff52
Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1192
Signed-off-by: Shlomi Ben-David <sbendavi(a)redhat.com>
---
M hooks/hook-dispatcher
1 file changed, 121 insertions(+), 77 deletions(-)
Approvals:
Shlomo Ben David: Verified; Looks good to me, approved
Anton Marchukov: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76739
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie797a8dd8e7b5aa1415e668bb430ff65ed62ff52
Gerrit-PatchSet: 1
Gerrit-Project: gerrit-admin
Gerrit-Branch: master
Gerrit-Owner: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years
Change in ovirt-hosted-engine-ha[v2.1.z]: Add transition to EngineMaybeAway from EngineStarting
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: Add transition to EngineMaybeAway from EngineStarting
......................................................................
Add transition to EngineMaybeAway from EngineStarting
When the agent tries to start the VM and it is already
running on another host, the VDSM reports an error:
"Failed to acquire lock".
Broker periodically checks the state of the VM,
but it sees the error message only once and then
the VM is destroyed.
The agent may miss the message if it sleeps too long.
This patch adds transition to EngineMaybeAway,
to check if the VM is running elsewhere.
Change-Id: I4d92e021ebf6398d7846a233531f1be5e94dbe5f
Bug-Url: https://bugzilla.redhat.com/1448699
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
(cherry picked from commit a0f909dbb95aad5d96cf5a671582ee8526f28a58)
---
M ovirt_hosted_engine_ha/agent/states.py
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/77166
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4d92e021ebf6398d7846a233531f1be5e94dbe5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: core: ReduceSD - fail when no md devices info
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: ReduceSD - fail when no md devices info
......................................................................
core: ReduceSD - fail when no md devices info
In some user envs the metadata for a block sd was resotored in a way
preventing vdsm to determine the vg metadata device of the domain.
As we don't support that configuration - we'd like to prevent devices
from being reduced from the domain in that case. This patch changes the
reduce command to verify that the metadata devices are present before
allowing to reduce a device from the domain.
Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348
Bug-Url: https://bugzilla.redhat.com/1454864
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/ReduceSANStorageDomainDevicesCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Liron Aravot: Verified
--
To view, visit https://gerrit.ovirt.org/77084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib4274f3f4a106f1be083bd36dcbe182acc5fe348
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: restapi: don't fail when listing vm session of non-existing ...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: restapi: don't fail when listing vm session of non-existing user
......................................................................
restapi: don't fail when listing vm session of non-existing user
When VM console sessions are listed and the there is session for
user which don't exist in oVirt database, we should not fail and
return 404, but we should just don't fetch additional data about
this user.
Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473
Bug-Url: https://bugzilla.redhat.com/1440861
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
(cherry picked from commit 8d29d060132f454dfdf3fb796a953cd371efdc09)
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmSessionsResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResourceTest.java
5 files changed, 41 insertions(+), 45 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77189
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I293f16cb02a6ebd56872ef49b06dbd6672ae1473
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: add confirm 'Host has been Rebooted' button
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: add confirm 'Host has been Rebooted' button
......................................................................
webadmin: add confirm 'Host has been Rebooted' button
Add Confirm 'Host has been Rebooted' button to the Hosts main tab
under Management options.
Change-Id: I503e55d6b3e8035ea21319b8286914f31d82c398
Bug-Url: https://bugzilla.redhat.com/1421715
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
1 file changed, 2 insertions(+), 3 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Irit Goihman: Verified
--
To view, visit https://gerrit.ovirt.org/77167
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I503e55d6b3e8035ea21319b8286914f31d82c398
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years