May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: vdsbroker: correlation id for quartz based jobs
by Code Review 24 May '17

24 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: vdsbroker: correlation id for quartz based jobs ...................................................................... vdsbroker: correlation id for quartz based jobs Correlation id was not provided for quartz based jobs so there was no way to correlate them between vdsm and the engine. Bug-Url: https://bugzilla.redhat.com/1112120 Change-Id: I0ece18beddd49e8f0492fabe62610d3774b69776 Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> --- M backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77191 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ece18beddd49e8f0492fabe62610d3774b69776 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: SyncLunsInfoForBlockStorageDomain - metadata devices r...
by Code Review 23 May '17

23 May '17

>From Liron Aravot <laravot(a)redhat.com>: Liron Aravot has submitted this change and it was merged. Change subject: core: SyncLunsInfoForBlockStorageDomain - metadata devices refresh ...................................................................... core: SyncLunsInfoForBlockStorageDomain - metadata devices refresh This patch changes the SyncLunsInfoForBlockStorageDomain command to skip executing the metadata devices refresh if no vdsId was passed to the command. refreshMetadataDevicesInfo() is executes BlockStorageDomainHelper.fillMetadataDevicesInfo() which currently doesn't use an api that support randomizing a host for execution. Currently all the flows the needs that functionallity do pass the vds id, while the command should obviously not be aware to the parameters passed by it's callers - as this patch is intended to be backported to the 4.1 branch the change here is minimal - skips the execution if no vds id was passed. In the master branch fillMetadataDevicesInfo() will be updated to supported randomizing a host which will enable us to remove that check. If we want to skip the metadata devices refresh it should be done using a specific parameter. Change-Id: I35bdcbe4d5ff55e2fbe39ca4ab28b05b4802454b Bug-Url: https://bugzilla.redhat.com/1452984 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 18 insertions(+), 7 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77168 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35bdcbe4d5ff55e2fbe39ca4ab28b05b4802454b Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: produceReport: Add db size to inventory script
by Code Review 23 May '17

23 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: produceReport: Add db size to inventory script ...................................................................... produceReport: Add db size to inventory script During the report, let's show the db size. Change-Id: I34e15c04a1ea4f74fcd75393e9b66674bdd74ca0 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/database_size.sql 3 files changed, 9 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77128 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34e15c04a1ea4f74fcd75393e9b66674bdd74ca0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Set disks from db when init CreateAllTemplateDisksFrom...
by Code Review 23 May '17

23 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Set disks from db when init CreateAllTemplateDisksFromSnapshotCommand ...................................................................... core: Set disks from db when init CreateAllTemplateDisksFromSnapshotCommand Before this patch, the init of CreateAllTemplateDisksFromSnapshotCommand lacks the proccess of populate vm disks from db to command context's getVm(), thus caused the following filterImageDisks(...) always operate on an empty diskmap. Change-Id: I57be9e653c825db21f66c640437544481c94fc13 Bug-Url: https://bugzilla.redhat.com/1453010 Signed-off-by: plysan <plysab(a)gmail.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests plysan: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77076 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57be9e653c825db21f66c640437544481c94fc13 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: plysan <plysab(a)gmail.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: plysan <plysab(a)gmail.com>

1 0

Change in jenkins[master]: lago: add fc26
by Code Review 23 May '17

23 May '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: lago: add fc26 ...................................................................... lago: add fc26 Allows us to test it against new libvirt 3.x upstream(among others). lago-ost-plugin will follow after this. Change-Id: Idc3fec1f8c49d744ccb386d46c78a4af68c51216 Signed-off-by: Nadav Goldin <ngoldin(a)redhat.com> --- M jobs/confs/projects/lago/lago_standard.yaml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Ready for merge Nadav Goldin: Verified; Ready for review Gil Shinar: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77155 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc3fec1f8c49d744ccb386d46c78a4af68c51216 Gerrit-PatchSet: 2 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: Fixed a typo in findbugs collection
by Code Review 23 May '17

23 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: Fixed a typo in findbugs collection ...................................................................... Fixed a typo in findbugs collection Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1381 Due to a typo at the part that supposed to collect the findbugs we've missed findbugsXml.xml file, and with this file missing some of the reports were not exported. This patch was tested and verified here: http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/240… on top of intentionally faulty patch sent by Tal Nissan (thanks for the help) Change-Id: I6b3a07ed44a0ee357d17a5b119cadf6cae031c67 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M automation/check-merged.sh M automation/check-patch.sh 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Belenky: Verified Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b3a07ed44a0ee357d17a5b119cadf6cae031c67 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Change error message when adding HE host without stora...
by Code Review 23 May '17

23 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Change error message when adding HE host without storage domain ...................................................................... core: Change error message when adding HE host without storage domain The previous error message mentioned cluster version 3.6, but cluster level checking was removed. Change-Id: I64f4378e862431de97e3af1231c9157c75e9ebde Bug-Url: https://bugzilla.redhat.com/1441431 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/76655 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64f4378e862431de97e3af1231c9157c75e9ebde Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: vms_check_no_timezone_set: SQL AS statement should be in caps
by Code Review 23 May '17

23 May '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. Change subject: vms_check_no_timezone_set: SQL AS statement should be in caps ...................................................................... vms_check_no_timezone_set: SQL AS statement should be in caps Change-Id: I12fa276a6264560efaa44397bdbcb45dede79248 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/vms_check_no_timezone_set.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12fa276a6264560efaa44397bdbcb45dede79248 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotC...
by Code Review 23 May '17

23 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotCommand ...................................................................... findbugs: Fix warning in CreateAllTemplateDisksFromSnapshotCommand The fields vmHandler masks a field with the same name in the superclass causing findbugs to issue a MF_CLASS_MASKS_FIELD warning, this patch removes the injection in the class and use the same injected member of the superclass which is the same Change-Id: Id364877d0d152c900740efc53af30933415bdc63 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/CreateAllTemplateDisksFromSnapshotCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77169 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id364877d0d152c900740efc53af30933415bdc63 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Some minor changes to the manual job
by Code Review 23 May '17

23 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: Some minor changes to the manual job ...................................................................... Some minor changes to the manual job [1] Removed the option to run 4.0 suites as we don't have them anymore. [2] As the latest_tested repo is not stable enough for tests, and generally it shouldn't be used in tests at all, I've replaced between 'latest_tested' and 'latest_release' so that the 'latest_release' repo will be the default one. Change-Id: I291b4995d0c5331f6f43b16c26fc29432fb7fed3 Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com> --- M jobs/confs/projects/ovirt/system-tests.yaml M jobs/confs/yaml/parmeters/upgrade-table.yaml M jobs/confs/yaml/templates/system_tests_templates.yaml 3 files changed, 5 insertions(+), 49 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/77066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I291b4995d0c5331f6f43b16c26fc29432fb7fed3 Gerrit-PatchSet: 5 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0