Change in ovirt-engine[master]: core: Inject private DAOs - gluster
by Code Review
>From Roy Golan <rgolan(a)redhat.com>:
Roy Golan has submitted this change and it was merged.
Change subject: core: Inject private DAOs - gluster
......................................................................
core: Inject private DAOs - gluster
Continued work of ChangeId I12e3906a5008ccbe0dcce1cb268dff7a5084789f
to clean-up protected injection of DAOs.
Change-Id: If9af587d1848d39aea57b9c5ba9288197bb06d33
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CommitRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeGeoRepSessionCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteAllGlusterVolumeSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ManageGlusterServiceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RestoreGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ScheduleGlusterVolumeSnapshotCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SetupGlusterGeoRepMountBrokerInternalCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRemoveGlusterVolumeBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/UpdateGlusterHookCommand.java
20 files changed, 128 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sahina Bose: Looks good to me, approved
Roy Golan: Verified
Moti Asayag: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76207
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If9af587d1848d39aea57b9c5ba9288197bb06d33
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: SyntaxChecker contains
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: SyntaxChecker contains
......................................................................
core: SyntaxChecker contains
Use Java 5's String#contains instead of the harder-to-understand
usage of String#indexOf.
Change-Id: I4ad3af4cd2050a645d306710f80e8bf56e61ae90
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76810
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ad3af4cd2050a645d306710f80e8bf56e61ae90
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Remove ColNameMapEntryComparator
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove ColNameMapEntryComparator
......................................................................
core: Remove ColNameMapEntryComparator
Replace ColNameMapEntryComparator with Java 8's built in
java.util.Map.Entry.comparingByValue().
Change-Id: Ia09a1506cc5bfea4cbb039e5a46e29a55d524c83
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76814
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09a1506cc5bfea4cbb039e5a46e29a55d524c83
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: SyntaxChecker array creation
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: SyntaxChecker array creation
......................................................................
core: SyntaxChecker array creation
As disAllowedChars is never modified, there's no reason to create a
new instance for each new SyntaxChecker. Instead, a single private
static final "variable" can be used.
Change-Id: I046f5f632423ed88f7f9689550f3789df0b81445
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76809
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I046f5f632423ed88f7f9689550f3789df0b81445
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter type inference
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseConditionFieldAutoCompleter type inference
......................................................................
core: BaseConditionFieldAutoCompleter type inference
Change-Id: Ic7b722f395c789731f2dc53afb13fb23bcb646b1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76811
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7b722f395c789731f2dc53afb13fb23bcb646b1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: RM SyntaxChecker#TAG_COLUMN_NAME_IN_CRITERIA
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RM SyntaxChecker#TAG_COLUMN_NAME_IN_CRITERIA
......................................................................
core: RM SyntaxChecker#TAG_COLUMN_NAME_IN_CRITERIA
Removed an unused constant.
Change-Id: I6991742e9078e2ba72b7b6e9da4118232a028e74
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76807
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6991742e9078e2ba72b7b6e9da4118232a028e74
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: Remove SyntaxChecker searchResultLimits
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Remove SyntaxChecker searchResultLimits
......................................................................
core: Remove SyntaxChecker searchResultLimits
Removed the unused constructor parameter.
Note that removing this parameter means that the SyntaxCheckerFactory
class no longer relies on ConfigValues, and the tests can be cleaned
up.
Change-Id: I9ad3d75860e1fdcbf8b97e8e2c73ca2491c356c2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java
M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerTest.java
4 files changed, 7 insertions(+), 17 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
Eli Mesika: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76808
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ad3d75860e1fdcbf8b97e8e2c73ca2491c356c2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter getConfigUtils()
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseConditionFieldAutoCompleter getConfigUtils()
......................................................................
core: BaseConditionFieldAutoCompleter getConfigUtils()
There's no reason for BaseConditionFieldAutoCompleter to check for
Config.getConfigUtils() nullability - in "real" scenarios the
ConfigUtils should be initialized, and in tests MockConfigRule should
be used.
Change-Id: I7db13ba6f0e63901ce211bf319e1be6f858fbee1
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 3 insertions(+), 10 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7db13ba6f0e63901ce211bf319e1be6f858fbee1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in ovirt-engine[master]: core: BaseConditionFieldAutoCompleter addAll
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: BaseConditionFieldAutoCompleter addAll
......................................................................
core: BaseConditionFieldAutoCompleter addAll
Use the optimized addAll(Collection<T>) method instead of looping
over a key set and calling add(T) on each item.
At worst, the code is just more elegant this way. At best, it may
hold some minor optimizations.
Change-Id: Ibcf15904984df8ee708e67673035e423d8b1a429
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/76813
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcf15904984df8ee708e67673035e423d8b1a429
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months
Change in jenkins[master]: General changes to upstream yamls for the new std-ci stage
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: General changes to upstream yamls for the new std-ci stage
......................................................................
General changes to upstream yamls for the new std-ci stage
I have refactored some yamls so I'll have all the prerequisites
for the new std-ci stage
- For jobs to be able to push to git, added injection
of git push credentials to all jobs
- Added support for projects that thier git repository name
is different then thier project name (e.g. ds-jenkins vs. jenkins).
To support that I have added special triggers
Change-Id: I19bd917090a4bf151d65efefc8bcfbbf52dea164
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/projects/defaults.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
M jobs/confs/yaml/triggers/standard.yaml
A jobs/confs/yaml/wrappers/inject_git_push_credentials.yaml
A jobs/confs/yaml/wrappers/standard.yaml
5 files changed, 61 insertions(+), 7 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73979
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I19bd917090a4bf151d65efefc8bcfbbf52dea164
Gerrit-PatchSet: 71
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 7 months