May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine-sdk[sdk_4.1]: Exclude unknown cURL debug types
by Code Review 16 May '17

16 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Exclude unknown cURL debug types ...................................................................... Exclude unknown cURL debug types Currently the cURL debug function that we use tries to convert all kinds of debug data to strings, in order to send them to the log. This does not work for binary data, for example for the SSL debug data. To avoid that this patch changes the debug function so that it ignores the debug data whose type doesn't know how to handle. Change-Id: I26e811ebe93034e68ccc6cbb6f74f2314c6c6cfc Bug-Url: https://bugzilla.redhat.com/1451042 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 60ddc809e585e8748fa45da3fa577715fa37f127) --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76880 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e811ebe93034e68ccc6cbb6f74f2314c6c6cfc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add debug data prefixes to indicate direction
by Code Review 16 May '17

16 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add debug data prefixes to indicate direction ...................................................................... Add debug data prefixes to indicate direction This patch adds prefixes to the debug lines to indicate the direction of the data. The '*' prefix will indicate informative messages. The '>' will indicate HTTP response data. The '<' prefix will indicate HTTP request data. Change-Id: I5752d2ddad7ed2123460ca253082bab4b3972987 Related-To: https://bugzilla.redhat.com/1451042 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5752d2ddad7ed2123460ca253082bab4b3972987 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Exclude unknown cURL debug types
by Code Review 16 May '17

16 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Exclude unknown cURL debug types ...................................................................... Exclude unknown cURL debug types Currently the cURL debug function that we use tries to convert all kinds of debug data to strings, in order to send them to the log. This does not work for binary data, for example for the SSL debug data. To avoid that this patch changes the debug function so that it ignores the debug data whose type doesn't know how to handle. Change-Id: I26e811ebe93034e68ccc6cbb6f74f2314c6c6cfc Bug-Url: https://bugzilla.redhat.com/1451042 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76863 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I26e811ebe93034e68ccc6cbb6f74f2314c6c6cfc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: sync ClientIp and consoleCurrentUserName values
by Code Review 16 May '17

16 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: sync ClientIp and consoleCurrentUserName values ...................................................................... core: sync ClientIp and consoleCurrentUserName values There are two issues solved in this patch regarding the update of vm.clientIp (sent by VDSM) and consoleCurrentUserName, consoleUserId (done in SetVmTicketCommand): 1. As part of resetVmAttributes() - the consoleCurrentUserName and consoleUserId are reset but clientIP is not. The clientp is reset only when vdsm sent it as null for the VM (after identifying that spice/vnc console connection was closed). This is not a healthy situation since when the VM is down the clientIp is set in DB while console user information in DB is null. Fixing it is done by reset ClientIp as part of resetVmAttributes(). 2. There is no vm locking done in SetVmTicketCommand, so there might be a scenario in which after starting a VM and opening a console, the console user info is still set to null for this opened console connection. The scenario is: a. the VmsMonitoring read the vmDb.consoleCurrentUserName and vmDb.consoleUserId as null b. in the middle and before the VmAnalyzer.updateVmDynamicData() is done, a console is opended and SetVmTicketCommand update relevant user info in Db. c. only then the VmAnalyzer.updateVmDynamicData() will update the DB - to null values that it read before. This may lead to an open console without console user data in DB and to write in audit log a message like: User <UNKNOWN> got disconnected from VM vm1 Fixing it is done by acquiring the vm's monitoring lock in SetVmTicketCommand. Change-Id: I17152754a22ad499febdb88259f40aeb9b54a4fe Bug-Url: https://bugzilla.redhat.com/1434937 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetVmTicketCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 2 files changed, 42 insertions(+), 29 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17152754a22ad499febdb88259f40aeb9b54a4fe Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Update VM disk read only through DiskVmElement
by Code Review 16 May '17

16 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Update VM disk read only through DiskVmElement ...................................................................... core: Update VM disk read only through DiskVmElement Change-Id: I6b31c74461d2cd17b2348684c36ad9f174f5c487 Bug-Url: https://bugzilla.redhat.com/1448832 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CloneVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreStatelessVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/exportimport/ImportVmFromConfigurationCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/AttachDiskToVmCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDetachVmDiskParameters.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskAttachmentsResource.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskAttachmentMapper.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java 9 files changed, 14 insertions(+), 28 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b31c74461d2cd17b2348684c36ad9f174f5c487 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: webadmin: VM lease can be selected even if not supported by ...
by Code Review 16 May '17

16 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VM lease can be selected even if not supported by version ...................................................................... webadmin: VM lease can be selected even if not supported by version Change-Id: Id1bf8305c258520c24c1bef54f6fabba4604bd2b Bug-Url: https://bugzilla.redhat.com/1422099 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 14 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/74681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bf8305c258520c24c1bef54f6fabba4604bd2b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: VM lease can be selected even if not supported by ...
by Code Review 16 May '17

16 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin: VM lease can be selected even if not supported by version ...................................................................... webadmin: VM lease can be selected even if not supported by version Change-Id: Id1bf8305c258520c24c1bef54f6fabba4604bd2b Bug-Url: https://bugzilla.redhat.com/1422099 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/UIConstants.properties 3 files changed, 14 insertions(+), 4 deletions(-) Approvals: Tomas Jelinek: Looks good to me, approved Tal Nisan: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/72268 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id1bf8305c258520c24c1bef54f6fabba4604bd2b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: merge: fix incorrect condition in getRequiredSizeForMerge
by Code Review 16 May '17

16 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: merge: fix incorrect condition in getRequiredSizeForMerge ...................................................................... merge: fix incorrect condition in getRequiredSizeForMerge The assignment of volumeType from commit 12629c667a2efed513519a751a4da295b7b2dad0 is incorrect and unnecessary, since the swap between top and base is only relevant for the old cold merge (pre-4.1) which when performed won't execute those line anyway, and this will make volumeType always VolumeType.SPARSE. Change-Id: I7ff90f90bb8af12e9e6191b825c70f2f6a907f38 Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java 1 file changed, 5 insertions(+), 7 deletions(-) Approvals: Benny Zlotnik: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Ala Hino: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/76638 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ff90f90bb8af12e9e6191b825c70f2f6a907f38 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: ovirt-imageio: Use release branch for release builds
by Code Review 16 May '17

16 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: ovirt-imageio: Use release branch for release builds ...................................................................... ovirt-imageio: Use release branch for release builds ovirt-imageio did not have a release branch, so we build releases from master. Update to build packages from the release branch. This can be merge only after the release branch will be created. Change-Id: If84777d2207c6254f08723eb1b0b23969b444c6c Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M jobs/confs/projects/ovirt-imageio/ovirt-imageio.yaml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me; Ready for review Nir Soffer: Looks good to me Barak Korren: Verified; Looks good to me, approved; Ready for merge Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/69061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If84777d2207c6254f08723eb1b0b23969b444c6c Gerrit-PatchSet: 3 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: validate usb unmanaged devices in runVmCommand
by Code Review 16 May '17

16 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: validate usb unmanaged devices in runVmCommand ...................................................................... core: validate usb unmanaged devices in runVmCommand In case the Usb policy is set to DISABLED for an "old" VM (<= 3.6) with an old USB configuration (i.e. more then one USB unmanaged controllers) and that VM is restarted/rerun/rebooted in engine 4.1: an error is thrown with host=UNKNOWN (null) since it is thrown in runVmCommand->initVm()->updateVmDevicesOnRun() phase while there is still no host scheduled for this VM. This scenario is unique since no manual VM configuration update validation is involved and the user won't know about that prior to restrating/re-running an old VM in new engine. To fix that we add the old USB configuration validation to runVmCommand()->validate() method instead of catching it later on in initVM() method. Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3 Bug-Url: https://bugzilla.redhat.com/1435579 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 35 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8876a17d90f5a70bc7bc05814875cbbb40601be3 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0