May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Avoid injection in IrsProxy
by Code Review 04 May '17

04 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid injection in IrsProxy ...................................................................... core: Avoid injection in IrsProxy Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I4f5184336c0263963f1c58b263c231e56999555f Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsProxy.java 1 file changed, 33 insertions(+), 29 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76378 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f5184336c0263963f1c58b263c231e56999555f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Avoid injection in MetadataDiskDescriptionHandler
by Code Review 04 May '17

04 May '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Avoid injection in MetadataDiskDescriptionHandler ...................................................................... core: Avoid injection in MetadataDiskDescriptionHandler Since all of the data to be logged is already present at the creating of the audit-log entity, there is no need to inject any beans to the AuditLogableBase and it can be replaced with a leaner and more efficient implementation of the AuditLogable. Change-Id: I0f980329c8ba761e03cc7c7a547eb25a82b00b53 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/MetadataDiskDescriptionHandler.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/76373 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0f980329c8ba761e03cc7c7a547eb25a82b00b53 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Add support for asynchronous requests
by Code Review 04 May '17

04 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add support for asynchronous requests ...................................................................... Add support for asynchronous requests This patch modifies the SDK so that it uses the 'multi' interface of the 'pycurl' library. This interface supports several advanced HTTP capabilities, like multiple connections and pipelining. The interface of the SDK is preserved, for backwards compatibility. The only new addition is a new 'wait' parameter, for all operations. The default value is 'true'. When the values is 'false' the operation is performed asynchronously, and a 'future' object is returned that can be used to retrieve the result later. For example: # Find the virtual machine and the service that manages it: vm = vms_service.list(search='name=myvm')[0] vm_service = vms_service.vm_service(vm.id) # Find the disk attachments, asynchronously: attachments_service = vm_service.disk_attachments_service attachments_future = attachments_service.list(wait=False) # Do some other tasks, for example sending some more asynchronous # requests, so that they are queued and potentially pipelined. # Later, wait for the result: attachments = attachments_future.wait() # Print the details: for attachment in attachments: print(attachment.disk.id) Change-Id: I106ccc52b58cd0aca23548e21cc21beac152e9e5 Bug-Url: https://bugzilla.redhat.com/1436981 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 9db60cb3a2498ecce94eb424f92ff1685b2abece) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java A sdk/examples/asynchronous_inventory.py M sdk/lib/ovirtsdk4/__init__.py M sdk/lib/ovirtsdk4/service.py 4 files changed, 420 insertions(+), 97 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76462 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I106ccc52b58cd0aca23548e21cc21beac152e9e5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Check content type only when really needed
by Code Review 04 May '17

04 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Check content type only when really needed ...................................................................... Check content type only when really needed Currently the SDK checks the content type of all responses, even of responses where the content type doesn't need to be provided. For example, when a 404 error code is generated by the application server, or by the web server, the content type may not be present, or may be HTML. In these situations the SDK is not reacting correctly, as the message that explains that the content type isn't correct is hiding other more important messages, like the HTTP result code. To avoid that this patch changes the SDK so that it will check the content type only when it really tries to parse the response body. In addition, the patch also changes the generated messages, so that the HTTP details, including the HTTP error code, will appear in the message in all cases. Change-Id: I005460365bce78acb020200cac770073427b617e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1440292 Related-To: https://bugzilla.redhat.com/show_bug.cgi?id=1444016 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit ef55570ea8b0e77f972b095608148b6368899a7d) --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java M sdk/lib/ovirtsdk4/__init__.py M sdk/lib/ovirtsdk4/reader.py M sdk/lib/ovirtsdk4/service.py M sdk/tests/test_vm_service.py 5 files changed, 204 insertions(+), 226 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76460 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I005460365bce78acb020200cac770073427b617e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[sdk_4.1]: Import submodules into top level module
by Code Review 04 May '17

04 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Import submodules into top level module ...................................................................... Import submodules into top level module This patch imports all of the submodules in SDK to the top level module. This has benefit that the readers/writers/types/services can be used right after the top level sdk module import, for example: import ovirtsdk4 as sdk vm = sdk.types.Vm() Change-Id: Iff4f44ccb8cf9cc018c8bf37a8f229c3d32633bc Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 7971f9f706d77d78953d8f4656e1b59b97385f5c) --- M sdk/lib/ovirtsdk4/__init__.py 1 file changed, 14 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76453 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff4f44ccb8cf9cc018c8bf37a8f229c3d32633bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel#finishSearch setEntity
by Code Review 04 May '17

04 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractUserPortalListModel#finishSearch setEntity ...................................................................... webadmin: AbstractUserPortalListModel#finishSearch setEntity Since UserPortalItemModel's constructor calls setEntity in its last line, explicitly calling it in this method is redundant. This patch cleans up the code by removing the redundant explicit call, and also offers a slight performance improvement by raising the related events only once instead of twice. Change-Id: Ie4e0b0901edf88326c65d26c42605a88361a195e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/76441 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4e0b0901edf88326c65d26c42605a88361a195e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel#onVmAndPoolLoad
by Code Review 04 May '17

04 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractUserPortalListModel#onVmAndPoolLoad ...................................................................... webadmin: AbstractUserPortalListModel#onVmAndPoolLoad In the original implementation, for N VMs and M pools this method filtered the pools by using an O(M*N) nested loop and running over all the VMs for each pool. A more efficient approach could be to run over all the VMs and collect them into a map that counts the number of VMs per pool (an O(N) operation), and then running over all the pools and checking if each pool hasn't reached it maximum VMs per user (an O(M) operation), for a total of O(M+N) time-complexity. Change-Id: I35ee323e073e2c9dcf68897fdaf745d65334c2b0 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 10 insertions(+), 15 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/76443 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35ee323e073e2c9dcf68897fdaf745d65334c2b0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel#finishSearch streams
by Code Review 04 May '17

04 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractUserPortalListModel#finishSearch streams ...................................................................... webadmin: AbstractUserPortalListModel#finishSearch streams Use Java 8's stream to clean up the implementation of finishSearch and replace the boilerplate for-loop that was used there. Note that the original implementation had an unwanted(?) side-effect of sorting the vmOrPoolAndPoolRepresentants passed to it which was never noticed as it was always called with local variables that were immediately disposed afterwards. This cleanup also removes that side effect. Change-Id: I7628853600dfb35407be0a51edef029065aaeeac Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 4 insertions(+), 10 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/76442 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7628853600dfb35407be0a51edef029065aaeeac Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel methods
by Code Review 04 May '17

04 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractUserPortalListModel methods ...................................................................... webadmin: AbstractUserPortalListModel methods Remove unused methods. Change-Id: I4a3f9c278dc5cdc88d43e47763b2fcb28511a76e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 0 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/76439 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a3f9c278dc5cdc88d43e47763b2fcb28511a76e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: AbstractUserPortalListModel Namables
by Code Review 04 May '17

04 May '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. Change subject: webadmin: AbstractUserPortalListModel Namables ...................................................................... webadmin: AbstractUserPortalListModel Namables Use Namable instead of Object when constructing pairs of "vms or pools" so that some type checking is performed, and we don't need to resort to raw types. Change-Id: Ibce99a72df12929608a137b9badabe18b644c0c5 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/AbstractUserPortalListModel.java 1 file changed, 10 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/76440 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibce99a72df12929608a137b9badabe18b644c0c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0