May 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: retrieve vm name from vm-manager instead of the database
by Code Review 07 May '17

07 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: retrieve vm name from vm-manager instead of the database ...................................................................... core: retrieve vm name from vm-manager instead of the database We need the name of the VM for the audit logs generated for failures to automatically start highly-available VMs. This patch replaces that retrieval of the name from the database with querying the cached value in the corresponding VmManager instance. Change-Id: I5d68b3c2964019e7dbef751fc0e5d516ae38a9b0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/76543 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5d68b3c2964019e7dbef751fc0e5d516ae38a9b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: vdsmfake: Filter el7 nodes for building containers
by Code Review 07 May '17

07 May '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. Change subject: vdsmfake: Filter el7 nodes for building containers ...................................................................... vdsmfake: Filter el7 nodes for building containers This filter is necessary to resolve a version mismatch between the docker build command inside the mock env to the outside docker-machine. Change-Id: I7db833c0a556b23b20f5b09112b5605fdc6b5148 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M jobs/confs/projects/ovirt-vdsmfake/ovirt-vdsmfake_standard.yaml 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76540 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7db833c0a556b23b20f5b09112b5605fdc6b5148 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Use AuditLogableImpl in AutoStartVmsRunner
by Code Review 07 May '17

07 May '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: engine: Use AuditLogableImpl in AutoStartVmsRunner ...................................................................... engine: Use AuditLogableImpl in AutoStartVmsRunner The PR extract shared code into a method and replaces the AuditLogableBase with AuditLogableImpl that requires less resources to retrieve the VM data. Change-Id: If8e54d9b55f883ea9f4c7ff9c501c4830994e8b4 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutoStartVmsRunner.java 1 file changed, 20 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Moti Asayag: Verified -- To view, visit https://gerrit.ovirt.org/76252 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8e54d9b55f883ea9f4c7ff9c501c4830994e8b4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: scheduler: Fix empty scores returned by external scheduler
by Code Review 05 May '17

05 May '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: scheduler: Fix empty scores returned by external scheduler ...................................................................... scheduler: Fix empty scores returned by external scheduler Fixes NPE if the external scheduler returns an empty score list. This can happen if an external policy times out. Change-Id: I0d2c4bbdb476b76b799a43a0a71f4de579452f1c Bug-Url: https://bugzilla.redhat.com/1444611 Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/external/ScoringResult.java 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Denis Chaplygin: Looks good to me, but someone else must approve Martin Sivák: Looks good to me, approved Jenkins CI: Passed CI tests Andrej Krejcir: Verified -- To view, visit https://gerrit.ovirt.org/76465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d2c4bbdb476b76b799a43a0a71f4de579452f1c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com> Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com> Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Add assign logical network to cluster example
by Code Review 05 May '17

05 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add assign logical network to cluster example ...................................................................... Add assign logical network to cluster example This patch add example of how to assign logical network to cluster. Change-Id: I43868beaecc20c6d413772cf1c590c710aaef324 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit ba54b8cce7a46e5bfe081af813f3ebe5e7bcbd89) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignNetworkToCluster.java 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76492 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43868beaecc20c6d413772cf1c590c710aaef324 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[sdk_4.1]: Add logical network create example
by Code Review 05 May '17

05 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add logical network create example ...................................................................... Add logical network create example This patch add example of creation logical network in datacenter. Change-Id: I88be156a938f8a57727ede2df603964ba0709fbd Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 442082a1c29f05fac09a332865e2f26a082971b8) --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddLogicalNetwork.java 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88be156a938f8a57727ede2df603964ba0709fbd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: sdk_4.1 Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add assign logical network to cluster example
by Code Review 05 May '17

05 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add assign logical network to cluster example ...................................................................... Add assign logical network to cluster example This patch add example of how to assign logical network to cluster. Change-Id: I43868beaecc20c6d413772cf1c590c710aaef324 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AssignNetworkToCluster.java 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I43868beaecc20c6d413772cf1c590c710aaef324 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-java[master]: Add logical network create example
by Code Review 05 May '17

05 May '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add logical network create example ...................................................................... Add logical network create example This patch add example of creation logical network in datacenter. Change-Id: I88be156a938f8a57727ede2df603964ba0709fbd Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- A sdk/src/test/java/org/ovirt/engine/sdk4/examples/AddLogicalNetwork.java 1 file changed, 67 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/76480 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88be156a938f8a57727ede2df603964ba0709fbd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Do not use :: for method calls in examples
by Code Review 05 May '17

05 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Do not use :: for method calls in examples ...................................................................... Do not use :: for method calls in examples Do not use :: for method calls in assign_network_to_cluster example. Change-Id: I76eaad34c03aac036d6f94f4a169c35c7ee13f17 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit a6de8912d6525b585a3557004706a9fc07928a52) --- M sdk/examples/assign_network_to_cluster.rb 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76eaad34c03aac036d6f94f4a169c35c7ee13f17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add logical network create example
by Code Review 05 May '17

05 May '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add logical network create example ...................................................................... Add logical network create example This patch add example of creation logical network in datacenter. Change-Id: I9192001df46b8d4f23559a357103e9327be89ace Signed-off-by: Ondra Machacek <omachace(a)redhat.com> (cherry picked from commit 920f91e5146ca374630aad2fc42a8ff272c0f3b9) --- A sdk/examples/add_logical_network.rb 1 file changed, 55 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/76482 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9192001df46b8d4f23559a357103e9327be89ace Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0