Change in ovirt-hosted-engine-setup[master]: packaging: spec: Add requirement for rubygem-fluent-plugin-c...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: Add requirement for rubygem-fluent-plugin-collectd-nest
......................................................................
packaging: spec: Add requirement for rubygem-fluent-plugin-collectd-nest
Change-Id: I083eaf60fa961118c8d60d076fcaf613e8fc37ab
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1426897
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77520
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I083eaf60fa961118c8d60d076fcaf613e8fc37ab
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: setup: Check health
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Check health
......................................................................
packaging: setup: Check health
This patch introduces a new utility that can create a standalone script
that can be copied to an older engine machine and ran to get a report.
Currently this report does not do much, but it's expected that we'll
move most of the checks done during engine-setup to be ran also by this
script.
Details:
packaging/setup/bin/bundle-ovirt-engine-health
- creates this "bundle" standalone script
packaging/setup/bin/ovirt-engine-health
- The health checker itself. Can also be ran directly on the engine
machine, but is mainly intended to be wrapped in the bundle.
packaging/setup/plugins/ovirt-engine-checks:
- A new plugins directory, that is shared by both engine-setup and
ovirt-engine-health.
packaging/setup/plugins/ovirt-engine-health:
- A new plugins directory, specific to the health checker
Also patched the spec and make files to allow building.
Also added packaging/setup/plugins/README to document this directory a
bit.
Also copied the code that checks cluster/DC versions compatibility to a
new plugin in plugins/ovirt-engine-checks, as a POC.
To try this, on the engine machine, after setup, run:
sh /usr/share/ovirt-engine/setup/bin/bundle-ovirt-engine-health
It will create (by default) ovirt-engine-health-check.run in current
directory. Copy this one to the target machine and run it there.
Change-Id: Iafb49d107c3b2b5623d11d0c4bbf907d6398e987
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M Makefile
M ovirt-engine.spec.in
A packaging/setup/bin/bundle-ovirt-engine-health
A packaging/setup/bin/ovirt-engine-health
M packaging/setup/bin/ovirt-engine-setup
M packaging/setup/ovirt_engine_setup/constants.py
A packaging/setup/plugins/README
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/__init__.py
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/engine.py
A packaging/setup/plugins/ovirt-engine-checks/ovirt-engine/db/versions.py
A packaging/setup/plugins/ovirt-engine-health/base/core/__init__.py
A packaging/setup/plugins/ovirt-engine-health/base/core/misc.py
12 files changed, 564 insertions(+), 3 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/75372
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafb49d107c3b2b5623d11d0c4bbf907d6398e987
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: setup: Make standard answerfile generation optional
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: setup: Make standard answerfile generation optional
......................................................................
packaging: setup: Make standard answerfile generation optional
Change-Id: I7aeaf72fd55542e6a7df0bf4e8647a50e2b6e6aa
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-common/base/core/answerfile.py
2 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/76552
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7aeaf72fd55542e6a7df0bf4e8647a50e2b6e6aa
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: findbugs: Clean up SF exclusion filters
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: findbugs: Clean up SF exclusion filters
......................................................................
findbugs: Clean up SF exclusion filters
SF (switch fallthrough) bugs are ignored throughout the codebase in
exclude-filters-general.xml. There's no reason to re-specify them in
other exclude-filters.xml files.
Change-Id: I8c689ad3dcf220969241f842f7aeaf5383415a0b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/compat/exclude-filters.xml
M backend/manager/modules/restapi/jaxrs/exclude-filters.xml
2 files changed, 0 insertions(+), 41 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/77498
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c689ad3dcf220969241f842f7aeaf5383415a0b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: Kernel cmdline fix
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Kernel cmdline fix
......................................................................
webadmin: Kernel cmdline fix
Problem: kernel cmdline textbox (Host dialog, Kernel side tab) was not
user editable since it was based on editor StringEntityModelLabelEditor
which uses content widget EntityModelLabel which is read only text box.
Editor changed to StringEntityModelTextBoxEditor.
Change-Id: I1f33fda4223bca53f299563c6c46b89c4f0b4c74
Bug-Url: https://bugzilla.redhat.com/1450951
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77497
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f33fda4223bca53f299563c6c46b89c4f0b4c74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: Fix permissions subtab of users
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: Fix permissions subtab of users
......................................................................
core: Fix permissions subtab of users
Previously the permissions sub-tab of user tab displayed permissions
of the user, which has assigned on specific object directly or
in-directly(inherited). But if the user was part of the group, those
permissions wasn't displayed. We displayed the permissions of the
groups of the currently logged-in user instead.
This patch fixes that, so we now display the permissions of the groups
of the user, which is selected in 'Users' tab instead of the user which
is currently logged-in.
Change-Id: Icbc1ee3b865349384b95a1d5f09880a448712359
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1455011
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAuthzGroupsByUserIdQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetPermissionsOnBehalfByAdElementIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/aaa/AuthzGroup.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PermissionDaoImpl.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendGroupResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/aaa/BackendUserResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendAssignedRolesResourceTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserPermissionListModel.java
M packaging/dbscripts/multi_level_administration_sp.sql
12 files changed, 165 insertions(+), 17 deletions(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbc1ee3b865349384b95a1d5f09880a448712359
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: change LSM lock scope to execution
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: change LSM lock scope to execution
......................................................................
core: change LSM lock scope to execution
Since the memory lock on the disk is not needed for
the entire command and only needed until the DB lock
is acquired, the scope can be changed to execution.
Having the lock in the Command scope also causes a
race condition if an operation runs after LSM tasks
are done but the engine lock was not released yet.
Change-Id: Ic2edf9ac086ed3b647e68379f3507443308e3a0c
Bug-Url: https://bugzilla.redhat.com/1456504
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77504
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2edf9ac086ed3b647e68379f3507443308e3a0c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: restapi: Adding network filter parameters
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Adding network filter parameters
......................................................................
restapi: Adding network filter parameters
The REST-API is extended to manage the parameters for libvirt's network
filters on the vm's nic.
Change-Id: I52513692bfdccdb328e85f4a3e887dd07d978773
Bug-Url: https://bugzilla.redhat.com/1366905
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicFilterParameterResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicFilterParametersResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/util/LinkHelper.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicFilterParameterResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmNicFilterParametersResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NetworkFilterParameterMapper.java
7 files changed, 715 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Dominik Holler: Verified
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/73720
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52513692bfdccdb328e85f4a3e887dd07d978773
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-release[master]: packaging: add Fedora 26 and latest virtio-win
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: add Fedora 26 and latest virtio-win
......................................................................
packaging: add Fedora 26 and latest virtio-win
- Add Fedora 26 support
- Move to latest virtio-win
Change-Id: I90c2d52ecdf1f04bc64574cffcb20f032e5d745e
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M Makefile.am
M automation/check-patch.packages
A automation/check-patch.repos.fc26
M configure.ac
M ovirt-el7-x86_64-deps.repo.in
M ovirt-f25-deps.repo.in
A ovirt-f26-deps.repo.in
M ovirt-release-master.spec.in
8 files changed, 65 insertions(+), 7 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Sandro Bonazzola: Verified; Looks good to me, approved; Passed CI tests
Objections:
Jenkins CI: Failed CI tests
--
To view, visit https://gerrit.ovirt.org/77400
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I90c2d52ecdf1f04bc64574cffcb20f032e5d745e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-release
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Ryan Barry <rbarry(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Yuval Turgeman <yturgema(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: aaa: English review of SSO messages that are surfaced to the...
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: aaa: English review of SSO messages that are surfaced to the login screen
......................................................................
aaa: English review of SSO messages that are surfaced to the login screen
Rephrase authentication errors presented
to end user in SSO login page.
Change-Id: I8f134c49c8bca001945db91526872d98250fecc2
Bug-Url: https://bugzilla.redhat.com/1440440
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/resources/AppMessages.properties
1 file changed, 11 insertions(+), 11 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76956
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8f134c49c8bca001945db91526872d98250fecc2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months