Change in ovirt-engine[master]: webadmin: Kernel cmdline fix
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Kernel cmdline fix
......................................................................
webadmin: Kernel cmdline fix
Problem: kernel cmdline textbox (Host dialog, Kernel side tab) was not
user editable since it was based on editor StringEntityModelLabelEditor
which uses content widget EntityModelLabel which is read only text box.
Editor changed to StringEntityModelTextBoxEditor.
Change-Id: I1f33fda4223bca53f299563c6c46b89c4f0b4c74
Bug-Url: https://bugzilla.redhat.com/1450951
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77389
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f33fda4223bca53f299563c6c46b89c4f0b4c74
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in jenkins[master]: Added GerritMergedChange class
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Added GerritMergedChange class
......................................................................
Added GerritMergedChange class
Class represents merged patches in Gerrit in the change queue context
Change-Id: Ib5c003c0244e5585fc50bfcacaa89352523d6b8f
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077
---
M scripts/change_queue/changes/__init__.py
M test/change_queue/test_changes.py
2 files changed, 93 insertions(+), 3 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/76320
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib5c003c0244e5585fc50bfcacaa89352523d6b8f
Gerrit-PatchSet: 8
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add support for request timeout
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add support for request timeout
......................................................................
Add support for request timeout
Currently the SDK supports a global 'timeout' parameter, but it doesn't
support specifying a different timeout for a particular request. This
patch adds that support.
Change-Id: I00501e97031b771571c64195e5eb8a106f0f77d1
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit ae414e7d997add7fd559a9b0f5500aac6f0adce3)
---
M generator/src/main/java/org/ovirt/sdk/ruby/ServicesGenerator.java
M sdk/ext/ovirtsdk4c/ov_http_client.c
M sdk/ext/ovirtsdk4c/ov_http_request.c
M sdk/ext/ovirtsdk4c/ov_http_request.h
M sdk/lib/ovirtsdk4/connection.rb
M sdk/lib/ovirtsdk4/service.rb
M sdk/spec/connection_timeout_spec.rb
7 files changed, 146 insertions(+), 16 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77455
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00501e97031b771571c64195e5eb8a106f0f77d1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: search: fix tags/values with underscore behaviour
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: search: fix tags/values with underscore behaviour
......................................................................
search: fix tags/values with underscore behaviour
This patch fixes a regression caused by [1] that attempts to resolve [2]
The fix caused tags including an "_" attached to Host or VM not to work.
The problem was that the [1] patch put "\" before "_" not only for a
condition with LIKE/ILIKE but also for "=" condition which cause the
search to return empty results.
The problem is that we have generated queries with ILIKE/LIKE in two forms :
1) <field> LIKE/ILIKE <value>
2) <value> LIKE/ILIKE ANY (string_to_array ......
[1] https://gerrit.ovirt.org/#/c/69926
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1409849
Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1446525
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/VdcUserConditionFieldAutoCompleter.java
3 files changed, 4 insertions(+), 5 deletions(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77484
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3d8e2075f99ce2600e64bd996280c68feb8f3fa0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in jenkins[master]: Enabled loading mirrors data from local file
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Enabled loading mirrors data from local file
......................................................................
Enabled loading mirrors data from local file
Also added python3-PyYAML to STD-CI packages to enable using in
python2 and python3 tests
Change-Id: I915d1c04cf271f9942f46846f0b25c381ec074d2
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1413
---
M automation/check-patch.packages
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc24
M scripts/mirror_client.py
M test/test_mirror_client.py
5 files changed, 100 insertions(+), 2 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77453
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I915d1c04cf271f9942f46846f0b25c381ec074d2
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in jenkins[master]: Add retries to mirror_client on JSON errors
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged.
Change subject: Add retries to mirror_client on JSON errors
......................................................................
Add retries to mirror_client on JSON errors
We've seen some reoccurring failures where JSON decoding for information
from the mirrors server fails. This is probably because we're seeing a
race condition with the data update in the server.
This path adds retries so that when this happens we will re-download the
information from the server and hopefully get a full file.
Change-Id: I2f53126d0e2bd9421edaf57f019db9d5e520adc6
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1086
---
M scripts/mirror_client.py
1 file changed, 15 insertions(+), 5 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77450
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2f53126d0e2bd9421edaf57f019db9d5e520adc6
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in ovirt-engine[master]: packaging: Rename ovirt-provider-ovn config values
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Rename ovirt-provider-ovn config values
......................................................................
packaging: Rename ovirt-provider-ovn config values
Rename ovirt-provider-ovn config values regarding
authentication following their rename in the
provider code.
Change-Id: I50784cc34ee7a076fd0b8c85fcacb2577fbffa5f
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Dominik Holler: Verified
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77486
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50784cc34ee7a076fd0b8c85fcacb2577fbffa5f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
6 years, 11 months
Change in ovirt-engine[master]: packaging: change ovn provider default user to admin@internal
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: change ovn provider default user to admin@internal
......................................................................
packaging: change ovn provider default user to admin@internal
The default user should be "admin@internal" instead of
"admin" to be able to authenticate against ovirt-auth.
Change-Id: Ic3ad843364e76725bb5fea8d7f92ba461f33bfe9
Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1451221
---
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Marcin Mirecki: Verified
Dominik Holler: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77192
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic3ad843364e76725bb5fea8d7f92ba461f33bfe9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in jenkins[master]: Add PyYAML package to all slaves
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: Add PyYAML package to all slaves
......................................................................
Add PyYAML package to all slaves
Add package for both Python 2 and Python 3.
The package is needed by mock_runner itself (to enable mirrors from
file) as well as the upstream re-basing functionality.
Change-Id: Ie154eb6183b0ec589f4923bef06d35cebdf5c5b7
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1413
Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1348
---
M jobs/confs/shell-scripts/mock_setup.sh
1 file changed, 10 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved; Ready for merge
Eyal Edri: Looks good to me
Barak Korren: Verified
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77459
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie154eb6183b0ec589f4923bef06d35cebdf5c5b7
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in jenkins[master]: remove ovirt-web-ui project
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: remove ovirt-web-ui project
......................................................................
remove ovirt-web-ui project
JIRA: https://ovirt-jira.atlassian.net/browse/OVIRT-1408
Change-Id: I59c3507b3922766a09788b6986e1da218383b369
Signed-off-by: Eyal Edri <eedri(a)redhat.com>
---
D jobs/confs/projects/ovirt-web-ui/ovirt-web-ui_standard.yaml
1 file changed, 0 insertions(+), 41 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved; Ready for merge
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77342
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59c3507b3922766a09788b6986e1da218383b369
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months