June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: backend: override applyLockProperties in SyncLUNs
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: override applyLockProperties in SyncLUNs ...................................................................... backend: override applyLockProperties in SyncLUNs The method applyLockProperties was not overridden by SyncLunsInfoForBlockStorageDomainCommand and thus the exclusive lock with the group SYNC_LUNS on the storage domain's id was never taken before running this command. Since we don't want two SyncLunsInfoForBlockStorageDomain commands to run concurrently for the same block storage domain, this patch overrides this method so that lock will be taken. Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1 Related-To: https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ica5aad22abd354c94110ab14d371be6d63ef43b1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncAttachedDirectLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncAttachedDirectLunsCommand ...................................................................... backend: introduce SyncAttachedDirectLunsCommand This patch introduces a new command to synchronize direct luns that are attached to VMs in a given data center. It is useful when upgrading a data center or when a direct lun lacks some information because it was created via the REST API without a host. The command gets the data center id and synchronizes all the attached direct luns in it. It can also get one or more attached direct luns ids and synchronize only them. Note that the reason that we can't synchronize a floating direct lun is that it can be done by a host from any of the data centers, and hosts from different data centers might return different information about the lun. When a direct lun is attached to a VM, we pick a random host from the data center that this vm belongs to and use it to synchtonize the lun's information. Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/disk_lun_map_sp.sql 13 files changed, 313 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78059 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: sync all luns when upgrading a data center
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: sync all luns when upgrading a data center ...................................................................... backend: sync all luns when upgrading a data center Up until now, when upgrading a data center from version <= 4.0 to version >= 4.1, all the storage domains' luns were synchronized in order to update their discard related new data from vdsm. However, direct luns were never synchronized and updated, so their discard related data was not automatically updated. Now, also direct luns that are attached to a VM in the data center are synchronized. Also, since UpdateStoragePoolCommand now uses SyncAllUsedLunsCommand and doesn't call directly to SyncLunsInfoForBlockStorageDomainCommand for all n active block storage domain, synchronizing all their luns should take ~ n times faster than it did before. Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Bug-Url:https://bugzilla.redhat.com/1455547 Bug-Url:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 2 files changed, 14 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncStorageDomainsLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncStorageDomainsLunsCommand ...................................................................... backend: introduce SyncStorageDomainsLunsCommand This patch introduces a new command to synchronize all active block storage domains in a given data center. Previously, when synchronizing more than one storage domain (when upgrading a data center or when activating a host where the other hosts in the data center are not active), the engine used to call SyncLunsInfoForBlockStorageDomainCommand for each storage domain. The problem was that SyncLunsInfoForBlockStorageDomainCommand used to call GetVgInfoVDSCommand, so for each storage domain we did a full roundtrip to vdsm and back to the engine. With this patch, SyncStorageDomainsLunsCommand calls GetDeviceList only once, and uses that information to update all the domains in the data center. Therefore, when synchronizing n domains, the engine should do it ~ n times faster than it did before. Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 380 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: introduce SyncAllUsedLunsCommand
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: introduce SyncAllUsedLunsCommand ...................................................................... backend: introduce SyncAllUsedLunsCommand This patch introduces a new command to synchronize all used luns in a given data center, storage domains' luns and attached direct luns. Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllUsedLunsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 42 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78060 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: feed SyncLunsInfo command with VG info
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: backend: feed SyncLunsInfo command with VG info ...................................................................... backend: feed SyncLunsInfo command with VG info This patch adds an option to set the list of luns, usually returned by GetVGInfoVDSCommand, in SyncLunsInfoForBlockStorageDomainParameters. When set, the command will not execute the call to GetVGInfoVDSCommand, but use the input from the parameters. Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsInfoForBlockStorageDomainParameters.java 6 files changed, 55 insertions(+), 15 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/78057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Refactor of setting disk attributes.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Refactor of setting disk attributes. ...................................................................... core: Refactor of setting disk attributes. Engine updates the new disk image with updated size and actual size attributes based on the downloaded image retrieved from Glance. The engine reads the image using inputstream and therefore makes it hard to maintain for extra fields to update. The proposed patch refactors the update of the disk image fields, to be done inside the parsing method, making diskImage a parameter in the method signature. Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Bug-Url: https://bugzilla.redhat.com/1456432 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/storage/OpenStackImageProviderProxy.java 1 file changed, 20 insertions(+), 16 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77949 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea7f2c6b566d9436d9799c56e86901e956ec49ae Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Update relative path in test.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Update relative path in test. ...................................................................... core: Update relative path in test. Use relative path of bll instead of root backend - when running tests from the IDE the working directory is the root folder although run it from bll with mvn will use working directory of backend/manager/modules/bll, therefore changing the relative path of the XML file in the test to be relative to bll so jenkins tests will pass and for the IDE the working directory should be changed manually in the run configurations to be backend/manager/modules/bll. Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77888 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54a8b0264e453696d168fc12a9ce6d9e6da5e946 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Filter out unregistered external VMs.
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Filter out unregistered external VMs. ...................................................................... core: Filter out unregistered external VMs. Once a storage domain is being imported and attached, the engine set a list of unregistered entities the user can register. If one of those entities is external VM the engine should ignore it since it is not a VM which the user should import. Change-Id: I13c4ef4d33929fc6d9fd098f913d67c3688aded0 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77889 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I13c4ef4d33929fc6d9fd098f913d67c3688aded0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: Use disk id instead of volume id in OvfUtilsTest
by Code Review 11 Jun '17

11 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: core: Use disk id instead of volume id in OvfUtilsTest ...................................................................... core: Use disk id instead of volume id in OvfUtilsTest This fix is related to test of unregistered disks. The engine filters out disks which are attached to VMs to know which are unregistered disks and which are not. Since the filtering is being done with the disk id the test should be changed to use the disk id in the OVF instead of the volume id. Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Bug-Url: https://bugzilla.redhat.com/1443641 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/utils/OvfUtilsTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Maor Lipchuk: Verified -- To view, visit https://gerrit.ovirt.org/77887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5d1f613a6ead694e93f8a29cda53b0f24d6de03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0