June 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: webadmin, userportal: Improve GWT symbol map handling
by Code Review 08 Jun '17

08 Jun '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. Change subject: webadmin,userportal: Improve GWT symbol map handling ...................................................................... webadmin,userportal: Improve GWT symbol map handling Before this patch, GWT .symbolMap files were installed through optional `{webadmin-portal,userportal}-debuginfo` RPM packages, which used the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps/ $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps/ with above directories containing <gwtPermStrongName>.symbolMap files. This had two main drawbacks: 1, GWT symbol maps were optional (not available right after Engine installation), imposing one extra step when trying to diagnose and fix GWT UI related problems 2, GWT symbol maps are big: 9 locales x 3 user agents = 27 .symbolMap files for each GWT application, for WebAdmin each .symbolMap file is ~37 M (x 27 = ~1 G) After this patch, GWT .symbolMap files are part of the core UI packages, using the following layout: $PREFIX/share/ovirt-engine/gwt-symbols/webadmin/symbolMaps.zip $PREFIX/share/ovirt-engine/gwt-symbols/userportal/symbolMaps.zip This solves both issues listed above. In case of an uncaught UI exception, `OvirtRemoteLoggingService` servlet opens the .zip file (using Java 8 zip FileSystem support) and streams relevant .symbolMap content needed for Java stack trace de-obfuscation. This also means that `{webadmin-portal,userportal}-debuginfo` RPM packages are now unnecessary and are therefore removed. Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Bug-Url: https://bugzilla.redhat.com/1431545 Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com> --- M Makefile M backend/manager/modules/restapi/apidoc/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml A frontend/webadmin/modules/frontend-assemblies/pom.xml A frontend/webadmin/modules/frontend-assemblies/src/main/resources/assemblies/gwt-symbols.xml D frontend/webadmin/modules/frontend-symbols/pom.xml D frontend/webadmin/modules/frontend-symbols/resources/userportal/.keep D frontend/webadmin/modules/frontend-symbols/resources/webadmin/.keep M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/OvirtRemoteLoggingService.java M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M ovirt-engine.spec.in M pom.xml 15 files changed, 161 insertions(+), 148 deletions(-) Approvals: Jenkins CI: Passed CI tests Greg Sheremeta: Looks good to me, approved Vojtech Szocs: Verified -- To view, visit https://gerrit.ovirt.org/77892 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I083a3b8ad5588f56b8569c862240591a44002326 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-scheduler-proxy[master]: Release 0.1.7
by Code Review 08 Jun '17

08 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Release 0.1.7 ...................................................................... Release 0.1.7 Change-Id: Ic288044c92db2cf03d9f7a669eea36d0f9e01618 Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- M VERSION M ovirt-scheduler-proxy.spec.in 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Martin Sivák: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/77999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic288044c92db2cf03d9f7a669eea36d0f9e01618 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-scheduler-proxy[master]: Override Fedora 24 repositories for CI
by Code Review 08 Jun '17

08 Jun '17

>From Martin Sivák <msivak(a)redhat.com>: Martin Sivák has submitted this change and it was merged. Change subject: Override Fedora 24 repositories for CI ...................................................................... Override Fedora 24 repositories for CI Change-Id: I422a2a30c9a0d79f276630cd013a14b5a3797f2f Signed-off-by: Martin Sivak <msivak(a)redhat.com> --- A automation/build-artifacts.repos.fc24 A automation/check-patch.repos.fc24 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Martin Sivák: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/78007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I422a2a30c9a0d79f276630cd013a14b5a3797f2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-scheduler-proxy Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: save the ovirt-engine provider id
by Code Review 08 Jun '17

08 Jun '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: save the ovirt-engine provider id ...................................................................... packaging: save the ovirt-engine provider id The id of the installed ovirt-provider-ovn should be saved by engine-setup. We could have multiple providers added to the provider, so we need to know which is the one added by engine-setup in case of future updates. Change-Id: I14a3676b4dc66afe09f0e25e6f8026af60b14c3b Signed-off-by: Marcin Mirecki<mmirecki(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py 2 files changed, 21 insertions(+), 2 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved Marcin Mirecki: Verified Jenkins CI: Passed CI tests Yedidyah Bar David: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/77778 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14a3676b4dc66afe09f0e25e6f8026af60b14c3b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncAttachedDirectLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncAttachedDirectLunsCommand ...................................................................... backend: introduce SyncAttachedDirectLunsCommand This patch introduces a new command to synchronize direct luns that are attached to VMs in a given data center. It is useful when upgrading a data center or when a direct lun lacks some information because it was created via the REST API without a host. The command gets the data center id and synchronizes all the attached direct luns in it. It can also get one or more attached direct luns ids and synchronize only them. Note that the reason that we can't synchronize a floating direct lun is that it can be done by a host from any of the data centers, and hosts from different data centers might return different information about the lun. When a direct lun is attached to a VM, we pick a random host from the data center that this vm belongs to and use it to synchtonize the lun's information. Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncAttachedDirectLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskLunMapDaoImpl.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDiskDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskLunMapDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskVmElementDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/LunDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M packaging/dbscripts/disk_lun_map_sp.sql 20 files changed, 342 insertions(+), 5 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62b2d6a19400c180ae5869990df92639bbaa9b3b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncAllUsedLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncAllUsedLunsCommand ...................................................................... backend: introduce SyncAllUsedLunsCommand This patch introduces a new command to synchronize all used luns in a given data center, storage domains' luns and attached direct luns. Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAllUsedLunsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 42 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Looks good to me, but someone else must approve Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77102 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I601c0efa1f61a6268ffa98a186f7cb1187a2a33b Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: sync all luns when upgrading a data center
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: sync all luns when upgrading a data center ...................................................................... backend: sync all luns when upgrading a data center Up until now, when upgrading a data center from version <= 4.0 to version >= 4.1, all the storage domains' luns were synchronized in order to update their discard related new data from vdsm. However, direct luns were never synchronized and updated, so their discard related data was not automatically updated. Now, also direct luns that are attached to a VM in the data center are synchronized. Also, since UpdateStoragePoolCommand now uses SyncAllUsedLunsCommand and doesn't call directly to SyncLunsInfoForBlockStorageDomainCommand for all n active block storage domain, synchronizing all their luns should take ~ n times faster than it did before. Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Bug-Url:https://bugzilla.redhat.com/1455547 Bug-Url:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/UpdateStoragePoolCommandTest.java 2 files changed, 14 insertions(+), 106 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77103 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2f191a5f3580d7c73764b9dcd80fe8b4ed43b1e Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: introduce SyncStorageDomainsLunsCommand
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: introduce SyncStorageDomainsLunsCommand ...................................................................... backend: introduce SyncStorageDomainsLunsCommand This patch introduces a new command to synchronize all active block storage domains in a given data center. Previously, when synchronizing more than one storage domain (when upgrading a data center or when activating a host where the other hosts in the data center are not active), the engine used to call SyncLunsInfoForBlockStorageDomainCommand for each storage domain. The problem was that SyncLunsInfoForBlockStorageDomainCommand used to call GetVgInfoVDSCommand, so for each storage domain we did a full roundtrip to vdsm and back to the engine. With this patch, SyncStorageDomainsLunsCommand calls GetDeviceList only once, and uses that information to update all the domains in the data center. Therefore, when synchronizing n domains, the engine should do it ~ n times faster than it did before. Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Related-To:https://bugzilla.redhat.com/1404389 Related-To:https://bugzilla.redhat.com/1455547 Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommand.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/AbstractSyncLunsCommandTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncStorageDomainsLunsCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 6 files changed, 377 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/74381 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I744ae190397e00856ed67b99046efd1b1bb26054 Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: use streams in GetDeviceListQuery
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: use streams in GetDeviceListQuery ...................................................................... backend: use streams in GetDeviceListQuery Change-Id: I24ac7b35724649418a21609d210b6535caa1ef32 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/lun/GetDeviceListQuery.java 1 file changed, 5 insertions(+), 5 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77099 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24ac7b35724649418a21609d210b6535caa1ef32 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: backend: feed SyncLunsInfo command with VG info
by Code Review 08 Jun '17

08 Jun '17

>From Daniel Erez <derez(a)redhat.com>: Daniel Erez has submitted this change and it was merged. Change subject: backend: feed SyncLunsInfo command with VG info ...................................................................... backend: feed SyncLunsInfo command with VG info This patch adds an option to set the list of luns, usually returned by GetVGInfoVDSCommand, in SyncLunsInfoForBlockStorageDomainParameters. When set, the command will not execute the call to GetVGInfoVDSCommand, but use the input from the parameters. Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Related-To:https://bugzilla.redhat.com/1455548 Signed-off-by: Idan Shaby <ishaby(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/SyncLunsInfoForBlockStorageDomainCommandTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SyncLunsInfoForBlockStorageDomainParameters.java 6 files changed, 55 insertions(+), 15 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests Idan Shaby: Verified -- To view, visit https://gerrit.ovirt.org/77100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7115d7fc4a90faa61039d541617adba6822db2dd Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0