Change in ovirt-log-collector[master]: inventory: check for vms with VirtIO serial console in <= 3.5
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged.
Change subject: inventory: check for vms with VirtIO serial console in <= 3.5
......................................................................
inventory: check for vms with VirtIO serial console in <= 3.5
VMs with VirtIO serial console enabled in cluster levels 3.5
and below cannot be later live migrated to 3.6 hosts (on RHEL7).
Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/vms_with_cluster_lower_3_6_with_virtio_serial_console.sql
4 files changed, 71 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77726
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50e493c7b2d849dc8a1588629f21bedf4bf832d7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-hosted-engine-ha[v2.1.z]: monitors: Send multiple ping packets and penalize based on n...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: monitors: Send multiple ping packets and penalize based on number of lost
......................................................................
monitors: Send multiple ping packets and penalize based on number of lost
Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7
Bug-Url:https://bugzilla.redhat.com/1449333
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/ping.py
3 files changed, 33 insertions(+), 12 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/77806
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: v2.1.z
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-hosted-engine-ha[master]: monitors: Send multiple ping packets and penalize based on n...
by Code Review
>From Martin Sivák <msivak(a)redhat.com>:
Martin Sivák has submitted this change and it was merged.
Change subject: monitors: Send multiple ping packets and penalize based on number of lost
......................................................................
monitors: Send multiple ping packets and penalize based on number of lost
Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7
Bug-Url:https://bugzilla.redhat.com/1449333
Signed-off-by: Andrej Krejcir <akrejcir(a)redhat.com>
---
M ovirt_hosted_engine_ha/agent/hosted_engine.py
M ovirt_hosted_engine_ha/agent/states.py
M ovirt_hosted_engine_ha/broker/submonitors/ping.py
3 files changed, 33 insertions(+), 12 deletions(-)
Approvals:
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Andrej Krejcir: Verified
--
To view, visit https://gerrit.ovirt.org/77558
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I59d8d69dd88f4adbdc9322642cfec9332b6f59e7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: filter unmanaged devices from payload
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: filter unmanaged devices from payload
......................................................................
core: filter unmanaged devices from payload
Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77769
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: legacy usb fix
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: legacy usb fix
......................................................................
core: legacy usb fix
Apparently having unmanaged usb controller along with the managed controllers
we add, might result in conflicting addresses. Therefore, in this patch we
remove existing controllers before adding new ones.
Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000
Bug-Url: https://bugzilla.redhat.com/1443078
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jenkins CI: Passed CI tests
Arik Hadas: Verified
--
To view, visit https://gerrit.ovirt.org/77782
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic1c6236024cd30be5f8cc8822fb295bf84429000
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in otopi[master]: packaging: spec: fix repolib handling
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: fix repolib handling
......................................................................
packaging: spec: fix repolib handling
fixed repolib creation even when building with maven.
Previously it worked only while building without maven.
Change-Id: I2aeb9702aa41c7c94eb763dd5efc829a79c3e852
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M otopi.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77783
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2aeb9702aa41c7c94eb763dd5efc829a79c3e852
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-hosted-engine-setup[master]: packaging: spec: update dependencies
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: update dependencies
......................................................................
packaging: spec: update dependencies
Re-aligned dependencies for 4.2
Change-Id: I7be1d4c7f089e704e6310932a31e6b875710eeb6
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77786
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7be1d4c7f089e704e6310932a31e6b875710eeb6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Use ID from params for the locks in AmendImageGroupVol...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Use ID from params for the locks in AmendImageGroupVolumesCommand
......................................................................
core: Use ID from params for the locks in AmendImageGroupVolumesCommand
Use the disk ID from the parameters to create the shared locks map instead
of fetching the disk from the database just to use its ID
Change-Id: Ia7255f3cfd7bfd38d3f8f50d76690b3976888583
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77668
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7255f3cfd7bfd38d3f8f50d76690b3976888583
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Method reference in AmendImageGroupVolumesCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: Method reference in AmendImageGroupVolumesCommand
......................................................................
core: Method reference in AmendImageGroupVolumesCommand
Replace Lambda call in method reference for cleaner code
Change-Id: Ic46586b3b3b067fd1788f87e20990a67eb36077c
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77661
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic46586b3b3b067fd1788f87e20990a67eb36077c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: AmendImageGroupVolumesCommand streams
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: core: AmendImageGroupVolumesCommand streams
......................................................................
core: AmendImageGroupVolumesCommand streams
Change-Id: I2aceb7f9a6fb11d1aaf7456aec950bfa9443733c
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
1 file changed, 4 insertions(+), 11 deletions(-)
Approvals:
Tal Nisan: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77660
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2aceb7f9a6fb11d1aaf7456aec950bfa9443733c
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months