Change in ovirt-engine[master]: core: filter unmanaged devices from payload
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged.
Change subject: core: filter unmanaged devices from payload
......................................................................
core: filter unmanaged devices from payload
Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmPayloadQuery.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ondra Machacek: Verified
Martin Peřina: Looks good to me, approved
Jenkins CI: Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77710
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3795295e6c5f6d32f8f90249962a83d0092f804b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[ovirt-engine-4.1]: core: Include jcl-over-slf4j into tools modules
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged.
Change subject: core: Include jcl-over-slf4j into tools modules
......................................................................
core: Include jcl-over-slf4j into tools modules
Apache commons-logging libraries are reimplemented within WildFly.
In older versions the reimplementation has been provided by
'org.slf4j.jcl-over-slf4j' module, but in newer version
reimplementation has been changed to
'org.jboss.logmanager.commons.logging'.
This works fine if application is executed inside running WildFly,
but we are using those libraries also outside running EAP in command
line tools. In order to be able to use slf4j as our logging frontend
we are using standard slf4j implementation instead of WildFly
reimplementation of slf4j for our command line tools. Apache
commons-logging is used indirectly through commons-configuration also
in command line tool engine-config, so we would need to add
'org.slf4j.jcl-over-slf4j' into our special modules for command
line tools to override this reimplementation change.
Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215
Bug-Url: https://bugzilla.redhat.com/1457900
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M backend/manager/dependencies/tools/pom.xml
A backend/manager/dependencies/tools/src/main/modules/org/apache/commons/logging/main/module.xml
A backend/manager/dependencies/tools/src/main/modules/org/slf4j/jcl-over-slf4j/main/module.xml
M ovirt-engine.spec.in
4 files changed, 50 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Verified; Looks good to me, approved
Juan Hernandez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77656
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3fce0af7de78f5757a13a18c06dcd885dc7c215
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: [maven-release-plugin] prepare release 4.1.7
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare release 4.1.7
......................................................................
[maven-release-plugin] prepare release 4.1.7
Change-Id: I0768a70b979dab5243e02b8850996f3ab1ae9c50
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77705
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0768a70b979dab5243e02b8850996f3ab1ae9c50
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: [maven-release-plugin] prepare for next development iteration
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: [maven-release-plugin] prepare for next development iteration
......................................................................
[maven-release-plugin] prepare for next development iteration
Change-Id: Id83190a7107ab4ed7e5047f29fda0d91a66b4d24
---
M generator/pom.xml
M pom.xml
M sdk/pom.xml
3 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77706
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id83190a7107ab4ed7e5047f29fda0d91a66b4d24
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Don't use curl_multi_wait if curl <= 7.28.0
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't use curl_multi_wait if curl <= 7.28.0
......................................................................
Don't use curl_multi_wait if curl <= 7.28.0
The curl_multi_wait function was introduced in version 7.28.0 of
libcurl. That version of libcurl isn't available in some environments,
in particular it isn't available in the operating system used by default
in the Travis environment: Ubuntu Precise LTS. As a result the SDK fails
during runtime because of the missing symbol. To avoid that problem this
patch changes the SDK so that during build time it check the version of
the libcurl library, and if it is older than 7.28.0 it uses the 'select'
system call instead.
Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit c0a3f7699c0d3491253098bc900c57f9a4b8a941)
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 26 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Update CHANGES.adoc for release 4.1.7
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Update CHANGES.adoc for release 4.1.7
......................................................................
Update CHANGES.adoc for release 4.1.7
This patch updates the CHANGES.adoc file, documenting the relevant
changes in release 4.1.7.
Change-Id: I99f21c7aa62c558455aab53166f0078051a3af80
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/CHANGES.adoc
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99f21c7aa62c558455aab53166f0078051a3af80
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Don't run the tests if -DskipTests=true
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't run the tests if -DskipTests=true
......................................................................
Don't run the tests if -DskipTests=true
Currently the tests of the SDK are executed even when the
'-DskipTests=true' option is given in the Maven command line. A side
effect of this is that the tests run twice in Travis. To avoid that this
patch changes the POM of the SDK so that the tests will not be executed
in this scenario.
Change-Id: Iecdca3b98478279a3923c0382ad7494017526b41
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 43814c08daf338bc078b3aafe3b015dddf52de06)
---
M sdk/pom.xml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77702
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecdca3b98478279a3923c0382ad7494017526b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add Linux to the Travis configuration
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add Linux to the Travis configuration
......................................................................
Add Linux to the Travis configuration
This patch changes the Travis configuration so that the build runs in
Linux and macOS.
Change-Id: I6f0a3b044fcb8323f52481f7c7adc09ddb55d301
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
(cherry picked from commit 743b9e642e9b4697ddee97911695cc8e223a8b9b)
---
M .travis.yml
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77703
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f0a3b044fcb8323f52481f7c7adc09ddb55d301
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: sdk_4.1
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[master]: Don't use curl_multi_wait if curl <= 7.28.0
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't use curl_multi_wait if curl <= 7.28.0
......................................................................
Don't use curl_multi_wait if curl <= 7.28.0
The curl_multi_wait function was introduced in version 7.28.0 of
libcurl. That version of libcurl isn't available in some environments,
in particular it isn't available in the operating system used by default
in the Travis environment: Ubuntu Precise LTS. As a result the SDK fails
during runtime because of the missing symbol. To avoid that problem this
patch changes the SDK so that during build time it check the version of
the libcurl library, and if it is older than 7.28.0 it uses the 'select'
system call instead.
Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/ext/ovirtsdk4c/ov_http_client.c
1 file changed, 26 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77695
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e15d50601baf35445a5162abefd1d67ed24542c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine-sdk-ruby[master]: Don't run the tests if -DskipTests=true
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Don't run the tests if -DskipTests=true
......................................................................
Don't run the tests if -DskipTests=true
Currently the tests of the SDK are executed even when the
'-DskipTests=true' option is given in the Maven command line. A side
effect of this is that the tests run twice in Travis. To avoid that this
patch changes the POM of the SDK so that the tests will not be executed
in this scenario.
Change-Id: Iecdca3b98478279a3923c0382ad7494017526b41
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M sdk/pom.xml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77699
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iecdca3b98478279a3923c0382ad7494017526b41
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months