Change in ovirt-engine-sdk-ruby[master]: Add Linux to the Travis configuration
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged.
Change subject: Add Linux to the Travis configuration
......................................................................
Add Linux to the Travis configuration
This patch changes the Travis configuration so that the build runs in
Linux and macOS.
Change-Id: I6f0a3b044fcb8323f52481f7c7adc09ddb55d301
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M .travis.yml
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77700
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f0a3b044fcb8323f52481f7c7adc09ddb55d301
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk-ruby
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: optimization that reduces one db access on run vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged.
Change subject: core: optimization that reduces one db access on run vm
......................................................................
core: optimization that reduces one db access on run vm
Retrieve the USB controller model, that may require accessing the database for
getting the cluster compatibility version, only when it is needed. Note that
most of the time there will be no unmanaged usb controller so the model will
not be needed in that place.
Change-Id: I14d7fb8994e3567f52a0d783d3b30175344c93cb
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/77665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14d7fb8994e3567f52a0d783d3b30175344c93cb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 10 months
Change in ovirt-engine[master]: core: Remove redundant character in test name.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Remove redundant character in test name.
......................................................................
core: Remove redundant character in test name.
Seems like there is a redundant character "d" in the test name.
(It could be that this meant to be DC as in testIsUpDC)
renaming it to testIsUp.
Change-Id: I6f7c0b304c093039e63703225f5208d09210faf7
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StoragePoolValidatorTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit https://gerrit.ovirt.org/77669
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f7c0b304c093039e63703225f5208d09210faf7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: Modified SysV service script for ovirt-engine
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: Modified SysV service script for ovirt-engine
......................................................................
packaging: Modified SysV service script for ovirt-engine
The SysV service script was modified to only return after the
service is fully started.
Change-Id: I392b3642e022d5bc162eeb2195340ddad8577ca9
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
Bug-Url: https://bugzilla.redhat.com/1075013
---
M ovirt-engine.spec.in
M packaging/services/ovirt-engine/ovirt-engine.sysv.in
2 files changed, 11 insertions(+), 0 deletions(-)
Approvals:
Lev Veyde: Verified
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77266
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I392b3642e022d5bc162eeb2195340ddad8577ca9
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: CreateAllSnapshotsFromVmCommand#validate
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: CreateAllSnapshotsFromVmCommand#validate
......................................................................
core: CreateAllSnapshotsFromVmCommand#validate
This patch validates that all disks supplied by the user as command
parameters on SDK / REST API are allowed for snapshot, in order to
avoid snapshot's creation for direct-LUN disks.
(And solve the bug below).
The operation will fail with an error message.
Change-Id: Ie2b3d1f9af8dda189d1f438a3bd772e4db9bf9c4
Bug-Url: https://bugzilla.redhat.com/1442037
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 23 insertions(+), 6 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved; Passed CI tests
Shani Leviim: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/76997
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2b3d1f9af8dda189d1f438a3bd772e4db9bf9c4
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: Validate that disks are attached the VM before taking ...
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Validate that disks are attached the VM before taking a snapshot
......................................................................
core: Validate that disks are attached the VM before taking a snapshot
This patch validates that all disks supplied by the user as command's
parameters on SDK / REST API are attached to the VM (also supplied as
a command parameter).
Change-Id: I2e31d001bcfe758c4cddd8e74d69d4701db305eb
Bug-Url: https://bugzilla.redhat.com/1452139
Signed-off-by: Shani Leviim <sleviim(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 25 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Shani Leviim: Verified
Ala Hino: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/77317
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e31d001bcfe758c4cddd8e74d69d4701db305eb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[ovirt-engine-4.1]: packaging: spec: Require fluentd collectd-nest and viaq_data...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged.
Change subject: packaging: spec: Require fluentd collectd-nest and viaq_data_model plugins
......................................................................
packaging: spec: Require fluentd collectd-nest and viaq_data_model plugins
Change-Id: I7280b41ba3da24ae291b6dd24b4c4bdadb1158bd
Bug-Url: https://bugzilla.redhat.com/1426904
Bug-Url: https://bugzilla.redhat.com/1426905
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit d9c60d668043d12ca20ff8c952ce8f6b9b4cc9e6)
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/77658
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7280b41ba3da24ae291b6dd24b4c4bdadb1158bd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: packaging: spec: Require fluentd collectd-nest and viaq_data...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: Require fluentd collectd-nest and viaq_data_model plugins
......................................................................
packaging: spec: Require fluentd collectd-nest and viaq_data_model plugins
Change-Id: I7280b41ba3da24ae291b6dd24b4c4bdadb1158bd
Bug-Url: https://bugzilla.redhat.com/1426904
Bug-Url: https://bugzilla.redhat.com/1426905
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M ovirt-engine.spec.in
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/77651
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7280b41ba3da24ae291b6dd24b4c4bdadb1158bd
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-host-deploy[ovirt-host-deploy-1.6]: metrics: Install fluentd collectd-nest and viaq_data_model p...
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: metrics: Install fluentd collectd-nest and viaq_data_model plugins
......................................................................
metrics: Install fluentd collectd-nest and viaq_data_model plugins
Change-Id: I1ea33e27c099c0969b37f8c3d3d0ec0d382f9b25
Bug-Url: https://bugzilla.redhat.com/1426900
Bug-Url: https://bugzilla.redhat.com/1426903
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 527a95bc7d8398a4cf5a185637b38cc2e61234de)
---
M src/plugins/ovirt-host-deploy/fluentd/packages.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/77657
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ea33e27c099c0969b37f8c3d3d0ec0d382f9b25
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: ovirt-host-deploy-1.6
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
6 years, 11 months
Change in ovirt-hosted-engine-setup[ovirt-hosted-engine-setup-2.1]: packaging: spec: Require fluentd viaq_data_model plugin
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged.
Change subject: packaging: spec: Require fluentd viaq_data_model plugin
......................................................................
packaging: spec: Require fluentd viaq_data_model plugin
Change-Id: I58b6ae6587acb9dc493ef00c8c32c8ed4a1e3d92
Bug-Url: https://bugzilla.redhat.com/1426898
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
(cherry picked from commit 5cfd6d3b4cee8e51fcfb463d87d363e51013d93e)
---
M ovirt-hosted-engine-setup.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified
--
To view, visit https://gerrit.ovirt.org/77654
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58b6ae6587acb9dc493ef00c8c32c8ed4a1e3d92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: ovirt-hosted-engine-setup-2.1
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months