July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Gluster disk as network device
by Code Review 23 Jul '17

23 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/41899 ) Change subject: core: Gluster disk as network device ...................................................................... core: Gluster disk as network device In 4.1, vdsm supports gluster libgfapi. This patch checks that cluster version is 4.1 (or higher). If so and the vm uses gluster disk, engine sets diskType to 'network'. Setting diskType to 'network' provides info to vdsm to use libgfapi interface. Change-Id: I061594c83342883804fc379a00a953591474bdbb Bug-Url: https://bugzilla.redhat.com/1022961 Signed-off-by: Ala Hino <ahino(a)redhat.com> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever(a)redhat.com> Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com> Signed-off-by: Sahina Bose <sabose(a)redhat.com> Signed-off-by: Denis Chaplygin <dchaplyg(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VmReplicateDiskParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuilderImpl.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmReplicateDiskVDSCommand.java 8 files changed, 59 insertions(+), 3 deletions(-) Approvals: Denis Chaplygin: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/41899 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I061594c83342883804fc379a00a953591474bdbb Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <d.mosquito(a)gmail.com> Gerrit-Reviewer: Prasanna Kumar Kalever <prasanna.kalever(a)redhat.com> Gerrit-Reviewer: Ramesh N <ramesh.mail2u(a)gmail.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Fix potential NPE when using NetworkPolicyUnit
by Code Review 23 Jul '17

23 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79686 ) Change subject: core: Fix potential NPE when using NetworkPolicyUnit ...................................................................... core: Fix potential NPE when using NetworkPolicyUnit PolicyUnitImpl#filter is only called from one place, SchedulingManager#runInternalFilters, which assumes it cannot return null. NetworkPolicyImpl breaks this rule by returning null if it's pass an empty list of hosts. This patch prevents this potential bug by returning an empty list instead. Change-Id: I2b689d9ddcc086e1836bcea7caa652608e43f708 Coverity-CID: 1378169 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79686 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2b689d9ddcc086e1836bcea7caa652608e43f708 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: backup flag added to storage domain static
by Code Review 23 Jul '17

23 Jul '17

>From Maor Lipchuk <mlipchuk(a)redhat.com>: Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/77142 ) Change subject: core: backup flag added to storage domain static ...................................................................... core: backup flag added to storage domain static New boolean field is introduced to set the storage domain as backup data storage domain. If value is set to true then that domain will be used as backup domain. Change-Id: I1453b52f4330d0e5cb12d8fa08426fd68f3cd329 Signed-off-by: Shubham Dubey <sdubey504(a)gmail.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/04_02_0420_add_backup_flag.sql 11 files changed, 57 insertions(+), 20 deletions(-) Approvals: Jenkins CI: Passed CI tests Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/77142 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1453b52f4330d0e5cb12d8fa08426fd68f3cd329 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: shubham dubey <sdubey504(a)gmail.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org> Gerrit-Reviewer: shubham dubey <sdubey504(a)gmail.com>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add multipath check for RHEV|VDSM PRIVATE
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79685 ) Change subject: inventory: Add multipath check for RHEV|VDSM PRIVATE ...................................................................... inventory: Add multipath check for RHEV|VDSM PRIVATE Change-Id: Ifb9856390a4563c712d3917030f536260818f653 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 39 insertions(+), 5 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb9856390a4563c712d3917030f536260818f653 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: ignore ssl=true and port=54321
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79684 ) Change subject: inventory: ignore ssl=true and port=54321 ...................................................................... inventory: ignore ssl=true and port=54321 These are defaults values in vdsm.conf, ignore these values and print any other conf listed. Change-Id: I36c183f991568728a4d2dbc77744ade878e66ff6 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/vdsm-config-reader 1 file changed, 7 insertions(+), 15 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79684 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I36c183f991568728a4d2dbc77744ade878e66ff6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: only display Main pkgs engine if required
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79683 ) Change subject: inventory: only display Main pkgs engine if required ...................................................................... inventory: only display Main pkgs engine if required This patch adds a validation before priting the section Change-Id: I7d24f7762c443420f6cfd27ba2c208362b628de6 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79683 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d24f7762c443420f6cfd27ba2c208362b628de6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: display bookmarks data
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79682 ) Change subject: inventory: display bookmarks data ...................................................................... inventory: display bookmarks data Change-Id: I89cdeab67bff70eb82a32d256151e52631b9ec14 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/bookmarks_query_name_value.sql A src/inventory_report/produceReport/sqls/bookmarks_query_number_of_rows.sql 4 files changed, 19 insertions(+), 0 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79682 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89cdeab67bff70eb82a32d256151e52631b9ec14 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[ovirt-log-collector-4.1]: produceReport: Present host configurations
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79681 ) Change subject: produceReport: Present host configurations ...................................................................... produceReport: Present host configurations This patch adds a new section - Host Configuration - and presents vdsm.conf in case it doesn't have the defaults values for ssl and port. Change-Id: I732b8b3161c33f5b014f4a46964c34dad0bd8398 Signed-off-by: Ala Hino <ahino(a)redhat.com> Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- A COPYING-GPL M Makefile.am M ovirt-log-collector.spec.in M src/inventory_report/Makefile.am M src/inventory_report/importDumpIntoNewDb.sh A src/inventory_report/inventory-profile M src/inventory_report/ovirt-log-collector-analyzer.sh M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/unpackHostsSosReports.sh A src/inventory_report/vdsm-config-reader 10 files changed, 534 insertions(+), 3 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/79681 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I732b8b3161c33f5b014f4a46964c34dad0bd8398 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: ovirt-log-collector-4.1 Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: Add multipath check for RHEV|VDSM PRIVATE
by Code Review 21 Jul '17

21 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79580 ) Change subject: inventory: Add multipath check for RHEV|VDSM PRIVATE ...................................................................... inventory: Add multipath check for RHEV|VDSM PRIVATE Change-Id: Ifb9856390a4563c712d3917030f536260818f653 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 39 insertions(+), 5 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79580 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb9856390a4563c712d3917030f536260818f653 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: [maven-release-plugin] prepare for next development iteration
by Code Review 21 Jul '17

21 Jul '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. ( https://gerrit.ovirt.org/79662 ) Change subject: [maven-release-plugin] prepare for next development iteration ...................................................................... [maven-release-plugin] prepare for next development iteration Change-Id: I8d4f47a73bc66f6ca2e27391bb94810ad5f9fb34 Signed-off-by: Ondra Machacek <omachace(a)redhat.com> --- M generator/pom.xml M pom.xml M sdk/pom.xml 3 files changed, 4 insertions(+), 4 deletions(-) Approvals: Ondra Machacek: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d4f47a73bc66f6ca2e27391bb94810ad5f9fb34 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0