Change in jenkins[master]: Add ovirt-ansible jobs
by Code Review
>From Eyal Edri <eedri(a)redhat.com>:
Eyal Edri has submitted this change and it was merged. ( https://gerrit.ovirt.org/79248 )
Change subject: Add ovirt-ansible jobs
......................................................................
Add ovirt-ansible jobs
Change-Id: I04342d8a423d5e7f1a3decb502fae6ac86505bad
Signed-off-by: Ondra Machacek <omachace(a)redhat.com>
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
A jobs/confs/projects/ovirt-ansible/ovirt-ansible.yaml
1 file changed, 34 insertions(+), 0 deletions(-)
Approvals:
Eyal Edri: Looks good to me, approved; Ready for merge
Barak Korren: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79248
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04342d8a423d5e7f1a3decb502fae6ac86505bad
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in jenkins[refs/meta/config]: Preserve votes when rebasing patches
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79748 )
Change subject: Preserve votes when rebasing patches
......................................................................
Preserve votes when rebasing patches
Change-Id: I3af15d9f84752d16ef55248a703821d0991aa31e
---
M project.config
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Passed CI tests; Ready for merge
--
To view, visit https://gerrit.ovirt.org/79748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3af15d9f84752d16ef55248a703821d0991aa31e
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: refs/meta/config
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in otopi[master]: core: Read config files early
by Code Review
>From Yedidyah Bar David <didi(a)redhat.com>:
Yedidyah Bar David has submitted this change and it was merged. ( https://gerrit.ovirt.org/79743 )
Change subject: core: Read config files early
......................................................................
core: Read config files early
It used to be at STAGE_INIT, PRIORITY_HIGH - 10.
A recent patch removed the priority.
So any plugin that happened to setdefault some env key to None,
before otopi ran core/config.py, succeeded. So answer files setting the
default (which is the default for our automatically-generated answer
files, so most automation tools inherited this as well), did not work.
Revert this for now.
Later on, we should move to STAGE_BOOT, but change all plugins that
set CONFIG_FILE_NAME to run before us (CORE_CONFIG_INIT).
Change-Id: Ib3adb0821c9d2702092e1bbd80234309888f2838
Signed-off-by: Yedidyah Bar David <didi(a)redhat.com>
---
M src/plugins/otopi/core/config.py
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Yedidyah Bar David: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79743
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib3adb0821c9d2702092e1bbd80234309888f2838
Gerrit-PatchSet: 2
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: core: set new Pool's images format to COW for 'auto select t...
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged. ( https://gerrit.ovirt.org/79599 )
Change subject: core: set new Pool's images format to COW for 'auto select target'
......................................................................
core: set new Pool's images format to COW for 'auto select target'
In case new pool is created based on a template with disk(s) and the
'Auto select target' checkbox (in 'Resource allocation' tab) is set,
all Pool VM's images are required to be created with volume format set to
the same format as the template's disk (RAW or COW).
If RAW format is required for the Pool VM's images, then the Pool
creation failed on validation phase.
Because of that problem, the 'auto select target' feature isn't working and it is a
regression (the regression was added in change id: I6f0f143).
This patch fixes it by setting each diskImage.volumeFormat of the Pool's template
to COW (or RAW if the disk storage type is CINDER) before creating the Pool's VMs.
Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a
Bug-Url: https://bugzilla.redhat.com/1468301
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolCommand.java
1 file changed, 16 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79599
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd04cbcea08125e06c0b9ffb237bcb53057a61a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: engine: handle NPE for guest info data of a powered-off vm
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged. ( https://gerrit.ovirt.org/79643 )
Change subject: engine: handle NPE for guest info data of a powered-off vm
......................................................................
engine: handle NPE for guest info data of a powered-off vm
In case of powering-off a running VM with guest info data (i.e.
guest agent installed) and guestOsType == OsType.Windows, then
displaying 'guest info' sub-tab raises a NPE.
This is becuase powering off a VM, sets vm.guestOs field to null in
ResourceManager.resetVmAttributes(), while other Os fields like
guestOsType are not set to null.
That causes VmGuestInfoModel.setGuestOsNamedVersion() to fail while
trying to access that field.
This patch fixes it by avoid setting vm.guestOs to null.
Bug-Url: https://bugzilla.redhat.com/1448650
Change-Id: I4f84fbe6abbc74bae54de80d8f5348646b8df3b4
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79643
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f84fbe6abbc74bae54de80d8f5348646b8df3b4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: don't remove VG ID of direct lun that is a part of ...
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged. ( https://gerrit.ovirt.org/79704 )
Change subject: backend: don't remove VG ID of direct lun that is a part of a SD
......................................................................
backend: don't remove VG ID of direct lun that is a part of a SD
When synchronizing a direct lun, the VG ID that comes from getDeviceList
used to be changed to an empty string before updating the lun in the DB,
assuming that a direct lun doesn't have a VG ID and thus the
information that comes from vdsm is old and irrelevant.
That isn't true when talking about a lun which is a part of a storage
domain (and thus has a VG ID) and is also used as a direct lun.
Therefore, this patch makes sure that when synchronizing a direct lun,
the VG ID will be updated only if it is not an empty string.
Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49
Bug-Url: https://bugzilla.redhat.com/1471759
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/pool/SyncAttachedDirectLunsCommandTest.java
2 files changed, 30 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/79704
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3171bee8bc0d45c459977638919489bb25cc4e49
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: Fix issues with HTTP retries in mirror_client
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79038 )
Change subject: Fix issues with HTTP retries in mirror_client
......................................................................
Fix issues with HTTP retries in mirror_client
The retrying loop had a couple of bugs:
1. It was retrying too fast, so was ineffective in practice
2. Exception raising code had an error which caused masking of the
actual exception that needed to be raised
Change-Id: I060ff165e37c713a1d0ccbe254b3cb0c7c8920c0
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1086
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M scripts/mirror_client.py
M test/test_mirror_client.py
2 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79038
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I060ff165e37c713a1d0ccbe254b3cb0c7c8920c0
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in jenkins[master]: Make writing of mirror latest index files atomic
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79068 )
Change subject: Make writing of mirror latest index files atomic
......................................................................
Make writing of mirror latest index files atomic
We had some issues with the writing of index files not being atomic, so
this patch makes it atomic.
This patch also includes code to ensure proper permissions are set on
the index files.
Change-Id: I2bd57f2ad4eb4bff9b768c6db70a29f37eee822b
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1086
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M scripts/mirror_mgr.sh
1 file changed, 43 insertions(+), 6 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79068
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2bd57f2ad4eb4bff9b768c6db70a29f37eee822b
Gerrit-PatchSet: 11
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in jenkins[master]: Make GitHub jobs deploy to 'tested'
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79289 )
Change subject: Make GitHub jobs deploy to 'tested'
......................................................................
Make GitHub jobs deploy to 'tested'
Since we're gonna remove 'experimental', and CQ does not support events
from GitHub yet, allow GitHub projects to deploy directly to the
'tested' repo.
This patch also includes initial work on per-stage publishers to avoid
making the check-merged jobs trigger the deploy jobs.
Change-Id: Ifc7070d016cf08971231917fd4a6e77f587fa7e3
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/yaml/publishers/standard.yaml
M jobs/confs/yaml/templates/standard-stage.yaml
2 files changed, 29 insertions(+), 12 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79289
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc7070d016cf08971231917fd4a6e77f587fa7e3
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gal Ben Haim <galbh2(a)gmail.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in ovirt-engine[master]: engine: Enable per cluster setting for gfapi access
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/71457 )
Change subject: engine: Enable per cluster setting for gfapi access
......................................................................
engine: Enable per cluster setting for gfapi access
in 4.1 cluster levels by checking for the additional feature
Change-Id: I3356e4c5bd38487c2ac8dae7105c61f996d3759f
Bug-Url: https://bugzilla.redhat.com/1022961
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java
M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtilsTest.java
A packaging/dbscripts/upgrade/04_02_0430_add_libgfapi_additional_feature.sql
3 files changed, 85 insertions(+), 7 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/71457
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3356e4c5bd38487c2ac8dae7105c61f996d3759f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ramesh N <ramesh.mail2u(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months