Change in ovirt-engine[master]: backend: direct LUN should not have a PV ID in the DB
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79877 )
Change subject: backend: direct LUN should not have a PV ID in the DB
......................................................................
backend: direct LUN should not have a PV ID in the DB
When a lun is used as a part of a storage domain, it contains a PV ID in
the luns table.
However, when it is used as a direct LUN, vdsm doesn't create a PV on it
and thus it shouldn't contain a PV ID in that table.
This patch makes sure that a lun won't have an old PV ID in the DB (the
PV ID of that lun which was previously a part of a storage domain) in
case it is used purely as a direct LUN, and not both as a part of a
storage domain and as a direct LUN.
Change-Id: I427bfae9102e1465d7f00d18bdf9cf9372b6c1a1
Bug-Url: https://bugzilla.redhat.com/1475767
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/connection/StorageHelperBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/LunHelper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/pool/SyncDirectLunsCommand.java
4 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/79877
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I427bfae9102e1465d7f00d18bdf9cf9372b6c1a1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[master]: backend: remove character restrictions from network names
by Code Review
>From Alona Kaplan <alkaplan(a)redhat.com>:
Alona Kaplan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79116 )
Change subject: backend: remove character restrictions from network names
......................................................................
backend: remove character restrictions from network names
Currently, oVirt limits the names of its networks to 15
alphanumeric characters. This limitation dates back to
the ages where all networks were VM network, all were
implemented by a Linux bridge, and the same name was
used to identify the network and the Linux bridge
implementing it on each host.
That has to change. 15 characters are not enough for
humans; spaces, and other special characters are
visually useful, and non-English speaking users
would love to use their native alphabet in network names.
For this reason network names are allowed to consist of 256 Unicode
characters. If a Linux bridge is created, the name is created
from the network name, if it is suitable, or from the network's uuid.
Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/AddNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/HostNetwork.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkDaoImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/NetworkDaoTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/NetworkUtils.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/bll/network/NetworkVdsmNameMapper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetCapabilitiesVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M packaging/dbscripts/create_views.sql
M packaging/dbscripts/network_sp.sql
A packaging/dbscripts/upgrade/04_02_0450_add_vdsm_name_to_network.sql
16 files changed, 115 insertions(+), 28 deletions(-)
Approvals:
Alona Kaplan: Looks good to me, approved
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
--
To view, visit https://gerrit.ovirt.org/79116
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idadf272959ae10afc1de7ed6ce6daed70b78b73d
Gerrit-PatchSet: 39
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: Make CI information available in the CI env
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78647 )
Change subject: Make CI information available in the CI env
......................................................................
Make CI information available in the CI env
This patch exposes the reposfile, the ci stage and the ci
distro to the mock env as environmental variables.
Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1069
Change-Id: I28069acb9af19daeaac9a0b0142995f6c9904576
---
M mock_configs/mock_runner.sh
1 file changed, 37 insertions(+), 2 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Daniel Belenky: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/78647
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I28069acb9af19daeaac9a0b0142995f6c9904576
Gerrit-PatchSet: 15
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in ovirt-engine[master]: core: reinstall of the host as a task
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged. ( https://gerrit.ovirt.org/79557 )
Change subject: core: reinstall of the host as a task
......................................................................
core: reinstall of the host as a task
Show host reinstall in tasks list.
Change-Id: I61316ddc2309d2305981f952a9cf9e29d80efb9c
Bug-Url: https://bugzilla.redhat.com/1457879
Signed-off-by: Miroslava Voglova <mvoglova(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Miroslava Voglova: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79557
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I61316ddc2309d2305981f952a9cf9e29d80efb9c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Miroslava Voglova <mvoglova(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Miroslava Voglova <mvoglova(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: Change the way poll script reads git push map file
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78812 )
Change subject: Change the way poll script reads git push map file
......................................................................
Change the way poll script reads git push map file
After finding out that push url wouldn't always differ
only in the base url but can also differ in the url path
we have decided to use regex as a key instead of url to
support all future occurences of clone and push urls
Change-Id: Ie99d101b98cdc61a4fde80430c4d3ce1edab58aa
---
M jobs/confs/python-scripts/poll-upstream-sources.py
1 file changed, 79 insertions(+), 24 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Gil Shinar: Verified; Ready for review
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78812
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99d101b98cdc61a4fde80430c4d3ce1edab58aa
Gerrit-PatchSet: 20
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in ovirt-engine[master]: core: use ovf:href instead of ovf:fileRef to identify disk id
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79589 )
Change subject: core: use ovf:href instead of ovf:fileRef to identify disk id
......................................................................
core: use ovf:href instead of ovf:fileRef to identify disk id
According to the OVF specification, ovf:fileRef attribute of a disk should
point to the ovf:id attribute of a File element within the References
section. However, we used that attribute exactly as the ovf:href attribute
of a File element so it was also used to retrieve the disk's (image group's)
id. This patches changes that so ovf:href will be used instead.
We should note that we still can't change the content of ovf:fileRef to
something else than the relative path of the volume because previous
versions still count on that.
Change-Id: I2b3a8f379a68ad089547f85d8d93d2bbb5213c54
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/OvfUtils.java
1 file changed, 4 insertions(+), 19 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Arik Hadas: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79589
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b3a8f379a68ad089547f85d8d93d2bbb5213c54
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: Export pushed container(s) details to an html file
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79753 )
Change subject: Export pushed container(s) details to an html file
......................................................................
Export pushed container(s) details to an html file
Instead of parsing container's details though Groovy,
collect_artifacts.sh will generate an HTML file which
will be read by Groovy as String.
Change-Id: I40bc4c7bd30f6ea923b70227f91c20cdac16895f
Signed-off-by: Daniel Belenky <dbelenky(a)redhat.com>
---
M jobs/confs/shell-scripts/collect_artifacts.sh
M jobs/confs/yaml/publishers/standard.yaml
2 files changed, 58 insertions(+), 16 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Daniel Belenky: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/79753
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I40bc4c7bd30f6ea923b70227f91c20cdac16895f
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in jenkins[master]: Fix cleanup_docker
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79402 )
Change subject: Fix cleanup_docker
......................................................................
Fix cleanup_docker
cleanup_docker failed when it encountered images (mostly layers)
without repo or tag.
This patch fixes the cleanup bug by addressing the images by
the image id instead of repo/tag.
Also moved a global constant (whitelisted repositories) to
the top of the file where it belongs.
Jira: https://ovirt-jira.atlassian.net/browse/OVIRT-1535
Change-Id: Ic6086eff1a211d8d4154b65b41d0a3a77d52e9f6
---
M jobs/confs/shell-scripts/cleanup_slave.sh
1 file changed, 6 insertions(+), 5 deletions(-)
Approvals:
Barak Korren: Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
Daniel Belenky: Verified; Ready for review
--
To view, visit https://gerrit.ovirt.org/79402
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6086eff1a211d8d4154b65b41d0a3a77d52e9f6
Gerrit-PatchSet: 6
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 9 months
Change in ovirt-engine[master]: webadmin: data table show '0 - 0' when no records to display
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79942 )
Change subject: webadmin: data table show '0 - 0' when no records to display
......................................................................
webadmin: data table show '0 - 0' when no records to display
When a data table had no records to show, the from count would
be '1' while the to/total count would be '0'. Showing record
'1 - 0' doesn't make sense. Now when no records are returned,
the from is set to '0'.
Change-Id: I1164429f53e6b62430e4cc094d0736a0fecfdf37
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/SimpleActionTable.java
1 file changed, 12 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, approved
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/79942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1164429f53e6b62430e4cc094d0736a0fecfdf37
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-live[ovirt-live-4.1]: build: ovirt-live 4.1.4
by Code Review
>From Lev Veyde <lveyde(a)redhat.com>:
Lev Veyde has submitted this change and it was merged. ( https://gerrit.ovirt.org/79936 )
Change subject: build: ovirt-live 4.1.4
......................................................................
build: ovirt-live 4.1.4
Change-Id: I3908da810c0083782f0db8118921c0c4c3cf963b
Signed-off-by: Lev Veyde <lveyde(a)redhat.com>
---
M centos-7/Makefile
M centos-7/kickstart/ovirt-live-ovirt-custom.ks.in
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Lev Veyde: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3908da810c0083782f0db8118921c0c4c3cf963b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: ovirt-live-4.1
Gerrit-Owner: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months