Change in ovirt-log-collector[master]: inventory: Warn if compatibility version for cluster is < 3.6
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79924 )
Change subject: inventory: Warn if compatibility version for cluster is < 3.6
......................................................................
inventory: Warn if compatibility version for cluster is < 3.6
In the past, we warn users if there are vms in compatibility < 3.6.
This patch adds validation for clusters.
Change-Id: I8eaf70ca42edbaf95d3d0d87ad58f241c66e9abc
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/cluster_query_minimum_3_6_compat_version.sql
4 files changed, 62 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79924
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8eaf70ca42edbaf95d3d0d87ad58f241c66e9abc
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[master]: Add warning about Legacy LDAP provider
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79918 )
Change subject: Add warning about Legacy LDAP provider
......................................................................
Add warning about Legacy LDAP provider
Change-Id: I437c6df7671c6e33867e9091d4ef3f7f297df3fd
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/vdc_options_query_AAA_legacy.sql
4 files changed, 27 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Ondra Machacek: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79918
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I437c6df7671c6e33867e9091d4ef3f7f297df3fd
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[ovirt-engine-4.1]: aaa: Flood of log: Unable to cleanup SsoSession
by Code Review
>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>:
Piotr Kliczewski has submitted this change and it was merged. ( https://gerrit.ovirt.org/79893 )
Change subject: aaa: Flood of log: Unable to cleanup SsoSession
......................................................................
aaa: Flood of log: Unable to cleanup SsoSession
If a session was invalidated by the
container before SSO gets a chance to clean
up expired sessions an IllegalStateException
is thrown. The log is flooded with messages
from the exception. Log the messages as debug
messages for such exceptions.
Change-Id: Id470fc204d7d7f2512a1858e0577bd48be269b96
Bug-Url: https://bugzilla.redhat.com/1474482
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/utils/TokenCleanupUtility.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Ravi Nori: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79893
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id470fc204d7d7f2512a1858e0577bd48be269b96
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[master]: db for PG 9.5 : fix sp return type
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/79910 )
Change subject: db for PG 9.5 : fix sp return type
......................................................................
db for PG 9.5 : fix sp return type
This patch fixes an issue in GetEntitiesNameMap SP that uses the "CREATE
TABLE" syntax to return a result set. (introduced in commit bc050c6f)
This is not the standard way we use although it is legal, we are using a
creation of a TYPE and then returning a SETOF the created TYPE.
The non-standard return value caused engine to crash with jdbc 42.3.1
(latest) and spring 4.3.9 (actually the crash is in spring)
This was a blocker for our planned shift to PG 9.5
After this patch, the engine runs OK and all DB DAO tests PASS.
Change-Id: Ic04b0b2470a173b6e2bc4ba6351bbee40930e604
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/labels_sp.sql
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Martin Peřina: Looks good to me, approved
Eli Mesika: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79910
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic04b0b2470a173b6e2bc4ba6351bbee40930e604
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add new Hosted Engine doc
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79921 )
Change subject: inventory: Add new Hosted Engine doc
......................................................................
inventory: Add new Hosted Engine doc
How to upgrade RHEV 3.5 Hosted-Engine environment with RHEL 6 hosts / hypervisors to RHEV 3.6
Change-Id: Ibf9e553fb7e33907b8ce2f10902ffe4359ea0b83
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
(cherry picked from commit dde7de014c263f14bb0ceb8d8e1ad1a0c80303d3)
---
M src/inventory_report/produceReport/docs-helper
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79921
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf9e553fb7e33907b8ce2f10902ffe4359ea0b83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[master]: inventory: Add new Hosted Engine doc
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79920 )
Change subject: inventory: Add new Hosted Engine doc
......................................................................
inventory: Add new Hosted Engine doc
How to upgrade RHEV 3.5 Hosted-Engine environment with RHEL 6 hosts / hypervisors to RHEV 3.6
Change-Id: Ibf9e553fb7e33907b8ce2f10902ffe4359ea0b83
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/docs-helper
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79920
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf9e553fb7e33907b8ce2f10902ffe4359ea0b83
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add From MAC and To MAC into the macpools query
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79919 )
Change subject: inventory: Add From MAC and To MAC into the macpools query
......................................................................
inventory: Add From MAC and To MAC into the macpools query
Change-Id: Ibb8b431f240ab4a4bf50128dfa2d6842a7cc0d34
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/sqls/mac_pools_query_show_data_based_on_datacenter_and_cluster.sql
1 file changed, 9 insertions(+), 5 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb8b431f240ab4a4bf50128dfa2d6842a7cc0d34
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[master]: webadmin: refactor configure popup, tab contents and dialog ...
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79804 )
Change subject: webadmin: refactor configure popup, tab contents and dialog tab panel
......................................................................
webadmin: refactor configure popup, tab contents and dialog tab panel
For the configuration popup, refactor the code to put as much view
setup in the UiBinder file as possible. Each content tab was also
refactored to layout the content in bootstrap/PatternFly containers
and to put as much view setup in UiBinders as possible. All config
tab content has also been configured to scroll vertically as needed.
Updated dialog tab panel such that a tab's content has no horizontal
margin allowing the tab's content to use the entire space or use the
default bootstrap/PatternFly container margins.
For the SharedMaxPoolView, refactored the layout code into a UIBinder
to maintain consistency between all of the config popup tab widgets.
Change-Id: I60bb1729d4b8297d69f710debc8d130f8a8bb53e
Signed-off-by: Scott J Dickerson <sdickers(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/ConfigurePopupView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RoleView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/SystemPermissionView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/instancetypes/InstanceTypesView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/instancetypes/InstanceTypesView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/macpool/SharedMacPoolView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/scheduling/ClusterPolicyView.ui.xml
13 files changed, 309 insertions(+), 264 deletions(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Greg Sheremeta: Looks good to me, but someone else must approve
Scott Dickerson: Verified
--
To view, visit https://gerrit.ovirt.org/79804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60bb1729d4b8297d69f710debc8d130f8a8bb53e
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Andrej Krejcir <akrejcir(a)redhat.com>
Gerrit-Reviewer: Denis Chaplygin <dchaplyg(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar <jtokar(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Phillip Bailey <phbailey(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yanir Quinn <yquinn(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in ovirt-engine[master]: webadmin: Add missing space in Job notification
by Code Review
>From Alexander Wels <awels(a)redhat.com>:
Alexander Wels has submitted this change and it was merged. ( https://gerrit.ovirt.org/79908 )
Change subject: webadmin: Add missing space in Job notification
......................................................................
webadmin: Add missing space in Job notification
When a Job finishes, a pop up message appears on the top right of
the screen.
A space character was missing between the result state and the
operation description.
Change-Id: I830bfada81e203ce3a25a06a920219fcccbbceec
Signed-off-by: Fred Rolland <frolland(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/overlay/TasksPresenter.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Freddy Rolland: Verified
--
To view, visit https://gerrit.ovirt.org/79908
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I830bfada81e203ce3a25a06a920219fcccbbceec
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 9 months
Change in jenkins[master]: Changed jenkins deploy to use trigger template
by Code Review
>From Gil Shinar <gshinar(a)redhat.com>:
Gil Shinar has submitted this change and it was merged. ( https://gerrit.ovirt.org/79887 )
Change subject: Changed jenkins deploy to use trigger template
......................................................................
Changed jenkins deploy to use trigger template
Change-Id: I7c4c6cf559740729484f2447e3d36eea4672396d
Signed-off-by: Gil Shinar <gshinar(a)redhat.com>
---
M jobs/confs/projects/jenkins/jenkins_deploy_yamls.yaml
M jobs/confs/yaml/templates/jenkins_deploy_yamls_template.yaml
A jobs/confs/yaml/triggers/jenkins_deploy.yaml
3 files changed, 28 insertions(+), 13 deletions(-)
Approvals:
Staging Jenkins Server: Passed CI tests
Gil Shinar: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79887
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c4c6cf559740729484f2447e3d36eea4672396d
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
6 years, 9 months