Change in ovirt-engine[master]: core: DiskValidator#isDiskPluggedToAnyNonDownVm(true)
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79381 )
Change subject: core: DiskValidator#isDiskPluggedToAnyNonDownVm(true)
......................................................................
core: DiskValidator#isDiskPluggedToAnyNonDownVm(true)
Commit 8d3cc2 unified the functionality of
isDiskPluggedToAnyNonDownVm and isDiskPluggedToVmsThatAreNotDown, but
botched the condition where checkOnlyVmsSnapshotPluggedTo=true.
In case it was set to true, the original
isDiskPluggedToVmsThatAreNotDown skipped VMs that had snapshots
plugged to them, while the unified code includes them in the filter
instead of excluding them.
This patch rectifies that mistake, and adds a proper test to assure
it is not broken again.
Change-Id: Ib7c02f8f621b98f252e8d81bcf3852c5a8d8fdf6
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
2 files changed, 17 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79381
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7c02f8f621b98f252e8d81bcf3852c5a8d8fdf6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: db: move permission data changes to SP call
by Code Review
>From Eli Mesika <emesika(a)redhat.com>:
Eli Mesika has submitted this change and it was merged. ( https://gerrit.ovirt.org/79287 )
Change subject: db: move permission data changes to SP call
......................................................................
db: move permission data changes to SP call
Postgres 9.3 introduced Materialized Views support.
In order to use that in oVirt we need to find out which views are
relatively complex and have a low data change rate.
The *permissions* views are a natural candidate for that, but before
that we need to change all direct changes on the permission table to use
a SP call in order to refresh the materialized views in one place.
This patch changes all data changes to use a SP call.
Change-Id: I4fb7cbdae37083b60938195256257cf848f133c0
Signed-off-by: emesika <emesika(a)redhat.com>
---
M packaging/dbscripts/base_disks_sp.sql
M packaging/dbscripts/clusters_sp.sql
M packaging/dbscripts/common_sp.sql
M packaging/dbscripts/cpu_profiles_sp.sql
M packaging/dbscripts/disk_profiles_sp.sql
M packaging/dbscripts/multi_level_administration_sp.sql
M packaging/dbscripts/network_sp.sql
M packaging/dbscripts/storages_sp.sql
M packaging/dbscripts/vds_sp.sql
M packaging/dbscripts/vm_pools_sp.sql
M packaging/dbscripts/vm_templates_sp.sql
M packaging/dbscripts/vms_sp.sql
12 files changed, 32 insertions(+), 82 deletions(-)
Approvals:
Martin Peřina: Looks good to me, but someone else must approve
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79287
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fb7cbdae37083b60938195256257cf848f133c0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: declare LiveMigrateVmDisks VdcAction as monitored
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/78103 )
Change subject: core: declare LiveMigrateVmDisks VdcAction as monitored
......................................................................
core: declare LiveMigrateVmDisks VdcAction as monitored
Change-Id: Ic8a96e17a4b35ec2999e1becabcc464b404184b6
Signed-off-by: Daniel Erez <derez(a)redhat.com>
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActionType.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
3 files changed, 11 insertions(+), 1 deletion(-)
Approvals:
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/78103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8a96e17a4b35ec2999e1becabcc464b404184b6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: webadmin: allow the server path to be only a slash
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79230 )
Change subject: webadmin: allow the server path to be only a slash
......................................................................
webadmin: allow the server path to be only a slash
Change-Id: I52023d924d6be05a70b2fdd0bcd3e8b62edbf925
Bug-Url: https://bugzilla.redhat.com/1425879
Signed-off-by: Benny Zlotnik <bzlotnik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/LinuxMountPointValidation.java
M frontend/webadmin/modules/uicommonweb/src/test/java/org/ovirt/engine/ui/uicommonweb/validation/LinuxMountPointValidationTest.java
2 files changed, 6 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Looks good to me, approved
Benny Zlotnik: Verified
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/79230
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I52023d924d6be05a70b2fdd0bcd3e8b62edbf925
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: engine: VDS_INSTALL_IN_PROGRESS_ERROR text change
by Code Review
>From Moti Asayag <masayag(a)redhat.com>:
Moti Asayag has submitted this change and it was merged. ( https://gerrit.ovirt.org/79022 )
Change subject: engine: VDS_INSTALL_IN_PROGRESS_ERROR text change
......................................................................
engine: VDS_INSTALL_IN_PROGRESS_ERROR text change
Text for VDS_INSTALL_IN_PROGRESS_ERROR is not misleading anymore,
when non-fatal error during host installation occurres.
Change-Id: I1bbef1460cb5cb75b6d2496159d9e672e2a44e51
Bug-Url: https://bugzilla.redhat.com/1448798
Signed-off-by: Miroslava Voglova <mvoglova(a)redhat.com>
---
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Miroslava Voglova: Verified
Martin Peřina: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79022
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1bbef1460cb5cb75b6d2496159d9e672e2a44e51
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Miroslava Voglova <mvoglova(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Miroslava Voglova <mvoglova(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in jenkins[master]: Added printing of tested changes in tester job
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79036 )
Change subject: Added printing of tested changes in tester job
......................................................................
Added printing of tested changes in tester job
So far we've just printed how many changes are tested, now also printing
which ones.
Change-Id: I9eb834f0fa44f7d17c4e200238ab60bd044e66b5
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1077
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M scripts/change_queue/__init__.py
M test/test_change_queue.py
2 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79036
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9eb834f0fa44f7d17c4e200238ab60bd044e66b5
Gerrit-PatchSet: 5
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 6 months
Change in jenkins[master]: Add email notifications to GerritMergedChange
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/78330 )
Change subject: Add email notifications to GerritMergedChange
......................................................................
Add email notifications to GerritMergedChange
Make change-queue events for merged changes in Gerrit be emailed to
infra. This is a temporary measure to help monitoring things before we
start having the change queue return notifications back to Gerrit directly.
Infra will only be notified on failed or rejected changes not for queued
or successful ones
Change-Id: I729aa6b5eac7ef8b6d86cf54150da84adcdce0b6
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1452
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M pipelines/change-queue.groovy
M pipelines/standard-enqueue.groovy
M scripts/change_queue/changes/__init__.py
M test/change_queue/test_changes.py
4 files changed, 19 insertions(+), 4 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78330
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I729aa6b5eac7ef8b6d86cf54150da84adcdce0b6
Gerrit-PatchSet: 7
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 6 months
Change in jenkins[master]: Added FC26 standard CI jobs for repoman.
by Code Review
>From Anton Marchukov <amarchuk(a)redhat.com>:
Anton Marchukov has submitted this change and it was merged. ( https://gerrit.ovirt.org/79374 )
Change subject: Added FC26 standard CI jobs for repoman.
......................................................................
Added FC26 standard CI jobs for repoman.
FC26 is released and needs to be supported.
Change-Id: I37146f559fc758c5aff3582f10b95d1bf7b2fed7
Signed-off-by: Anton Marchukov <anton(a)marchukov.com>
---
M jobs/confs/projects/repoman/repoman_build-artifacts.yaml
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Anton Marchukov: Verified; Looks good to me, approved; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79374
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I37146f559fc758c5aff3582f10b95d1bf7b2fed7
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
7 years, 6 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: hosts tab - fix datacenter
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79373 )
Change subject: inventory: hosts tab - fix datacenter
......................................................................
inventory: hosts tab - fix datacenter
Currently, the hosts table is not displaying the
correct datacenter name. This patch address it.
Change-Id: Ie079d8d7dadeb577122d5193a3b41eb8d3843717
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79373
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie079d8d7dadeb577122d5193a3b41eb8d3843717
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-log-collector[master]: inventory: hosts tab - fix datacenter
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79368 )
Change subject: inventory: hosts tab - fix datacenter
......................................................................
inventory: hosts tab - fix datacenter
Currently, the hosts table is not displaying the
correct datacenter name. This patch address it.
Change-Id: Ie079d8d7dadeb577122d5193a3b41eb8d3843717
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved
Martin Mucha: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79368
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie079d8d7dadeb577122d5193a3b41eb8d3843717
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months