Change in ovirt-engine[master]: core: Unify disk existence validations
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79275 )
Change subject: core: Unify disk existence validations
......................................................................
core: Unify disk existence validations
Reuse DiskValidator.isDiskExists' logic instead of reimplementing it
in the command.
Change-Id: Ie35e876474e65bdc06baf1b7013583befd4e3190
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CopyImageGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
3 files changed, 37 insertions(+), 63 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79275
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie35e876474e65bdc06baf1b7013583befd4e3190
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: MoveOrCopyDiskCommandTest storage type tests
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79324 )
Change subject: core: MoveOrCopyDiskCommandTest storage type tests
......................................................................
core: MoveOrCopyDiskCommandTest storage type tests
MoveOrCopyDiskCommandTest has a bunch of tests for supported storage
types.
This logic is part of the DiskValidator, not the command, and thus
it makes no sense to test it in MoveOrCopyDiskCommand's UNIT test.
Change-Id: Ifc61b94367c20be21ff45d145eac583e5e8c33f9
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 0 insertions(+), 42 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79324
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc61b94367c20be21ff45d145eac583e5e8c33f9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: AmendImageGroupVolumesCommandTest DiskValidator
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79276 )
Change subject: core: AmendImageGroupVolumesCommandTest DiskValidator
......................................................................
core: AmendImageGroupVolumesCommandTest DiskValidator
Mock the DiskValidator in AmendImageGroupVolumesCommandTest so that
the test tests the command and not the inner workings of the
validator.
Change-Id: I0c7a77f414adf1bf33e1e571f0d39a787c2ddb40
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommandTest.java
2 files changed, 18 insertions(+), 14 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79276
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c7a77f414adf1bf33e1e571f0d39a787c2ddb40
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Fix typo in DiskValidator method name
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79244 )
Change subject: core: Fix typo in DiskValidator method name
......................................................................
core: Fix typo in DiskValidator method name
Change-Id: I42431dced19c904eff7cb36b2e478f7482a5c6de
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
4 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79244
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I42431dced19c904eff7cb36b2e478f7482a5c6de
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Remove MoveOrCopyDiskCommandTest#vmDeviceDao
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79271 )
Change subject: core: Remove MoveOrCopyDiskCommandTest#vmDeviceDao
......................................................................
core: Remove MoveOrCopyDiskCommandTest#vmDeviceDao
Remove unused member.
Change-Id: I6f518bfa1aa2b53ffbbef9d8d4dc01c0088d26e0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79271
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f518bfa1aa2b53ffbbef9d8d4dc01c0088d26e0
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79272 )
Change subject: core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking
......................................................................
core: MoveOrCopyDiskCommandTest DiskVmElementDao mocking
Removed mocking of DiskVmElementDao, which is not used directly by
the command, and replaced it with mocking of the validator that uses
it.
This way, the MoveOrCopyDiskCommandTest only tests the command's
logic, and not the internal workings of the validator.
Change-Id: I3a4618628d1f256a3a2b643ce190f225f9cabe6d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79272
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3a4618628d1f256a3a2b643ce190f225f9cabe6d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: MoveOrCopyDiskCommandTest validations
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79270 )
Change subject: core: MoveOrCopyDiskCommandTest validations
......................................................................
core: MoveOrCopyDiskCommandTest validations
Reuse ValidateTestUtils instead of reimplementing its logic.
Change-Id: I4a903ff3925fae551ba5bf2d895bebbc87dda7d2
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
1 file changed, 10 insertions(+), 28 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79270
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4a903ff3925fae551ba5bf2d895bebbc87dda7d2
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: create Pool with 'auto select target' on disks with id...
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79301 )
Change subject: core: create Pool with 'auto select target' on disks with identical DD
......................................................................
core: create Pool with 'auto select target' on disks with identical DD
Trying to create new Pool based on a Template with at least two disks
from the same Data Domain (same Target) and checking the 'Auto select
target' check box (in 'Resource Allocation' side tab), causes the whole
pool creation to fail.
This bug is because of invalid use of Java Streams in ImagesHandler
(done as part of a refactoring patch: commit a6d29adf20b9052b117e86c36a01dcc0fce7c9e7).
This patch fixes it by replacing the Java Streams back to a regular loop
statement.
Change-Id: I702b65a5411ec1bb92a8c40829cbd271d7c9b29f
Bug-Url: https://bugzilla.redhat.com/1468313
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/ImagesHandler.java
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79301
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I702b65a5411ec1bb92a8c40829cbd271d7c9b29f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: engine: handle NPE for guest info data of a powered-off vm
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/79258 )
Change subject: engine: handle NPE for guest info data of a powered-off vm
......................................................................
engine: handle NPE for guest info data of a powered-off vm
In case of powering-off a running VM with guest info data (i.e.
guest agent installed) and guestOsType == OsType.Windows, then
displaying 'guest info' sub-tab raises a NPE.
This is becuase powering off a VM, sets vm.guestOs field to null in
ResourceManager.resetVmAttributes(), while other Os fields like
guestOsType are not set to null.
That causes VmGuestInfoModel.setGuestOsNamedVersion() to fail while
trying to access that field.
This patch fixes it by avoid setting vm.guestOs to null.
Bug-Url: https://bugzilla.redhat.com/1448650
Change-Id: I4f84fbe6abbc74bae54de80d8f5348646b8df3b4
Signed-off-by: Sharon Gratch <sgratch(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuestInfoModel.java
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Sharon Gratch: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79258
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f84fbe6abbc74bae54de80d8f5348646b8df3b4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months
Change in ovirt-engine[master]: core: Migrate VideoDeviceSettings to CDI
by Code Review
>From Martin Betak <mbetak(a)redhat.com>:
Martin Betak has submitted this change and it was merged. ( https://gerrit.ovirt.org/78834 )
Change subject: core: Migrate VideoDeviceSettings to CDI
......................................................................
core: Migrate VideoDeviceSettings to CDI
Replace static utility class with a CDI singleton. This is done mainly to
enable the migration of ClusterUtils to CDI in subsequent patch.
Change-Id: I5bdb59b3f250250bdad79191bd9d9c3a728f3602
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/LegacyVideoSettings.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VgamemVideoSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VideoDeviceSettings.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmOverheadCalculatorImpl.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/snapshots/CreateAllSnapshotsFromVmCommandTest.java
6 files changed, 137 insertions(+), 90 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Martin Betak: Verified
Allon Mureinik: Looks good to me, approved
Arik Hadas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/78834
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bdb59b3f250250bdad79191bd9d9c3a728f3602
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 6 months