Change in jenkins[master]: Move global_setup.sh to run first
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79084 )
Change subject: Move global_setup.sh to run first
......................................................................
Move global_setup.sh to run first
global_setup.sh is meant to be the 1st setup script that runs on a
slave, so here we make sure that this is the case.
Also re-factored templates for system-tests jobs a little to unify the
way they use builders.
Change-Id: I0daefa86f6b70501b8b3ee842ee7688022b4c56b
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1507
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/projects/ovirt/system-tests.yaml
A jobs/confs/yaml/builders/global-setup.yaml
M jobs/confs/yaml/builders/standard.yaml
M jobs/confs/yaml/builders/system_tests_builders.yaml
M jobs/confs/yaml/templates/system_tests_templates.yaml
5 files changed, 11 insertions(+), 10 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79084
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0daefa86f6b70501b8b3ee842ee7688022b4c56b
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in jenkins[master]: Move setup steps to global_setup.sh
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79096 )
Change subject: Move setup steps to global_setup.sh
......................................................................
Move setup steps to global_setup.sh
Moved some generic setup steps from mock_setup.sh to global_setup.sh
because they are not specific to mock.
Change-Id: I006178f09b4bed07667cdc9bb88bc6518c5ae209
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1507
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/shell-scripts/global_setup.sh
M jobs/confs/shell-scripts/mock_setup.sh
2 files changed, 44 insertions(+), 29 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Daniel Belenky: Looks good to me
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79096
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I006178f09b4bed07667cdc9bb88bc6518c5ae209
Gerrit-PatchSet: 3
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in jenkins[master]: Move generic cleanup steps to cleanup_slave.sh
by Code Review
>From Barak Korren <bkorren(a)redhat.com>:
Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/79103 )
Change subject: Move generic cleanup steps to cleanup_slave.sh
......................................................................
Move generic cleanup steps to cleanup_slave.sh
We had several non-mock cleanup steps in 'mock_cleanup.sh'. This patch
moves them to their right place in 'cleanup_slave.sh'.
This patch also:
* Fixes libvirt cleanup code in cleanup_slave.sh
* Makes the job fail if something failed in cleanup_slave.sh
Change-Id: I1560f0171a614f654a245b4f2d42d9830813d9b1
Jira-Ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1507
Signed-off-by: Barak Korren <bkorren(a)redhat.com>
---
M jobs/confs/shell-scripts/cleanup_slave.sh
M jobs/confs/shell-scripts/mock_cleanup.sh
2 files changed, 58 insertions(+), 65 deletions(-)
Approvals:
Barak Korren: Verified; Looks good to me, approved; Ready for merge
Gil Shinar: Looks good to me
Jenkins CI: Passed CI tests
Daniel Belenky: Looks good to me
--
To view, visit https://gerrit.ovirt.org/79103
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1560f0171a614f654a245b4f2d42d9830813d9b1
Gerrit-PatchSet: 4
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
6 years, 11 months
Change in ovirt-engine[master]: engine: delete stray comment about userportal
by Code Review
>From Oved Ourfali <oourfali(a)redhat.com>:
Oved Ourfali has submitted this change and it was merged. ( https://gerrit.ovirt.org/79065 )
Change subject: engine: delete stray comment about userportal
......................................................................
engine: delete stray comment about userportal
Change-Id: Ia323f733852494d95994900bef83c08f99bfad5b
Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Greg Sheremeta: Verified
Oved Ourfali: Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia323f733852494d95994900bef83c08f99bfad5b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Add DC into storage domain table
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79240 )
Change subject: inventory: Add DC into storage domain table
......................................................................
inventory: Add DC into storage domain table
Change-Id: If96a2c6fc5c26fb9cad82980fc0937854248604a
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/produceReport.sh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79240
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If96a2c6fc5c26fb9cad82980fc0937854248604a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: add MTU, description, subnet and gateway
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79239 )
Change subject: inventory: add MTU, description, subnet and gateway
......................................................................
inventory: add MTU, description, subnet and gateway
In the network query add the fields: MTU, description,
subnet and gateway
Change-Id: I6bf441dc7e2784ac421f918d3dab14dd98f935d2
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/sqls/networks_table_not_using_network_attachments.sql
M src/inventory_report/produceReport/sqls/networks_table_using_network_attachments.sql
2 files changed, 10 insertions(+), 2 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79239
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bf441dc7e2784ac421f918d3dab14dd98f935d2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: sort main packages installed in the system
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79238 )
Change subject: inventory: sort main packages installed in the system
......................................................................
inventory: sort main packages installed in the system
Change-Id: I010334d16afb494b99dc413d19a053d3f940b679
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/produceReport/pre-upgrade-checks
M src/inventory_report/produceReport/produceReport.sh
2 files changed, 3 insertions(+), 6 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79238
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I010334d16afb494b99dc413d19a053d3f940b679
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-log-collector[ovirt-log-collector-4.1]: inventory: Display Storage Domains Lun Data
by Code Review
>From Douglas Schilling Landgraf <dougsland(a)redhat.com>:
Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79237 )
Change subject: inventory: Display Storage Domains Lun Data
......................................................................
inventory: Display Storage Domains Lun Data
This patch shares storage domain name and data like:
iqn, port, connection, portal.
Change-Id: I67bdb7457d6d796417f2cc77e7ac12dc53490517
Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com>
---
M src/inventory_report/Makefile.am
M src/inventory_report/produceReport/produceReport.sh
A src/inventory_report/produceReport/sqls/lun_storage_server_connection_map_query_number_connection_map.sql
A src/inventory_report/produceReport/sqls/storage_domains_lun_data.sql
4 files changed, 30 insertions(+), 0 deletions(-)
Approvals:
Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/79237
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I67bdb7457d6d796417f2cc77e7ac12dc53490517
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: ovirt-log-collector-4.1
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: DiskValidator#isDiskAttachedToAnyVm streams
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79060 )
Change subject: core: DiskValidator#isDiskAttachedToAnyVm streams
......................................................................
core: DiskValidator#isDiskAttachedToAnyVm streams
This patches changes the implementation of the isDiskAttachedToAnyVm
method to first generate the list of offending VM names (which should
be a non-op if there are none), and then perform the check on the
generated string instead of the original list.
While this patch doesn't have too much meaning on its own, it sets up
the subsequent patch, which will add another filter clause to the
aforementioned stream.
Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/79060
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c89929c040c9e6cb7913b24ba2484db34562752
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months
Change in ovirt-engine[master]: core: DiskValidatorTest#createVmDeviceForDisk signature
by Code Review
>From Allon Mureinik <amureini(a)redhat.com>:
Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79059 )
Change subject: core: DiskValidatorTest#createVmDeviceForDisk signature
......................................................................
core: DiskValidatorTest#createVmDeviceForDisk signature
Remove method arguments which always get with the same values, and
inline them as literals in the method's body.
Change-Id: I5ab3d2391e3ebb4bf6be83b953143b34e7292bb0
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java
1 file changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Verified
Maor Lipchuk: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/79059
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ab3d2391e3ebb4bf6be83b953143b34e7292bb0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 11 months