July 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Allow transferring images for down VMs
by Code Review 10 Jul '17

10 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79061 ) Change subject: core: Allow transferring images for down VMs ...................................................................... core: Allow transferring images for down VMs Currently, DiskValidator#isDiskAttachedToAnyVm() is used to block image transfers on all non-floating disks. This behavior seems to be a bit too naive, as there's no storage-related not to upload/download an image that happens to have a database entry that ties it to a VM. For simplicity's sake, the operation is still blocked for any status other than DOWN. In the future, we can consider refining this restriction. Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061 Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 22 insertions(+), 8 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia313a451f7642b10b1ee3a46d2ce1bdd1d2fa061 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Allow transferring for unplugged disks
by Code Review 10 Jul '17

10 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79205 ) Change subject: core: Allow transferring for unplugged disks ...................................................................... core: Allow transferring for unplugged disks If a disk is not plugged to a VM, the VM's status is inconsequential. This patch refines the validation to ignore unplugged disks Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/image/TransferDiskImageCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 4 files changed, 42 insertions(+), 26 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I761546f9e41daf74306863ce48f30003fa2de8fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDo...
by Code Review 10 Jul '17

10 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79206 ) Change subject: core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDownVm ...................................................................... core: Sort results of DiskValidator#isDiskAPluggedToAnyNonDownVm Change-Id: I0872fcca50ed21749b7c1477417b1a27efd3c7f4 Bug-Url: https://bugzilla.redhat.com/1414499 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/DiskValidator.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79206 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0872fcca50ed21749b7c1477417b1a27efd3c7f4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: DiskValidatorTest any matcher
by Code Review 10 Jul '17

10 Jul '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/79058 ) Change subject: core: DiskValidatorTest any matcher ...................................................................... core: DiskValidatorTest any matcher Use the modern any() matcher instead of the outdated any(Class) matcher in order to clean up the code. Change-Id: I34fc71d1604761563ce5c4080cfa8251b0b82b4c Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/DiskValidatorTest.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/79058 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I34fc71d1604761563ce5c4080cfa8251b0b82b4c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: OVIRT-1511 - fix mock configs for Fedora 23 and 24
by Code Review 10 Jul '17

10 Jul '17

>From Evgheni Dereveanchin <ederevea(a)redhat.com>: Evgheni Dereveanchin has submitted this change and it was merged. ( https://gerrit.ovirt.org/79227 ) Change subject: OVIRT-1511 - fix mock configs for Fedora 23 and 24 ...................................................................... OVIRT-1511 - fix mock configs for Fedora 23 and 24 Repository keys moved to a different location in version 1.4.1, this patch changes some Fedora mock configs to point to the correct location. Change-Id: I3a122fc3efa50d953cb494dcb61caad681b856c6 Signed-off-by: Evgheni Dereveanchin <ederevea(a)redhat.com> Jira-ticket: https://ovirt-jira.atlassian.net/browse/OVIRT-1511 --- M mock_configs/fedora-23-x86_64.cfg M mock_configs/fedora-23-x86_64_proxied.cfg M mock_configs/fedora-24-ppc64le.cfg M mock_configs/fedora-24-ppc64le_proxied.cfg M mock_configs/fedora-24-x86_64.cfg M mock_configs/fedora-24-x86_64_proxied.cfg 6 files changed, 12 insertions(+), 12 deletions(-) Approvals: Barak Korren: Looks good to me Jenkins CI: Passed CI tests Evgheni Dereveanchin: Verified; Looks good to me, approved; Ready for merge -- To view, visit https://gerrit.ovirt.org/79227 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3a122fc3efa50d953cb494dcb61caad681b856c6 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: inventory: Add DC into storage domain table
by Code Review 10 Jul '17

10 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79233 ) Change subject: inventory: Add DC into storage domain table ...................................................................... inventory: Add DC into storage domain table Change-Id: If96a2c6fc5c26fb9cad82980fc0937854248604a Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/produceReport.sh 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Martin Mucha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79233 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If96a2c6fc5c26fb9cad82980fc0937854248604a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: add MTU, description, subnet and gateway
by Code Review 10 Jul '17

10 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79229 ) Change subject: inventory: add MTU, description, subnet and gateway ...................................................................... inventory: add MTU, description, subnet and gateway In the network query add the fields: MTU, description, subnet and gateway Change-Id: I6bf441dc7e2784ac421f918d3dab14dd98f935d2 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/sqls/networks_table_not_using_network_attachments.sql M src/inventory_report/produceReport/sqls/networks_table_using_network_attachments.sql 2 files changed, 10 insertions(+), 2 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved; Passed CI tests Martin Mucha: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/79229 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bf441dc7e2784ac421f918d3dab14dd98f935d2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-log-collector[master]: inventory: sort main packages installed in the system
by Code Review 10 Jul '17

10 Jul '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/79228 ) Change subject: inventory: sort main packages installed in the system ...................................................................... inventory: sort main packages installed in the system Change-Id: I010334d16afb494b99dc413d19a053d3f940b679 Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh 2 files changed, 3 insertions(+), 6 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Martin Mucha: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/79228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I010334d16afb494b99dc413d19a053d3f940b679 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: add vm downtime
by Code Review 10 Jul '17

10 Jul '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/78619 ) Change subject: core: add vm downtime ...................................................................... core: add vm downtime There are few approaches for calculating the elapsed time of a VM. One approach, that is used today, is to aggregate the time the VM was running. This approach has some drawbacks. An alternative approach is to aggregate the time the VM was down and then to compute the elapsed time according to the current time, the overall downtime, and the boot time (that is, the time the VM was started and not restoring an existing memory state). Since we are going with the latter approach, this patch adds the VM downtime. Change-Id: Id5174843c70c485e89f7b5a4c61a8a83a8827fec Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/CreateVDSCommandParameters.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfProperties.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/04_02_0360_add_downtime_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 13 files changed, 60 insertions(+), 3 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/78619 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id5174843c70c485e89f7b5a4c61a8a83a8827fec Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: setup: Renew certs if missing SubjectAltName
by Code Review 10 Jul '17

10 Jul '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/79221 ) Change subject: packaging: setup: Renew certs if missing SubjectAltName ...................................................................... packaging: setup: Renew certs if missing SubjectAltName We already add SubjectAltName to new certs. Now also add it during upgrade if missing. Keep the same question about pki renew, just update the text. Change the link to a new page on ovirt.org about pki renew. Change-Id: I88e93e6d8d3f8f29329269fb270440af2f7d3c4c Bug-Url: https://bugzilla.redhat.com/1450293 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 70e3aade5655f41d1348e5c2c2fc73b8671ca8f7) --- M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 2 files changed, 28 insertions(+), 5 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, approved Jenkins CI: Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79221 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e93e6d8d3f8f29329269fb270440af2f7d3c4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0