Change in ovirt-engine[master]: core: Use Java streams in RemoveImageCommand
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80917 )
Change subject: core: Use Java streams in RemoveImageCommand
......................................................................
core: Use Java streams in RemoveImageCommand
Change-Id: I85118df1713a313a6fded663b1b1df6e6385897f
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/…
[View More]storage/disk/image/RemoveImageCommand.java
1 file changed, 8 insertions(+), 21 deletions(-)
Approvals:
Tal Nisan: Verified
Eyal Shenitzky: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, approved
Freddy Rolland: Looks good to me, but someone else must approve
Shani Leviim: Looks good to me, but someone else must approve
Idan Shaby: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/80917
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I85118df1713a313a6fded663b1b1df6e6385897f
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eyal Shenitzky <eshenitz(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: webadmin: detect base template correctly on import template
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81078 )
Change subject: webadmin: detect base template correctly on import template
......................................................................
webadmin: detect base template correctly on import template
The problem was that while the template is being imported, it is checked, if
the template has it's base template already in the system. If not, the …
[View More]template
has to be imported as clone.
The problem was, that when the template was a base template, it was always
enforced to be imported to the system as a clone.
Fixed by a proper check. The patch also contains one additional null check to
make sure the frontend does not throw a NPE while leaving the screen.
Change-Id: I8499d4bdc35b3ef50a723d42143691cd267ceb80
Bug-Url: https://bugzilla.redhat.com/1485804
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8499d4bdc35b3ef50a723d42143691cd267ceb80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[master]: restapi: Add LLDP
by Code Review
>From Juan Hernandez <juan.hernandez(a)redhat.com>:
Juan Hernandez has submitted this change and it was merged. ( https://gerrit.ovirt.org/78580 )
Change subject: restapi: Add LLDP
......................................................................
restapi: Add LLDP
The Link Layer Discovery Protocol (LLDP) is a vendor-neutral
networking protocol, used by network devices, especially switches,
for advertising their identity, capabilities and management addresses
on an IEEE 802 …
[View More]local area network (LAN).
The restapi provides information received by LLDP on a host NIC.
Bug-Url: https://bugzilla.redhat.com/1479677
Change-Id: I1dddb3b15c346a95fc69e2fd727035edb2f8ea1c
Signed-off-by: Dominik Holler <dholler(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicsResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendLinkLayerDiscoveryProtocolResource.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendLinkLayerDiscoveryProtocolResourceTest.java
A backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/LinkLayerDiscoveryProtocolElementMapper.java
5 files changed, 213 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Dominik Holler: Verified
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/78580
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1dddb3b15c346a95fc69e2fd727035edb2f8ea1c
Gerrit-PatchSet: 22
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in jenkins[master]: jobs: Add FC26 builds for WildFly
by Code Review
>From Sandro Bonazzola <sbonazzo(a)redhat.com>:
Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/81099 )
Change subject: jobs: Add FC26 builds for WildFly
......................................................................
jobs: Add FC26 builds for WildFly
Adds FC26 builds for ovirt-engine-wildfly and
ovirt-engine-wildfly-overlay packages
Change-Id: If38f53891d68269c10aa122bdab33f8fe0d45778
Signed-off-by: Martin Perina <mperina(a)…
[View More]redhat.com>
---
M jobs/confs/projects/ovirt-engine-wildfly-overlay/ovirt-engine-wildfly-overlay_standard.yaml
M jobs/confs/projects/ovirt-engine-wildfly/ovirt-engine-wildfly_standard.yaml
2 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Sandro Bonazzola: Looks good to me, approved
Martin Peřina: Ready for review
Barak Korren: Verified; Looks good to me; Ready for merge
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/81099
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If38f53891d68269c10aa122bdab33f8fe0d45778
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com>
Gerrit-Reviewer: Dafna Ron <dron(a)redhat.com>
Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com>
Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>
[View Less]
7 years, 4 months
Change in ovirt-engine[ovirt-engine-3.6]: engine: Expanding monitoring lock to the whole setup network...
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80840 )
Change subject: engine: Expanding monitoring lock to the whole setup networks command
......................................................................
engine: Expanding monitoring lock to the whole setup networks command
The monitoring-lock was expanded to the whole SetupNetworks execution.
Partial backport of https://gerrit.ovirt.org/#/c/59318
…
[View More]Change-Id: I599317d16fdcf165dc31e89b0c5bb2f3d8797bbe
Bug-Url: https://bugzilla.redhat.com/1283489
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworksCommand.java
1 file changed, 17 insertions(+), 16 deletions(-)
Approvals:
Meni Yakove: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80840
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I599317d16fdcf165dc31e89b0c5bb2f3d8797bbe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Meni Yakove <myakove(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Staging Jenkins Server
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[master]: core: Custom Id is not persisted to the database
by Code Review
>From Martin Peřina <mperina(a)redhat.com>:
Martin Peřina has submitted this change and it was merged. ( https://gerrit.ovirt.org/80907 )
Change subject: core: Custom Id is not persisted to the database
......................................................................
core: Custom Id is not persisted to the database
When creating a audit log record, there is an option to assign a
custom id string to the record, this is used for example when dealing
with interfaces where the …
[View More]custom id value gets the interface name
in order to handle event flooding correctly.
However, the custom id value is used when generating the key for the
audit log cache but since it is not persisted to the database, each
record in the cache that has a non-empty custom id value will not be
cleaned from the cache since the key for searching this record will
have always an empty custom id value.
This behavior may lead to cache flooding and memory leak.
Change-Id: I4867253abd8ef35dbab6ecd28cc2aa9a8bae15aa
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1483889
Signed-off-by: emesika <emesika(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAuditLogByIdCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/AuditLogDaoImpl.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
A packaging/dbscripts/upgrade/04_02_0540_add_audit_log_custom_id.sql
7 files changed, 26 insertions(+), 1 deletion(-)
Approvals:
Eli Mesika: Verified
Jenkins CI: Passed CI tests
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80907
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4867253abd8ef35dbab6ecd28cc2aa9a8bae15aa
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[master]: backend: Backup feature configured for storage domain.
by Code Review
>From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged. ( https://gerrit.ovirt.org/79033 )
Change subject: backend: Backup feature configured for storage domain.
......................................................................
backend: Backup feature configured for storage domain.
This patch propose a backend support for backup storage domain.
Backup storage domain should keep the disks' data unchanged, therefore
running VMs with …
[View More]disks reside on the storage domain is forbidden.
To apply that restriction several validation were added:
1. VMs cannot run if one or more of their disks is in backup storage domain.
2. Disks of running VMs could not be moved or copied to a backup storage domain.
3. Backup storage domain should not be elected as master storage domain.
4. User can not activate a disk reside on a backup storage domain and attached to a running VM.
5. Export and ISO storage domains cannot be backup storage domains.
For more information about the feature see the following wiki link:
https://github.com/oVirt/ovirt-site/pull/1003
Change-Id: Ib76657e7082d07cb991c960c33ca2cff0800d4c9
Signed-off-by: Shubham Dubey <sdubey504(a)gmail.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/domain/UpdateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidator.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/disk/MoveOrCopyDiskCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/AddStorageDomainCommonTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/StorageDomainCommandBaseTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/lsm/LiveMigrateVmDisksCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainValidatorTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/frontend/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
17 files changed, 194 insertions(+), 6 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Looks good to me, but someone else must approve
Maor Lipchuk: Looks good to me, approved
shubham dubey: Verified
--
To view, visit https://gerrit.ovirt.org/79033
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib76657e7082d07cb991c960c33ca2cff0800d4c9
Gerrit-PatchSet: 41
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: shubham dubey <sdubey504(a)gmail.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Benny Zlotnik <bzlotnik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-Reviewer: shubham dubey <sdubey504(a)gmail.com>
[View Less]
7 years, 4 months
Change in ovirt-engine[master]: core: Memory devices spec param size in MiB
by Code Review
>From Arik Hadas <ahadas(a)redhat.com>:
Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/81048 )
Change subject: core: Memory devices spec param size in MiB
......................................................................
core: Memory devices spec param size in MiB
Memory device spec params 'size' uses MiB unit even with libvirt domain
xml.
Without libvirt xml it used MiB (vdsm:
lib.vdsm.virt.vmdevices.core.Memory#from_xml_tree) and till …
[View More]this patch
with libvirt xml it temporarily used KiB.
Previewing snapshot created in period when using KiB might cause
problems but this bug wasn't in any released version.
Change-Id: I00382b1013e2a5be5d8306a81f27b2300165f642
Bug-Url: https://bugzilla.redhat.com/1482042
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/libvirt/VmDevicesConverter.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Jakub Niedermertl: Verified
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/81048
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00382b1013e2a5be5d8306a81f27b2300165f642
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[master]: webadmin: detect base template correctly on import template
by Code Review
>From Tomas Jelinek <tjelinek(a)redhat.com>:
Tomas Jelinek has submitted this change and it was merged. ( https://gerrit.ovirt.org/81044 )
Change subject: webadmin: detect base template correctly on import template
......................................................................
webadmin: detect base template correctly on import template
The problem was that while the template is being imported, it is checked, if
the template has it's base template already in the system. If …
[View More]not, the template
has to be imported as clone.
The problem was, that when the template was a base template, it was always
enforced to be imported to the system as a clone.
Fixed by a proper check. The patch also contains one additional null check to
make sure the frontend does not throw a NPE while leaving the screen.
Change-Id: I8499d4bdc35b3ef50a723d42143691cd267ceb80
Bug-Url: https://bugzilla.redhat.com/1484392
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/TemplateBackupModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
Jakub Niedermertl: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Michal Skrivanek: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/81044
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8499d4bdc35b3ef50a723d42143691cd267ceb80
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
[View Less]
7 years, 4 months
Change in ovirt-engine[ovirt-engine-4.1]: backend: remove unrequired validation from vnicprofile.
by Code Review
>From Tal Nisan <tnisan(a)redhat.com>:
Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/81074 )
Change subject: backend: remove unrequired validation from vnicprofile.
......................................................................
backend: remove unrequired validation from vnicprofile.
A previous patch that was meant to update backend validaitons of
vnic profile wasn't complete (https://gerrit.ovirt.org/#/c/80838/)
as it didn't remove the …
[View More]restriction for alphanumeric and "-".
This problem only appears in 4.1 and shouldn't be applied to master.
Change-Id: Id15aa08194ffa713f4b8a9abc20bd5006f29ad6a
Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477569
Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Leon Goldberg: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/81074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id15aa08194ffa713f4b8a9abc20bd5006f29ad6a
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.1
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Dominik Holler <dholler(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
[View Less]
7 years, 4 months