Allon Mureinik has submitted this change and it was merged. Change subject: core : ImportVm with snapshots without collapse - not all disks are copied ...................................................................... core : ImportVm with snapshots without collapse - not all disks are copied When importing a vmlists of disk ids and image ids are being populated in order to be used when creating the parameters for MoveOrCopyImageGroupCommand. When vm has snapshots, vm.getImages() returnes the DiskImage instances of all the disks snapshots as well - that caused that when importing the vm that has snapshots without collapse, same disk id was added few times to the disk's id list. When creating the tasks for copying the disks, the iteration is according to the disk count, meaning that possibly we will execute copy of the same image group while other image groups won't be copied at all - which will cause that the imported vm will have only some of it's disks. the proposed fix adds only the disk id\image of the leaf disk, so duplicate id's won't be added. Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Bug-Url: https://bugzilla.redhat.com/912697 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib850d2d22ea6acb37320ad2b1bd6c571e1048faa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Ayal Baron <abaron@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov@gmail.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk@redhat.com>