November 2015 - Kimchi-devel - oVirt List Archives

[PATCH V3] Issue #737: Wok base framework calls resource model's lookup twice
by archus＠linux.vnet.ibm.com 23 Nov '15

23 Nov '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> In case of GET lookup was called twice. Once before is_authorized() and then in self.get(). This added overhead to system when lookup() is called for each value in list from get_list() of Collection. So to avoid this, removed lookup() call from get(). Also updated code to call self.lookup() before self.get() in resource's update() and collection's create(). Archana Singh (1): Issue #737: Wok base framework calls resource model's lookup twice src/wok/control/base.py | 5 ++--- src/wok/plugins/kimchi/control/storagepools.py | 1 + 2 files changed, 3 insertions(+), 3 deletions(-) -- 2.1.4

2 2

[PATCH V2] #748 Sosreport generation.
by mesmriti＠linux.vnet.ibm.com 23 Nov '15

23 Nov '15

From: Megha Smriti <mesmriti(a)linux.vnet.ibm.com> The reveiw comments have been taken care of and changes were made to keep a separate sosreport method and the path where the sosreport will be generated will be specified in the sosreport command. Ex: path_sosreport = '/var/tmp/' command = ['sosreport', '--batch', '--name=%s' % name, '--tmp-dir=%s' % path_sosreport] Megha Smriti (1): model/debugreports.py Rodrigo Trujillo (1): Allow listStorageVolumes ajax call be synchronized src/wok/plugins/gingerbase/model/debugreports.py | 103 ++++++++++++--------- src/wok/plugins/kimchi/ui/js/src/kimchi.api.js | 7 +- .../ui/js/src/kimchi.guest_storage_add.main.js | 2 +- .../kimchi/ui/js/src/kimchi.storage_main.js | 2 +- 4 files changed, 67 insertions(+), 47 deletions(-) -- 2.4.3

2 5

[PATCH v3] Create logical pool from existing VG
by Aline Manera 23 Nov '15

23 Nov '15

V2 - V3: - Address Rodrigo's comments Aline Manera (1): Create logical pool from existing VG src/wok/plugins/kimchi/API.json | 5 + src/wok/plugins/kimchi/control/host.py | 22 ++++ src/wok/plugins/kimchi/disks.py | 123 +++++++++++++++++++++ src/wok/plugins/kimchi/docs/API.md | 25 ++++- src/wok/plugins/kimchi/i18n.py | 5 + src/wok/plugins/kimchi/mockmodel.py | 27 +++++ src/wok/plugins/kimchi/model/host.py | 27 +++++ src/wok/plugins/kimchi/model/libvirtstoragepool.py | 9 +- src/wok/plugins/kimchi/model/storagepools.py | 30 +++-- .../plugins/kimchi/tests/test_mock_storagepool.py | 8 +- 10 files changed, 264 insertions(+), 17 deletions(-) -- 2.5.0

2 3

[PATCH] Gingerbase: adapting unit tests to use WoK /tests/utils.py
by dhbarboza82＠gmail.com 23 Nov '15

23 Nov '15

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> As a follow up of the recent changes in the WoK /tests/utils.py module in Kimchi, the same procedure is now being done in Gingerbase: - unit tests now points to tests.utils - Gingerbase tests/utils.py module was deleted Signed-off-by: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> --- src/wok/plugins/ginger | 2 +- src/wok/plugins/gingerbase/tests/run_tests.sh.in | 3 +- .../plugins/gingerbase/tests/test_authorization.py | 3 +- src/wok/plugins/gingerbase/tests/test_host.py | 4 +- src/wok/plugins/gingerbase/tests/test_rest.py | 6 +- src/wok/plugins/gingerbase/tests/utils.py | 262 --------------------- 6 files changed, 11 insertions(+), 269 deletions(-) delete mode 100644 src/wok/plugins/gingerbase/tests/utils.py diff --git a/src/wok/plugins/ginger b/src/wok/plugins/ginger index 84f36db..a0cc2a3 160000 --- a/src/wok/plugins/ginger +++ b/src/wok/plugins/ginger @@ -1 +1 @@ -Subproject commit 84f36dbbfe63869fa97cd68e9abdeaffdf1846d9 +Subproject commit a0cc2a369abf5ec93068924c3b681957d1c82cb3 diff --git a/src/wok/plugins/gingerbase/tests/run_tests.sh.in b/src/wok/plugins/gingerbase/tests/run_tests.sh.in index 3b08fa6..ab3de12 100644 --- a/src/wok/plugins/gingerbase/tests/run_tests.sh.in +++ b/src/wok/plugins/gingerbase/tests/run_tests.sh.in @@ -52,6 +52,7 @@ for ((i=0;i<${#LIST[@]};i++)); do fi done +# ../../../../../ refers to wok root # ../../../../ refers to wok directory # ../../../ refers to plugins directory -PYTHONPATH=../../../../:../../../ $CMD $OPTS ${MODEL_LIST[@]} ${MOCK_LIST[@]} +PYTHONPATH=../../../../../:../../../../:../../../ $CMD $OPTS ${MODEL_LIST[@]} ${MOCK_LIST[@]} diff --git a/src/wok/plugins/gingerbase/tests/test_authorization.py b/src/wok/plugins/gingerbase/tests/test_authorization.py index d0fc57c..0650f0a 100644 --- a/src/wok/plugins/gingerbase/tests/test_authorization.py +++ b/src/wok/plugins/gingerbase/tests/test_authorization.py @@ -23,9 +23,10 @@ import os import unittest from functools import partial +from tests.utils import get_free_port, patch_auth, request, run_server + from wok.plugins.gingerbase import mockmodel -from utils import get_free_port, patch_auth, request, run_server test_server = None model = None diff --git a/src/wok/plugins/gingerbase/tests/test_host.py b/src/wok/plugins/gingerbase/tests/test_host.py index 4f3e848..5d158bb 100644 --- a/src/wok/plugins/gingerbase/tests/test_host.py +++ b/src/wok/plugins/gingerbase/tests/test_host.py @@ -29,8 +29,10 @@ import time import unittest from functools import partial +from tests.utils import get_free_port, patch_auth, request +from tests.utils import run_server, wait_task + from wok.plugins.gingerbase.mockmodel import MockModel -from utils import get_free_port, patch_auth, request, run_server, wait_task test_server = None diff --git a/src/wok/plugins/gingerbase/tests/test_rest.py b/src/wok/plugins/gingerbase/tests/test_rest.py index a8138c6..c723a0e 100644 --- a/src/wok/plugins/gingerbase/tests/test_rest.py +++ b/src/wok/plugins/gingerbase/tests/test_rest.py @@ -26,13 +26,13 @@ import time import unittest from functools import partial +from tests.utils import get_free_port, patch_auth, request +from tests.utils import run_server, wait_task + from wok.rollbackcontext import RollbackContext from wok.plugins.gingerbase import mockmodel -from utils import get_free_port, patch_auth, request -from utils import run_server, wait_task - test_server = None model = None diff --git a/src/wok/plugins/gingerbase/tests/utils.py b/src/wok/plugins/gingerbase/tests/utils.py deleted file mode 100644 index 111cb02..0000000 --- a/src/wok/plugins/gingerbase/tests/utils.py +++ /dev/null @@ -1,262 +0,0 @@ -# -# Project Ginger Base -# -# Copyright IBM, Corp. 2013-2015 -# -# Code derived from Project Kimchi -# -# This library is free software; you can redistribute it and/or -# modify it under the terms of the GNU Lesser General Public -# License as published by the Free Software Foundation; either -# version 2.1 of the License, or (at your option) any later version. -# -# This library is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU -# Lesser General Public License for more details. -# -# You should have received a copy of the GNU Lesser General Public -# License along with this library; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA -# - -import base64 -import cherrypy -import grp -import httplib -import inspect -import json -import os -import socket -import ssl -import sys -import threading -import time -import unittest -from contextlib import closing -from lxml import etree - -import wok.server -from wok.config import config, PluginPaths -from wok.auth import User, USER_NAME, USER_GROUPS, USER_ROLES, tabs -from wok.exception import NotFoundError, OperationFailed -from wok.utils import wok_log - -from wok.plugins.gingerbase import mockmodel - - -_ports = {} - -# provide missing unittest decorators and API for python 2.6; these decorators -# do not actually work, just avoid the syntax failure -if sys.version_info[:2] == (2, 6): - def skipUnless(condition, reason): - if not condition: - sys.stderr.write('[expected failure] ') - raise Exception(reason) - return lambda obj: obj - - unittest.skipUnless = skipUnless - unittest.expectedFailure = lambda obj: obj - - def assertGreater(self, a, b, msg=None): - if not a > b: - self.fail('%s not greater than %s' % (repr(a), repr(b))) - - def assertGreaterEqual(self, a, b, msg=None): - if not a >= b: - self.fail('%s not greater than or equal to %s' - % (repr(a), repr(b))) - - def assertIsInstance(self, obj, cls, msg=None): - if not isinstance(obj, cls): - self.fail('%s is not an instance of %r' % (repr(obj), cls)) - - def assertIn(self, a, b, msg=None): - if a not in b: - self.fail("%s is not in %b" % (repr(a), repr(b))) - - def assertNotIn(self, a, b, msg=None): - if a in b: - self.fail("%s is in %b" % (repr(a), repr(b))) - - unittest.TestCase.assertGreaterEqual = assertGreaterEqual - unittest.TestCase.assertGreater = assertGreater - unittest.TestCase.assertIsInstance = assertIsInstance - unittest.TestCase.assertIn = assertIn - unittest.TestCase.assertNotIn = assertNotIn - - -def get_free_port(name='http'): - global _ports - if _ports.get(name) is not None: - return _ports[name] - sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) - with closing(sock): - try: - sock.bind(("0.0.0.0", 0)) - except: - raise Exception("Could not find a free port") - _ports[name] = sock.getsockname()[1] - return _ports[name] - - -def run_server(host, port, ssl_port, test_mode, cherrypy_port=None, - model=None, environment='development'): - - if cherrypy_port is None: - cherrypy_port = get_free_port('cherrypy_port') - - if ssl_port is None: - ssl_port = get_free_port('https') - - args = type('_', (object,), - {'host': host, 'port': port, 'ssl_port': ssl_port, - 'cherrypy_port': cherrypy_port, 'max_body_size': '4*1024', - 'ssl_cert': '', 'ssl_key': '', - 'test': test_mode, 'access_log': '/dev/null', - 'error_log': '/dev/null', 'environment': environment, - 'log_level': 'debug'})() - if model is not None: - setattr(args, 'model', model) - - s = wok.server.Server(args) - t = threading.Thread(target=s.start) - t.setDaemon(True) - t.start() - cherrypy.engine.wait(cherrypy.engine.states.STARTED) - return s - - -def silence_server(): - """ - Silence server status messages on stdout - """ - cherrypy.config.update({"environment": "embedded"}) - - -def running_as_root(): - return os.geteuid() == 0 - - -def _request(conn, path, data, method, headers): - if headers is None: - headers = {'Content-Type': 'application/json', - 'Accept': 'application/json'} - if 'AUTHORIZATION' not in headers.keys(): - user, pw = mockmodel.fake_user.items()[0] - hdr = "Basic " + base64.b64encode("%s:%s" % (user, pw)) - headers['AUTHORIZATION'] = hdr - conn.request(method, path, data, headers) - return conn.getresponse() - - -def request(host, port, path, data=None, method='GET', headers=None): - # verify if HTTPSConnection has context parameter - if "context" in inspect.getargspec(httplib.HTTPSConnection.__init__).args: - context = ssl._create_unverified_context() - conn = httplib.HTTPSConnection(host, port, context=context) - else: - conn = httplib.HTTPSConnection(host, port) - - return _request(conn, path, data, method, headers) - - -def get_remote_iso_path(): - """ - Get a remote iso with the right arch from the distro files shipped - with gingerbase. - """ - host_arch = os.uname()[4] - remote_path = '' - with open(os.path.join(PluginPaths('gingerbase').conf_dir, 'distros.d', - 'fedora.json')) as fedora_isos: - # Get a list of dicts - json_isos_list = json.load(fedora_isos) - for iso in json_isos_list: - if (iso.get('os_arch')) == host_arch: - remote_path = iso.get('path') - break - - return remote_path - - -class FakeUser(User): - auth_type = "fake" - sudo = True - - def __init__(self, username): - self.user = {} - self.user[USER_NAME] = username - self.user[USER_GROUPS] = None - self.user[USER_ROLES] = dict.fromkeys(tabs, 'user') - - def get_groups(self): - return sorted([group.gr_name for group in grp.getgrall()])[0:3] - - def get_roles(self): - if self.sudo: - self.user[USER_ROLES] = dict.fromkeys(tabs, 'admin') - return self.user[USER_ROLES] - - def get_user(self): - return self.user - - @staticmethod - def authenticate(username, password, service="passwd"): - try: - return mockmodel.fake_user[username] == password - except KeyError, e: - raise OperationFailed("GGBAUTH0001E", {'username': 'username', - 'code': e.message}) - - -def patch_auth(sudo=True): - """ - Override the authenticate function with a simple test against an - internal dict of users and passwords. - """ - config.set("authentication", "method", "fake") - FakeUser.sudo = sudo - - -def normalize_xml(xml_str): - return etree.tostring(etree.fromstring(xml_str, - etree.XMLParser(remove_blank_text=True))) - - -def wait_task(task_lookup, taskid, timeout=10): - for i in range(0, timeout): - task_info = task_lookup(taskid) - if task_info['status'] == "running": - wok_log.info("Waiting task %s, message: %s", - taskid, task_info['message']) - time.sleep(1) - else: - return - wok_log.error("Timeout while process long-run task, " - "try to increase timeout value.") - - -# The action functions in model backend raise NotFoundError exception if the -# element is not found. But in some tests, these functions are called after -# the element has been deleted if test finishes correctly, then NofFoundError -# exception is raised and rollback breaks. To avoid it, this wrapper ignores -# the NotFoundError. -def rollback_wrapper(func, resource, *args): - try: - func(resource, *args) - except NotFoundError: - # VM has been deleted already - return - - -# This function is used to test storage volume upload. -# If we use self.request, we may encode multipart formdata by ourselves -# requests lib take care of encode part, so use this lib instead -def fake_auth_header(): - headers = {'Accept': 'application/json'} - user, pw = mockmodel.fake_user.items()[0] - hdr = "Basic " + base64.b64encode("%s:%s" % (user, pw)) - headers['AUTHORIZATION'] = hdr - return headers -- 2.4.3

2 1

[PATCH 0/4 V2] Upgrade ObjectStore data to Kimchi-2.0
by pvital＠linux.vnet.ibm.com 23 Nov '15

23 Nov '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch-set contains some fixes and changes related to upgrade process of objectstore data from Kimchi-1.5.1 (or older) to the new Wok and Kimchi-2.0 structure. This is a V2 submission completely different from V1, since it's solving the problem using a different approach, common to all supported distros, during the startup of Kimchi plugin. The patch-set was tested on Fedora 22 and Ubuntu-14.04 distros. Paulo Vital (4): Add version to objectstore information. Add Kimchi version to objectstore entries. Upgrade Kimchi objectstore content. Change Kimchi version. src/wok/objectstore.py | 20 +++++-- src/wok/plugins/kimchi/VERSION | 2 +- src/wok/plugins/kimchi/config.py.in | 5 ++ src/wok/plugins/kimchi/i18n.py | 1 + src/wok/plugins/kimchi/model/diskutils.py | 7 ++- src/wok/plugins/kimchi/model/storagepools.py | 4 +- src/wok/plugins/kimchi/model/templates.py | 4 +- src/wok/plugins/kimchi/model/vms.py | 20 ++++--- src/wok/plugins/kimchi/root.py | 10 ++++ src/wok/plugins/kimchi/tests/test_model.py | 4 +- src/wok/plugins/kimchi/utils.py | 80 +++++++++++++++++++++++++++- tests/test_objectstore.py | 5 ++ 12 files changed, 143 insertions(+), 19 deletions(-) -- 2.4.3

4 8

[PATCH V2] Add OVS bridges recognition support
by Lucio Correia 20 Nov '15

20 Nov '15

Allow bridged networks to be created from OVS bridges, and adapt VM XML to work with OVS networks. In some distributions, i.e. Fedora, the directories "bridge" and "brif" are not created for OVS bridges, and they are the method Kimchi uses to detect bridges. This patch also fixes that by recognizing OVS bridges through OVS commands, allowing networks to be created using OVS bridges in those distributions. Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- src/wok/plugins/kimchi/model/networks.py | 4 +++ src/wok/plugins/kimchi/netinfo.py | 53 ++++++++++++++++++++++++++++-- src/wok/plugins/kimchi/xmlutils/network.py | 5 +++ 3 files changed, 60 insertions(+), 2 deletions(-) diff --git a/src/wok/plugins/kimchi/model/networks.py b/src/wok/plugins/kimchi/model/networks.py index 54cb0ea..5cd33e7 100644 --- a/src/wok/plugins/kimchi/model/networks.py +++ b/src/wok/plugins/kimchi/model/networks.py @@ -176,9 +176,13 @@ class NetworksModel(object): # User specified bridge interface, simply use it self._ensure_iface_up(iface) + params['ovs'] = False if netinfo.is_bridge(iface): params['bridge'] = iface + if netinfo.is_ovs_bridge(iface): + params['ovs'] = True + # User wants Linux bridge network, but didn't specify bridge interface elif params['connection'] == "bridge": # create Linux bridge interface first and use it as actual iface diff --git a/src/wok/plugins/kimchi/netinfo.py b/src/wok/plugins/kimchi/netinfo.py index c5746d7..ff91489 100644 --- a/src/wok/plugins/kimchi/netinfo.py +++ b/src/wok/plugins/kimchi/netinfo.py @@ -21,6 +21,9 @@ import ethtool import glob import os +from distutils.spawn import find_executable +from wok.utils import run_command +from wok.utils import wok_log NET_PATH = '/sys/class/net' NIC_PATH = '/sys/class/net/*/device' @@ -73,13 +76,51 @@ def is_vlan(iface): def bridges(): - return [b.split('/')[-2] for b in glob.glob(BRIDGE_PATH)] + return list(set([b.split('/')[-2] for b in glob.glob(BRIDGE_PATH)] + + ovs_bridges())) def is_bridge(iface): return iface in bridges() +# In some distributions, like Fedora, the files bridge and brif are not created +# under /sys/class/net/<ovsbridge> for OVS bridges. These specific functions +# allows one to differentiate OVS bridges from other types of bridges. +def ovs_bridges(): + ovs_cmd = find_executable("ovs-vsctl") + + # openvswitch not installed: there is no OVS bridge configured + if ovs_cmd is None: + return [] + + out, error, rc = run_command([ovs_cmd, '--oneline', 'list-br']) + if rc != 0: + wok_log.info("Error listing OVS bridges") + return [] + + return list(set(out.split('\n')) - set([''])) + + +def is_ovs_bridge(iface): + return iface in ovs_bridges() + + +def ovs_bridge_ports(ovsbr): + ovs_cmd = find_executable("ovs-vsctl") + + # openvswitch not installed: there is no OVS bridge configured + if ovs_cmd is None: + return [] + + out, error, rc = run_command([ovs_cmd, '--oneline', 'list-ports', ovsbr]) + if rc != 0: + wok_log.info("Error listing OVS bridge ports for %s" % str(ovsbr)) + return [] + + return list(set(out.split('\n')) - set([''])) + + def all_interfaces(): return [d.rsplit("/", 1)[-1] for d in glob.glob(NET_PATH + '/*')] @@ -91,11 +132,19 @@ def slaves(bonding): def ports(bridge): + if bridge in ovs_bridges(): + return ovs_bridge_ports(bridge) + return os.listdir(BRIDGE_PORTS % bridge) def is_brport(nic): - return os.path.exists(NET_BRPORT % nic) + ovs_brports = [] + + for ovsbr in ovs_bridges(): + ovs_brports += ovs_bridge_ports(ovsbr) + + return os.path.exists(NET_BRPORT % nic) or nic in ovs_brports def is_bondlave(nic): diff --git a/src/wok/plugins/kimchi/xmlutils/network.py b/src/wok/plugins/kimchi/xmlutils/network.py index 14c7e13..f9594e6 100644 --- a/src/wok/plugins/kimchi/xmlutils/network.py +++ b/src/wok/plugins/kimchi/xmlutils/network.py @@ -95,6 +95,11 @@ def to_network_xml(**kwargs): if bridge: network.append(E.bridge(name=bridge)) + # Add virtualport element for openvswitch bridges + ovs = kwargs.get('ovs') + if ovs: + network.append(E.virtualport(type='openvswitch')) + # None means is Isolated network, {} means default mode nat params = kwargs.get('forward', {"mode": None}) forward = _get_forward_elem(**params) -- 1.9.1

1 1

[PATCH 0/3 - v2] Checks memory alignment to 256 MiB and number of slots in PPC
by Rodrigo Trujillo 19 Nov '15

19 Nov '15

V2: - Created global variable to hold PPC Memory aligment value: 256 currently - Fix missing platform import - Changed mathematical operators by bitwise operators when manipulate memory values V1: This patchset makes necessary changes to check and change in PPC: - memory and maxMemory must be aligned to 256 MiB - Number of slots must be <= 32 Rodrigo Trujillo (3): Check memory alignment in PowerPC to 256MiB Check and align number of memory slot to 32 in PowerPC Change memory multipliers/divisors by bitwise operators src/wok/plugins/kimchi/i18n.py | 3 ++ src/wok/plugins/kimchi/model/vms.py | 38 ++++++++++++++++++++-- src/wok/plugins/kimchi/osinfo.py | 7 ++++ src/wok/plugins/kimchi/tests/test_livemigration.py | 2 +- src/wok/plugins/kimchi/vmtemplate.py | 8 ++++- 5 files changed, 54 insertions(+), 4 deletions(-) -- 2.1.0

3 10

[PATCH 0/2] Github #760: Enabling the import of WoK module /test/utils.py
by dhbarboza82＠gmail.com 19 Nov '15

19 Nov '15

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> This patch set makes changes in WoK and Kimchi to allow the unit tests of all WoK plugins access to the /tests/utils.py module of WoK. This module is replicated at /plugins/kimchi/tests/utils.py and it was deleted. See https://github.com/kimchi-project/kimchi/issues/760 for further info Daniel Henrique Barboza (2): WoK: making /tests/utils.py available to all WoK plug-ins Kimchi: updating unit tests to use WoK /test/utils.py src/wok/plugins/kimchi/tests/run_tests.sh.in | 3 +- src/wok/plugins/kimchi/tests/test_authorization.py | 9 +- src/wok/plugins/kimchi/tests/test_host.py | 4 +- src/wok/plugins/kimchi/tests/test_livemigration.py | 21 +- src/wok/plugins/kimchi/tests/test_mock_network.py | 3 +- .../plugins/kimchi/tests/test_mock_storagepool.py | 4 +- .../kimchi/tests/test_mock_storagevolume.py | 3 +- src/wok/plugins/kimchi/tests/test_mockmodel.py | 5 +- src/wok/plugins/kimchi/tests/test_model.py | 3 +- src/wok/plugins/kimchi/tests/test_model_network.py | 6 +- .../plugins/kimchi/tests/test_model_storagepool.py | 4 +- .../kimchi/tests/test_model_storagevolume.py | 7 +- src/wok/plugins/kimchi/tests/test_networkxml.py | 7 +- src/wok/plugins/kimchi/tests/test_rest.py | 5 +- src/wok/plugins/kimchi/tests/test_template.py | 4 +- src/wok/plugins/kimchi/tests/utils.py | 259 --------------------- tests/__init__.py | 18 ++ tests/utils.py | 6 +- 18 files changed, 72 insertions(+), 299 deletions(-) delete mode 100644 src/wok/plugins/kimchi/tests/utils.py create mode 100644 tests/__init__.py -- 2.4.3

3 6

[PATCH] Issue #755 : Action's states are showing in correctly for Repositories
by atreyee＠linux.vnet.ibm.com 19 Nov '15

19 Nov '15

From: Atreyee Mukhopadhyay <atreyee(a)linux.vnet.ibm.com> Fix Action enable/disable functionality of the repositories. --- .../plugins/gingerbase/ui/js/src/gingerbase.host.js | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/wok/plugins/gingerbase/ui/js/src/gingerbase.host.js b/src/wok/plugins/gingerbase/ui/js/src/gingerbase.host.js index 24a4aa6..6a6e690 100644 --- a/src/wok/plugins/gingerbase/ui/js/src/gingerbase.host.js +++ b/src/wok/plugins/gingerbase/ui/js/src/gingerbase.host.js @@ -161,11 +161,21 @@ gingerbase.host_main = function() { if (!repository) { return; } - $('#repositories-grid-remove-button').prop('disabled', false); - $('#repositories-grid-edit-button').prop('disabled', false); + var selectedRow = $('tr',repositoriesGrid.bodyContainer); + $('#repositories-grid-remove-button',selectedRow).prop('disabled', false); + $('#repositories-grid-edit-button',selectedRow).prop('disabled', false); var enabled = repository['enabled']; - $('#repositories-grid-enable-button') - .text(i18n[enabled ? 'GGBREPO6017M' : 'GGBREPO6016M']) + var actionHtml,actionText,actionIcon =''; + if(enabled){ + actionText= i18n['GGBREPO6017M']; + actionIcon = 'fa-pause'; + }else{ + actionText= i18n['GGBREPO6016M']; + actionIcon = 'fa-play-circle-o'; + } + actionHtml = ['<i class="fa',' ',actionIcon,'"></i>','',actionText].join(''); + $('#repositories-grid-enable-button',selectedRow) + .html(actionHtml) .prop('disabled', false); }, frozenFields: [], -- 2.1.0

2 1

[PATCH 0/3 - v3] Checks memory alignment to 256 MiB and number of slots in PPC
by Rodrigo Trujillo 19 Nov '15

19 Nov '15

V3: - Make modifications asked by Aline - Rebase with latest master code V2: - Created global variable to hold PPC Memory aligment value: 256 currently - Fix missing platform import - Changed mathematical operators by bitwise operators when manipulate memory values V1: This patchset makes necessary changes to check and change in PPC: - memory and maxMemory must be aligned to 256 MiB - Number of slots must be <= 32 Rodrigo Trujillo (3): Check memory alignment in PowerPC to 256MiB Check and align number of memory slot to 32 in PowerPC Change memory multipliers/divisors by bitwise operators src/wok/plugins/kimchi/i18n.py | 3 +- src/wok/plugins/kimchi/model/vms.py | 38 ++++++++++++++++++++-- src/wok/plugins/kimchi/osinfo.py | 7 ++++ src/wok/plugins/kimchi/tests/test_livemigration.py | 2 +- src/wok/plugins/kimchi/vmtemplate.py | 8 ++++- 5 files changed, 52 insertions(+), 6 deletions(-) -- 2.1.0

2 4

[PATCH] New Navigation bar
by atreyee＠linux.vnet.ibm.com 18 Nov '15

18 Nov '15

From: Atreyee Mukhopadhyay <atreyee(a)linux.vnet.ibm.com> This patch is to implement new feature mentioned in issue #746. First level navigation bar with Host and Virtualization tabs. Second level tab navigation based on first level navigation. Atreyee Mukhopadhyay (1): Issue #746 : New navigation bar. src/wok/plugins/gingerbase/ui/config/tab-ext.xml | 1 + src/wok/plugins/kimchi/ui/config/tab-ext.xml | 1 + ui/css/src/modules/_toolbar.scss | 9 ++- ui/css/src/modules/_wok-variables.scss | 7 +- ui/js/src/wok.main.js | 81 +++++++++++++++++++++--- ui/pages/wok-ui.html.tmpl | 6 +- 6 files changed, 91 insertions(+), 14 deletions(-) -- 2.1.0

4 8

[PATCH 0/4] Live migration backend: additional features
by dhbarboza82＠gmail.com 18 Nov '15

18 Nov '15

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> *** REQUIRES THE FOLLOWING PATCH TO APPLY *** 'Live migration backend: non-shared storage VM migration' This patchset implements the remaining features of the live migration backend to be shipped in Kimchi 2.0: - password-less root setup: if provided with a user/password that has SUDO ALL access in the remote host, the backend will set the password-less environment automatically. - added same remote hypervisor verification - added same remote architecture verification - (ppc64 only): if applicable, verify subcores-per-core This is the usage after this patchset: - migrating a VM without any credentials: if the password less root login isn't set, it will simply abort the operation: $ curl -k -u user -H "Content-Type: application/json" -H "Accept: application/json" "https://localhost:8001/plugins/kimchi/vms/<vm_name>/migrate" -X POST -d '{"remote_host":"a_remote_host" }' - migrating a vm with credentials: same thing as above, but will set up the password less root login if it's not set yet: $ curl -k -u root -H "Content-Type: application/json" -H "Accept: application/json" "https://localhost:8001/plugins/kimchi/vms/<vm_name>/migrate" -X POST -d '{"remote_host":"a_remote_host", "user":"a_sudoall_user", "password":"passwd_of_user" }' Note that 'sudoall_user' can be the root of the remote host. *** NOTE *** First patch is a change in WoK necessary to make the 'user' and 'password' fields optional. Daniel Henrique Barboza (4): WoK: control/base.py: _generate_action_handler_base changes Live migration: new features changes in docs/API/i18n Live migration: model changes for the new features Live migration: unit tests for the new features src/wok/control/base.py | 5 +- src/wok/plugins/kimchi/API.json | 6 + src/wok/plugins/kimchi/control/vms.py | 3 +- src/wok/plugins/kimchi/docs/API.md | 3 +- src/wok/plugins/kimchi/docs/README.md | 6 +- src/wok/plugins/kimchi/i18n.py | 8 + src/wok/plugins/kimchi/model/vms.py | 177 +++++++++++++++++++-- src/wok/plugins/kimchi/tests/test_livemigration.py | 81 +++++++++- 8 files changed, 270 insertions(+), 19 deletions(-) -- 2.4.3

4 11

[PATCH] Add "io"="native" when creating a disk on Kimchi
by Ramon Medeiros 18 Nov '15

18 Nov '15

When running complex workloads with NFS servers, some machines hang when power off is pressed. With io=native, servers can poweroff correctly. Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- src/wok/plugins/kimchi/xmlutils/disk.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/wok/plugins/kimchi/xmlutils/disk.py b/src/wok/plugins/kimchi/xmlutils/disk.py index 84be91d..2ed2ef4 100644 --- a/src/wok/plugins/kimchi/xmlutils/disk.py +++ b/src/wok/plugins/kimchi/xmlutils/disk.py @@ -53,6 +53,7 @@ def get_disk_xml(params): driver = E.driver(name='qemu', type=params['format']) if params['type'] != 'cdrom': driver.set('cache', 'none') + driver.set("io", "native") disk.append(driver) -- 2.1.0

3 2

[PATCH V2] Create logical pool from existing VG
by Aline Manera 18 Nov '15

18 Nov '15

Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- src/wok/plugins/kimchi/API.json | 5 + src/wok/plugins/kimchi/control/host.py | 22 ++++ src/wok/plugins/kimchi/disks.py | 123 +++++++++++++++++++++ src/wok/plugins/kimchi/docs/API.md | 25 ++++- src/wok/plugins/kimchi/i18n.py | 4 + src/wok/plugins/kimchi/mockmodel.py | 27 +++++ src/wok/plugins/kimchi/model/host.py | 29 +++++ src/wok/plugins/kimchi/model/libvirtstoragepool.py | 9 +- src/wok/plugins/kimchi/model/storagepools.py | 30 +++-- .../plugins/kimchi/tests/test_mock_storagepool.py | 8 +- 10 files changed, 265 insertions(+), 17 deletions(-) diff --git a/src/wok/plugins/kimchi/API.json b/src/wok/plugins/kimchi/API.json index 961f35f..7daa2a9 100644 --- a/src/wok/plugins/kimchi/API.json +++ b/src/wok/plugins/kimchi/API.json @@ -141,6 +141,11 @@ "error": "KCHPOOL0025E" } } + }, + "from_vg": { + "description": "Use an existing VG or create a new one", + "type": "boolean", + "error": "KCHPOOL0026E" } } } diff --git a/src/wok/plugins/kimchi/control/host.py b/src/wok/plugins/kimchi/control/host.py index 9bc703a..39df0d0 100644 --- a/src/wok/plugins/kimchi/control/host.py +++ b/src/wok/plugins/kimchi/control/host.py @@ -35,12 +35,34 @@ class Host(Resource): self.devices = Devices(self.model) self.cpuinfo = CPUInfo(self.model) self.partitions = Partitions(self.model) + self.vgs = VolumeGroups(self.model) @property def data(self): return {} +class VolumeGroups(Collection): + def __init__(self, model): + super(VolumeGroups, self).__init__(model) + self.role_key = 'host' + self.uri_fmt = "/host/vgs" + self.admin_methods = ['GET'] + self.resource = VolumeGroup + + +class VolumeGroup(Resource): + def __init__(self, model, id=None): + super(VolumeGroup, self).__init__(model, id) + self.role_key = 'host' + self.uri_fmt = "/host/vgs/%s" + self.admin_methods = ['GET'] + + @property + def data(self): + return self.info + + class VMHolders(SimpleCollection): def __init__(self, model, device_id): super(VMHolders, self).__init__(model) diff --git a/src/wok/plugins/kimchi/disks.py b/src/wok/plugins/kimchi/disks.py index eb40e3a..0ac792e 100644 --- a/src/wok/plugins/kimchi/disks.py +++ b/src/wok/plugins/kimchi/disks.py @@ -194,3 +194,126 @@ def get_partition_details(name): dev['path'] = dev_path dev['name'] = name return dev + + +def vgs(): + """ + lists all volume groups in the system. All size units are in bytes. + + [{'vgname': 'vgtest', 'size': 999653638144L, 'free': 0}] + """ + cmd = ['vgs', + '--units', + 'b', + '--nosuffix', + '--noheading', + '--unbuffered', + '--options', + 'vg_name,vg_size,vg_free'] + + proc = subprocess.Popen(cmd, + stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + + out, err = proc.communicate() + + if proc.returncode != 0: + raise OperationFailed("KCHDISKS0003E", {'err': err}) + + if not out: + return [] + + # remove blank spaces and create a list of VGs + vgs = map(lambda v: v.strip(), out.strip('\n').split('\n')) + + # create a dict based on data retrieved from vgs + return map(lambda l: {'vgname': l[0], + 'size': long(l[1]), + 'free': long(l[2])}, + [fields.split() for fields in vgs]) + + +def lvs(vgname=None): + """ + lists all logical volumes found in the system. It can be filtered by + the volume group. All size units are in bytes. + + [{'lvname': 'lva', 'path': '/dev/vgtest/lva', 'size': 12345L}, + {'lvname': 'lvb', 'path': '/dev/vgtest/lvb', 'size': 12345L}] + """ + cmd = ['lvs', + '--units', + 'b', + '--nosuffix', + '--noheading', + '--unbuffered', + '--options', + 'lv_name,lv_path,lv_size,vg_name'] + + proc = subprocess.Popen(cmd, + stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + + out, err = proc.communicate() + + if proc.returncode != 0: + raise OperationFailed("KCHDISKS0003E", {'err': err}) + + if not out: + return [] + + # remove blank spaces and create a list of LVs filtered by vgname, if + # provided + lvs = filter(lambda f: vgname is None or vgname in f, + map(lambda v: v.strip(), out.strip('\n').split('\n'))) + + # create a dict based on data retrieved from lvs + return map(lambda l: {'lvname': l[0], + 'path': l[1], + 'size': long(l[2])}, + [fields.split() for fields in lvs]) + + +def pvs(vgname=None): + """ + lists all physical volumes in the system. It can be filtered by the + volume group. All size units are in bytes. + + [{'pvname': '/dev/sda3', + 'size': 469502001152L, + 'uuid': 'kkon5B-vnFI-eKHn-I5cG-Hj0C-uGx0-xqZrXI'}, + {'pvname': '/dev/sda2', + 'size': 21470642176L, + 'uuid': 'CyBzhK-cQFl-gWqr-fyWC-A50Y-LMxu-iHiJq4'}] + """ + cmd = ['pvs', + '--units', + 'b', + '--nosuffix', + '--noheading', + '--unbuffered', + '--options', + 'pv_name,pv_size,pv_uuid,vg_name'] + + proc = subprocess.Popen(cmd, + stdout=subprocess.PIPE, + stderr=subprocess.PIPE) + + out, err = proc.communicate() + + if proc.returncode != 0: + raise OperationFailed("KCHDISKS0003E", {'err': err}) + + if not out: + return [] + + # remove blank spaces and create a list of PVs filtered by vgname, if + # provided + pvs = filter(lambda f: vgname is None or vgname in f, + map(lambda v: v.strip(), out.strip('\n').split('\n'))) + + # create a dict based on data retrieved from pvs + return map(lambda l: {'pvname': l[0], + 'size': long(l[1]), + 'uuid': l[2]}, + [fields.split() for fields in pvs]) diff --git a/src/wok/plugins/kimchi/docs/API.md b/src/wok/plugins/kimchi/docs/API.md index 52368b7..14f014d 100644 --- a/src/wok/plugins/kimchi/docs/API.md +++ b/src/wok/plugins/kimchi/docs/API.md @@ -444,7 +444,8 @@ A interface represents available network interface on VM. * **GET**: Retrieve a summarized list of all defined Storage Pools * **POST**: Create a new Storage Pool - * name: The name of the Storage Pool. + * name: The name of the Storage Pool. It corresponds to the VG name while + creating a logical storage pool from an existing VG. * type: The type of the defined Storage Pool. Supported types: 'dir', 'kimchi-iso', 'netfs', 'logical', 'iscsi', 'scsi' * path: The path of the defined Storage Pool. @@ -466,6 +467,8 @@ A interface represents available network interface on VM. * username: Login username of the iSCSI target. * password: Login password of the iSCSI target. * adapter_name: SCSI host name. + * from_vg: Indicate if a logical pool will be created from an + existing VG or not. ### Resource: Storage Pool @@ -897,6 +900,26 @@ List of available groups. Otherwise blank. * available: false, if the partition is in use by system; true, otherwise. +### Collection: Volume Groups + +**URI:** /plugins/kimchi/host/vgs + +**Methods:** + +* **GET**: Retrieves a detailed list of all volume groups in the host. + +### Resource: Volume Group + +**URI:** /plugins/kimchi/host/vgs/*:name* + +**Methods:** + +* **GET**: Retrieve the description of a single Volume Group: + * name: The volume group name. Used to identify it in this API. + * lvs: The logical volumes associated to this volume group. + * pvs: The phisical volumes associated to this volume group. + * free: Amount of free space in the volume group. + * size: Total size of the volume group. ### Collection: Peers diff --git a/src/wok/plugins/kimchi/i18n.py b/src/wok/plugins/kimchi/i18n.py index 59b61de..a4092e7 100644 --- a/src/wok/plugins/kimchi/i18n.py +++ b/src/wok/plugins/kimchi/i18n.py @@ -29,6 +29,7 @@ messages = { "KCHDISKS0001E": _("Error while getting block devices. Details: %(err)s"), "KCHDISKS0002E": _("Error while getting block device information for %(device)s."), + "KCHDISKS0003E": _("Unable to retrieve LVM information. Details: %(err)s"), "KCHPART0001E": _("Partition %(name)s does not exist in the host"), @@ -199,6 +200,7 @@ messages = { "KCHPOOL0035E": _("Unable to delete pool %(name)s as it is associated with some templates"), "KCHPOOL0036E": _("A volume group named '%(name)s' already exists. Please, choose another name to create the logical pool."), "KCHPOOL0037E": _("Unable to update database with deep scan information due error: %(err)s"), + "KCHPOOL0038E": _("No volume group '%(name)s' found. Please, specify an existing volume group to create the logical pool from."), "KCHVOL0001E": _("Storage volume %(name)s already exists"), "KCHVOL0002E": _("Storage volume %(name)s does not exist in storage pool %(pool)s"), @@ -294,4 +296,6 @@ messages = { "KCHCPUINF0002E": _("Invalid vCPU/topology combination."), "KCHCPUINF0003E": _("This host (or current configuration) does not allow CPU topology."), + "KCHLVMS0001E": _("Invalid volume group name parameter: %(name)s."), + } diff --git a/src/wok/plugins/kimchi/mockmodel.py b/src/wok/plugins/kimchi/mockmodel.py index 895401e..9186f78 100644 --- a/src/wok/plugins/kimchi/mockmodel.py +++ b/src/wok/plugins/kimchi/mockmodel.py @@ -39,6 +39,7 @@ from wok.plugins.kimchi.model.libvirtstoragepool import NetfsPoolDef from wok.plugins.kimchi.model.libvirtstoragepool import StoragePoolDef from wok.plugins.kimchi.model.model import Model from wok.plugins.kimchi.model.storagepools import StoragePoolModel +from wok.plugins.kimchi.model.storagepools import StoragePoolsModel from wok.plugins.kimchi.model.storagevolumes import StorageVolumeModel from wok.plugins.kimchi.model.storagevolumes import StorageVolumesModel from wok.plugins.kimchi.model import storagevolumes @@ -73,6 +74,7 @@ class MockModel(Model): defaults.update(mockmodel_defaults) osinfo.defaults = dict(defaults) + self._mock_vgs = MockVolumeGroups() self._mock_partitions = MockPartitions() self._mock_devices = MockDevices() self._mock_storagevolumes = MockStorageVolumes() @@ -113,6 +115,7 @@ class MockModel(Model): setattr(self, m, mock_method) DeviceModel.lookup = self._mock_device_lookup + StoragePoolsModel._check_lvm = self._check_lvm StoragePoolModel._update_lvm_disks = self._update_lvm_disks StorageVolumesModel.get_list = self._mock_storagevolumes_get_list StorageVolumeModel.doUpload = self._mock_storagevolume_doUpload @@ -252,6 +255,10 @@ class MockModel(Model): return MockModel._libvirt_get_vol_path(pool, vol) + def _check_lvm(self, name, from_vg): + # do not do any verification while using MockModel + pass + def _update_lvm_disks(self, pool_name, disks): conn = self.conn.get() pool = conn.storagePoolLookupByName(pool_name.encode('utf-8')) @@ -334,6 +341,12 @@ class MockModel(Model): def _mock_partition_lookup(self, name): return self._mock_partitions.partitions[name] + def _mock_volumegroups_get_list(self): + return self._mock_vgs.data.keys() + + def _mock_volumegroup_lookup(self, name): + return self._mock_vgs.data[name] + def _mock_vm_clone(self, name): new_name = get_next_clone_name(self.vms_get_list(), name) snapshots = MockModel._mock_snapshots.get(name, []) @@ -418,6 +431,20 @@ class MockStorageVolumes(object): 'isvalid': True}} +class MockVolumeGroups(object): + def __init__(self): + self.data = {"hostVG": {"lvs": [], + "name": "hostVG", + "pvs": ["/dev/vdx"], + "free": 5347737600, + "size": 5347737600}, + "kimchiVG": {"lvs": [], + "name": "kimchiVG", + "pvs": ["/dev/vdz", "/dev/vdw"], + "free": 10695475200, + "size": 10695475200}} + + class MockPartitions(object): def __init__(self): self.partitions = {"vdx": {"available": True, "name": "vdx", diff --git a/src/wok/plugins/kimchi/model/host.py b/src/wok/plugins/kimchi/model/host.py index 96f4bea..4a37dc8 100644 --- a/src/wok/plugins/kimchi/model/host.py +++ b/src/wok/plugins/kimchi/model/host.py @@ -241,3 +241,32 @@ class PartitionModel(object): def lookup(self, name): return disks.get_partition_details(name) + + +class VolumeGroupsModel(object): + def __init__(self, **kargs): + pass + + def get_list(self): + if not disks.vgs(): + return [] + return [vg['vgname'] for vg in disks.vgs()] + + +class VolumeGroupModel(object): + def __init__(self, **kargs): + pass + + def lookup(self, name): + def _format(vg): + return {'name': vg['vgname'], + 'size': vg['size'], + 'free': vg['free'], + 'pvs': [pv['pvname'] for pv in disks.pvs(vg['vgname'])], + 'lvs': [lv['lvname'] for lv in disks.lvs(vg['vgname'])]} + + vgs = [_format(vg) for vg in disks.vgs() if vg['vgname'] == name] + if not vgs: + raise InvalidParameter("KCHLVMS0001E", {'name': name}) + + return vgs[0] diff --git a/src/wok/plugins/kimchi/model/libvirtstoragepool.py b/src/wok/plugins/kimchi/model/libvirtstoragepool.py index 5da0b3b..0fa8ce0 100644 --- a/src/wok/plugins/kimchi/model/libvirtstoragepool.py +++ b/src/wok/plugins/kimchi/model/libvirtstoragepool.py @@ -144,11 +144,12 @@ class LogicalPoolDef(StoragePoolDef): pool = E.pool(type='logical') pool.append(E.name(self.poolArgs['name'])) - source = E.source() - for device_path in self.poolArgs['source']['devices']: - source.append(E.device(path=device_path)) + if not self.poolArgs['source'].get('from_vg', False): + source = E.source() + for device_path in self.poolArgs['source']['devices']: + source.append(E.device(path=device_path)) + pool.append(source) - pool.append(source) pool.append(E.target(E.path(self.path))) return ET.tostring(pool, encoding='unicode', pretty_print=True) diff --git a/src/wok/plugins/kimchi/model/storagepools.py b/src/wok/plugins/kimchi/model/storagepools.py index cc0bc7c..ec866c5 100644 --- a/src/wok/plugins/kimchi/model/storagepools.py +++ b/src/wok/plugins/kimchi/model/storagepools.py @@ -142,9 +142,27 @@ class StoragePoolsModel(object): raise OperationFailed("KCHPOOL0006E", {'err': e.get_error_message()}) + def _check_lvm(self, name, from_vg): + vgdisplay_cmd = ['vgdisplay', name.encode('utf-8')] + output, error, returncode = run_command(vgdisplay_cmd) + # From vgdisplay error codes: + # 1 error reading VGDA + # 2 volume group doesn't exist + # 3 not all physical volumes of volume group online + # 4 volume group not found + # 5 no volume groups found at all + # 6 error reading VGDA from lvmtab + if from_vg and returncode in [2, 4, 5]: + raise InvalidOperation("KCHPOOL0038E", {'name': name}) + + if not from_vg and returncode not in [2, 4, 5]: + raise InvalidOperation("KCHPOOL0036E", {'name': name}) + def create(self, params): task_id = None conn = self.conn.get() + from_vg = params.get('source', {}).get('from_vg', False) + try: name = params['name'] if name == ISO_POOL_NAME: @@ -154,17 +172,7 @@ class StoragePoolsModel(object): # used before but a volume group will already exist with this name # So check the volume group does not exist to create the pool if params['type'] == 'logical': - vgdisplay_cmd = ['vgdisplay', name.encode('utf-8')] - output, error, returncode = run_command(vgdisplay_cmd) - # From vgdisplay error codes: - # 1 error reading VGDA - # 2 volume group doesn't exist - # 3 not all physical volumes of volume group online - # 4 volume group not found - # 5 no volume groups found at all - # 6 error reading VGDA from lvmtab - if returncode not in [2, 4, 5]: - raise InvalidOperation("KCHPOOL0036E", {'name': name}) + self._check_lvm(name, from_vg) if params['type'] == 'kimchi-iso': task_id = self._do_deep_scan(params) diff --git a/src/wok/plugins/kimchi/tests/test_mock_storagepool.py b/src/wok/plugins/kimchi/tests/test_mock_storagepool.py index ea9843b..a2609eb 100644 --- a/src/wok/plugins/kimchi/tests/test_mock_storagepool.py +++ b/src/wok/plugins/kimchi/tests/test_mock_storagepool.py @@ -65,6 +65,10 @@ class MockStoragepoolTests(unittest.TestCase): ) def test_storagepool(self): + # MockModel always returns 2 VGs (hostVG, kimchiVG) + vgs = json.loads(self.request('/plugins/kimchi/host/vgs').read()) + vg_names = [vg['name'] for vg in vgs] + # MockModel always returns 2 partitions (vdx, vdz) partitions = json.loads( self.request('/plugins/kimchi/host/partitions').read() @@ -89,7 +93,9 @@ class MockStoragepoolTests(unittest.TestCase): 'source': {'host': '127.0.0.1', 'target': 'iqn.2015-01.localhost.kimchiUnitTest'}}, {'type': 'logical', 'name': u'kīмсhīUnitTestLogicalPool', - 'source': {'devices': [devs[0]]}}] + 'source': {'devices': [devs[0]]}}, + {'type': 'logical', 'name': vg_names[0], + 'source': {'from_vg': True}}] def _do_test(params): name = params['name'] -- 2.5.0

2 2

[PATCH v2] Display guest IP address
by Socorro Stoppler 18 Nov '15

18 Nov '15

Display guest IP address for each network interface configured This is based off of Samuel's master branch v1 - first version v2 - display 'unavailable' in the UI if IP is not available for the guest Socorro Stoppler (1): Display guest IP address for each network interface configured src/wok/plugins/ginger | 2 +- src/wok/plugins/kimchi/ui/js/src/kimchi.guest_edit_main.js | 9 ++++++++- src/wok/plugins/kimchi/ui/pages/guest-edit.html.tmpl | 4 ++++ 3 files changed, 13 insertions(+), 2 deletions(-) -- 1.9.1

2 2

Display guest IP addressFrom 8651c8cc40fe963f24534464aa2b9ebf1715fdbb Mon Sep 17 00:00:00 2001
by Socorro Stoppler 17 Nov '15

17 Nov '15

Display guest IP address for each network interface configured Socorro Stoppler (1): Display guest IP address for each network interface configured src/wok/plugins/ginger | 2 +- src/wok/plugins/kimchi/ui/js/src/kimchi.guest_edit_main.js | 6 ++++-- src/wok/plugins/kimchi/ui/pages/guest-edit.html.tmpl | 4 ++++ 3 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.1

3 7

[PATCH v5] shutdown and reboot actions on plain linux vs linux with KVM
by chandra＠linux.vnet.ibm.com 17 Nov '15

17 Nov '15

From: chandrureddy <chandra(a)linux.vnet.ibm.com> UI was using REST API 'plugins/kimchi/vms' to get the vms prior ginger base Ginger Base should handle on both plain linux vs linux with KVM capabilities. Changes made to take care shutdown or reboot actions triggered: 1. send error message in case vms are running. 2. send success in case vms are not running on KVM or plain linux will trigger shutdown or reboot action in this case. chandrureddy (1): shutdown and reboot actions on plain linux vs linux with KVM src/wok/plugins/gingerbase/i18n.py | 1 + src/wok/plugins/gingerbase/model/host.py | 47 +++++++++++++++------- .../gingerbase/ui/js/src/gingerbase.host.js | 27 +++++++------ src/wok/plugins/gingerbase/ui/pages/i18n.json.tmpl | 3 ++ 4 files changed, 51 insertions(+), 27 deletions(-) -- 2.1.0

2 3

[PATCH] Issue #757 : clean generated css files when 'make clean' executed
by chandra＠linux.vnet.ibm.com 17 Nov '15

17 Nov '15

From: chandrureddy <chandra(a)linux.vnet.ibm.com> Delete the following generated files when 'make clean' executed. 1. wok.css 2. bootstrap.custom.css 3. bootstrap-select.custom.css --- ui/css/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/css/Makefile.am b/ui/css/Makefile.am index c67bb0e..d137c3b 100644 --- a/ui/css/Makefile.am +++ b/ui/css/Makefile.am @@ -31,4 +31,4 @@ dist_css_DATA = theme-default.min.css jquery-ui.custom.css wok.css bootstrap.cu theme-default.min.css: theme-default/*.css cat $^ > $@ -CLEANFILES = theme-default.min.css +CLEANFILES = theme-default.min.css wok.css bootstrap.custom.css bootstrap-select.custom.css -- 2.1.0

2 2

[PATCH] Live migration - non shared storagen support
by dhbarboza82＠gmail.com 17 Nov '15

17 Nov '15

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> This patch implements non shared storage for the live migration backend. No API changes were made. To test it (WoK running with default ports): curl -u root -H "Content-Type: application/json" -H "Accept: application/json" -k "https://localhost:8001/plugins/kimchi/vms/migrate_test/migrate" -X POST -d '{"remote_host": "remote_host_ip", "user":"root"}' Daniel Henrique Barboza (1): Live migration backend: non-shared storage VM migration src/wok/plugins/kimchi/i18n.py | 4 + src/wok/plugins/kimchi/model/vms.py | 105 +++++++++++++++++++- src/wok/plugins/kimchi/tests/test_livemigration.py | 107 ++++++++++++++++----- 3 files changed, 190 insertions(+), 26 deletions(-) -- 2.4.3

2 3

[PATCH v2] Live migration - non shared storage support
by dhbarboza82＠gmail.com 17 Nov '15

17 Nov '15

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> Changes in v2: - using libvirt API to get the disk size as suggested by Aline This patch implements non shared storage for the live migration backend. No API changes were made. To test it (WoK running with default ports): curl -u root -H "Content-Type: application/json" -H "Accept: application/json" -k "https://localhost:8001/plugins/kimchi/vms/migrate_test/migrate" -X POST -d '{"remote_host": "remote_host_ip", "user":"root"}' Daniel Henrique Barboza (1): Live migration backend: non-shared storage VM migration src/wok/plugins/kimchi/i18n.py | 4 + src/wok/plugins/kimchi/model/vms.py | 104 +++++++++++++++++++- src/wok/plugins/kimchi/tests/test_livemigration.py | 107 ++++++++++++++++----- 3 files changed, 189 insertions(+), 26 deletions(-) -- 2.4.3

2 3

[PATCH 0/2 - v2] Implement front-end support to add multiple disks in Template
by Rodrigo Trujillo 16 Nov '15

16 Nov '15

V2 - Rebase over latest new UI patches V1 - Initial version Rodrigo Trujillo (2): Allow listStorageVolumes ajax call be synchronized UI - Implement multiple disks support in Template edit window src/wok/plugins/kimchi/ui/js/src/kimchi.api.js | 7 +- .../ui/js/src/kimchi.guest_storage_add.main.js | 2 +- .../kimchi/ui/js/src/kimchi.storage_main.js | 2 +- .../kimchi/ui/js/src/kimchi.template_edit_main.js | 246 ++++++++++----------- .../kimchi/ui/pages/template-edit.html.tmpl | 5 +- 5 files changed, 130 insertions(+), 132 deletions(-) -- 2.1.0

2 7

RFC - #728 - Processor Info in s390 architecture
by Suresh Babu Angadi 16 Nov '15

16 Nov '15

Hi Team, With the current implementation of gingerbase, the processor information is empty for s390 architecture. O/p of /plugins/gingerbase/host on one of the lpar with KVM for IBM z systems: { "os_distro":"KVM for IBM z Systems", "os_codename":"Z", "os_version":"1.1.1", "cpus":3, "memory":4000559104 } Note: cpu_model is not fetched for s390x architecture. Additional Information which can be provided for benefit of end users: Architecture Details: "architecture": "x86 or s390x or ppc etc" CPU details(for x86 and s390x): Showing online cpus count and offline cpus count(planned to use lscpu for x86 and s390x, not sure how to fetch these details in power pc). Display offline CPUs only if any processors are offline. "cpus": {"online": <integer(online_cpus_count)> "offline": <integer(offline_cpus_count)>} Processor Type(s390x): shared and dedicated cpus "cpus": {"online": <integer(online_cpus_count)> "offline": <integer(offline_cpus_count)> "shared": <integer(shared_cpus_count)> "dedicated": <integer(dedicated_cpus_count)>} Host Name(for all architecture): Currently IP address is displayed in the new UI (below kimchi logo). Displaying host name would be more meaningful. Memory Details(s390x specific): In s390x architecture, we can have online and offline memory. example: [root@ ~]# lsmem Address Range Size (MB) State Removable Device =============================================================================== 0x0000000000000000-0x000000000fffffff 256 online no 0 0x0000000010000000-0x000000002fffffff 512 online yes 1-2 0x0000000030000000-0x000000007fffffff 1280 online no 3-7 0x0000000080000000-0x00000000ffffffff 2048 offline - 8-15 Memory device size : 256 MB Memory block size : 256 MB* **Total online memory : 2048 MB** **Total offline memory: 2048 MB* so memory would be split to include total online and total offline memory. memory: {"online": <total_online_memory>, "offline":<total offline memory>} Virtualization Details(s390x specific): Providing Hypervisor and Hypervisor Vendor details when virtualized. Example Hypervisor: PR/SM , Hypervisor vendor: IBM. Lpar Details: Lpar name and Lpar ID "virtualization": {"hypervisor":"PR/SM", "hypervisor_vendor": "IBM", "lpar_name": "LP6", "lpar_number":"22"} So the o/p json of /plugins/gingerbase/host would look like below: for x86: { "os_distro":"Fedora", "architecture":"x86_64" "cpu_model":"Intel(R) Core(TM) i5-3320M CPU @ 2.60GHz", "cpus":{"online":3, "offline":2}, "os_version":"21", "os_codename":"Twenty One", "memory":7933894656 "host":<host_name> } for power: Only change, addition of "architecture" and "host" information, unless we decide to show offline cpus for s390x: { "os_distro":"KVM for IBM z Systems", "os_codename":"Z", "os_version":"1.1.1", "architecture": "s390x" "cpu_model": "IBM / 2827 / 743 H43" cpus: {"online":2, "offline":2, "shared":2, "dedicated":0} memory : {"online" : 2147483628, "offline" : 2147483628} "virtualization": {"hypervisor":"PR/SM", "hypervisor_vendor": "IBM", "lpar_name": "LP6", "lpar_number":"22"}, "host":"zfwpc160" } -- Regards, Suresh Babu Angadi

2 2

[RFC] UI - Live migration UI design
by Daniel Henrique Barboza 16 Nov '15

16 Nov '15

Hi, The backend for this feature is almost completed and the API is defined, so let's talk about the UI. This is the API (note: the upstream version is outdated, will be updated in an incoming patch): **URI:** /plugins/kimchi/vms/*:name* * **POST**: *See Virtual Machine Actions* **Actions (POST):** * migrate: Migrate a virtual machine to a remote server, only support live mode without block migration. * remote_host: IP address or hostname of the remote server. * user *(optional)*: User to log on at the remote server. * password *(optional)*: password of the user in the remote server This API will return a task ID for the UI to track its progress, pretty much like it is done with the 'clone' feature. This is how I imagine the UI: - a button called "migrate" at the same submenu as clone VM. - when pressed, a new window appears with the following content: -------- "Disclaimer: this process cannot be stopped after started, can take a long time to complete and will turn off this current VM when it is over." * textfield to input the remote_server, name "remote server" * checkbox with text: "Delete this VM when the migration is completed" Text: "The following fields are optional. Fill them if you want Kimchi to setup a password-less ssh session between the localhost and the remote host. The setup process will only be successful if the user has 'SUDO ALL' permission in the remote machine" * textfield to input the username of the remote host * password field to input the password of the user in the remote host * "Cancel" and "Start" buttons at the bottom ------------- This is the workflow/behavior I would expect of it: - clicking "Cancel" at any time will dismiss the window and nothing happens; - clicking "Start" without remote_host field will issue an error "remote host field cannot be blank" or something like that - clicking "Start" with a remote host field will start the process - clicking "Start" with remote host and only one of the user or password filled will raise an error "both user and password fields must be filled". - if, **and only if **, the user checks the checkbox "Delete VM ....", the UI will delete the VM after the migration process is completed by using the proper API (I believe it is DELETE /vms/name). This is all I have for the UI for this feature ATM. I'll update this RFC if required. Please provide comments and suggestions. The final backend for this feature will be submitted to the ML at the start of the next week. Let me know if there's any doubts about how Kimchi's live migration backend works. Daniel

4 4

[RFC] Add support for guest serial console
by Ramon Medeiros 16 Nov '15

16 Nov '15

Hi, i want to discuss about the support of guest serial console. To access a serial console, i need to add the xml of the device (http://wiki.libvirt.org/page/Unable_to_connect_to_console_of_a_running_doma…) <serial type='pty'> <target port='0'/> </serial> <console type='pty'> <target type='serial' port='0'/> </console> And, the operation system of the VM need to point to the serial: console=ttyS0,115200 So, how we can make sure that the user can access the machine by serial console: 1) Just add the xml and let the user add the statement above? 2) Use libvirt to add this parameters (https://libvirt.org/formatdomain.html#elementsOSKernel) -- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

2 1

[PATCH 1/2] Allow listStorageVolumes ajax call be synchronized
by Rodrigo Trujillo 13 Nov '15

13 Nov '15

This patch changes kimchi.listStorageVolumes function to receive a new parameter 'sync' in order to set it as synchronous call. Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo(a)linux.vnet.ibm.com> --- src/wok/plugins/kimchi/ui/js/src/kimchi.api.js | 7 ++++--- src/wok/plugins/kimchi/ui/js/src/kimchi.guest_storage_add.main.js | 2 +- src/wok/plugins/kimchi/ui/js/src/kimchi.storage_main.js | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/wok/plugins/kimchi/ui/js/src/kimchi.api.js b/src/wok/plugins/kimchi/ui/js/src/kimchi.api.js index b1acdb9..d5e9ddd 100644 --- a/src/wok/plugins/kimchi/ui/js/src/kimchi.api.js +++ b/src/wok/plugins/kimchi/ui/js/src/kimchi.api.js @@ -393,12 +393,13 @@ var kimchi = { }); }, - listStorageVolumes : function(poolName, suc, err) { + listStorageVolumes : function(poolName, suc, err, sync) { $.ajax({ url : 'plugins/kimchi/storagepools/' + encodeURIComponent(poolName) + '/storagevolumes', type : 'GET', contentType : 'application/json', dataType : 'json', + async : !sync, success : suc, error : err }); @@ -452,7 +453,7 @@ var kimchi = { return; } suc(isos, true); - }, err); + }, err, false); } else if (status === "running") { if (deepScanHandler.stop) { return; @@ -463,7 +464,7 @@ var kimchi = { } suc(isos, false); setTimeout(monitorTask, 2000); - }, err); + }, err, false); } else if (status === "failed") { if (deepScanHandler.stop) { return; diff --git a/src/wok/plugins/kimchi/ui/js/src/kimchi.guest_storage_add.main.js b/src/wok/plugins/kimchi/ui/js/src/kimchi.guest_storage_add.main.js index ec07cf0..d6606ee 100644 --- a/src/wok/plugins/kimchi/ui/js/src/kimchi.guest_storage_add.main.js +++ b/src/wok/plugins/kimchi/ui/js/src/kimchi.guest_storage_add.main.js @@ -94,7 +94,7 @@ kimchi.guest_storage_add_main = function() { } } $('#guest-disk').selectMenu("setData", options); - }); + }, null, false); }); diff --git a/src/wok/plugins/kimchi/ui/js/src/kimchi.storage_main.js b/src/wok/plugins/kimchi/ui/js/src/kimchi.storage_main.js index 40a43f6..cba8fb4 100644 --- a/src/wok/plugins/kimchi/ui/js/src/kimchi.storage_main.js +++ b/src/wok/plugins/kimchi/ui/js/src/kimchi.storage_main.js @@ -282,7 +282,7 @@ kimchi.doListVolumes = function(poolObj) { slide.slideDown('slow'); }, function(err) { wok.message.error(err.responseJSON.reason); - }); + }, false); } kimchi.initLogicalPoolExtend = function() { -- 2.1.0

2 3