December 2015 - Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi] Issue 797: show volumes even if pool is busy
by Jose Ricardo Ziviani 22 Dec '15

22 Dec '15

This commit fixes the issue https://github.com/kimchi-project/kimchi/issues/797. It will display all volumes of a pool even if that particular pool is busy. Jose Ricardo Ziviani (1): Ignore pool.refresh if it cannot be called i18n.py | 2 -- model/storagepools.py | 27 +++++++++------------------ model/storagevolumes.py | 8 +++----- 3 files changed, 12 insertions(+), 25 deletions(-) -- 1.9.1

3 5

[PATCH v2] [Kimchi] Issue 797: show volumes even if pool is busy
by Jose Ricardo Ziviani 22 Dec '15

22 Dec '15

This commit fixes the issue https://github.com/kimchi-project/kimchi/issues/797. It will display all volumes of a pool even if that particular pool is busy. Jose Ricardo Ziviani (1): Ignore pool.refresh if it cannot be called i18n.py | 2 -- model/storagepools.py | 27 +++++++++------------------ model/storagevolumes.py | 8 +++----- 3 files changed, 12 insertions(+), 25 deletions(-) -- 1.9.1

3 3

[PATCH] [Wok] Make run_command log its output into a file.
by pvital＠linux.vnet.ibm.com 22 Dec '15

22 Dec '15

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> Adds the ability of run_command to log the output of a console command into the file /tmp/wok_tee_log_file, like the "tee" command does. Using this patch, a command that takes too many time to execute can be monitored by reading the log file while other tasks are executed. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- src/wok/utils.py | 45 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/src/wok/utils.py b/src/wok/utils.py index 997adf3..96569d4 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -40,6 +40,7 @@ from wok.exception import InvalidParameter, TimeoutExpired wok_log = cherrypy.log.error_log +tee_log_file = '/tmp/wok_tee_log_file' task_id = 0 @@ -131,13 +132,15 @@ def import_module(module_name, class_name=''): return __import__(module_name, globals(), locals(), [class_name]) -def run_command(cmd, timeout=None, silent=False): +def run_command(cmd, timeout=None, silent=False, tee=False): """ cmd is a sequence of command arguments. timeout is a float number in seconds. timeout default value is None, means command run without timeout. silent is bool, it will log errors using debug handler not error. silent default value is False. + tee is bool and stores the output of the command in a log file, like 'tee' + tee default value is False. """ # subprocess.kill() can leave descendants running # and halting the execution. Using psutil to @@ -155,6 +158,18 @@ def run_command(cmd, timeout=None, silent=False): else: timeout_flag[0] = True + def tee_log(msg=None): + if msg is None: + return + + f = open(tee_log_file, 'a') + msg +='\n' + try: + f.write(msg) + except TypeError: + f.write(msg.encode('utf_8')) + f.close() + proc = None timer = None timeout_flag = [False] @@ -167,8 +182,31 @@ def run_command(cmd, timeout=None, silent=False): timer.setDaemon(True) timer.start() - out, error = proc.communicate() wok_log.debug("Run command: '%s'", " ".join(cmd)) + if tee: + output = [] + while True: + line = "" + try: + line = proc.stdout.readline() + line = line.decode('utf_8') + except Exception: + type, e, tb = sys.exc_info() + wok_log.error(e) + wok_log.error("The output of the command could not be " + " decoded as %s\ncmd: %s\n line ignored: %s" % + ('utf_8', cmd, repr(line))) + pass + + output.append(line) + if not line: + break + line = line.rstrip('\n\r') + tee_log(line) + out = ''.join(output) + error = proc.stderr.read() + else: + out, error = proc.communicate() if out: wok_log.debug("out:\n%s", out) @@ -214,7 +252,8 @@ def run_command(cmd, timeout=None, silent=False): finally: if timer and not timeout_flag[0]: timer.cancel() - + if tee and os.path.exists(tee_log_file): + os.remove(tee_log_file) def parse_cmd_output(output, output_items): res = [] -- 2.5.0

2 1

[PATCH V2] [Wok] Issue #12: wokd start fails if plugin does not have ui/config/tab-ext.xml
by archus＠linux.vnet.ibm.com 22 Dec '15

22 Dec '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> Currently, it gets the list of tab-ext.xml for all the installed plugins and then each file is parsed in for loop. Moved code which parse the tab-ext.xml file inside try except block to handle IOError. On IOError(File not found) continue the for loop to parse other plugins tab-ext.xml. Signed-off-by: Archana Singh <archus(a)linux.vnet.ibm.com> --- src/wok/utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/wok/utils.py b/src/wok/utils.py index 997adf3..0138bd2 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -109,7 +109,11 @@ def get_all_tabs(): tabs = [] for f in files: - root = ET.parse(f) + try: + root = ET.parse(f) + except (IOError), e: + wok_log.debug("Unable to load %s", f) + continue tabs.extend([t.text.lower() for t in root.getiterator('title')]) return tabs -- 2.1.0

3 2

[PATCH] [Wok] Issue #10: wok.message with closeable as true is also fading out after timeout
by archus＠linux.vnet.ibm.com 22 Dec '15

22 Dec '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> Added check if closeable is true, then don't setTimeout to fadeOut the message. Signed-off-by: Archana Singh <archus(a)linux.vnet.ibm.com> --- ui/js/src/wok.message.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/ui/js/src/wok.message.js b/ui/js/src/wok.message.js index 5f5759e..63bf84e 100644 --- a/ui/js/src/wok.message.js +++ b/ui/js/src/wok.message.js @@ -36,15 +36,17 @@ wok.message = function(msg, level, node, closeable) { $message.alert(); $message.fadeIn(100); - var timeout = setTimeout(function() { - $message.delay(4000).fadeOut(100, function() { - $message.alert('close'); - $(this).remove(); - if ($(container).children().length < 1) { - $(container).hide(); - } - }); - }, 10000); + if(!closeable){ + var timeout = setTimeout(function() { + $message.delay(4000).fadeOut(100, function() { + $message.alert('close'); + $(this).remove(); + if ($(container).children().length < 1) { + $(container).hide(); + } + }); + }, 10000); + } }; wok.message.warn = function(msg, node, closeable) { -- 2.1.0

3 2

Scrum meetings
by Aline Manera 21 Dec '15

21 Dec '15

Hi all, There will be no scrum meeting this week (Dec 23th) neither in the next one (Dec 30th) due the holidays. The next scrum meeting will be on Jan 06th 2016! And we will make it once a week again, as more and more people are joining the community. The time keeps the same: 9AM EDT on Wednesdays. Merry Christmas and Happy New Year to you all! Regards, Aline Manera

1 0

[RFC] Usage of X-editable plugin (https://vitalets.github.io/x-editable/) for plugins ginger new ui developments
by Atreye Mukhopadhyay 21 Dec '15

21 Dec '15

Hi All, I would like propose the use of X-editable bootstrap plugin (https://vitalets.github.io/x-editable/) for grid in-place editing.It can be easily integrated with bootstrap and jquey-bootgrid plugin and be used for grid inline editing. Official Github location of X-editable implementation is @ https://github.com/vitalets/x-editable. X-editable code is of license type MIT so I guess it can be used safely. Please feel free to comment on this topic and have your opinion.

1 0

[PATCH] [Wok] Issue #12: wokd start fails if plugin does not have ui/config/tab-ext.xml
by archus＠linux.vnet.ibm.com 21 Dec '15

21 Dec '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> Currently, it gets the list of tab-ext.xml for all the installed plugins and then each file is parsed in for loop. Moved code which parse the tab-ext.xml file inside try except block to handle IOError. On IOError(File not found) continue the for loop to parse other plugins tab-ext.xml. Signed-off-by: Archana Singh <archus(a)linux.vnet.ibm.com> --- src/wok/utils.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/wok/utils.py b/src/wok/utils.py index 997adf3..0138bd2 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -109,7 +109,11 @@ def get_all_tabs(): tabs = [] for f in files: - root = ET.parse(f) + try: + root = ET.parse(f) + except (IOError), e: + wok_log.debug("Unable to load %s", f) + continue tabs.extend([t.text.lower() for t in root.getiterator('title')]) return tabs -- 2.1.0

1 0

[PATCH] [Wok] Issue #12:wokd start fails if plugin does not have ui/config/tab-ext.xml
by archus＠linux.vnet.ibm.com 21 Dec '15

21 Dec '15

From: Archana Singh <archus(a)linux.vnet.ibm.com> Currently the tab-ext.xml are read and parse for each plugin in side for loop. Moved code which parse of tab-ext.xml file inside try except block to handle IOError. On IOError(File not found) continue the for loop to parse other plugins tab-ext.xml Signed-off-by: Archana Singh <archus(a)linux.vnet.ibm.com> --- src/wok/utils.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/wok/utils.py b/src/wok/utils.py index 997adf3..1c997e3 100644 --- a/src/wok/utils.py +++ b/src/wok/utils.py @@ -109,7 +109,10 @@ def get_all_tabs(): tabs = [] for f in files: - root = ET.parse(f) + try: + root = ET.parse(f) + except (IOError), e: + continue tabs.extend([t.text.lower() for t in root.getiterator('title')]) return tabs -- 2.1.0

2 1

Kimchi 2.0 is released!
by Aline Manera 18 Dec '15

18 Dec '15

On behalf of everyone who has worked hard on this release, I am pleased to announce the availability of *Kimchi 2.0*! This release is an important milestone for Kimchi and Ginger communities, as Wok and Ginger Base (two new projects originated from Kimchi) are also officially announced! Wok is a cherrypy-based web framework with HTML5 support that is extended by plugins which expose functionality through REST APIs. And it is part of Kimchi community. Ginger Base is a Wok plugin for base host management. It was originated from the former Host tab in Kimchi and it is now part of Ginger community. From now on, Kimchi is a Wok plugin to manage KVM guests. Kimchi depends on Wok and Ginger Base, so make sure you have them installed in your system in addition to Kimchi. You can find more information about Wok at: http://kimchi-project.github.io/wok/; and more information about Ginger Base at: http://kimchi-project.github.io/gingerbase/ Among many features, this release includes: ✔ New UI design ✔ Resources filtering ✔ Guest memory utilization statistics ✔ Support to add multiple disks to a Template ✔ Provide information about guest IP addresses We have worked hard to ensure that Kimchi runs well on the most popular Linux distributions including: Fedora 23, Ubuntu 15.10, openSUSE 13.2, and RHEL 7.2. Kimchi uses standard Linux interfaces so it should run well on many other distributions too. You can easily grab this release in tarball format or via git: ✔ https://github.com/kimchi-project/kimchi/archive/2.0.0.tar.gz ✔ git clone --recursive https://github.com/kimchi-project/kimchi.git There are also some packages available at: ✔ http://kimchi-project.github.io/kimchi/downloads/ Go ahead! Give it a try and let us know what you think! Regards, Aline Manera

2 1