March 2017 - Kimchi-devel - oVirt List Archives

[PATCH] Add apache configuration
by Cédric Bosdonnat 11 Apr '17

11 Apr '17

Provide an apache2 virtual host configuration in contrib. With this, the user can choose to use either nginx or apache as a proxy. The reason why the configuration has been added to contrib rather than src/apache2 to mimic the nginx config, is that there is no distro with the same apache2 config layout than others. Also add Wants and After for apache2 in the systemd unit file. Signed-off-by: Cédric Bosdonnat <cbosdonnat(a)suse.com> --- contrib/wok.conf.apache | 34 ++++++++++++++++++++++++++++++++++ contrib/wokd.service.systemd | 2 ++ 2 files changed, 36 insertions(+) create mode 100644 contrib/wok.conf.apache diff --git a/contrib/wok.conf.apache b/contrib/wok.conf.apache new file mode 100644 index 00000000..c7e650ee --- /dev/null +++ b/contrib/wok.conf.apache @@ -0,0 +1,34 @@ +Listen 8001 +Listen 8000 + +<VirtualHost *:8001> + ErrorLog /var/log/apache2/error_log + TransferLog /var/log/apache2/access_log + + Timeout 600 + LimitRequestBody 4294967296 + + SSLEngine on + SSLCertificateFile /etc/wok/wok-cert.pem + SSLCertificateKeyFile /etc/wok/wok-key.pem + SSLOpenSSLConfCmd DHParameters /etc/wok/dhparams.pem + SSLSessionCacheTimeout 600 + + RewriteEngine On + RewriteCond %{HTTP:Upgrade} =websocket [NC] + RewriteRule /(.*) ws://localhost:64667/$1 [P,L] + + ProxyPass /websockify http://127.0.0.1:64667/websockify + ProxyPassReverse /websockify http://127.0.0.1:64667/websockify + + ProxyPass / http://127.0.0.1:8010/ + ProxyPassReverse / http://127.0.0.1:8010/ +</VirtualHost> + +<VirtualHost *:8000> + ErrorLog /var/log/apache2/error_log + TransferLog /var/log/apache2/access_log + + RewriteEngine On + RewriteRule ^/(.*)$ https://localhost:8001/$1 [R] +</VirtualHost> diff --git a/contrib/wokd.service.systemd b/contrib/wokd.service.systemd index 621be601..eba80a9d 100644 --- a/contrib/wokd.service.systemd +++ b/contrib/wokd.service.systemd @@ -3,6 +3,8 @@ Description=Wok - Webserver Originated from Kimchi Documentation=https://github.com/kimchi-project/wok/wiki Wants=nginx.service After=nginx.service +Wants=apache2.service +After=apache2.service [Service] Type=simple -- 2.12.0

3 3

[PATCH] [Wok] python-mock not listed as dependency
by Ramon Medeiros 11 Apr '17

11 Apr '17

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- docs/fedora-deps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md index 29b477f..484f409 100644 --- a/docs/fedora-deps.md +++ b/docs/fedora-deps.md @@ -42,7 +42,7 @@ Packages required for UI development Packages required for tests --------------------------- - $ sudo yum install pyflakes python-pep8 python-requests rpmlint + $ sudo yum install pyflakes python-pep8 python-requests rpmlint python-mock # For RHEL systems, install the additional packages: $ sudo yum install python-unittest2 -- 2.9.3

2 2

Wok 2.4 and Kimchi 2.4 are now released!
by Aline Manera 04 Apr '17

04 Apr '17

On behalf of everyone who has worked hard on this release, I am pleased to announce the availability of *Wok 2.4* and *Kimchi 2.4*! Kimchi 2.4 depends on *Wok 2.4* and *Ginger Base 2.3*! So make sure to have both of them properly installed in your system. Among many features, Wok 2.4 release includes: ✔ Plugins management ✔ Block authentication request after too many failures ✔ Asynchronous UI notification using Websockets ✔ Bug fixes Kimchi 2.4 release includes: ✔ Initial s390x systems support ✔ Guest CPU hot plug and unplug ✔ Live migration over RDMA ✔ Live snapshot support ✔ Bug fixes We have worked hard to ensure that Wok and Kimchi run well on the most popular Linux distributions including: Fedora 25, Ubuntu 16.10, openSUSE LEAP 42.2, and CentOS 7. They use standard Linux interfaces so it should run well on many other distributions too. You can easily grab this release in tarball format or via git: ✔ https://github.com/kimchi-project/wok/archive/2.4.0.tar.gz ✔ https://github.com/kimchi-project/kimchi/archive/2.4.0.tar.gz ✔ git clone -b stable-2.4.x --recursivehttps://github.com/kimchi-project/wok.git There are also some packages available for download at: ✔http://kimchi-project.github.io/wok/downloads/ ✔http://kimchi-project.github.io/kimchi/downloads/ Go ahead! Give it a try and let us know what you think! Regards, Aline Manera

3 7

[PATCH v2] [Wok] python-mock not listed as dependency
by Ramon Medeiros 29 Mar '17

29 Mar '17

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- Changes: v2: do it for all distros docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 1 + docs/ubuntu-deps.md | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md index 29b477f..484f409 100644 --- a/docs/fedora-deps.md +++ b/docs/fedora-deps.md @@ -42,7 +42,7 @@ Packages required for UI development Packages required for tests --------------------------- - $ sudo yum install pyflakes python-pep8 python-requests rpmlint + $ sudo yum install pyflakes python-pep8 python-requests rpmlint python-mock # For RHEL systems, install the additional packages: $ sudo yum install python-unittest2 diff --git a/docs/opensuse-deps.md b/docs/opensuse-deps.md index a6086da..eee39f9 100644 --- a/docs/opensuse-deps.md +++ b/docs/opensuse-deps.md @@ -31,3 +31,4 @@ Packages required for tests --------------------------- $ sudo zypper install python-pyflakes python-pep8 python-requests rpmlint + python-mock diff --git a/docs/ubuntu-deps.md b/docs/ubuntu-deps.md index cdffc59..3607998 100644 --- a/docs/ubuntu-deps.md +++ b/docs/ubuntu-deps.md @@ -30,4 +30,4 @@ Packages required for UI development Packages required for tests --------------------------- - $ sudo apt-get install pep8 pyflakes python-requests + $ sudo apt-get install pep8 pyflakes python-requests python-mock -- 2.9.3

3 2

[PATCH] [WoK] Bug fix #205: adding 'user-log.dita' help page
by dhbarboza82＠gmail.com 29 Mar '17

29 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> Added a new help page 'user-log.dita' with User Log help information. Changed 'settings.dita' to reflect the contents of the Settings tab. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- ui/pages/help/en_US/settings.dita | 10 ++++------ ui/pages/help/en_US/user-log.dita | 42 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 6 deletions(-) create mode 100644 ui/pages/help/en_US/user-log.dita diff --git a/ui/pages/help/en_US/settings.dita b/ui/pages/help/en_US/settings.dita index bebac17..9144697 100644 --- a/ui/pages/help/en_US/settings.dita +++ b/ui/pages/help/en_US/settings.dita @@ -1,7 +1,7 @@ <?xml version="1.0" encoding="UTF-8"?>  <title>Settings</title> <csbody> <dl><dlentry> -<dt>User Activity Log</dt> -<dd>This section displays user activity log of Wok and its plugins.</dd> -<dd>To get any specific log result, please use the 'Advanced Search' option. You can specify a particular application (such as wok, ginger, gingerbase, gingers390x, kimchi), an user, request type or even date range.</dd> -<dd>Select "Reset to Default" option to clear the search criteria.</dd> -<dd>Download: Use this option to download user activity log.</dd> +<dt>Plugins Management</dt> +<dd>This section displays the current plug-in status of WoK..</dd> +<dd>In the 'Status' column it is possible to enable or disable a specific plug-in. Enabling a plug-in will enable all its dependencies (example: enabling Kimchi will enable Gingerbase as well). Likewise, disabling a plug-in will disable all plug-ins that depends on the now disabled plug-in (example: disabling Gingerbase will disable Kimchi and Ginger).</dd> </dlentry> </dl><?Pub Caret 2101?> </csbody> diff --git a/ui/pages/help/en_US/user-log.dita b/ui/pages/help/en_US/user-log.dita new file mode 100644 index 0000000..a06136b --- /dev/null +++ b/ui/pages/help/en_US/user-log.dita @@ -0,0 +1,42 @@ +<?xml version="1.0" encoding="UTF-8"?> + + +<!DOCTYPE cshelp PUBLIC "-//IBM//DTD DITA CSHelp//EN" + "..\dtd\cshelp.dtd"> +<?Pub Sty _display FontColor="red"?> +<?Pub Inc?> + +<cshelp id="settings" xml:lang="en-us"> +<title>Activity Log</title> +<csbody> +<dl><dlentry> +<dt>User Activity Log</dt> +<dd>This section displays user activity log of Wok and its plugins.</dd> +<dd>To get any specific log result, please use the 'Advanced Search' option. You can specify a particular application (such as wok, ginger, gingerbase, gingers390x, kimchi), an user, request type or even date range.</dd> +<dd>Select "Reset to Default" option to clear the search criteria.</dd> +<dd>Download: Use this option to download user activity log.</dd> +</dlentry> +</dl><?Pub Caret 2101?> +</csbody> +</cshelp> +<?Pub *0000003732?> -- 2.9.3

2 1

[PATCH] [Kimchi] Bug fix: Set original VLAN device to network parameters to be updated
by Aline Manera 29 Mar '17

29 Mar '17

It is part of the #1087 fix Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- model/networks.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/model/networks.py b/model/networks.py index eb1590e..ce93bb1 100644 --- a/model/networks.py +++ b/model/networks.py @@ -532,6 +532,9 @@ class NetworkModel(object): if params.get('vlan_id') or params.get('interfaces'): raise InvalidParameter("KCHNET0032E") + # merge parameters + info.update(params) + # get target device if bridge was created by Kimchi if connection == 'bridge': iface = info['interfaces'][0] @@ -544,18 +547,13 @@ class NetworkModel(object): else: info['interfaces'] = original['interfaces'] = [port] - # merge parameters - info.update(params) - # delete original network self.delete(name) try: # create new network - network = self.collection.create(info) + return self.collection.create(info) except: # restore original network self.collection.create(original) raise - - return network -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix: Inform user there is no interface available when creating a network
by Aline Manera 29 Mar '17

29 Mar '17

When there is no interface available, the user will not be able to create some networks so inform that to user using the existing drop down menu instead of a label message fixed in the dialog (which was displayed even though for network not requiring an interface). Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.network_add_main.js | 7 +++---- ui/pages/network-add.html.tmpl | 7 ++----- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/ui/js/src/kimchi.network_add_main.js b/ui/js/src/kimchi.network_add_main.js index e1fdf13..c990e89 100644 --- a/ui/js/src/kimchi.network_add_main.js +++ b/ui/js/src/kimchi.network_add_main.js @@ -1,7 +1,7 @@ /* * Project Kimchi * - * Copyright IBM Corp, 2015-2016 + * Copyright IBM Corp, 2015-2017 * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -79,9 +79,8 @@ kimchi.setDefaultNetworkType = function(isInterfaceAvail, bEdit) { if (!bEdit) { kimchi.enableBridgeOptions(false); } - $("#networkBriDisabledLabel").removeClass('hidden'); - } else { - $("#networkBriDisabledLabel").remove(); + $("#destinationList button").addClass("disabled"); + $("#networkDestinationID").attr("title", "No interface available"); } }; diff --git a/ui/pages/network-add.html.tmpl b/ui/pages/network-add.html.tmpl index 14373ff..47be6f3 100644 --- a/ui/pages/network-add.html.tmpl +++ b/ui/pages/network-add.html.tmpl @@ -1,7 +1,7 @@ #* * Project Kimchi * - * Copyright IBM Corp, 2015-2016 + * Copyright IBM Corp, 2015-2017 * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -46,11 +46,8 @@ <option value="bridge">$_("Bridged: Virtual machines are connected through a network bridge")</option> </select> </div> - <div id="networkBriDisabledLabel" class="form-group hidden"> - <p>$_("(No interfaces found)")</p> - </div> <div id="bridgedContent"> - <div class="form-group"> + <div id="destinationList" class="form-group"> <label for="networkDestinationID">$_("Destination"): </label> <select id="networkDestinationID" data-size="5" class="selectpicker col-md-12 col-lg-12 form-control" data-none-selected-text="$_('Select an Interface')"> </select> -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix 1119: Proper check NetworkManager is running when creating new network
by Aline Manera 29 Mar '17

29 Mar '17

It was relying on Capabilities to verify NetworkManager was running or not. But the Capabilities value is only updated on lookup() which was leading on a wrong assumption. To fix that, call FeatureTests function directly. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- model/networks.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/model/networks.py b/model/networks.py index eb1590e..b653b23 100644 --- a/model/networks.py +++ b/model/networks.py @@ -33,7 +33,7 @@ from wok.plugins.gingerbase.netinfo import get_vlan_device, is_bridge, is_vlan from wok.plugins.gingerbase.netinfo import ports from wok.plugins.kimchi import network as knetwork from wok.plugins.kimchi.config import kimchiPaths -from wok.plugins.kimchi.model.config import CapabilitiesModel +from wok.plugins.kimchi.model.featuretests import FeatureTests from wok.plugins.kimchi.osinfo import defaults as tmpl_defaults from wok.plugins.kimchi.xmlutils.interface import get_iface_xml from wok.plugins.kimchi.xmlutils.network import create_linux_bridge_xml @@ -52,8 +52,6 @@ class NetworksModel(object): if self.conn.isQemuURI(): self._check_default_networks() - self.caps = CapabilitiesModel(**kargs) - def _check_default_networks(self): networks = list(set(tmpl_defaults.get('networks', []))) @@ -228,7 +226,7 @@ class NetworksModel(object): # connection == macvtap and iface is not bridge elif netinfo.is_bare_nic(iface) or netinfo.is_bonding(iface): # libvirt bridge creation will fail with NetworkManager enabled - if self.caps.nm_running: + if FeatureTests.is_nm_running(): raise InvalidParameter('KCHNET0027E') if 'vlan_id' in params: -- 2.9.3

1 1

[PATCH] [WoK] Removing sessionStorage call in wok.main.js
by dhbarboza82＠gmail.com 27 Mar '17

27 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> sessionStorage was being used in early versions of the websocket notifications implementation to avoid opening multiple connections, before the current single permanent connection approach was implemented. If the 'wokNotificationWebSocket' key existed in the sessionStorage, we skipped the opening of a new websocket. This patch removes the sessionStorage usage because it accomplishes nothing in current code. No verification is made using the created 'wokNotificationWebSocket' session key in the code. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- ui/js/src/wok.main.js | 1 - 1 file changed, 1 deletion(-) diff --git a/ui/js/src/wok.main.js b/ui/js/src/wok.main.js index 26dc723..411b05e 100644 --- a/ui/js/src/wok.main.js +++ b/ui/js/src/wok.main.js @@ -69,7 +69,6 @@ wok.startNotificationWebSocket = function () { } }; - sessionStorage.setItem('wokNotificationWebSocket', 'true'); var heartbeat = setInterval(function() { wok.notificationsWebSocket.send(window.btoa('heartbeat')); }, 30000); -- 2.9.3

2 1

[PATCH] [WoK] Bug fix #189: Forcing download of user log file
by dhbarboza82＠gmail.com 27 Mar '17

27 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> The error in staticfile() happens when the browser tries to open a recently created file in a separated tab/window but this file isn't declared in the cherry-py config with tools.staticfile.on, like '/favicon.ico' for example. A suitable solution to avoid the error is to force the browser to download the file instead of opening it. According to the Cherry-py docs: "Using "application/x-download" response content-type, you can tell a browser that a resource should be downloaded onto the user’s machine rather than displayed." This patch set the application type of all '.txt' files created under the /data/logs dir as 'application/x-download'. Signed-off-by: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> --- src/wok/config.py.in | 3 +++ tests/test_config.py.in | 5 ++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/wok/config.py.in b/src/wok/config.py.in index 677d0ed..c2bcc28 100644 --- a/src/wok/config.py.in +++ b/src/wok/config.py.in @@ -202,6 +202,9 @@ class WokConfig(dict): '/data/logs': { 'tools.staticdir.on': True, 'tools.staticdir.dir': '%s/logs' % paths.state_dir, + 'tools.staticdir.content_types': { + 'txt': 'application/x-download' + }, 'tools.nocache.on': False, 'tools.wokauth.on': True, }, diff --git a/tests/test_config.py.in b/tests/test_config.py.in index 9b8c851..a4d65bb 100644 --- a/tests/test_config.py.in +++ b/tests/test_config.py.in @@ -1,7 +1,7 @@ # # Project Wok # -# Copyright IBM Corp, 2014-2016 +# Copyright IBM Corp, 2014-2017 # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -84,6 +84,9 @@ class ConfigTests(unittest.TestCase): '/data/logs': { 'tools.staticdir.on': True, 'tools.staticdir.dir': '%s/logs' % paths.state_dir, + 'tools.staticdir.content_types': { + 'txt': 'application/x-download' + }, 'tools.nocache.on': False, 'tools.wokauth.on': True, }, -- 2.9.3

2 1

[PATCH] [Kimchi] Bug fix: Display full Volume dropdown menu content even when pool has few volumes
by Aline Manera 27 Mar '17

27 Mar '17

When the storage pool has one or two storage volumes, the dropdown menu would not display all the options as the height set to it was not enough. To avoid that, increase the min-height configuration. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- ui/css/kimchi.css | 6 +++++- ui/css/src/modules/_storage.scss | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ui/css/kimchi.css b/ui/css/kimchi.css index 0af9293..2d44919 100644 --- a/ui/css/kimchi.css +++ b/ui/css/kimchi.css @@ -2514,11 +2514,15 @@ ul { #storage-root-container .volumes .volumeslist { padding: 22px; - min-height: 136px; + min-height: 188px; max-height: 505px; overflow: hidden; } +#storage-root-container .volumes .volumeslist .wok-list { + min-height: inherit; +} + #storage-root-container .volumes .volumeslist .row { font-size: 0; margin-bottom: 22px; diff --git a/ui/css/src/modules/_storage.scss b/ui/css/src/modules/_storage.scss index 70cb3fa..c8b84a9 100644 --- a/ui/css/src/modules/_storage.scss +++ b/ui/css/src/modules/_storage.scss @@ -82,11 +82,15 @@ .volumeslist { padding: 22px; - min-height: 136px; + min-height: 188px; max-height: 505px; overflow: hidden; } + .volumeslist .wok-list { + min-height: inherit; + } + .volumeslist .row { font-size: 0; margin-bottom: 22px; -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix: Proper display storage volume content on gallery view
by Aline Manera 27 Mar '17

27 Mar '17

On Storage volume gallery view, the volume box content was a mess. Fix it. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- ui/css/kimchi.css | 10 +++++----- ui/css/src/modules/_storage.scss | 10 +++++----- ui/pages/tabs/storage.html.tmpl | 6 +++--- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ui/css/kimchi.css b/ui/css/kimchi.css index 2d44919..948b888 100644 --- a/ui/css/kimchi.css +++ b/ui/css/kimchi.css @@ -2683,7 +2683,7 @@ ul { #storage-root-container .volumes .wok-gallery .volume-box-inner { padding: 0 16px; width: 409px; - height: 150px; + height: auto; display: flex; flex-flow: row wrap; justify-content: space-around; @@ -2745,8 +2745,8 @@ ul { #storage-root-container .volumes .wok-gallery span.column-format, #storage-root-container .volumes .wok-gallery span.column-type { order: 3; - width: 142px; - margin-top: -5px; + width: auto; + margin: 5px 0px; } #storage-root-container .volumes .wok-gallery span.gallery-header { @@ -2937,14 +2937,14 @@ ul { @media (min-width: 992px) { #storage-root-container .volumes .wok-list.wok-datagrid > .wok-datagrid-header > span.column-name, #storage-root-container .volumes .wok-list.wok-datagrid > .wok-datagrid-body > .wok-datagrid-row > div > div > div > span.column-name { - width: 250px; + width: 450px; } } @media (min-width: 1200px) { #storage-root-container .volumes .wok-list.wok-datagrid > .wok-datagrid-header > span.column-name, #storage-root-container .volumes .wok-list.wok-datagrid > .wok-datagrid-body > .wok-datagrid-row > div > div > div > span.column-name { - width: 300px; + width: 500px; } } diff --git a/ui/css/src/modules/_storage.scss b/ui/css/src/modules/_storage.scss index 0123009..cf81d1b 100644 --- a/ui/css/src/modules/_storage.scss +++ b/ui/css/src/modules/_storage.scss @@ -240,7 +240,7 @@ .volume-box-inner { padding: 0 16px; width: 409px; - height: 150px; + height: auto; display: flex; flex-flow: row wrap; justify-content: space-around; @@ -303,8 +303,8 @@ span.column-format, span.column-type { order: 3; - width: 142px; - margin-top: -5px; + width: auto; + margin: 5px 0px; } span.gallery-header { @@ -457,10 +457,10 @@ > span.column-name { width: 202px; @media (min-width: $screen-md) { - width: 250px; + width: 450px; } @media (min-width: $screen-lg) { - width: 300px; + width: 500px; } label { diff --git a/ui/pages/tabs/storage.html.tmpl b/ui/pages/tabs/storage.html.tmpl index 9675579..ad88b65 100644 --- a/ui/pages/tabs/storage.html.tmpl +++ b/ui/pages/tabs/storage.html.tmpl @@ -1,7 +1,7 @@ #* * Project Kimchi * - * Copyright IBM Corp, 2013-2016 + * Copyright IBM Corp, 2013-2017 * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -172,10 +172,10 @@ <input type="checkbox" class="wok-checkbox" name="selected-volume[]" id="{checkbox}" value="{name}"> <label class="volume-name volume-name-filter" for="{checkbox}"><span class="volume-inline-progress hidden"><span class="wok-loading-icon"></span></span> {name}</label></span><span class="column-used"><span role="presentation" class="volume-icon {capacityIcon}"></span> {capacityLevel}%</span><span class="column-used-by volume-used-by-filter"><i class="fa fa-exclamation-circle" data-toggle="tooltip" title="$_('Used by the following VMs:') {used_by_formatted}" data-placement="bottom" data-original-title="$_('Used by the following VMs:') {used_by_formatted}"></i><span class="format-text" data-toggle="tooltip" title="$_('Used by the following VMs:') {used_by_formatted}" data-placement="bottom" data-original-title="$_('Used by the following VMs:') {used_by_formatted}">{used_by_text}</span></span><span class="column-format volume-format-filter"><span class="gallery-header" title="$_('Format')">$_('Format')</span><span class="format-text">{format}</span></span><span class="column-type volume-type-filter"><span class="gallery-header" title="$_('Type')">$_('Type')</span>{type}</span><span class="column-used-by volume-used-by-filter"><i class="fa fa-exclamation-circle" data-toggle="tooltip" title="$_('Used by the following VMs:') {used_by_formatted}" data-placement="bottom" data-original-title="$_('Used by the following VMs:') {used_by_formatted}"></i><span class="format-text" data-toggle="tooltip" title="$_('Used by the following VMs:') {used_by_formatted}" data-placement="bottom" data-original-title="$_('Used by the following VMs:') {used_by_formatted}">{used_by_text}</span></span><span class="column-used"><span role="presentation" class="volume-icon {capacityIcon}"></span> {capacityLevel}%</span><span class="column-allocated"><span class="gallery-header" title="$_('Allocation')">$_('Allocation')</span>{allocation}</span><span class="column-capacity"><span class="gallery-header" title="$_('Capacity')">$_('Capacity')</span>{capacity}</span><span class="column-progress hidden"><span class="progress-status"></span> <span class="progress-transferred"></span> -- 2.9.3

2 3

[PATCH] [Kimchi] Bug fix #1123: Do not rely on Wok configuration to get host information
by Aline Manera 22 Mar '17

22 Mar '17

The host information is only part of nginx configuration. So get the information of the running system to configure federation feature over openSLP Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- model/peers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/peers.py b/model/peers.py index 1be606b..c0dccce 100644 --- a/model/peers.py +++ b/model/peers.py @@ -34,7 +34,7 @@ class PeersModel(object): return # register server on openslp - hostname = socket.getfqdn(wok_config.get("server", "host")) + hostname = socket.getfqdn() port = wok_config.get("server", "proxy_port") self.url = hostname + ":" + port -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix: Preserve "View Gallery" button location when opening Storage Volume actions menu
by Aline Manera 22 Mar '17

22 Mar '17

The "View Gallery" button was being moved to left when opening the Storage Volume actions drop down menu. Fix it. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.storage_main.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/ui/js/src/kimchi.storage_main.js b/ui/js/src/kimchi.storage_main.js index bfde50c..0429456 100644 --- a/ui/js/src/kimchi.storage_main.js +++ b/ui/js/src/kimchi.storage_main.js @@ -1,7 +1,7 @@ /* * Project Kimchi * - * Copyright IBM Corp, 2013-2016 + * Copyright IBM Corp, 2013-2017 * * Licensed under the Apache License, Version 2.0 (the 'License'); * you may not use this file except in compliance with the License. @@ -640,11 +640,6 @@ kimchi.doListVolumes = function(poolObj) { $('.pool-action', volumeDiv).on('show.bs.dropdown', function () { $(volumeDiv).scrollTop(0); - $(this).css('position','absolute'); - $('.toggle-gallery',volumeDiv).css({ - 'position':'absolute', - 'margin-top': '1px' - }); $(volumeDiv).bind('mousewheel DOMMouseScroll', function(e) { e.preventDefault(); }); -- 2.9.3

2 2

[PATCH v5] [Kimchi 0/4] Bug fix #1091: Allow to set disk performance options per guest and template
by Ramon Medeiros 21 Mar '17

21 Mar '17

Changes: v5: Increase commit message verbosity Always return cache and io Improve documentation at API.md v4: Add support for templates (creation and update) v3: Add docs v2: Use REST API for tests General fixes Ramon Medeiros (4): Read io and cache option from disks Allow disks to update cache and io flags Bug fix #1091: Allow to set disk performance options per guest and template Add tests to verify if cache and io of a disk can be changed API.json | 26 ++++++++++++++++++- docs/API.md | 12 +++++++++ i18n.py | 1 - model/vmstorages.py | 55 ++++++++++++++++++++++++++-------------- tests/test_rest.py | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++- vmtemplate.py | 19 +++++++++++++- xmlutils/disk.py | 14 ++++++++++- 7 files changed, 175 insertions(+), 24 deletions(-) -- 2.9.3

1 4

[PATCH v4 0/4] Bug fix #1091: Allow to set disk performance options per guest and template
by Ramon Medeiros 20 Mar '17

20 Mar '17

Changes: v4: Add support for templates (creation and update) v3: Add docs v2: Use REST API for tests General fixes Ramon Medeiros (4): Read io and cache option from disks Allow disks to update cache and io flags Bug fix #1091: Allow to set disk performance options per guest and template Add tests to verify if cache and io of a disk can be changed API.json | 26 ++++++++++++++++++++++++- docs/API.md | 4 ++++ i18n.py | 1 - model/vmstorages.py | 55 ++++++++++++++++++++++++++++++++++------------------ tests/test_rest.py | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++- vmtemplate.py | 19 +++++++++++++++++- xmlutils/disk.py | 23 ++++++++++++++++++++-- 7 files changed, 159 insertions(+), 25 deletions(-) -- 2.9.3

2 9

Cleaning up Datastore errors?
by wk 20 Mar '17

20 Mar '17

Heh, originally sent to -users but evidently noone looks at that. -------------- Our kimchi hosts have people constantly working on from the command line including changing qcow2 image names (our practice is to name them similar to the instance name so its easy to see whats up in /var/lib/libvirt/images) So after a while the wok error log is full of these messages. and we often get reoccuring pink error messages in the WebUI. Is there a way to cleanout/fix/ignore the datastore for those of use who also work directly with libvirt. -bill WOKOBJST0001E: Unable to find 5f48fb31-0d73-4df7-948c-02beefee83d1 in datastore WOKOBJST0001E: Unable to find c7d94dcb-185f-4917-9b2e-d304f5ce807b in datastore WOKOBJST0001E: Unable to find d7f82fc8-44dd-484f-aaf9-f4ed0de3efe3 in datastore WOKOBJST0001E: Unable to find f88269b8-8ca9-4689-b8aa-c7e720e3c396 in datastore WOKOBJST0001E: Unable to find b46491f9-4351-4b82-ad57-87568dd55f3e in datastore WOKOBJST0001E: Unable to find 7c34a9fd-b3b6-4894-a6f1-baf6b7099403 in datastore WOKOBJST0001E: Unable to find 0eb316fe-803c-4b25-9dae-522c02748e5c in datastore WOKOBJST0001E: Unable to find 4e5663b8-300d-4ad0-8959-ecdc489e8c71 in datastore WOKOBJST0001E: Unable to find 5f48fb31-0d73-4df7-948c-02beefee83d1 in datastore WOKOBJST0001E: Unable to find c7d94dcb-185f-4917-9b2e-d304f5ce807b in datastore

3 2

[PATCH] python-mock not listed as dependency
by Ramon Medeiros 16 Mar '17

16 Mar '17

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- docs/fedora-deps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md index 29b477f..484f409 100644 --- a/docs/fedora-deps.md +++ b/docs/fedora-deps.md @@ -42,7 +42,7 @@ Packages required for UI development Packages required for tests --------------------------- - $ sudo yum install pyflakes python-pep8 python-requests rpmlint + $ sudo yum install pyflakes python-pep8 python-requests rpmlint python-mock # For RHEL systems, install the additional packages: $ sudo yum install python-unittest2 -- 2.9.3

1 1

[PATCH] [Wok] Bug fix #207: Fix LDAPUser class initialization
by Aline Manera 15 Mar '17

15 Mar '17

It was wrongly calling PAMUser instance on LDAPUser class initialization. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/wok/auth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wok/auth.py b/src/wok/auth.py index 976d729..0ad1893 100644 --- a/src/wok/auth.py +++ b/src/wok/auth.py @@ -192,7 +192,7 @@ class LDAPUser(User): auth_type = "ldap" def __init__(self, username): - super(PAMUser, self).__init__(username) + super(LDAPUser, self).__init__(username) @staticmethod def authenticate(username, password): -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix #1107: Only set cache=none to disks that support direct IO
by Aline Manera 13 Mar '17

13 Mar '17

ZFS volumes and GlusterFS does not support direct IO and setting cache=none will not allow the guest to start. So only set cache=none when direct IO is supported to avoid problems. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- xmlutils/disk.py | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/xmlutils/disk.py b/xmlutils/disk.py index 02d6811..97298c5 100644 --- a/xmlutils/disk.py +++ b/xmlutils/disk.py @@ -1,7 +1,7 @@ # # Project Kimchi # -# Copyright IBM Corp, 2015-2016 +# Copyright IBM Corp, 2015-2017 # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -17,6 +17,7 @@ # License along with this library; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +import errno import lxml.etree as ET import os import socket @@ -28,7 +29,7 @@ from lxml.builder import E from wok.exception import InvalidParameter, NotFoundError from wok.plugins.kimchi.utils import check_url_path - +from wok.utils import wok_log BUS_TO_DEV_MAP = {'ide': 'hd', 'virtio': 'vd', 'scsi': 'sd'} DEV_TYPE_SRC_ATTR_MAP = {'file': 'file', 'block': 'dev'} @@ -51,11 +52,22 @@ def get_disk_xml(params): disk_type = _get_disk_type(path) if len(path) > 0 else 'file' disk = E.disk(type=disk_type, device=params['type']) driver = E.driver(name='qemu', type=params['format']) - if params['type'] != 'cdrom': - driver.set('cache', 'none') + try: + fd = os.open(path, os.O_RDONLY | os.O_DIRECT) + os.close(fd) + wok_log.debug("Disk '%s' supports direct I/O. Setting cache=none" + "to enable live migration" % path) + except OSError, e: + if e.errno == errno.EINVAL: + wok_log.debug("Disk '%s' does not support direct I/O: " + "'%s'. Let libvirt sets the default cache mode." % + (path, e.message)) + else: + if params['type'] != 'cdrom': + driver.set('cache', 'none') - if params.get('pool_type') == "netfs": - driver.set("io", "native") + if params.get('pool_type') == "netfs": + driver.set("io", "native") disk.append(driver) -- 2.9.3

2 2

[PATCH] [Kimchi 0/2] Run wok tests without administration permissions
by Lucio Correia 13 Mar '17

13 Mar '17

Lucio Correia (2): Fix tests to run without proxy Remove test for HTTP error 413 tests/test_model_storagevolume.py | 24 ++---------------------- tests/test_rest.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 30 deletions(-) -- 2.7.4

3 6

[PATCH v3] [Kimchi] Remove websocket initialization from Kimchi
by dhbarboza82＠gmail.com 13 Mar '17

13 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v3: - changed tearDown() to tearDownModule() in test_mockmodel.py v2: - removed websockify references from docs and build files. *** ATTENTION: REQUIRES '[WoK] Asynchronous UI notification implementation' PATCH *** Daniel Henrique Barboza (1): Use Websocket facilities from WoK contrib/DEBIAN/control.in | 1 - contrib/kimchi.spec.fedora.in | 1 - contrib/kimchi.spec.suse.in | 1 - docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 3 +- docs/ubuntu-deps.md | 2 +- model/vms.py | 2 +- root.py | 4 +- tests/test_mockmodel.py | 2 +- websocket.py | 121 ------------------------------------------ 10 files changed, 6 insertions(+), 133 deletions(-) delete mode 100644 websocket.py -- 2.9.3

2 3

[PATCH] [Kimchi 0/8] Run test_model with regular user
by Lucio Correia 10 Mar '17

10 Mar '17

Lucio Correia (8): Do not hardcode default directories Always use /var/tmp to store test files Mock default storage pools and networks for testing Use "qemu:///session" as test_model libvirt uri Remove 'run as root' requirement from some tests Skip tests that need to run as root Make test_use_test_host architecture independent Mock user probe functions model/storagepools.py | 5 +- osinfo.py | 12 +- tests/test_model.py | 407 +++++++++++++++++++++++++++++++++++++------------- 3 files changed, 321 insertions(+), 103 deletions(-) -- 2.7.4

1 8

[PATCH v4] [WoK] Asynchronous UI notification implementation
by dhbarboza82＠gmail.com 10 Mar '17

10 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v4: - server_loop with the socket listen was daemonized v3: - changed listener registration to be message specific instead of generic. v2: - Simplified UI code. Using now an array instead of a hashmap to prevent the need of inserting a listener identifier; - Changed the push server initialization. Moved it to server.py to avoid execution in the unit tests, but allow execution in the test mode. Do the same treatment with the ws_proxy initialization; - Socket file was moved to /run/user/<user_id>/woknotifications - Inserted notifications in base model level. Put code in base WoK classes to allow notifications for every model event without the need of adding it manually; - Standardization of messages sent. Messages are being sent in the pattern METHOD:plugin/entity/action; - Minor code fixes (imports, remove kimchi references); - Added websockify as a WoK runtime dependency. See patch commit message for more information. Daniel Henrique Barboza (1): Asynchronous UI notification implementation contrib/DEBIAN/control.in | 1 + contrib/wok.spec.fedora.in | 1 + contrib/wok.spec.suse.in | 1 + docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 3 +- docs/ubuntu-deps.md | 3 +- src/wok/config.py.in | 8 ++ src/wok/control/base.py | 16 ++-- src/wok/model/notifications.py | 2 +- src/wok/pushserver.py | 164 +++++++++++++++++++++++++++++++++++++++++ src/wok/reqlogger.py | 11 ++- src/wok/root.py | 3 + src/wok/server.py | 13 +++- src/wok/websocket.py | 123 +++++++++++++++++++++++++++++++ ui/js/src/wok.main.js | 54 ++++++++++++++ ui/js/wok.user-log.js | 4 + 16 files changed, 395 insertions(+), 14 deletions(-) create mode 100644 src/wok/pushserver.py create mode 100644 src/wok/websocket.py -- 2.9.3

2 2

[PATCH] [Kimchi] Use Websocket facilities from WoK
by dhbarboza82＠gmail.com 10 Mar '17

10 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> *** ATTENTION: REQUIRES '[WoK] Asynchronous UI notification implementation' PATCH *** Daniel Henrique Barboza (1): Use Websocket facilities from WoK model/vms.py | 2 +- root.py | 4 +- websocket.py | 121 ----------------------------------------------------------- 3 files changed, 2 insertions(+), 125 deletions(-) delete mode 100644 websocket.py -- 2.9.3

4 4