- Kimchi-devel - oVirt List Archives

[PATCH][Kimchi] Issue #933: Invalid image path not marking template as "invalid" (back-end)
by Ramon Medeiros 18 Aug '16

18 Aug '16

Template was not checking if image-based templates are still valid. Now, if image is missing, an warning will be displayed at UI Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- vmtemplate.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/vmtemplate.py b/vmtemplate.py index 79730cf..7ac0541 100644 --- a/vmtemplate.py +++ b/vmtemplate.py @@ -492,13 +492,19 @@ class VMTemplate(object): if invalid_networks: invalid['networks'] = invalid_networks - # validate storagepools integrity + # validate storagepools and image-based templates integrity for disk in self.info['disks']: pool_uri = disk['pool']['name'] pool_name = pool_name_from_uri(pool_uri) if pool_name not in self._get_active_storagepools_name(): invalid['storagepools'] = [pool_name] + if disk.get("base") is None: + continue + + if os.path.exists(disk.get("base")) is False: + invalid['vm-image'] = disk["base"] + # validate iso integrity # FIXME when we support multiples cdrom devices iso = self.info.get('cdrom') -- 2.5.5

2 1

[PATCH][Kimchi 0/2] Do not delete pool and network in use by templates or guests
by Ramon Medeiros 18 Aug '16

18 Aug '16

Ramon Medeiros (2): Do not remove storagepools linked to guests Update tests i18n.py | 1 + model/storagepools.py | 21 +++++++++++++++++++++ tests/test_rest.py | 4 +++- 3 files changed, 25 insertions(+), 1 deletion(-) -- 2.5.5

2 3

[PATCH][Kimchi] Fix test_model pep8 non-compliant syntax
by Ramon Medeiros 18 Aug '16

18 Aug '16

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- tests/test_model.py | 29 ++++++++++------------------- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/tests/test_model.py b/tests/test_model.py index 27225f8..09821b1 100644 --- a/tests/test_model.py +++ b/tests/test_model.py @@ -466,12 +466,9 @@ class ModelTests(unittest.TestCase): self.assertEqual(fw_manager.opened_ports, {}) mock_run_cmd.assert_has_calls( - [ - call(['firewall-cmd', '--state', '-q']), - call(['firewall-cmd', '--add-port=5905/tcp']), - call(['firewall-cmd', '--remove-port=5905/tcp']) - ] - ) + [call(['firewall-cmd', '--state', '-q']), + call(['firewall-cmd', '--add-port=5905/tcp']), + call(['firewall-cmd', '--remove-port=5905/tcp'])]) @mock.patch('wok.plugins.kimchi.model.virtviewerfile.run_command') def test_firewall_provider_ufw(self, mock_run_cmd): @@ -487,13 +484,10 @@ class ModelTests(unittest.TestCase): self.assertEqual(fw_manager.opened_ports, {}) mock_run_cmd.assert_has_calls( - [ - call(['firewall-cmd', '--state', '-q']), - call(['ufw', 'status']), - call(['ufw', 'allow', '5905/tcp']), - call(['ufw', 'deny', '5905/tcp']) - ] - ) + [call(['firewall-cmd', '--state', '-q']), + call(['ufw', 'status']), + call(['ufw', 'allow', '5905/tcp']), + call(['ufw', 'deny', '5905/tcp'])]) @mock.patch('wok.plugins.kimchi.model.virtviewerfile.run_command') def test_firewall_provider_iptables(self, mock_run_cmd): @@ -515,12 +509,9 @@ class ModelTests(unittest.TestCase): 5905, '-j', 'ACCEPT'] mock_run_cmd.assert_has_calls( - [ - call(['firewall-cmd', '--state', '-q']), - call(['ufw', 'status']), - call(iptables_add), call(iptables_del) - ] - ) + [call(['firewall-cmd', '--state', '-q']), + call(['ufw', 'status']), + call(iptables_add), call(iptables_del)]) @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') @mock.patch('wok.plugins.kimchi.model.virtviewerfile.' -- 2.5.5

2 8

[RFC] Invalid image path not marking template as "invalid" (kimchi-project/kimchi: Issue #933)
by Ramon Medeiros 18 Aug '16

18 Aug '16

vmtemplate.py has a function that checks template integrity (validate_integrity), that check template and if found some parameters invalid, warn the user. Today, the function is not verifying disks. I'll do it. Just want to make sure i'm checking all kind: Here is the function: def validate_integrity(self): invalid = {} # validate networks integrity invalid_networks = list(set(self.info['networks']) - set(self._get_all_networks_name())) if invalid_networks: invalid['networks'] = invalid_networks # validate storagepools and integrity for disk in self.info['disks']: pool_uri = disk['pool']['name'] pool_name = pool_name_from_uri(pool_uri) if pool_name not in self._get_active_storagepools_name(): invalid['storagepools'] = [pool_name] if os.path.exists(disk["base"]) # validate iso integrity # FIXME when we support multiples cdrom devices iso = self.info.get('cdrom') if iso: if os.path.exists(iso): st_mode = os.stat(iso).st_mode if not (stat.S_ISREG(st_mode) or stat.S_ISBLK(st_mode)): invalid['cdrom'] = [iso] elif not check_url_path(iso): invalid['cdrom'] = [iso] self.info['invalid'] = invalid return self.info I just need to get the loop "# validate storagepools and integrity" and add a checking: # validate storagepools and integrity for disk in self.info['disks']: pool_uri = disk['pool']['name'] pool_name = pool_name_from_uri(pool_uri) if pool_name not in self._get_active_storagepools_name(): invalid['storagepools'] = [pool_name] + + if not os.path.exists(disk.get("base")): + invalid["disks"] = disk + I guess this way i can validate disks on dir storagepools, and nfs. But, what about netboot and other kind? -- Ramon Nunes Medeiros Kimchi Developer Linux Technology Center Brazil IBM Systems & Technology Group Phone : +55 19 2132 7878 ramonn(a)br.ibm.com

3 2

[RFC] Feature Request (#860) - Support Guest Autostart
by Bianca Carvalho 18 Aug '16

18 Aug '16

Hello, I'm working to implement Support Guest Autostart feature described here: https://github.com/kimchi-project/kimchi/issues/860. Autostart option will be passed in the curl command, for example: curl -u root -H "Content-Type: application/json" -H "Accept: application/json" -k http://localhost:8010/plugins/kimchi/vms/<VM> -X PUT -d '{"autostart": True}' To show if the autostart is on or off: curl -u root -H "Content-Type: application/json" -H "Accept: application/json" -k http://localhost:8010/plugins/kimchi/vms/<VM> -X GET To implement this feature, I was thinking about use dom.setAutostart(1) in update function (vms.py), edit lookup to get params passed in the curl command (using PUT) and include an 'autostart' entry in API.json . Any other suggestion will be welcome. Thanks, Bianca Carvalho

3 2

[PATCH] [Wok] Status Label on user log #145
by peterpnns＠gmail.com 18 Aug '16

18 Aug '16

From: peterpennings <peterpnns(a)gmail.com> This patch adds a label message to show the HTTP status code on user log. peterpennings: Status label on user log #145 ui/js/wok.user-log.js | 37 ++++- ui/pages/i18n.json.tmpl | 1 + 2 files changed, 320 insertions(+), 24 deletions(-) -- 2.5.0

4 4

[PATCH v3][Kimchi 0/3] Issue #857: Support VM description
by Ramon Medeiros 17 Aug '16

17 Aug '16

Changes: v3: Fix pep8 issues v2: Create xml tag when updating a xml that does not have the tag Update messages to use Virtual machine instead of VM Ramon Medeiros (3): Issue #857: Support VM description Update tests Update docs API.json | 20 ++++++++++++++++++++ docs/API.md | 6 ++++++ i18n.py | 2 ++ model/vms.py | 34 +++++++++++++++++++++++++++++++--- tests/test_mockmodel.py | 3 ++- tests/test_model.py | 3 ++- vmtemplate.py | 5 ++++- 7 files changed, 67 insertions(+), 6 deletions(-) -- 2.5.5

2 4

[PATCH v2][Kimchi 0/3] Issue #857: Support VM description
by Ramon Medeiros 17 Aug '16

17 Aug '16

Changes: Create xml tag when updating a xml that does not have the tag Update messages to use Virtual machine instead of VM Ramon Medeiros (3): Issue #857: Support VM description Update tests Update docs API.json | 20 ++++++++++++++++++++ docs/API.md | 6 ++++++ i18n.py | 2 ++ model/vms.py | 35 ++++++++++++++++++++++++++++++++--- tests/test_mockmodel.py | 3 ++- tests/test_model.py | 3 ++- vmtemplate.py | 5 ++++- 7 files changed, 68 insertions(+), 6 deletions(-) -- 2.5.5

2 4

[PATCH][Kimchi 0/3] Issue #857: Support VM description
by Ramon Medeiros 16 Aug '16

16 Aug '16

3 7

[PATCH] [Kimchi] Issue# 317 Inconsistent button status when adding or creating new resources
by Socorro Stoppler 16 Aug '16

16 Aug '16

From: Socorro <socorro(a)linux.vnet.ibm.com> - Addressed last comment by pvital in github issue in that only the Network tab now has this problem in that the 'Create' button is enabled after clicking on Add a Newtwork. It should be disabled by default until the minimum of the required fields are filled. In the Network case, network name field (as long as valid) will enable the Create button as soon as at least one character is typed in. Signed-off-by: Socorro <socorro(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.network_add_main.js | 6 +++--- ui/pages/network-add.html.tmpl | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/js/src/kimchi.network_add_main.js b/ui/js/src/kimchi.network_add_main.js index fd45f34..e1fdf13 100644 --- a/ui/js/src/kimchi.network_add_main.js +++ b/ui/js/src/kimchi.network_add_main.js @@ -153,9 +153,9 @@ kimchi.changeNetworkDestination = function() { kimchi.updateNetworkFormButton = function() { if($("#networkName").hasClass("invalid-field")){ - $("#networkFormOk").button("disable"); - }else{ - $("#networkFormOk").button("enable"); + $("#networkFormOk").attr('disabled', true); + } else{ + $("#networkFormOk").attr('disabled', false); } }; diff --git a/ui/pages/network-add.html.tmpl b/ui/pages/network-add.html.tmpl index fbbea3d..14373ff 100644 --- a/ui/pages/network-add.html.tmpl +++ b/ui/pages/network-add.html.tmpl @@ -66,7 +66,7 @@ </div> </div> <div class="modal-footer"> - <button type="submit" id="networkFormOk" class="btn btn-default">$_("Create")</button> + <button type="submit" id="networkFormOk" class="btn btn-default" disabled="disabled">$_("Create")</button> <button type="button" id="networkFormCancel" data-dismiss="modal" class="btn btn-default">$_("Cancel")</button> </div> </div> -- 2.7.4

3 2