- Kimchi-devel - oVirt List Archives

[PATCH v2][Kimchi 0/2] Makes Kimchi better use /etc
by Rodrigo Trujillo 18 Mar '16

18 Mar '16

v2: - Apply review changes v1: - Kimchi package version was not looking at /etc/kimchi - Moves template.conf to /etc Rodrigo Trujillo (2): Fix issue #840: Change distros.d internal path Move 'template.conf' to /etc Makefile.am | 7 +++++-- config.py.in | 5 ++++- contrib/kimchi.spec.fedora.in | 1 - contrib/kimchi.spec.suse.in | 1 - model/config.py | 4 ++++ model/networks.py | 4 ++-- model/storagepools.py | 5 ++--- osinfo.py | 3 ++- tests/test_model.py | 8 ++++---- 9 files changed, 23 insertions(+), 15 deletions(-) -- 2.1.0

2 3

[PATCH][Kimchi 0/2] Makes Kimchi better use /etc
by Rodrigo Trujillo 18 Mar '16

18 Mar '16

- Kimchi package version was not looking at /etc/kimchi - Moves template.conf to /etc Rodrigo Trujillo (2): Fix issue #840: Change distros.d internal path Move 'template.conf' to /etc Makefile.am | 7 +++++-- config.py.in | 7 ++++++- contrib/kimchi.spec.fedora.in | 1 - contrib/kimchi.spec.suse.in | 1 - model/config.py | 4 ++++ model/networks.py | 4 ++-- model/storagepools.py | 5 ++--- osinfo.py | 3 ++- tests/test_model.py | 8 ++++---- 9 files changed, 25 insertions(+), 15 deletions(-) -- 2.1.0

2 5

[PATCH] [Kimchi] Issue #788: Network information mismatch in template creation
by sguimaraes943＠gmail.com 18 Mar '16

18 Mar '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> Samuel Guimarães (1): Issue #788: Network information mismatch in template creation ui/js/src/kimchi.network.js | 6 +++--- ui/js/src/kimchi.template_edit_main.js | 8 +++++--- 2 files changed, 8 insertions(+), 6 deletions(-) -- 1.9.3

2 2

[PATCH] [Kimchi] Issue #809: PCI filter does not seem to work
by sguimaraes943＠gmail.com 17 Mar '16

17 Mar '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch fixes issue #809 "PCI filter does not seem to work". This fix requires "Added jquery.containsNC to enable case insensitive pseudo-selector in JS" applied since it uses this snippet to allow case insensitive filter. Samuel Guimarães (1): Issue #809: PCI filter does not seem to work ui/js/src/kimchi.guest_edit_main.js | 49 ++++++++++++++++++++----------------- ui/pages/guest-edit.html.tmpl | 8 +++--- 2 files changed, 31 insertions(+), 26 deletions(-) -- 1.9.3

3 3

[PATCH] [Kimchi] Issue #818: Frontend doesn't update the PCI tab after a PCI attachment
by sguimaraes943＠gmail.com 17 Mar '16

17 Mar '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> Tested with real environment. The "Save" button is disabled by default when switching to a tab that has inline editing feature, so this patch doesn't cover issue #847 yet. Samuel Guimarães (1): Issue #818: Frontend doesn't update the PCI tab after a PCI attachment ui/js/src/kimchi.guest_edit_main.js | 40 ++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 18 deletions(-) -- 1.9.3

3 3

[PATCH] [Kimchi] Fix problem when removing window size fo GPU
by Jose Ricardo Ziviani 17 Mar '16

17 Mar '16

- This patch fixes errors when removing the window size command from libvirt qemu:commandline xml. Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- model/vmhostdevs.py | 32 ++++++++++---------------------- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/model/vmhostdevs.py b/model/vmhostdevs.py index 2a62249..5f33d10 100644 --- a/model/vmhostdevs.py +++ b/model/vmhostdevs.py @@ -290,7 +290,8 @@ class VMHostDevsModel(object): new_xml = self._add_win_memory_size(dom, size) # update the XML - self.conn.get().defineXML(new_xml) + if new_xml is not None: + self.conn.get().defineXML(new_xml) def _update_win_memory_size(self, dom, counter, wnd_size): root = objectify.fromstring(dom.XMLDesc(0)) @@ -304,12 +305,11 @@ class VMHostDevsModel(object): if not arg.values()[0].startswith(CMDLINE_FIELD_NAME): continue - # update mem_win_size value if counter > 1: arg.set('value', CMDLINE_FIELD_NAME + '=' + wnd_size) - # remove mem_win_size - elif counter <= 1: + else: + line.remove(arg.getprevious()) line.remove(arg) return etree.tostring(root, encoding='utf-8', @@ -330,25 +330,12 @@ class VMHostDevsModel(object): root.append(etree.fromstring(get_qemucmdline_xml(args))) return etree.tostring(root, encoding='utf-8', pretty_print=True) - # <qemu:commandline> exists and already has the tag - # <qemu:arg value='-global'> (user could already been using this for - # something else), so we just add our <qemu:arg...> missing. - found = False - for arg in cmdline.iterchildren(): - if arg.values()[0] == '-global': - EM = ElementMaker(namespace=QEMU_NAMESPACE, - nsmap={'qemu': QEMU_NAMESPACE}) - cmdline.append(EM.arg(value=val)) - found = True - break - # <qemu:commandline> exists but there is no <qemu:arg value global> # so, we add those missing arguments inside the exising cmdline - if not found: - EM = ElementMaker(namespace=QEMU_NAMESPACE, - nsmap={'qemu': QEMU_NAMESPACE}) - cmdline.append(EM.arg(value='-global')) - cmdline.append(EM.arg(value=val)) + EM = ElementMaker(namespace=QEMU_NAMESPACE, + nsmap={'qemu': QEMU_NAMESPACE}) + cmdline.append(EM.arg(value='-global')) + cmdline.append(EM.arg(value=val)) return etree.tostring(root, encoding='utf-8', pretty_print=True) @@ -443,7 +430,8 @@ class VMHostDevModel(object): if e.attrib['type'] == 'pci': self._delete_affected_pci_devices(dom, dev_name, pci_devs) if is_3D_device: - self.update_mmio_guest(vmid, False) + devsmodel = VMHostDevsModel(conn=self.conn) + devsmodel.update_mmio_guest(vmid, False) break else: raise NotFoundError('KCHVMHDEV0001E', -- 1.9.1

2 1

probleme for kimchi
by Nicolas Naud 17 Mar '16

17 Mar '16

Hi, I'm problem after install kimchi on debian: "KCHVM0019E: Impossible de démarrer la machine virtuelle test. Détails : unsupported configuration: Memory cgroup is not available on this host" Thanks you -- Nicolas Naud Technicien informatique SFA - Administration générale - Service Informatique Général TSA 51106 9, Rue C C Chenou Bât B5 86073 POITIERS POITIERS CEDEX 9 Tél : +33 5 49 45 38 16 Port : 06.19.13.20.59 Courriel : nicolas.naud(a)univ-poitiers.fr

2 1

[PATCH] [Kimchi] Issue 814: UI just show exported NFS path when clicked twice at field
by sguimaraes943＠gmail.com 17 Mar '16

17 Mar '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> I wasn't able to reproduce the issue with a nfs path pointing to localhost but I did tested with two NFS paths in a NFS server and found that wok.combobox() and wok.selectFilter() dropdowns were showing an empty list. If the list is empty their objects are destroyed but the validation still occurs when the user types a valid ip address and a nfs path. Samuel Guimarães (1): Issue 814: UI just show exported NFS path when clicked twice at field ui/js/src/kimchi.storagepool_add_main.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) -- 1.9.3

3 3

[PATCH v2] [Kimchi 0/4] Fix issues on web serial console
by Jose Ricardo Ziviani 17 Mar '16

17 Mar '16

v2: - applied code review This patchset contains some issues found in the web serial console code as well as some small improvements. Jose Ricardo Ziviani (4): Move unix socket files from /tmp to /run Improve log messages printed by the serial console Make serial console timeout configurable Check if guest is listening to serial before connecting to it i18n.py | 2 + kimchi.conf | 3 ++ model/vms.py | 26 ++++++++-- serialconsole.py | 117 +++++++++++++++++++++++++++++++-------------- tests/test_model.py | 4 +- ui/serial/html/serial.html | 4 -- 6 files changed, 109 insertions(+), 47 deletions(-) -- 1.9.1

4 8

[PATCH] [Kimchi] Issue #847: Save button is having wrong behavior when edit a running Guest
by sguimaraes943＠gmail.com 16 Mar '16

16 Mar '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch addresses the Save Button in Edit Guests modal window when the user switches to different tabs and goes back to General tab if a VM is running. Samuel Guimarães (1): Issue #847: Save button is having wrong behavior when edit a running Guest ui/js/src/kimchi.guest_edit_main.js | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 1.9.3

2 2