- Kimchi-devel - oVirt List Archives

[PATCH v3] [Kimchi 0/8] Network API change + VEPA network support
by dhbarboza82＠gmail.com 17 Feb '16

17 Feb '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> v3: - Lucio suggestions made: docs/API.md and 'bridge' connection in test_template.py v2: - changes on the existing network backend This patch set implements two major changes in the network backend and API of Kimchi: - first 4 patches: changed the API to allow networks to be created with more than one interface Changing 'interface' to 'interfaces' in the network backend to allow more than one interface to be added to a network. Existing networks that use only one interface were adapted to use interfaces[0] instead. UI changes were made to comply with this change. - last 4 patches: second version of the VEPA network patch set. VEPA networks are somewhat similar to macvtap networks that tunnels traffic between VMs by using an external VEPA-enabled switch that will process and forward the frames faster than the host CPU/OS can do. The UI support is similar to what we already have for the macvtap network. ATM the UI doesn't support multiple physical devices being assigned to a single VEPA network but the backend does. This can be enhanced in the future with an UI patch. The idea was to have some UI support to get the feature alive ASAP. To create a VEPA network the process is similar to the bridge network, allowing more interfaces to be declared in the new 'interfaces' parameter of the networks backend. This is the XML created when adding a VEPA network using one interface: <network> <name>vepa_net</name> <uuid>d6a3c86b-0592-4ccf-abf0-0abb353870b3</uuid> <forward dev='enp0s25' mode='vepa'> <interface dev='enp0s25'/> </forward> </network> This is how a VM can declare a interface that belongs to this network: <interface type='network'> <mac address='52:54:00:9c:be:bd'/> <source network='vepa_net'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> This is how the XML looks like when turning on the VM. Libvirt will take care of the creation of the VEPA tunnel by using the assigned physical interface in the network. If more interfaces were added to the network, libvirt will do a load balance between them and the VMs: <interface type='direct'> <mac address='52:54:00:9c:be:bd'/> <source network='vepa_net' dev='enp0s25' mode='vepa'/> <target dev='macvtap0'/> <model type='virtio'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Daniel Henrique Barboza (8): Changing network API 'interface' to array: docs and API Changing network API: control and model changes Changing network API: unit test changes Changing network API: UI changes VEPA network support: API and i18n changes VEPA network support - models and xmlutils changes VEPA network support: additional backend unit tests VEPA network support: UI changes API.json | 8 ++--- control/networks.py | 4 +-- docs/API.md | 14 +++++---- i18n.py | 7 +++-- model/networks.py | 61 +++++++++++++++++++++++------------- tests/test_mock_network.py | 11 ++----- tests/test_model_network.py | 13 +++++--- tests/test_networkxml.py | 44 +++++++++++++++++++++++++- tests/test_template.py | 12 ++++--- ui/js/src/kimchi.network.js | 5 +-- ui/js/src/kimchi.network_add_main.js | 12 +++---- ui/pages/network-add.html.tmpl | 5 +-- xmlutils/network.py | 10 +++++- 13 files changed, 139 insertions(+), 67 deletions(-) -- 2.5.0

3 11

[PATCH] [Kimchi] Bugfix 804: Disable connect vnc when VM is powered off
by Jose Ricardo Ziviani 17 Feb '16

17 Feb '16

- When a VM is powered off, the option to connect to its vnc should not be displayed under the actions menu otherwise users will get errors. Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.guest_main.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.guest_main.js b/ui/js/src/kimchi.guest_main.js index bfd62a8..83ee3f0 100644 --- a/ui/js/src/kimchi.guest_main.js +++ b/ui/js/src/kimchi.guest_main.js @@ -652,7 +652,8 @@ kimchi.createGuestLi = function(vmObject, prevScreenImage, openMenu) { var consoleActions = guestActions.find("[name=vm-console]"); var consoleLinkActions = result.find(".vnc-link"); - if ((vmObject.graphics['type'] == 'vnc') || (vmObject.graphics['type'] == 'spice')) { + if (((vmObject.graphics['type'] == 'vnc') || (vmObject.graphics['type'] == 'spice')) + && (!vmPoweredOffBool)) { consoleActions.on("click", function(event) { event.preventDefault(); kimchi.openVmConsole(event); -- 1.9.1

3 2

[PATCH] [Kimchi] Bugfix 843: Add sourceURL comment for kimchi.min.js
by Jose Ricardo Ziviani 17 Feb '16

17 Feb '16

- browser javascript debuggers cannot inspect dynamic loaded javascript because such scripts have no name (they are created with eval). The comment //# sourceURL=name is a way to solve it. - https://developer.chrome.com/devtools/docs/javascript-debugging Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- ui/js/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/ui/js/Makefile.am b/ui/js/Makefile.am index c9d1218..c24feeb 100644 --- a/ui/js/Makefile.am +++ b/ui/js/Makefile.am @@ -23,5 +23,6 @@ dist_js_DATA = kimchi.min.js $(filter-out kimchi.min.js, $(wildcard *.js)) kimchi.min.js: src/*.js cat $(sort $^) > $@ + echo "//# sourceURL=kimchi.min.js" >> $@ CLEANFILES = kimchi.min.js -- 1.9.1

3 2

[PATCH] [Wok] Allow user disables HTTP port
by Aline Manera 17 Feb '16

17 Feb '16

This patch adds a new option to wok.conf file - https_only - to allow user disable HTTP port. The default value for https_only option is false, which means HTTP and HTTPS are allowed. When set to true, all the connections will be done through HTTPS. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/nginx/wok.conf.in | 7 +------ src/wok.conf.in | 6 +++++- src/wok/config.py.in | 1 + src/wok/proxy.py | 16 +++++++++++++++- src/wokd.in | 4 ++++ tests/utils.py | 10 +++++----- 6 files changed, 31 insertions(+), 13 deletions(-) diff --git a/src/nginx/wok.conf.in b/src/nginx/wok.conf.in index 501377e..8dd5d7c 100644 --- a/src/nginx/wok.conf.in +++ b/src/nginx/wok.conf.in @@ -32,7 +32,6 @@ events { } http { - log_format main '$remote_addr - $remote_user [$time_local] "$request" ' '$status $body_bytes_sent "$http_referer" ' '"$http_user_agent" "$http_x_forwarded_for"'; @@ -88,9 +87,5 @@ http { proxy_set_header Connection $connection_upgrade; } } - - server { - listen ${host_addr}:${proxy_port}; - rewrite ^/(.*)$ https://$host:${proxy_ssl_port}/$1 redirect; - } + ${http_config} } diff --git a/src/wok.conf.in b/src/wok.conf.in index 7d479d3..77a79b6 100644 --- a/src/wok.conf.in +++ b/src/wok.conf.in @@ -9,9 +9,13 @@ # Port to listen on #port = 8000 -# If present, start an SSL-enabled server on the given port +# Start an SSL-enabled server on the given port #ssl_port = 8001 +# Allow user disables HTTP port. In that case, all the connections +# will be done directly through HTTPS port (values: true|false) +#https_only = false + # Cherrypy server port #cherrypy_port = 8010 diff --git a/src/wok/config.py.in b/src/wok/config.py.in index 5d32ba4..40fbcda 100644 --- a/src/wok/config.py.in +++ b/src/wok/config.py.in @@ -232,6 +232,7 @@ def _get_config(): config.set("server", "host", "0.0.0.0") config.set("server", "port", "8000") config.set("server", "ssl_port", "8001") + config.set("server", "https_only", "false") config.set("server", "cherrypy_port", "8010") config.set("server", "websockets_port", "64667") config.set("server", "ssl_cert", "") diff --git a/src/wok/proxy.py b/src/wok/proxy.py index c7bc665..9d39dbd 100644 --- a/src/wok/proxy.py +++ b/src/wok/proxy.py @@ -33,6 +33,14 @@ from wok import sslcert from wok.config import paths +HTTP_CONFIG = """ +server { + listen %(host_addr)s:%(proxy_port)s; + rewrite ^/(.*)$ https://$host:%(proxy_ssl_port)s/$1 redirect; +} +""" + + def _create_proxy_config(options): """Create nginx configuration file based on current ports config @@ -75,6 +83,12 @@ def _create_proxy_config(options): # Setting up Diffie-Hellman group with 2048-bit file dhparams_pem = os.path.join(config_dir, "dhparams.pem") + http_config = '' + if options.https_only == 'false': + http_config = HTTP_CONFIG % {'host_addr': options.host, + 'proxy_port': options.port, + 'proxy_ssl_port': options.ssl_port} + # Read template file and create a new config file # with the specified parameters. with open(os.path.join(nginx_config_dir, "wok.conf.in")) as template: @@ -82,8 +96,8 @@ def _create_proxy_config(options): data = Template(data) data = data.safe_substitute(user=user_proxy, host_addr=options.host, - proxy_port=options.port, proxy_ssl_port=options.ssl_port, + http_config=http_config, cherrypy_port=options.cherrypy_port, websockets_port=options.websockets_port, cert_pem=cert, cert_key=key, diff --git a/src/wokd.in b/src/wokd.in index 59a81f8..7255d3c 100644 --- a/src/wokd.in +++ b/src/wokd.in @@ -46,6 +46,7 @@ def main(options): host = config.config.get("server", "host") port = config.config.get("server", "port") ssl_port = config.config.get("server", "ssl_port") + https_only = config.config.get("server", "https_only") cherrypy_port = config.config.get("server", "cherrypy_port") websockets_port = config.config.get("server", "websockets_port") runningEnv = config.config.get("server", "environment") @@ -59,6 +60,9 @@ def main(options): help="Port to listen on (default %s)" % port) parser.add_option('--ssl-port', type="int", default=ssl_port, help="Port to enable SSL (default %s)" % ssl_port) + parser.add_option('--https_only', type="choice", default=https_only, + choices=['false', 'true'], + help="Disable HTTP port (default %s)" % ssl_port) parser.add_option('--cherrypy_port', type="int", default=cherrypy_port, help="Cherrypy server port (default %s)" % cherrypy_port) parser.add_option('--websockets_port', type="int", default=websockets_port, diff --git a/tests/utils.py b/tests/utils.py index bb9efb0..d158ba1 100644 --- a/tests/utils.py +++ b/tests/utils.py @@ -115,11 +115,11 @@ def run_server(host, port, ssl_port, test_mode, cherrypy_port=None, args = type('_', (object,), {'host': host, 'port': port, 'ssl_port': ssl_port, - 'cherrypy_port': cherrypy_port, 'max_body_size': '4*1024', - 'websockets_port': 64667, 'ssl_cert': '', - 'ssl_key': '', 'test': test_mode, 'access_log': '/dev/null', - 'error_log': '/dev/null', 'environment': environment, - 'log_level': 'debug'})() + 'https_only': 'false', 'cherrypy_port': cherrypy_port, + 'websockets_port': 64667, 'ssl_cert': '', 'ssl_key': '', + 'max_body_size': '4*1024', 'test': test_mode, + 'access_log': '/dev/null', 'error_log': '/dev/null', + 'environment': environment, 'log_level': 'debug'})() if model is not None: setattr(args, 'model', model) -- 2.5.0

2 2

[PATCH] [Wok] Fixed radio and checkbox focus event v3
by sguimaraes943＠gmail.com 17 Feb '16

17 Feb '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch fixes focus event and keyboard navigation with radio and checkboxes input fields. v2 - Fixes checkbox pointer cursor v3 - Fixes focus ring color when checkbox is active samhenri (1): Fixed radio and checkbox focus event ui/css/src/modules/_wok-forms.scss | 11 ++++++-- ui/css/wok.css | 57 ++++++++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 14 deletions(-) -- 1.9.3

2 2

[PATCH] [Wok] Fix pep8 E126 (continuation line) issues
by Jose Ricardo Ziviani 17 Feb '16

17 Feb '16

Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- tests/test_config.py.in | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/test_config.py.in b/tests/test_config.py.in index 28c7a57..23eeca2 100644 --- a/tests/test_config.py.in +++ b/tests/test_config.py.in @@ -136,77 +136,77 @@ class ConfigTests(unittest.TestCase): 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/fontawesome-webfont.ttf' % paths.fontawesome_dir + '%s/fontawesome-webfont.ttf' % paths.fontawesome_dir }, '/fonts/OpenSans-LightItalic.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-LightItalic.ttf' % paths.opensans_dir + '%s/OpenSans-LightItalic.ttf' % paths.opensans_dir }, '/fonts/OpenSans-Bold.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-Bold.ttf' % paths.opensans_dir + '%s/OpenSans-Bold.ttf' % paths.opensans_dir }, '/fonts/OpenSans-Italic.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-Italic.ttf' % paths.opensans_dir + '%s/OpenSans-Italic.ttf' % paths.opensans_dir }, '/fonts/OpenSans-Semibold.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-Semibold.ttf' % paths.opensans_dir + '%s/OpenSans-Semibold.ttf' % paths.opensans_dir }, '/fonts/OpenSans-Light.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-Light.ttf' % paths.opensans_dir + '%s/OpenSans-Light.ttf' % paths.opensans_dir }, '/fonts/OpenSans-SemiboldItalic.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-SemiboldItalic.ttf' % paths.opensans_dir + '%s/OpenSans-SemiboldItalic.ttf' % paths.opensans_dir }, '/fonts/OpenSans-ExtraBold.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-ExtraBold.ttf' % paths.opensans_dir + '%s/OpenSans-ExtraBold.ttf' % paths.opensans_dir }, '/fonts/OpenSans-BoldItalic.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-BoldItalic.ttf' % paths.opensans_dir + '%s/OpenSans-BoldItalic.ttf' % paths.opensans_dir }, '/fonts/OpenSans-ExtraBoldItalic.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-ExtraBoldItalic.ttf' % paths.opensans_dir + '%s/OpenSans-ExtraBoldItalic.ttf' % paths.opensans_dir }, '/fonts/OpenSans-Regular.ttf': { 'tools.wokauth.on': False, 'tools.nocache.on': False, 'tools.staticfile.on': True, 'tools.staticfile.filename': - '%s/OpenSans-Regular.ttf' % paths.opensans_dir + '%s/OpenSans-Regular.ttf' % paths.opensans_dir } } -- 1.9.1

3 2

[PATCH] [Wok] Bugfix 33: Implement a multiprocess file handler for log system
by Jose Ricardo Ziviani 17 Feb '16

17 Feb '16

- This commit adds a new watched file handler, used in Wok, but it uses a recursive lock before emitting the log register to avoid possible concurrency issues since multiple processes will write in the same log file. Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- *NOTE*: based on '[PATCH] [Wok] Bugfix 30: Duplicated log messages' src/wok/safewatchedfilehandler.py | 44 +++++++++++++++++++++++++++++++++++++++ src/wok/server.py | 4 ++-- 2 files changed, 46 insertions(+), 2 deletions(-) create mode 100644 src/wok/safewatchedfilehandler.py diff --git a/src/wok/safewatchedfilehandler.py b/src/wok/safewatchedfilehandler.py new file mode 100644 index 0000000..c5fad85 --- /dev/null +++ b/src/wok/safewatchedfilehandler.py @@ -0,0 +1,44 @@ +# +# Project Kimchi +# +# Copyright IBM, Corp. 2016 +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +from logging.handlers import WatchedFileHandler +from multiprocessing import RLock + + +class SafeWatchedFileHandler(WatchedFileHandler): + + def __init__(self, filename, mode='a', encoding=None, delay=0): + WatchedFileHandler.__init__(self, filename, mode, encoding, delay) + self._lock = RLock() + + def close(self): + self._lock.acquire(timeout=2) + try: + WatchedFileHandler.close(self) + + finally: + self._lock.release() + + def emit(self, record): + self._lock.acquire(timeout=2) + try: + WatchedFileHandler.emit(self, record) + + finally: + self._lock.release() diff --git a/src/wok/server.py b/src/wok/server.py index 13851e8..75b41d5 100644 --- a/src/wok/server.py +++ b/src/wok/server.py @@ -35,6 +35,7 @@ from wok.control import sub_nodes from wok.model import model from wok.proxy import start_proxy, terminate_proxy from wok.root import WokRoot +from wok.safewatchedfilehandler import SafeWatchedFileHandler from wok.utils import get_enabled_plugins, import_class LOGGING_LEVEL = {"debug": logging.DEBUG, @@ -122,8 +123,7 @@ class Server(object): cherrypy.log.access_log.addHandler(h) # Create handler to error log file - h = logging.handlers.WatchedFileHandler(options.error_log, 'a', - delay=1) + h = SafeWatchedFileHandler(options.error_log, 'a', delay=1) h.setLevel(logLevel) h.setFormatter(cherrypy._cplogging.logfmt) -- 1.9.1

3 2

[PATCH] [Wok] Bugfix 30: Duplicated log messages
by Jose Ricardo Ziviani 17 Feb '16

17 Feb '16

- today we have two file handlers pointing to the same file, this commit closes the standard file handler to use the watched file handler. Signed-off-by: Jose Ricardo Ziviani <joserz(a)linux.vnet.ibm.com> --- src/wok/server.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/wok/server.py b/src/wok/server.py index 80c1da2..13851e8 100644 --- a/src/wok/server.py +++ b/src/wok/server.py @@ -101,6 +101,17 @@ class Server(object): if dev_env: cherrypy.log.screen = True + # close standard file handlers because we are going to use a + # watchedfiled handler, otherwise we will have two file handlers + # pointing to the same file, duplicating log enries + for handler in cherrypy.log.access_log.handlers[:]: + if isinstance(handler, logging.FileHandler): + cherrypy.log.access_log.removeHandler(handler) + + for handler in cherrypy.log.error_log.handlers[:]: + if isinstance(handler, logging.FileHandler): + cherrypy.log.error_log.removeHandler(handler) + # Create handler to access log file h = logging.handlers.WatchedFileHandler(options.access_log, 'a', delay=1) -- 1.9.1

3 2

[PATCH v2] [Kimchi 0/8] Network API change + VEPA network support
by dhbarboza82＠gmail.com 16 Feb '16

16 Feb '16

From: Daniel Henrique Barboza <dhbarboza82(a)gmail.com> v2: - changes on the existing network backend This patch set implements two major changes in the network backend and API of Kimchi: - first 4 patches: changed the API to allow networks to be created with more than one interface Changing 'interface' to 'interfaces' in the network backend to allow more than one interface to be added to a network. Existing networks that use only one interface were adapted to use interfaces[0] instead. UI changes were made to comply with this change. - last 4 patches: second version of the VEPA network patch set. VEPA networks are somewhat similar to macvtap networks that tunnels traffic between VMs by using an external VEPA-enabled switch that will process and forward the frames faster than the host CPU/OS can do. The UI support is similar to what we already have for the macvtap network. ATM the UI doesn't support multiple physical devices being assigned to a single VEPA network but the backend does. This can be enhanced in the future with an UI patch. The idea was to have some UI support to get the feature alive ASAP. To create a VEPA network the process is similar to the bridge network, allowing more interfaces to be declared in the new 'interfaces' parameter of the networks backend. This is the XML created when adding a VEPA network using one interface: <network> <name>vepa_net</name> <uuid>d6a3c86b-0592-4ccf-abf0-0abb353870b3</uuid> <forward dev='enp0s25' mode='vepa'> <interface dev='enp0s25'/> </forward> </network> This is how a VM can declare a interface that belongs to this network: <interface type='network'> <mac address='52:54:00:9c:be:bd'/> <source network='vepa_net'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> This is how the XML looks like when turning on the VM. Libvirt will take care of the creation of the VEPA tunnel by using the assigned physical interface in the network. If more interfaces were added to the network, libvirt will do a load balance between them and the VMs: <interface type='direct'> <mac address='52:54:00:9c:be:bd'/> <source network='vepa_net' dev='enp0s25' mode='vepa'/> <target dev='macvtap0'/> <model type='virtio'/> <alias name='net0'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> Daniel Henrique Barboza (8): Changing network API 'interface' to array: docs and API Changing network API: control and model changes Changing network API: unit test changes Changing network API: UI changes VEPA network support: API and i18n changes VEPA network support - models and xmlutils changes VEPA network support: additional backend unit tests VEPA network support: UI changes API.json | 8 ++--- control/networks.py | 4 +-- docs/API.md | 15 +++++---- i18n.py | 7 +++-- model/networks.py | 61 +++++++++++++++++++++++------------- tests/test_mock_network.py | 11 ++----- tests/test_model_network.py | 13 +++++--- tests/test_networkxml.py | 44 +++++++++++++++++++++++++- tests/test_template.py | 12 ++++--- ui/js/src/kimchi.network.js | 5 +-- ui/js/src/kimchi.network_add_main.js | 12 +++---- ui/pages/network-add.html.tmpl | 5 +-- xmlutils/network.py | 10 +++++- 13 files changed, 140 insertions(+), 67 deletions(-) -- 2.5.0

3 14

[PATCH] [Wok] Fixed radio and checkbox focus event v2
by sguimaraes943＠gmail.com 16 Feb '16

16 Feb '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch fixes focus event and keyboard navigation with radio and checkboxes input fields. v2 - Fixes checkboxes Samuel Guimarães (1): Fixed radio and checkbox focus event ui/css/src/modules/_wok-forms.scss | 11 ++++++-- ui/css/wok.css | 57 ++++++++++++++++++++++++++++++-------- 2 files changed, 54 insertions(+), 14 deletions(-) -- 1.9.3

2 2