- Kimchi-devel - oVirt List Archives

[PATCH] Add m4/pkg.m4 to source code
by Aline Manera 18 Aug '15

18 Aug '15

Commit aaa60fae added PKG_CONFIG as dependency. So the autoconf need the m4/pkg.m4 file in order to properly do the build. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- m4/pkg.m4 | 214 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 214 insertions(+) create mode 100644 m4/pkg.m4 diff --git a/m4/pkg.m4 b/m4/pkg.m4 new file mode 100644 index 0000000..c5b26b5 --- /dev/null +++ b/m4/pkg.m4 @@ -0,0 +1,214 @@ +# pkg.m4 - Macros to locate and utilise pkg-config. -*- Autoconf -*- +# serial 1 (pkg-config-0.24) +# +# Copyright © 2004 Scott James Remnant <scott(a)netsplit.com>. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. +# +# As a special exception to the GNU General Public License, if you +# distribute this file as part of a program that contains a +# configuration script generated by Autoconf, you may include it under +# the same distribution terms that you use for the rest of that program. + +# PKG_PROG_PKG_CONFIG([MIN-VERSION]) +# ---------------------------------- +AC_DEFUN([PKG_PROG_PKG_CONFIG], +[m4_pattern_forbid([^_?PKG_[A-Z_]+$]) +m4_pattern_allow([^PKG_CONFIG(_(PATH|LIBDIR|SYSROOT_DIR|ALLOW_SYSTEM_(CFLAGS|LIBS)))?$]) +m4_pattern_allow([^PKG_CONFIG_(DISABLE_UNINSTALLED|TOP_BUILD_DIR|DEBUG_SPEW)$]) +AC_ARG_VAR([PKG_CONFIG], [path to pkg-config utility]) +AC_ARG_VAR([PKG_CONFIG_PATH], [directories to add to pkg-config's search path]) +AC_ARG_VAR([PKG_CONFIG_LIBDIR], [path overriding pkg-config's built-in search path]) + +if test "x$ac_cv_env_PKG_CONFIG_set" != "xset"; then + AC_PATH_TOOL([PKG_CONFIG], [pkg-config]) +fi +if test -n "$PKG_CONFIG"; then + _pkg_min_version=m4_default([$1], [0.9.0]) + AC_MSG_CHECKING([pkg-config is at least version $_pkg_min_version]) + if $PKG_CONFIG --atleast-pkgconfig-version $_pkg_min_version; then + AC_MSG_RESULT([yes]) + else + AC_MSG_RESULT([no]) + PKG_CONFIG="" + fi +fi[]dnl +])# PKG_PROG_PKG_CONFIG + +# PKG_CHECK_EXISTS(MODULES, [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND]) +# +# Check to see whether a particular set of modules exists. Similar +# to PKG_CHECK_MODULES(), but does not set variables or print errors. +# +# Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG]) +# only at the first occurence in configure.ac, so if the first place +# it's called might be skipped (such as if it is within an "if", you +# have to call PKG_CHECK_EXISTS manually +# -------------------------------------------------------------- +AC_DEFUN([PKG_CHECK_EXISTS], +[AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl +if test -n "$PKG_CONFIG" && \ + AC_RUN_LOG([$PKG_CONFIG --exists --print-errors "$1"]); then + m4_default([$2], [:]) +m4_ifvaln([$3], [else + $3])dnl +fi]) + +# _PKG_CONFIG([VARIABLE], [COMMAND], [MODULES]) +# --------------------------------------------- +m4_define([_PKG_CONFIG], +[if test -n "$$1"; then + pkg_cv_[]$1="$$1" + elif test -n "$PKG_CONFIG"; then + PKG_CHECK_EXISTS([$3], + [pkg_cv_[]$1=`$PKG_CONFIG --[]$2 "$3" 2>/dev/null` + test "x$?" != "x0" && pkg_failed=yes ], + [pkg_failed=yes]) + else + pkg_failed=untried +fi[]dnl +])# _PKG_CONFIG + +# _PKG_SHORT_ERRORS_SUPPORTED +# ----------------------------- +AC_DEFUN([_PKG_SHORT_ERRORS_SUPPORTED], +[AC_REQUIRE([PKG_PROG_PKG_CONFIG]) +if $PKG_CONFIG --atleast-pkgconfig-version 0.20; then + _pkg_short_errors_supported=yes +else + _pkg_short_errors_supported=no +fi[]dnl +])# _PKG_SHORT_ERRORS_SUPPORTED + + +# PKG_CHECK_MODULES(VARIABLE-PREFIX, MODULES, [ACTION-IF-FOUND], +# [ACTION-IF-NOT-FOUND]) +# +# +# Note that if there is a possibility the first call to +# PKG_CHECK_MODULES might not happen, you should be sure to include an +# explicit call to PKG_PROG_PKG_CONFIG in your configure.ac +# +# +# -------------------------------------------------------------- +AC_DEFUN([PKG_CHECK_MODULES], +[AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl +AC_ARG_VAR([$1][_CFLAGS], [C compiler flags for $1, overriding pkg-config])dnl +AC_ARG_VAR([$1][_LIBS], [linker flags for $1, overriding pkg-config])dnl + +pkg_failed=no +AC_MSG_CHECKING([for $1]) + +_PKG_CONFIG([$1][_CFLAGS], [cflags], [$2]) +_PKG_CONFIG([$1][_LIBS], [libs], [$2]) + +m4_define([_PKG_TEXT], [Alternatively, you may set the environment variables $1[]_CFLAGS +and $1[]_LIBS to avoid the need to call pkg-config. +See the pkg-config man page for more details.]) + +if test $pkg_failed = yes; then + AC_MSG_RESULT([no]) + _PKG_SHORT_ERRORS_SUPPORTED + if test $_pkg_short_errors_supported = yes; then + $1[]_PKG_ERRORS=`$PKG_CONFIG --short-errors --print-errors --cflags --libs "$2" 2>&1` + else + $1[]_PKG_ERRORS=`$PKG_CONFIG --print-errors --cflags --libs "$2" 2>&1` + fi + # Put the nasty error message in config.log where it belongs + echo "$$1[]_PKG_ERRORS" >&AS_MESSAGE_LOG_FD + + m4_default([$4], [AC_MSG_ERROR( +[Package requirements ($2) were not met: + +$$1_PKG_ERRORS + +Consider adjusting the PKG_CONFIG_PATH environment variable if you +installed software in a non-standard prefix. + +_PKG_TEXT])[]dnl + ]) +elif test $pkg_failed = untried; then + AC_MSG_RESULT([no]) + m4_default([$4], [AC_MSG_FAILURE( +[The pkg-config script could not be found or is too old. Make sure it +is in your PATH or set the PKG_CONFIG environment variable to the full +path to pkg-config. + +_PKG_TEXT + +To get pkg-config, see <http://pkg-config.freedesktop.org/>.])[]dnl + ]) +else + $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS + $1[]_LIBS=$pkg_cv_[]$1[]_LIBS + AC_MSG_RESULT([yes]) + $3 +fi[]dnl +])# PKG_CHECK_MODULES + + +# PKG_INSTALLDIR(DIRECTORY) +# ------------------------- +# Substitutes the variable pkgconfigdir as the location where a module +# should install pkg-config .pc files. By default the directory is +# $libdir/pkgconfig, but the default can be changed by passing +# DIRECTORY. The user can override through the --with-pkgconfigdir +# parameter. +AC_DEFUN([PKG_INSTALLDIR], +[m4_pushdef([pkg_default], [m4_default([$1], ['${libdir}/pkgconfig'])]) +m4_pushdef([pkg_description], + [pkg-config installation directory @<:@]pkg_default[@:>@]) +AC_ARG_WITH([pkgconfigdir], + [AS_HELP_STRING([--with-pkgconfigdir], pkg_description)],, + [with_pkgconfigdir=]pkg_default) +AC_SUBST([pkgconfigdir], [$with_pkgconfigdir]) +m4_popdef([pkg_default]) +m4_popdef([pkg_description]) +]) dnl PKG_INSTALLDIR + + +# PKG_NOARCH_INSTALLDIR(DIRECTORY) +# ------------------------- +# Substitutes the variable noarch_pkgconfigdir as the location where a +# module should install arch-independent pkg-config .pc files. By +# default the directory is $datadir/pkgconfig, but the default can be +# changed by passing DIRECTORY. The user can override through the +# --with-noarch-pkgconfigdir parameter. +AC_DEFUN([PKG_NOARCH_INSTALLDIR], +[m4_pushdef([pkg_default], [m4_default([$1], ['${datadir}/pkgconfig'])]) +m4_pushdef([pkg_description], + [pkg-config arch-independent installation directory @<:@]pkg_default[@:>@]) +AC_ARG_WITH([noarch-pkgconfigdir], + [AS_HELP_STRING([--with-noarch-pkgconfigdir], pkg_description)],, + [with_noarch_pkgconfigdir=]pkg_default) +AC_SUBST([noarch_pkgconfigdir], [$with_noarch_pkgconfigdir]) +m4_popdef([pkg_default]) +m4_popdef([pkg_description]) +]) dnl PKG_NOARCH_INSTALLDIR + + +# PKG_CHECK_VAR(VARIABLE, MODULE, CONFIG-VARIABLE, +# [ACTION-IF-FOUND], [ACTION-IF-NOT-FOUND]) +# ------------------------------------------- +# Retrieves the value of the pkg-config variable for the given module. +AC_DEFUN([PKG_CHECK_VAR], +[AC_REQUIRE([PKG_PROG_PKG_CONFIG])dnl +AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])dnl + +_PKG_CONFIG([$1], [variable="][$3]["], [$2]) +AS_VAR_COPY([$1], [pkg_cv_][$1]) + +AS_VAR_IF([$1], [""], [$5], [$4])dnl +])# PKG_CHECK_VAR -- 2.1.0

2 3

[Wok] Add new CSS and JS assets resources
by Samuel Henrique De Oliveira Guimaraes 18 Aug '15

18 Aug '15

Hi team, I'm trying to add Bootstrap.min.css file do Kimchi plugin but I think I have to edit the Makefiles to include them in the server. If I edit wok-ui.html.tmpl it doesn't render anything and throws a 404 error. If I remove the line that I'm using to include Bootstrap or any other CSS or JS file that I've added, it goes back to normal. Where do I edit to include my new assets? Thanks, Samuel

2 3

Re: [Kimchi-devel] Wok index page mock up
by Samuel Henrique De Oliveira Guimaraes 13 Aug '15

13 Aug '15

Oh, I see. Well, coincidently today I saw two articles evaluating the usability of the hamburger button: http://deep.design/the-hamburger-menu/ https://medium.com/mobile-growth/who-moved-my-hamburger-d237860bc589 -Most sites and applications are redesign or realigning their structure and getting rid of the hamburger button going back to… Tabs! I think the navbar should have some contextual changes when browsing the API documentation and sample plugin compared to the current new-ui proposed for Wok. I need to validate some ui patterns first. I still need to present some mockups for low resolution screens with the navbar in the new-ui, adding more tabs doesn’t seem like a good option. Once the new-ui is stable I’ll work on some mockups and share with ML. Thanks, Samuel From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: quinta-feira, 13 de agosto de 2015 01:28 To: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br> Cc: alinefm(a)linux.vnet.ibm.com; kimchi-devel(a)ovirt.org; socorro(a)linux.vnet.ibm.com Subject: Re: RE: RE: [Kimchi-devel] Wok index page mock up Not sure if I got you correctly there. I wasn't just referring to the API documentation, I was talking about overall layout of wok with all it's plugins loaded. ----- Original message ----- From: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>> To: Harshal Patil/India/IBM@IBMIN Cc: "alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>" <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>>, "kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>" <kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>>, "socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>" <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Subject: RE: RE: [Kimchi-devel] Wok index page mock up Date: Thu, Aug 13, 2015 1:48 AM Yes, I think this pattern with fixed top, menu icon and search field is very good for the purpose of a documentation tool. For the mockup I’ve edited a HTML page, captured it and added the logo with Gimp. Samuel From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: quarta-feira, 12 de agosto de 2015 01:02 To: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>> Cc: alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>; kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>; socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com> Subject: Re: RE: [Kimchi-devel] Wok index page mock up Hi, Thanks for your comments. I liked the API explorer you have proposed. For the hamburger and logo bar, do you want to keep a static bar or do you want to consider a dynamically changing contextual bar? I have attached the example of later here. So depending upon which context you are it changes it's colour and items in the bar. The screenshots are from 'Inbox for Gmail'. We can keep the logo somewhere there but we can also show which 'plugin' the is interacting with and change the color scheme accordingly. E.g if user selects 'Kimchi' plugin from hamburger menu we can display 'Kimchi' next to that hamburger menu (while continue to display 'Wok' in the center or something like that). This way we can get rid of 'tabs'. The top bar serves that purpose. Let me know what do you think. BTW, which mock up tool you used to create that mockup page of wok? Harshal ----- Original message ----- From: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>> To: Harshal Patil/India/IBM@IBMIN, "alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>" <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>> Cc: "kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>" <kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>>, "socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>" <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Subject: RE: [Kimchi-devel] Wok index page mock up Date: Wed, Aug 12, 2015 3:06 AM Hi Harshal, I liked the mockup. It looks good and I think that for Wok service we should have a clean interface since we are going to provide API documentation, it should feature different elements than Kimchi and Ginger but maintain the same design language. I think this is a good direction because if you look to several products Wikis and docs, they are adding some of the same elements that we can see in this mockup like the Hamburger Icon and an off-canvas menu. For the REST API documentation I was thinking in something similar to the attached image and this link: http://petstore.swagger.io/ However, that part would need user authentication for security reasons. Regarding the logo, I believe it should be large and centered in the index page. Kimchi logo is good enough, maybe a flat version of it: From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: terça-feira, 11 de agosto de 2015 16:49 To: alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com> Cc: kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>; Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>>; socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com> Subject: Re: [Kimchi-devel] Wok index page mock up Opps sorry Aline, forgot to answer your questions.. 1. It was inspired from Android's hamburger menu design. It's also your in 'Inbox for Gmail's desktop page. But of course, this is not a final design. We can improve it further, if required. 2. IMHO, user doesn't need to login just to see the index page. There is nothing in there which needs to be protected behind a login page. 3. It could be right next to hamburger menu or on the RHS. ----- Original message ----- From: Aline Manera <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>> To: Harshal Patil/India/IBM@IBMIN, kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>, Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>>, Socorro Stoppler <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Cc: Subject: Re: [Kimchi-devel] Wok index page mock up Date: Tue, Aug 11, 2015 8:47 PM Hi Harshal, Thanks for sending this mockup! In general it looks good for me. Only some comments/doubts: 1) What is 3 lines button on the left corner? Does this represent a menu or something? 2) Will the welcome page be shown as the first page or user will need to login to get the welcome page? 3) Will wok have a logo? Where in page will we display it? Maybe Socorro and Samuel can help us more on the page layout as they are UI experts =) Regards, Aline Manera On 10/08/2015 07:43, Harshal Patil wrote: Hi, Working on issue #718 ,https://github.com/kimchi-project/kimchi/issues/718 Just some initial mock up about page layouts. Please let me know what do you think about it. These mock ups are only for showing the layout, so please ignore things like color scheme, font types etc. Here is the pdf, https://drive.google.com/file/d/0B3vI9LCU26KEN19kcjZtbTVyOGM/view?usp=shari… I am using Pencil to create that, so if you want to edit something here is pencil file, https://drive.google.com/file/d/0B3vI9LCU26KETm52bU00V1hDZ00/view?usp=shari… Thanks _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org<mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

1 0

[Wok] Webfonts and Fedora
by Samuel Henrique De Oliveira Guimaraes 13 Aug '15

13 Aug '15

Following the Helvetica Neue topic previously discussed in the mailing list, I think we have another issue with fonts here. In the current [wok] branch there's a folder called "Fontello" within the ui assets with some ttf, svg, woff and eot files. Fontello is a service that allows you to choose characters from different font families. According to Fedora Fonts Policy: 1. Fonts released upstream in separate archives MUST be packaged in separate source packages (src.rpm), unless they belong to the same font family. 2. Packagers SHOULD ask upstream to release each font family in a separate versioned archive, when it bundles in a common release archive: 1. fonts with other material such as application code, or 2. different font families. ? As an exception, when a project is the upstream of several font families, which are all licensed the same way, and released on the same date, with the same version, the use of a common release archive is tolerated. 3. Packagers MUST package each font family in a separate (noarch.rpm) (sub)package, notwithstanding on how they applied the previous source package (src.rpm) rules. The only admitted exceptions are: 0. source packages that only include one font family and no other code or content (font documentation excepted), in which case a simple package is fine, 1. font families which are designed to extend other font families with larger Unicode coverage (for example Arial Unicode, Droid Sans Fallback), in which case grouping the font family and its extension in a single (sub)package is acceptable. ? such cases should be notified to the fontconfig maintainer and the Fedora fonts list<https://fedoraproject.org/wiki/Fonts_SIG_mailing_lists>, so the font family split can be eventually hidden from users. 2. fonts that use a format that bundles different font families in a single file. 4. On the other hand, the different faces of a font family MUST be packaged together in a common (noarch.rpm) (sub)package, and not spread over different (sub)packages[3]<https://fedoraproject.org/wiki/Packaging:FontsPolicy#cite_note-2>. https://fedoraproject.org/wiki/Packaging:FontsPolicy And Web Assets Packaging: All system fonts (available in %{_datadir}/fonts) are automatically made available in %{_webassetdir}/fonts/ via a symlink. For more information on packaging system fonts, see the font guidelines<https://fedoraproject.org/wiki/Packaging:FontsPolicy>. Please note that [Web_Assets/Fonts|only fonts available in the Fedora package collection are made available on HTTP servers by default]. Please note that those guidelines prohibit packaging fonts elsewhere. There is no compelling reason to support other font formats, as most browsers that support web fonts support the TTF or OTF formats used by system fonts, therefore alternative web font formats like WOFF are prohibited. https://fedoraproject.org/wiki/Packaging:Web_Assets#Fonts So, instead of putting font files within Kimchi project, we have to use a package. From the list of icons used to build this Fontello.ttf file, only Font Awesome has a Fedora Package. The problem is that this font uses trademarked icons such as Windows, Spotify, Skype, Facebook, Twitter and other brands when you download it, not sure if they removed from their RPM. We would also have to provide a service that exposes the TTF and OTF files in the same URL, protocol and port that Kimchi is running, something like https://localhost:8001/fonts/font-awesome.ttf for instance. As for TTF and OTF support, according to this support table, we got all A-grade browsers: http://caniuse.com/#feat=ttf The same goes for Open Sans font and an alternative to Traditional Chinese and Simplified Chinese from Adobe called Source Han Sans: https://apps.fedoraproject.org/packages/open-sans-fonts/overview/ https://apps.fedoraproject.org/packages/adobe-source-han-sans-tw-fonts https://apps.fedoraproject.org/packages/adobe-source-han-sans-cn-fonts The other solution for our icons would be export each glyph we want to use in SVG format (and keep font-awesome license within). It seems that this is ok with Font-Awesome but not with the other fonts available in Fontello. So, for now I'm removing all font files from [wok] branch and I'll submit a patch later. What are your thoughts? Any advice? Regards, Samuel

1 0

Re: [Kimchi-devel] Wok index page mock up
by Samuel Henrique De Oliveira Guimaraes 13 Aug '15

13 Aug '15

Yes, I think this pattern with fixed top, menu icon and search field is very good for the purpose of a documentation tool. For the mockup I’ve edited a HTML page, captured it and added the logo with Gimp. Samuel From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: quarta-feira, 12 de agosto de 2015 01:02 To: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br> Cc: alinefm(a)linux.vnet.ibm.com; kimchi-devel(a)ovirt.org; socorro(a)linux.vnet.ibm.com Subject: Re: RE: [Kimchi-devel] Wok index page mock up Hi, Thanks for your comments. I liked the API explorer you have proposed. For the hamburger and logo bar, do you want to keep a static bar or do you want to consider a dynamically changing contextual bar? I have attached the example of later here. [cid:image003.png@01D0D522.DEB4CE60][cid:image004.png@01D0D522.DEB4CE60][cid:image005.png@01D0D522.DEB4CE60] So depending upon which context you are it changes it's colour and items in the bar. The screenshots are from 'Inbox for Gmail'. We can keep the logo somewhere there but we can also show which 'plugin' the is interacting with and change the color scheme accordingly. E.g if user selects 'Kimchi' plugin from hamburger menu we can display 'Kimchi' next to that hamburger menu (while continue to display 'Wok' in the center or something like that). This way we can get rid of 'tabs'. The top bar serves that purpose. Let me know what do you think. BTW, which mock up tool you used to create that mockup page of wok? Harshal ----- Original message ----- From: Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>> To: Harshal Patil/India/IBM@IBMIN, "alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>" <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>> Cc: "kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>" <kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>>, "socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>" <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Subject: RE: [Kimchi-devel] Wok index page mock up Date: Wed, Aug 12, 2015 3:06 AM Hi Harshal, I liked the mockup. It looks good and I think that for Wok service we should have a clean interface since we are going to provide API documentation, it should feature different elements than Kimchi and Ginger but maintain the same design language. I think this is a good direction because if you look to several products Wikis and docs, they are adding some of the same elements that we can see in this mockup like the Hamburger Icon and an off-canvas menu. For the REST API documentation I was thinking in something similar to the attached image and this link: http://petstore.swagger.io/ [cid:image006.png@01D0D522.DEB4CE60] However, that part would need user authentication for security reasons. Regarding the logo, I believe it should be large and centered in the index page. Kimchi logo is good enough, maybe a flat version of it: [cid:image007.png@01D0D522.DEB4CE60] From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: terça-feira, 11 de agosto de 2015 16:49 To: alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com> Cc: kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>; Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>>; socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com> Subject: Re: [Kimchi-devel] Wok index page mock up Opps sorry Aline, forgot to answer your questions.. 1. It was inspired from Android's hamburger menu design. It's also your in 'Inbox for Gmail's desktop page. But of course, this is not a final design. We can improve it further, if required. 2. IMHO, user doesn't need to login just to see the index page. There is nothing in there which needs to be protected behind a login page. 3. It could be right next to hamburger menu or on the RHS. ----- Original message ----- From: Aline Manera <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>> To: Harshal Patil/India/IBM@IBMIN, kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>, Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>>, Socorro Stoppler <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Cc: Subject: Re: [Kimchi-devel] Wok index page mock up Date: Tue, Aug 11, 2015 8:47 PM Hi Harshal, Thanks for sending this mockup! In general it looks good for me. Only some comments/doubts: 1) What is 3 lines button on the left corner? Does this represent a menu or something? 2) Will the welcome page be shown as the first page or user will need to login to get the welcome page? 3) Will wok have a logo? Where in page will we display it? Maybe Socorro and Samuel can help us more on the page layout as they are UI experts =) Regards, Aline Manera On 10/08/2015 07:43, Harshal Patil wrote: Hi, Working on issue #718 ,https://github.com/kimchi-project/kimchi/issues/718 Just some initial mock up about page layouts. Please let me know what do you think about it. These mock ups are only for showing the layout, so please ignore things like color scheme, font types etc. Here is the pdf, https://drive.google.com/file/d/0B3vI9LCU26KEN19kcjZtbTVyOGM/view?usp=shari… I am using Pencil to create that, so if you want to edit something here is pencil file, https://drive.google.com/file/d/0B3vI9LCU26KETm52bU00V1hDZ00/view?usp=shari… Thanks _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org<mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

2 1

[Wok] Exposing tabs when not logged
by Samuel Henrique De Oliveira Guimaraes 12 Aug '15

12 Aug '15

Hi team, In the new UI design spec the navbar displays the plugins / tabs in the navbar even when the user is logged out. I was studying wok JS files and I've tried to load the tabs in the DOM tree in the login page with no success. Then It occurred to me: Is it right to show the tabs and hostname when the user is not logged in? I question this because in the tabs-ext.xml we can see the access roles and some tabs clearly are not supposed to be seen by non-admin users. What are your thoughts? Thanks, Samuel

3 3

Re: [Kimchi-devel] Fw: [Ginger-dev-list] [RFC] Inheriting Kimchi's Host tab
by Archana Singh 12 Aug '15

12 Aug '15

Please find my comment inline. > > From: Aline Manera <alinefm(a)linux.vnet.ibm.com> > To: ginger-dev-list(a)nongnu.org > Date: 08/11/2015 08:12 PM > Subject: [Ginger-dev-list] [RFC] Inheriting Kimchi's Host tab > Sent by: ginger-dev-list-bounces+archanasingh=in.ibm.com(a)nongnu.org > ------------------------------------------------------------------------ > > > > Hi all, > > As we have agreed on Kimchi mailing list, the Ginger community will be > responsible for the Host tab (today part of Kimchi) in a way of 2 > different plugins: ginger-basic and ginger. > ginger-basic will provide host basic information, host statistics and > debug reports support. And among the current Ginger features, it will > also provide software updates and repositories management. > > For Kimchi perspective, we need to transform part of the Host tab into > the ginger-basic plugin and add it as a Kimchi dependency. > To move the discussion as soon as possible to Ginger community, my > suggestion is to move the entire Host tab into ginger-basic plugin in > the first moment. > Once we do that, we can move software update and repositories management > APIs to Ginger. > > Here is my proposal: > > 1) Create ginger-basic plugin which will launch the Host tab as it is > today. > It will be done on Kimchi community. > > 2) Move software update and repositories management *APIs* from > ginger-basic to ginger. > Only the API will be updated. The UI will keep the same. > > 3) Add ginger-basic as a Ginger dependency. > In this step, Ginger standalone will launch 2 tabs: Host and > Administration. > > All that can be done by the end of September. > > Once we have the new UI widgets done, Samuel will start working on > merging those 2 tabs into one as we just need the update how UI is built. > The idea is to release Ginger as one single Host tab in the December @Samuel: As I was looking into current UI implementation to understand how to merge two plugins into one tab. But now it does not make sense to spend time on understanding this in exiting UI, as the plan is to do this on new UI. As I am not expert on bootstrap, is bootstrap already has some feature to merge two plugins into one tab? If not, then do you think it is better to consider this point while implementing new UI, so that merging(two plugins into one tab) can be easier wherever required. Or do you think still it make sense to spend some time to understand how can this be done in exiting UI? I hope I make sense to you. Please let me know your input. Or spending some time in current UI implementation on how to merge will be required? > release - in addition to wok and Kimchi as a plugin. > > Let me know what you think about it. > > Regards, > Aline Manera > >

3 2

[PATCH 1/1] Fix :704 -page refreshing issue for wok branch
by Atreyee 12 Aug '15

12 Aug '15

'undefined' value displayed in url and page was getting refreshed after logged into wok page Signed-off-by: Atreyee <atreyee(a)linux.vnet.ibm.com> --- ui/css/theme-default/message.css | 10 ++++++++++ ui/js/src/wok.main.js | 15 +++++++++++++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/ui/css/theme-default/message.css b/ui/css/theme-default/message.css index 28c392b..7cce15b 100644 --- a/ui/css/theme-default/message.css +++ b/ui/css/theme-default/message.css @@ -133,3 +133,13 @@ border: 2px solid #444; color: #444; } + +.noPluginMessage{ + font-size: 18px; + height: 48px; + line-height: 48px; + text-shadow: -1px -1px 1px #ccc, 1px 1px 1px #fff; + padding-left: 10px; + padding-top:10px; + +} diff --git a/ui/js/src/wok.main.js b/ui/js/src/wok.main.js index f4c9940..0d9baec 100644 --- a/ui/js/src/wok.main.js +++ b/ui/js/src/wok.main.js @@ -102,10 +102,15 @@ wok.main = function() { var defaultTab = tabs[0] var defaultTabPath = defaultTab && defaultTab['path'] + + //redirect to empty page when no plugin installed + if(tabs.length===0){ + DEFAULT_HASH = 'wok-empty'; + }else{ // Remove file extension from 'defaultTabPath' DEFAULT_HASH = defaultTabPath && defaultTabPath.substring(0, defaultTabPath.lastIndexOf('.')) - + } $('#nav-menu').append(genTabs(tabs)); callback && callback(); @@ -136,11 +141,16 @@ wok.main = function() { * and clear location.hash to jump to home page. */ var tab = $('#nav-menu a[href="' + url + '"]'); - if (tab.length === 0) { + if (tab.length === 0 && url!='wok-empty.html') { location.hash = ''; return; } + //Remove the tab arrow indicator for no plugin + if(url=='wok-empty.html'){ + $('.menu-arrow').hide(); + $('#main').html('No plugins installed currently.You can download the available plugins <a href="https://github.com/kimchi-project/kimchi">Kimchi</a> and <a href="https://github.com/kimchi-project/ginger">Ginger</a> from Github').addClass('noPluginMessage'); + }else{ // Animate arrow indicator. var left = $(tab).parent().position().left; var width = $(tab).parent().width(); @@ -163,6 +173,7 @@ wok.main = function() { } // Load page content. loadPage(url); + } }; /** -- 2.1.0

3 3

Re: [Kimchi-devel] Wok index page mock up
by Samuel Henrique De Oliveira Guimaraes 12 Aug '15

12 Aug '15

Hi Harshal, I liked the mockup. It looks good and I think that for Wok service we should have a clean interface since we are going to provide API documentation, it should feature different elements than Kimchi and Ginger but maintain the same design language. I think this is a good direction because if you look to several products Wikis and docs, they are adding some of the same elements that we can see in this mockup like the Hamburger Icon and an off-canvas menu. For the REST API documentation I was thinking in something similar to the attached image and this link: http://petstore.swagger.io/ [cid:image001.png@01D0D460.E60DAFF0] However, that part would need user authentication for security reasons. Regarding the logo, I believe it should be large and centered in the index page. Kimchi logo is good enough, maybe a flat version of it: [cid:image002.png@01D0D464.2E266270] From: Harshal Patil [mailto:harshal.patil@in.ibm.com] Sent: terça-feira, 11 de agosto de 2015 16:49 To: alinefm(a)linux.vnet.ibm.com Cc: kimchi-devel(a)ovirt.org; Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br>; socorro(a)linux.vnet.ibm.com Subject: Re: [Kimchi-devel] Wok index page mock up Opps sorry Aline, forgot to answer your questions.. 1. It was inspired from Android's hamburger menu design. It's also your in 'Inbox for Gmail's desktop page. But of course, this is not a final design. We can improve it further, if required. 2. IMHO, user doesn't need to login just to see the index page. There is nothing in there which needs to be protected behind a login page. 3. It could be right next to hamburger menu or on the RHS. ----- Original message ----- From: Aline Manera <alinefm(a)linux.vnet.ibm.com<mailto:alinefm@linux.vnet.ibm.com>> To: Harshal Patil/India/IBM@IBMIN, kimchi-devel(a)ovirt.org<mailto:kimchi-devel@ovirt.org>, Samuel Henrique De Oliveira Guimaraes <samuel.guimaraes(a)eldorado.org.br<mailto:samuel.guimaraes@eldorado.org.br>>, Socorro Stoppler <socorro(a)linux.vnet.ibm.com<mailto:socorro@linux.vnet.ibm.com>> Cc: Subject: Re: [Kimchi-devel] Wok index page mock up Date: Tue, Aug 11, 2015 8:47 PM Hi Harshal, Thanks for sending this mockup! In general it looks good for me. Only some comments/doubts: 1) What is 3 lines button on the left corner? Does this represent a menu or something? 2) Will the welcome page be shown as the first page or user will need to login to get the welcome page? 3) Will wok have a logo? Where in page will we display it? Maybe Socorro and Samuel can help us more on the page layout as they are UI experts =) Regards, Aline Manera On 10/08/2015 07:43, Harshal Patil wrote: Hi, Working on issue #718 ,https://github.com/kimchi-project/kimchi/issues/718 Just some initial mock up about page layouts. Please let me know what do you think about it. These mock ups are only for showing the layout, so please ignore things like color scheme, font types etc. Here is the pdf, https://drive.google.com/file/d/0B3vI9LCU26KEN19kcjZtbTVyOGM/view?usp=shari… I am using Pencil to create that, so if you want to edit something here is pencil file, https://drive.google.com/file/d/0B3vI9LCU26KETm52bU00V1hDZ00/view?usp=shari… Thanks _______________________________________________ Kimchi-devel mailing list Kimchi-devel(a)ovirt.org<mailto:Kimchi-devel@ovirt.org> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

2 1

Wok index page mock up
by Harshal Patil 11 Aug '15

11 Aug '15

2 4