- Kimchi-devel - oVirt List Archives

Libvirt bug ? (Multiple errors in edit guest storage window #405)
by Rodrigo Trujillo 20 Aug '14

20 Aug '14

Hi all, I have worked to fix https://github.com/kimchi-project/kimchi/issues/405 In problem (2) the cause seems to be an error in libvirt, it is saving the device with wrong protocol, which makes kimchi not return the path. Reproduce: 1- Create a virtual machine with a local cdrom iso configure. You will see a device such as ("virsh edit" shows): <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <source file='/ISOS/ubuntu-14.04-server-amd64.iso'/> <target dev='hdc' bus='ide'/> <readonly/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> 2- Create a file with new device (same dev name) configuration, such as (/tmp/new-cdrom): <disk device="cdrom" type="network"> <driver type="raw" name="qemu"/> <target bus="ide" dev="hdc"/> <source protocol="http" name="/releases/14.04.1/release/ubuntu-14.04.1-desktop-amd64+mac.iso"> <host port="80" name="cdimages.ubuntu.com"/> </source> </disk> 3- Update the virtual machine device with virsh: sudo virsh update-device <VM-NAME> /tmp/new-cdrom 4- Edit the vm xml and you will see that the device was added with "NBD" protocol and without HOST information!!! : <disk type='network' device='cdrom'> <driver name='qemu' type='raw'/> <source protocol='nbd' name='/releases/14.04.1/release/ubuntu-14.04.1-desktop-amd64+mac.iso'/> <target dev='hdc' bus='ide'/> <readonly/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> ---------------------- Kimchi uses "dom.updateDeviceFlags", the same API. Notice that this happens when changing from local to remote ISO only. Remote to remote works ... and local to local too. Does anyone have idea why this happens ? As workaround I can detach, then attach the device again. Thoughts ? Rodrigo Trujillo

1 0

[PATCH] Bugfix UI: Change button text to indicate user network is generating
by Wen Wang 20 Aug '14

20 Aug '14

From: Wen Wang <wenwang(a)linux.vnet.ibm.com> When network is generating, if the network is not up, we bring the network up first, then we create the network. During the time we bring the network up(less than 10s), we change the text as well as the layout of the button to indicate this process is working. Signed-off-by: Wen Wang <wenwang(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.network.js | 3 +++ ui/pages/i18n.json.tmpl | 1 + 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js index c8f983f..cee5864 100644 --- a/ui/js/src/kimchi.network.js +++ b/ui/js/src/kimchi.network.js @@ -270,6 +270,8 @@ kimchi.openNetworkDialog = function(okCallback) { title : i18n.KCHNET6003M }); $("#networkFormOk").on("click", function() { + $("#networkFormOk").button("disable"); + $("#networkFormOk span").text(i18n.KCHAPI6008M); okCallback(); }); $("#enableVlan").on("click", function() { @@ -337,6 +339,7 @@ kimchi.cleanNetworkDialog = function() { $("#networkDestinationLabel").text($("#networkDestinationID li:first-child").text()); $("#networkFormOk").off("click"); $("#networkFormOk").button("disable"); + $("#networkFormOk span").text(i18n.KCHAPI6005M); $("#networkVlanID").toggle(false); $("#labelNetworkVlanID").toggle(false); $("#enableVlan").prop("checked", false); diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl index ccfb081..cbcd077 100644 --- a/ui/pages/i18n.json.tmpl +++ b/ui/pages/i18n.json.tmpl @@ -49,6 +49,7 @@ "KCHAPI6005M": "$_("Create")", "KCHAPI6006M": "$_("Warning")", "KCHAPI6007M": "$_("Save")", + "KCHAPI6008M": "$_("Creating...")", "KCHGRD6001M": "$_("Loading...")", "KCHGRD6002M": "$_("An error occurs while checking for packages update.")", -- 1.7.1

4 5

[RFC] ISO pool: Support to download ISO from URL
by Crístian Viana 20 Aug '14

20 Aug '14

The following API changes should be made to implement the remote download ISO feature: 1) POST /storagepools/ISO/storagevolumes/download {'url': <http|https|ftp|ftps>, 'name': <volume name>} Description: Starts downloading a remote ISO image to Kimchi's storage pool. Parameters: 'url': specifies where the image is hosted. Required. 'name': specifies the name of the local file when the download finishes. If this parameter is omitted, Kimchi will try to use the same file name as the remote file. Optional. Return codes: 200: the remote URL is valid and the download started successfully. 400: the remote URL is not valid; the provided 'name' is already in use (this error shouldn't happen if 'name' is omitted). the storage pool doesn't have enough free space to hold the remote file. Return data: {'name': <vol-name>} 2) POST /storagepools/ISO/storagevolumes/download/pause {'name': <volume name>} Description: Pauses a remote ISO download. Parameters: 'name': the remote volume name to be paused. Required. Return codes: 200: 'name' is an ongoing download file and the operation was paused successfully. 400: 'name' is an invalid volume name (doesn't exist / isn't an ongoing download); download referred by 'name' cannot be paused. Return data: {} 3) POST /storagepools/ISO/storagevolumes/download/resume {'name': <volume name>} Description: Resumes a paused remote ISO download. Parameters: 'name': the remote volume name to be resumed. Required. Return codes: 200: 'name' is a paused download file and the operation was resumed successfully. 400: 'name' is an invalid volume name (doesn't exist / isn't a paused download). Return data: {} 4) POST /storagepools/ISO/storagevolumes/download/cancel {'name': <volume name>} Description: Cancels a remote ISO download. Parameters: 'name': the remote volume name to be canceled. Required. Return codes: 200: 'name' is an ongoing download file and the operation was canceled successfully. Whatever data has been downloaded so far should be deleted. 400: 'name' is an invalid volume name (doesn't exist / isn't an ongoing download). Return data: {} 5) POST /storagepools/ISO/storagevolumes/download/status {'name': <volume name>} Description: Provides status of a remote ISO download. Parameters: 'name': the remote volume name. Required. Return codes: 200: 'name' is a download file and its status information was returned successfully. 400: 'name' is an invalid volume name (doesn't exist / isn't a remote download). Return data: {'name': <volume name>, 'status': [downloading|paused], 'total_size': <size in bytes>, 'downloaded_size': <size in bytes>} I tried to put together the feedback given in another e-mail thread, especially by Aline, Royce and Yu Xin Huo, along with some ideas of my own. This RFC doesn't support choosing a different storage pool other than "ISO" to host the downloaded files. If we're doing this, wel need to update this new API accordingly. The implementation details will be discussed later. Please share your feedback with us.

3 10

[PATCH] Bug fix: Github #354
by Daniel Henrique Barboza 19 Aug '14

19 Aug '14

The following patch fixes the issue described in Github #354: "storage: used nfs source path need to be filtered out in creation page" https://github.com/kimchi-project/kimchi/issues/354 Daniel Henrique Barboza (1): model/storagetargets: filtering used nfs paths src/kimchi/model/storagetargets.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) -- 1.8.3.1

4 6

[PATCH] Add hover description to template type icons
by Crístian Viana 19 Aug '14

19 Aug '14

The small icons on each template indicate whether they are local or remote but that may not be obvious to everyone. Show a description when the user hovers the mouse over the template icons indicating what they mean: local or remote template. Also, the same descriptive text will be shown in the icon's place if the browser is not able to load images. Signed-off-by: Crístian Viana <vianac(a)linux.vnet.ibm.com> --- ui/js/src/kimchi.template_main.js | 2 ++ ui/pages/i18n.json.tmpl | 2 ++ ui/pages/tabs/templates.html.tmpl | 2 +- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/ui/js/src/kimchi.template_main.js b/ui/js/src/kimchi.template_main.js index 3c8421d..ae3f290 100644 --- a/ui/js/src/kimchi.template_main.js +++ b/ui/js/src/kimchi.template_main.js @@ -25,8 +25,10 @@ kimchi.doListTemplates = function() { var isLocal = /^\//.test(value['cdrom']); if(isLocal){ value.location = "images/theme-default/icon-local.png"; + value.iconDescription = i18n['KCHTMPL6004M']; }else{ value.location = "images/theme-default/icon-remote.png"; + value.iconDescription = i18n['KCHTMPL6005M']; } listHtml += kimchi.substitute(templateHtml, value); }); diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl index f1478a7..8e6fcd6 100644 --- a/ui/pages/i18n.json.tmpl +++ b/ui/pages/i18n.json.tmpl @@ -61,6 +61,8 @@ "KCHTMPL6002M": "$_("It will take long time. Do you want to continue?")", "KCHTMPL6003M": "$_("This will permanently delete the template. Would you like to continue?")", + "KCHTMPL6004M": "$_("Local template")", + "KCHTMPL6005M": "$_("Remote template")", "KCHHOST6001E": "$_("Unable to shut down system as there are some virtual machines running!")", diff --git a/ui/pages/tabs/templates.html.tmpl b/ui/pages/tabs/templates.html.tmpl index 7cf7fcd..4fe1d73 100644 --- a/ui/pages/tabs/templates.html.tmpl +++ b/ui/pages/tabs/templates.html.tmpl @@ -50,7 +50,7 @@ <div class="template-icon template-icon-position"> <img alt="" src="{icon}"> - <img alt="" src="{location}" class="template-type-icon-position"> + <img alt="{iconDescription}" title="{iconDescription}" src="{location}" class="template-type-icon-position"> </div> <div class="template-general template-title template-title-position"> <h2 class="title" title="{name}">{name}</h2> -- 1.9.3

3 3

RFC: Discover Kimchi Peers - UI Mockup
by Yu Xin Huo 19 Aug '14

19 Aug '14

4 6

RFC: Display iSCSI Targets - UI Mockup
by Yu Xin Huo 19 Aug '14

19 Aug '14

4 5

[RFC] Mock for Authorization: Allow admin user change permission settings when VM is running
by Wen Wang 19 Aug '14

19 Aug '14

Hi all, Here is the new design of the "Edit" function. We are going to enable user viewing VM details when VMs are running and "Permission" is always available whether a VM is running or not. Here's the detail of the design: 1) Enable "Edit" in "Action" whether VM is running or not. 2) Delete "Manage Media" button and move it to a tab in "Edit" 3) Enable "Permission" & "Manage Media" and provide read-only privilege of "General", "Storage", "Interface" when a VM is running. 4) Enable "General", "Storage", "Interface", "Permission" and provide read-only privilege of "Manage Media"when a VM is not running. Mocks are added below: Delete "Manage Media" and enable "Edit" all the time. When a VM is running, tabs are presented: When a VM is not running, tabs are presented all like what is right now only with a new tab of "Manage Media" read-only: Any comment is welcomed Best Regards Wang Wen

3 6

RFC: Asynchronous event notify
by Wen Wang 19 Aug '14

19 Aug '14

Hi all, Back-end: STOMP <http://stomp.github.com/> is a simple text-orientated messaging protocol, based on which, we can accomplish the "TCP for the web". What we need is a message server and a client that communicate with the server. We can send messages to server using this protocol and receive messages from server, which needs a subscription to the server first and then server gives the callback. Here are the possible STOMP servers: Apache ActiveMQ the most popular and powerful open source messaging and Integration Patterns server Apache Apollo a redesigned version of ActiveMQ CoilMQ a lightweight pure Python STOMP broker inspired by StompServer Gozirra a lightweight Java STOMP broker HornetQ puts the buzz in messaging MorbidQ a STOMP publish/subscribe server with absolutely no potential to cluster RabbitMQ an Erlang-based, multi-protocol broker with full support for STOMP via a plugin Sprinkle written in Python and runs on Unix type platforms Stampy a Java implementation of the STOMP 1.2 specification StompConnect provides a bridge to any other JMS provider StompServer a lightweight pure Ruby STOMP server And the client: pyactivemq module for communicating with the ActiveMQ message broker stomper a client implementation of the STOMP protocol stompest a full-featured STOMP implementation for Python including both synchronous and asynchronous clients stompy implementation of the STOMP protocol in Python stomp.py a Python client library which can also be run as a standalone, command-line client for testing. Front-end: As I mentioned before. Front-end only change the way that the long time task communicate with the back-end. UI should look just the same with a more enhanced display. Also, more function will be enabled according to this like we can enable actions when generating a debug report, etc. Best Regards Wang Wen

1 0

[RFC] upload ISO to OOTB pool
by Royce Lv 19 Aug '14

19 Aug '14

1. Backend: (1)API definition: POST /storagepools/isos/storagevolumes/upload {'file': fileobject} -- This is from backend view, as cherrypy's embedded support wraps fileobject. REF:http://docs.cherrypy.org/en/latest/pkg/cherrypy.tutorial.html?highlight… (2) implementation: We can get the file handler from cherrypy's embedded scheme, and use it to read and write to a local file, ref: https://groups.google.com/forum/#!topic/cherrypy-users/xGvxBGgQ90k The only thing we need to concern at backend is the file size, cherrypy demo has proposed a example leverage cgi lib: http://tools.cherrypy.org/wiki/DirectToDiskFileUpload 2. For UI, we need to supply user with a form which input type is 'file', or we construct formdata in ajax(for IE only supported in IE10+): REF: http://stackoverflow.com/questions/6974684/how-to-send-formdata-objects-wit… 3. To support the progress bar in UI, we can utilize resumable js: http://github.com/23/resumable.js

2 2