- Kimchi-devel - oVirt List Archives

[PATCHv2 0/3] UI: Manage guest disk
by lvroyce＠linux.vnet.ibm.com 23 Apr '14

23 Apr '14

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> This patchset fix bug relating to select menu, Add guest disk attach/detach ui support, choose reasonable bus as default for disk/cdrom, refresh the disk display view. Royce Lv (3): Fix select menu data append UI: Support add guest disk Display all disk types in storage edit view ui/css/theme-default/guest-storage-add.css | 16 +++++ ui/js/src/kimchi.guest_edit_main.js | 5 +- ui/js/src/kimchi.guest_storage_add.main.js | 110 +++++++++++++++++++++++++++-- ui/js/widgets/select-menu.js | 3 +- ui/pages/guest-edit.html.tmpl | 17 ++++- ui/pages/guest-storage-add.html.tmpl | 50 ++++++++++++- 6 files changed, 188 insertions(+), 13 deletions(-) -- 1.8.3.2

4 13

[PATCH] bug fix: from persistent xml get user and group
by shaohef＠linux.vnet.ibm.com 23 Apr '14

23 Apr '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> define domain just edit the persistent xml. So we should get user and group from persistent xml instead of live xml when domain is living. Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Signed-off-by: Royce Lv <lvroyce(a)linux.vnet.ibm.com> --- src/kimchi/model/vms.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/kimchi/model/vms.py b/src/kimchi/model/vms.py index 90e9537..2b9bf56 100644 --- a/src/kimchi/model/vms.py +++ b/src/kimchi/model/vms.py @@ -258,9 +258,11 @@ class VMModel(object): old_xml = new_xml = dom.XMLDesc(0) + meta_xml = (dom.XMLDesc(libvirt.VIR_DOMAIN_XML_INACTIVE) + if dom.isPersistent() else old_xml) metadata_xpath = "/domain/metadata/kimchi/access/%s" - users = xpath_get_text(old_xml, metadata_xpath % "user") - groups = xpath_get_text(old_xml, metadata_xpath % "group") + users = xpath_get_text(meta_xml, metadata_xpath % "user") + groups = xpath_get_text(meta_xml, metadata_xpath % "group") for key, val in params.items(): if key == 'users': -- 1.9.0

4 8

[PATCH 0/5] Add users and groups to VMs
by Aline Manera 22 Apr '14

22 Apr '14

From: Aline Manera <alinefm(a)br.ibm.com> This patch set is based on Cristian's patches. It uses the <metadata> tag to store users and groups to the VM XML. It does not uses virDomain.setMetadata() as it does not well in some libvirt versions. Aline Manera (4): Use proper term "user name" instead of "user id" Add functions to check if a user/group exists Return users and groups when fetching VM info Add/remove users and groups to VMs Crístian Viana (1): Override only the updated "User" methods in "patch_auth" docs/API.md | 6 ++++ po/en_US.po | 55 ++++++++++++++++++++++++++++-- po/kimchi.pot | 55 ++++++++++++++++++++++++++++-- po/pt_BR.po | 63 ++++++++++++++++++++++++++++++++--- po/zh_CN.po | 62 +++++++++++++++++++++++++++++++--- src/kimchi/API.json | 22 ++++++++++++ src/kimchi/auth.py | 60 ++++++++++++++++++++++----------- src/kimchi/control/vms.py | 6 ++-- src/kimchi/i18n.py | 10 ++++-- src/kimchi/mockmodel.py | 7 ++-- src/kimchi/model/vms.py | 68 ++++++++++++++++++++++++++++++++------ src/kimchi/root.py | 4 +-- tests/test_authorization.py | 19 +++++++++++ tests/test_mockmodel.py | 2 +- tests/test_model.py | 44 +++++++++++++++++++++++- tests/test_rest.py | 10 +++--- tests/utils.py | 26 ++++----------- ui/js/src/kimchi.login_window.js | 16 ++++----- ui/js/src/kimchi.user.js | 14 ++++---- ui/pages/login-window.html.tmpl | 4 +-- 20 files changed, 457 insertions(+), 96 deletions(-) -- 1.7.10.4

3 14

[PATCH V2 0/3] VM shutdown support in backend
by shaohef＠linux.vnet.ibm.com 22 Apr '14

22 Apr '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> V1 -> V2 update a new domain state pmsuspended ShaoHe Feng (3): VM shutdown support in backend VM shutdown support in UI New domain state pmsuspended docs/API.md | 3 +++ src/kimchi/control/vms.py | 1 + src/kimchi/i18n.py | 1 + src/kimchi/mockmodel.py | 3 +++ src/kimchi/model/vms.py | 11 ++++++++++- ui/js/src/kimchi.api.js | 11 +++++++++++ ui/js/src/kimchi.guest_main.js | 23 +++++++++++++++++++++++ ui/pages/guest.html.tmpl | 1 + ui/pages/i18n.html.tmpl | 2 ++ 9 files changed, 55 insertions(+), 1 deletion(-) -- 1.9.0

2 4

[PATCH 0/5] API to list system users and groups
by Aline Manera 22 Apr '14

22 Apr '14

From: Aline Manera <alinefm(a)br.ibm.com> While setting users and groups to a VM the user needs to know what are the available values. So add the following API: - /host/users: to list system users - /host/groups: to list system groups Aline Manera (5): Create a new common collection named SimpleCollection Add API to list system users and groups Update users/groups verification based on new API Remove unused code Update test cases src/kimchi/auth.py | 22 ---------------------- src/kimchi/control/base.py | 17 +++++++++++++++++ src/kimchi/control/host.py | 14 +++++++++++++- src/kimchi/control/plugins.py | 19 ++----------------- src/kimchi/i18n.py | 4 ++-- src/kimchi/mockmodel.py | 30 ++++++++++++++++++++++++------ src/kimchi/model/host.py | 18 ++++++++++++++++++ src/kimchi/model/vms.py | 20 ++++++++++++-------- tests/test_authorization.py | 19 ------------------- tests/test_model.py | 8 ++++---- tests/test_rest.py | 24 ++++++++++++++++++++---- 11 files changed, 112 insertions(+), 83 deletions(-) -- 1.7.10.4

2 11

[PATCH] Bug fix: add PYTHONPATH for contrib/check_i18n.py
by shaohef＠linux.vnet.ibm.com 22 Apr '14

22 Apr '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> for plugin i18n.py, it will import the base i18n.py The i18n.py may from install directory install of source directory. Signed-off-by: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> Signed-off-by: Mark Wu <wudxw(a)linux.vnet.ibm.com> Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index ca5623d..85949d8 100644 --- a/Makefile.am +++ b/Makefile.am @@ -81,7 +81,7 @@ I18N_FILES = plugins/*/i18n.py \ $(NULL) check-local: - contrib/check_i18n.py $(I18N_FILES) + PYTHONPATH=src contrib/check_i18n.py $(I18N_FILES) find . -path './.git' -prune -type f -o \ -name '*.py' -o -name '*.py.in' | xargs $(PYFLAKES) | \ grep -w -v $(SKIP_PYFLAKES_ERR) | \ -- 1.9.0

3 2

[PATCH] packaging: ship kimchi with plugins/__init__.py
by zhshzhou＠linux.vnet.ibm.com 22 Apr '14

22 Apr '14

From: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> If we do not package and install plugins/__init__.py, plugins can not be imported as "import kimchi.plugins.pluginXYZ". The plugins also can not be discovered and imported dynamically. This patch fixes the problem. Signed-off-by: Zhou Zheng Sheng <zhshzhou(a)linux.vnet.ibm.com> --- contrib/kimchi.spec.fedora.in | 1 + contrib/kimchi.spec.suse.in | 1 + plugins/Makefile.am | 5 ++++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in index 1cd99b0..62d3000 100644 --- a/contrib/kimchi.spec.fedora.in +++ b/contrib/kimchi.spec.fedora.in @@ -141,6 +141,7 @@ rm -rf $RPM_BUILD_ROOT %{python_sitelib}/kimchi/control/vm/*.py* %{python_sitelib}/kimchi/model/*.py* %{python_sitelib}/kimchi/API.json +%{python_sitelib}/kimchi/plugins/*.py* %{_datadir}/kimchi/doc/API.md %{_datadir}/kimchi/doc/README.md %{_datadir}/kimchi/doc/kimchi-guest.png diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in index efb2c08..524a000 100644 --- a/contrib/kimchi.spec.suse.in +++ b/contrib/kimchi.spec.suse.in @@ -67,6 +67,7 @@ rm -rf $RPM_BUILD_ROOT %{python_sitelib}/kimchi/control/vm/*.py* %{python_sitelib}/kimchi/model/*.py* %{python_sitelib}/kimchi/API.json +%{python_sitelib}/kimchi/plugins/*.py* %{_datadir}/kimchi/doc/API.md %{_datadir}/kimchi/doc/README.md %{_datadir}/kimchi/doc/kimchi-guest.png diff --git a/plugins/Makefile.am b/plugins/Makefile.am index 2ceedae..894d28e 100644 --- a/plugins/Makefile.am +++ b/plugins/Makefile.am @@ -19,4 +19,7 @@ SUBDIRS = sample -EXTRA_DIST = __init__.py +plugins_PYTHON = \ + __init__.py + +pluginsdir = $(pythondir)/kimchi/plugins -- 1.9.0

4 3

[PATCH V2 0/2] bug fix: from persistent xml get user and group
by shaohef＠linux.vnet.ibm.com 22 Apr '14

22 Apr '14

From: ShaoHe Feng <shaohef(a)linux.vnet.ibm.com> V1 -> V2: libvirt also support virDomain.metadata and virDomain.setMetadata two api. use virDomain.metadata to get the user and group. use virDomain.setMetadata to set the user and group. ShaoHe Feng (2): bug fix: get user and group metadata by libvirt virDomain.metadata API use libvirt api to set user and group metadata by virDomain.setMetadata API src/kimchi/i18n.py | 1 + src/kimchi/model/vms.py | 52 ++++++++++++++++++++++++++++++++++++++----------- 2 files changed, 42 insertions(+), 11 deletions(-) -- 1.9.0

3 4

[PATCH 0/2] UI support for manage guest disk
by lvroyce＠linux.vnet.ibm.com 22 Apr '14

22 Apr '14

From: Royce Lv <lvroyce(a)linux.vnet.ibm.com> Royce Lv (2): Fix select menu data append UI: Support add guest disk ui/css/theme-default/guest-storage-add.css | 16 +++++ ui/js/src/kimchi.guest_storage_add.main.js | 105 +++++++++++++++++++++++++++-- ui/js/widgets/select-menu.js | 1 + ui/pages/guest-storage-add.html.tmpl | 50 +++++++++++++- 4 files changed, 165 insertions(+), 7 deletions(-) -- 1.8.3.2

3 5

[PATCH] Github #329: Packaging - Update Fedora spec file to address SELinux
by Paulo Vital 22 Apr '14

22 Apr '14

Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- contrib/kimchi.spec.fedora.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in index 77bf6bf..185f0ff 100644 --- a/contrib/kimchi.spec.fedora.in +++ b/contrib/kimchi.spec.fedora.in @@ -105,6 +105,8 @@ iptables -I INPUT -p tcp --dport 8001 -j ACCEPT iptables -I INPUT -p tcp --dport 64667 -j ACCEPT service iptables save >/dev/null 2>&1 %endif +# Add SELinux rules to "open" Kimchi ports +semanage permissive -a httpd_t %preun @@ -129,6 +131,8 @@ if [ "$1" -ge 1 ] ; then /bin/systemctl try-restart kimchid.service >/dev/null 2>&1 || : fi exit 0 +# Rollback SELinux rules +semanage permissive -d httpd_t %clean -- 1.8.3.1

2 1