- Kimchi-devel - oVirt List Archives

Cleaning up Datastore errors?
by wk 20 Mar '17

20 Mar '17

Heh, originally sent to -users but evidently noone looks at that. -------------- Our kimchi hosts have people constantly working on from the command line including changing qcow2 image names (our practice is to name them similar to the instance name so its easy to see whats up in /var/lib/libvirt/images) So after a while the wok error log is full of these messages. and we often get reoccuring pink error messages in the WebUI. Is there a way to cleanout/fix/ignore the datastore for those of use who also work directly with libvirt. -bill WOKOBJST0001E: Unable to find 5f48fb31-0d73-4df7-948c-02beefee83d1 in datastore WOKOBJST0001E: Unable to find c7d94dcb-185f-4917-9b2e-d304f5ce807b in datastore WOKOBJST0001E: Unable to find d7f82fc8-44dd-484f-aaf9-f4ed0de3efe3 in datastore WOKOBJST0001E: Unable to find f88269b8-8ca9-4689-b8aa-c7e720e3c396 in datastore WOKOBJST0001E: Unable to find b46491f9-4351-4b82-ad57-87568dd55f3e in datastore WOKOBJST0001E: Unable to find 7c34a9fd-b3b6-4894-a6f1-baf6b7099403 in datastore WOKOBJST0001E: Unable to find 0eb316fe-803c-4b25-9dae-522c02748e5c in datastore WOKOBJST0001E: Unable to find 4e5663b8-300d-4ad0-8959-ecdc489e8c71 in datastore WOKOBJST0001E: Unable to find 5f48fb31-0d73-4df7-948c-02beefee83d1 in datastore WOKOBJST0001E: Unable to find c7d94dcb-185f-4917-9b2e-d304f5ce807b in datastore

3 2

[PATCH] python-mock not listed as dependency
by Ramon Medeiros 16 Mar '17

16 Mar '17

Signed-off-by: Ramon Medeiros <ramonn(a)linux.vnet.ibm.com> --- docs/fedora-deps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/fedora-deps.md b/docs/fedora-deps.md index 29b477f..484f409 100644 --- a/docs/fedora-deps.md +++ b/docs/fedora-deps.md @@ -42,7 +42,7 @@ Packages required for UI development Packages required for tests --------------------------- - $ sudo yum install pyflakes python-pep8 python-requests rpmlint + $ sudo yum install pyflakes python-pep8 python-requests rpmlint python-mock # For RHEL systems, install the additional packages: $ sudo yum install python-unittest2 -- 2.9.3

1 1

[PATCH] [Wok] Bug fix #207: Fix LDAPUser class initialization
by Aline Manera 15 Mar '17

15 Mar '17

It was wrongly calling PAMUser instance on LDAPUser class initialization. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- src/wok/auth.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wok/auth.py b/src/wok/auth.py index 976d729..0ad1893 100644 --- a/src/wok/auth.py +++ b/src/wok/auth.py @@ -192,7 +192,7 @@ class LDAPUser(User): auth_type = "ldap" def __init__(self, username): - super(PAMUser, self).__init__(username) + super(LDAPUser, self).__init__(username) @staticmethod def authenticate(username, password): -- 2.9.3

2 2

[PATCH] [Kimchi] Bug fix #1107: Only set cache=none to disks that support direct IO
by Aline Manera 13 Mar '17

13 Mar '17

ZFS volumes and GlusterFS does not support direct IO and setting cache=none will not allow the guest to start. So only set cache=none when direct IO is supported to avoid problems. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- xmlutils/disk.py | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/xmlutils/disk.py b/xmlutils/disk.py index 02d6811..97298c5 100644 --- a/xmlutils/disk.py +++ b/xmlutils/disk.py @@ -1,7 +1,7 @@ # # Project Kimchi # -# Copyright IBM Corp, 2015-2016 +# Copyright IBM Corp, 2015-2017 # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Lesser General Public @@ -17,6 +17,7 @@ # License along with this library; if not, write to the Free Software # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +import errno import lxml.etree as ET import os import socket @@ -28,7 +29,7 @@ from lxml.builder import E from wok.exception import InvalidParameter, NotFoundError from wok.plugins.kimchi.utils import check_url_path - +from wok.utils import wok_log BUS_TO_DEV_MAP = {'ide': 'hd', 'virtio': 'vd', 'scsi': 'sd'} DEV_TYPE_SRC_ATTR_MAP = {'file': 'file', 'block': 'dev'} @@ -51,11 +52,22 @@ def get_disk_xml(params): disk_type = _get_disk_type(path) if len(path) > 0 else 'file' disk = E.disk(type=disk_type, device=params['type']) driver = E.driver(name='qemu', type=params['format']) - if params['type'] != 'cdrom': - driver.set('cache', 'none') + try: + fd = os.open(path, os.O_RDONLY | os.O_DIRECT) + os.close(fd) + wok_log.debug("Disk '%s' supports direct I/O. Setting cache=none" + "to enable live migration" % path) + except OSError, e: + if e.errno == errno.EINVAL: + wok_log.debug("Disk '%s' does not support direct I/O: " + "'%s'. Let libvirt sets the default cache mode." % + (path, e.message)) + else: + if params['type'] != 'cdrom': + driver.set('cache', 'none') - if params.get('pool_type') == "netfs": - driver.set("io", "native") + if params.get('pool_type') == "netfs": + driver.set("io", "native") disk.append(driver) -- 2.9.3

2 2

[PATCH] [Kimchi 0/2] Run wok tests without administration permissions
by Lucio Correia 13 Mar '17

13 Mar '17

Lucio Correia (2): Fix tests to run without proxy Remove test for HTTP error 413 tests/test_model_storagevolume.py | 24 ++---------------------- tests/test_rest.py | 16 ++++++++-------- 2 files changed, 10 insertions(+), 30 deletions(-) -- 2.7.4

3 6

[PATCH v3] [Kimchi] Remove websocket initialization from Kimchi
by dhbarboza82＠gmail.com 13 Mar '17

13 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v3: - changed tearDown() to tearDownModule() in test_mockmodel.py v2: - removed websockify references from docs and build files. *** ATTENTION: REQUIRES '[WoK] Asynchronous UI notification implementation' PATCH *** Daniel Henrique Barboza (1): Use Websocket facilities from WoK contrib/DEBIAN/control.in | 1 - contrib/kimchi.spec.fedora.in | 1 - contrib/kimchi.spec.suse.in | 1 - docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 3 +- docs/ubuntu-deps.md | 2 +- model/vms.py | 2 +- root.py | 4 +- tests/test_mockmodel.py | 2 +- websocket.py | 121 ------------------------------------------ 10 files changed, 6 insertions(+), 133 deletions(-) delete mode 100644 websocket.py -- 2.9.3

2 3

[PATCH] [Kimchi 0/8] Run test_model with regular user
by Lucio Correia 10 Mar '17

10 Mar '17

Lucio Correia (8): Do not hardcode default directories Always use /var/tmp to store test files Mock default storage pools and networks for testing Use "qemu:///session" as test_model libvirt uri Remove 'run as root' requirement from some tests Skip tests that need to run as root Make test_use_test_host architecture independent Mock user probe functions model/storagepools.py | 5 +- osinfo.py | 12 +- tests/test_model.py | 407 +++++++++++++++++++++++++++++++++++++------------- 3 files changed, 321 insertions(+), 103 deletions(-) -- 2.7.4

1 8

[PATCH v4] [WoK] Asynchronous UI notification implementation
by dhbarboza82＠gmail.com 10 Mar '17

10 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v4: - server_loop with the socket listen was daemonized v3: - changed listener registration to be message specific instead of generic. v2: - Simplified UI code. Using now an array instead of a hashmap to prevent the need of inserting a listener identifier; - Changed the push server initialization. Moved it to server.py to avoid execution in the unit tests, but allow execution in the test mode. Do the same treatment with the ws_proxy initialization; - Socket file was moved to /run/user/<user_id>/woknotifications - Inserted notifications in base model level. Put code in base WoK classes to allow notifications for every model event without the need of adding it manually; - Standardization of messages sent. Messages are being sent in the pattern METHOD:plugin/entity/action; - Minor code fixes (imports, remove kimchi references); - Added websockify as a WoK runtime dependency. See patch commit message for more information. Daniel Henrique Barboza (1): Asynchronous UI notification implementation contrib/DEBIAN/control.in | 1 + contrib/wok.spec.fedora.in | 1 + contrib/wok.spec.suse.in | 1 + docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 3 +- docs/ubuntu-deps.md | 3 +- src/wok/config.py.in | 8 ++ src/wok/control/base.py | 16 ++-- src/wok/model/notifications.py | 2 +- src/wok/pushserver.py | 164 +++++++++++++++++++++++++++++++++++++++++ src/wok/reqlogger.py | 11 ++- src/wok/root.py | 3 + src/wok/server.py | 13 +++- src/wok/websocket.py | 123 +++++++++++++++++++++++++++++++ ui/js/src/wok.main.js | 54 ++++++++++++++ ui/js/wok.user-log.js | 4 + 16 files changed, 395 insertions(+), 14 deletions(-) create mode 100644 src/wok/pushserver.py create mode 100644 src/wok/websocket.py -- 2.9.3

2 2

[PATCH] [Kimchi] Use Websocket facilities from WoK
by dhbarboza82＠gmail.com 10 Mar '17

10 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> *** ATTENTION: REQUIRES '[WoK] Asynchronous UI notification implementation' PATCH *** Daniel Henrique Barboza (1): Use Websocket facilities from WoK model/vms.py | 2 +- root.py | 4 +- websocket.py | 121 ----------------------------------------------------------- 3 files changed, 2 insertions(+), 125 deletions(-) delete mode 100644 websocket.py -- 2.9.3

4 4

[PATCH v2] [Kimchi] Remove websocket initialization from Kimchi
by dhbarboza82＠gmail.com 10 Mar '17

10 Mar '17

From: Daniel Henrique Barboza <danielhb(a)linux.vnet.ibm.com> v2: - removed websockify references from docs and build files. *** ATTENTION: REQUIRES '[WoK] Asynchronous UI notification implementation' PATCH *** Daniel Henrique Barboza (1): Use Websocket facilities from WoK contrib/DEBIAN/control.in | 1 - contrib/kimchi.spec.fedora.in | 1 - contrib/kimchi.spec.suse.in | 1 - docs/fedora-deps.md | 2 +- docs/opensuse-deps.md | 3 +- docs/ubuntu-deps.md | 2 +- model/vms.py | 2 +- root.py | 4 +- websocket.py | 121 ------------------------------------------ 9 files changed, 5 insertions(+), 132 deletions(-) delete mode 100644 websocket.py -- 2.9.3

1 1