- Kimchi-devel - oVirt List Archives

[PATCH] [Kimchi] Add support to Libvirt Events.
by pvital＠linux.vnet.ibm.com 17 May '16

17 May '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch adds support to handle in Kimchi any Libvirt Event, just by adding a callback to process the event and register the event with the callback. None event is being registered by this patch and they need be added by developer by demand in the code. To see how register an event, the unit test test_libvirtevents.py register two events and then use them in the code. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- i18n.py | 3 + model/libvirtevents.py | 59 ++++++++++ model/model.py | 5 +- tests/test_model_libvirtevents.py | 219 ++++++++++++++++++++++++++++++++++++++ 4 files changed, 285 insertions(+), 1 deletion(-) create mode 100644 model/libvirtevents.py create mode 100644 tests/test_model_libvirtevents.py diff --git a/i18n.py b/i18n.py index 2301e60..49b7f1c 100644 --- a/i18n.py +++ b/i18n.py @@ -334,4 +334,7 @@ messages = { "KCHCONN0001E": _("Unable to establish connection with libvirt. Please check your libvirt URI which is often defined in /etc/libvirt/libvirt.conf"), "KCHCONN0002E": _("Libvirt service is not active. Please start the libvirt service in your host system."), + "KCHEVENT0001E": _("Failed to register the default event implementation."), + "KCHEVENT0002E": _("Failed to register timeout event."), + "KCHEVENT0003E": _("Failed to Run the default event implementation."), } diff --git a/model/libvirtevents.py b/model/libvirtevents.py new file mode 100644 index 0000000..ab5c17d --- /dev/null +++ b/model/libvirtevents.py @@ -0,0 +1,59 @@ +# +# Project Kimchi +# +# Copyright IBM Corp, 2016 +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +import cherrypy +import libvirt +import time + +from wok.exception import OperationFailed + + +class LibvirtEvents(object): + def __init__(self): + # Register default implementation of event handlers + if libvirt.virEventRegisterDefaultImpl() < 0: + raise OperationFailed('KCHEVENT0001E') + + # Run a background thread with the event loop. Using cherrypy + # BackgroundTask class due to issues when using threading module with + # cherrypy. + self.event_loop_thread = cherrypy.process.plugins.BackgroundTask( + 2, + self._event_loop_run + ) + self.event_loop_thread.setName('KimchiLibvirtEventLoop') + self.event_loop_thread.setDaemon(True) + self.event_loop_thread.start() + + # Set an event timeout to control the self._event_loop_run + if libvirt.virEventAddTimeout(0, self._kimchi_EventTimeout, None) < 0: + raise OperationFailed('KCHEVENT0002E') + + # Event loop method to be executed in background as thread + def _event_loop_run(self): + while True: + if libvirt.virEventRunDefaultImpl() < 0: + raise OperationFailed('KCHEVENT0003E') + + def is_event_loop_alive(self): + return self.event_loop_thread.isAlive() + + # Event loop handler used to limit length of waiting for any other event. + def _kimchi_EventTimeout(self, timer, opaque): + time.sleep(1) diff --git a/model/model.py b/model/model.py index e44f804..ed474d2 100644 --- a/model/model.py +++ b/model/model.py @@ -26,6 +26,7 @@ from wok.plugins.kimchi import config from wok.utils import import_module, listPathModules from wok.plugins.kimchi.model.libvirtconnection import LibvirtConnection +from wok.plugins.kimchi.model.libvirtevents import LibvirtEvents class Model(BaseModel): @@ -43,8 +44,10 @@ class Model(BaseModel): return instances self.objstore = ObjectStore(objstore_loc or config.get_object_store()) + self.events = LibvirtEvents() self.conn = LibvirtConnection(libvirt_uri) - kargs = {'objstore': self.objstore, 'conn': self.conn} + kargs = {'objstore': self.objstore, 'conn': self.conn, + 'eventsloop': self.events} models = [] # Import task model from Wok diff --git a/tests/test_model_libvirtevents.py b/tests/test_model_libvirtevents.py new file mode 100644 index 0000000..d7dc675 --- /dev/null +++ b/tests/test_model_libvirtevents.py @@ -0,0 +1,219 @@ +# -*- coding: utf-8 -*- +# +# Project Kimchi +# +# Copyright IBM Corp, 2016 +# +# This library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. +# +# This library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. +# +# You should have received a copy of the GNU Lesser General Public +# License along with this library; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + +import json +import libvirt +import os +import shutil +import tempfile +import time +import unittest + +import tests.utils as utils + +from wok.basemodel import Singleton +from wok.rollbackcontext import RollbackContext + +from wok.plugins.kimchi.model import model + +import iso_gen + + +TMP_DIR = '/var/lib/kimchi/tests/' +UBUNTU_ISO = TMP_DIR + 'ubuntu14.04.iso' +TMP_EVENT = None +EVENT_ID = 0 + + +def setUpModule(): + global TMP_DIR, TMP_EVENT + + if not os.path.exists(TMP_DIR): + os.makedirs(TMP_DIR) + + TMP_EVENT = tempfile.mktemp() + + iso_gen.construct_fake_iso(UBUNTU_ISO, True, '14.04', 'ubuntu') + + # Some FeatureTests functions depend on server to validate their result. + # As CapabilitiesModel is a Singleton class it will get the first result + # from FeatureTests which may be wrong when using the Model instance + # directly - the case of this test_model.py + # So clean Singleton instances to make sure to get the right result when + # running the following tests. + Singleton._instances = {} + + +def tearDownModule(): + global TMP_DIR, TMP_EVENT + + os.unlink(TMP_EVENT) + shutil.rmtree(TMP_DIR) + + +def _get_next_event_id(): + global EVENT_ID + EVENT_ID += 1 + return EVENT_ID + + +def _get_event_id(): + global EVENT_ID + return EVENT_ID + + +def _store_event(data): + global TMP_EVENT + with open(TMP_EVENT, "a") as file: + file.write("%s\n" % data) + + +def _get_event(id): + global TMP_EVENT + with open(TMP_EVENT, "r") as file: + for event in [line.rstrip('\n') for line in file.readlines()]: + fields = event.split('|') + if fields[0] == id: + return fields[1] + + +class LibvirtEventsTests(unittest.TestCase): + def setUp(self): + self.tmp_store = tempfile.mktemp() + + def tearDown(self): + os.unlink(self.tmp_store) + + def domain_event_lifecycle_cb(self, conn, dom, event, detail, *args): + """ + Callback to handle Domain (VMs) events - VM Livecycle. + """ + evStrings = ("Defined", "Undefined", "Started", "Suspended", "Resumed", + "Stopped", "Shutdown", "PMSuspended", "Crashed") + evDetails = (("Added", "Updated"), + ("Removed", ), + ("Booted", "Migrated", "Restored", "Snapshot", "Wakeup"), + ("Paused", "Migrated", "IOError", "Watchdog", "Restored", + "Snapshot", "API error"), + ("Unpaused", "Migrated", "Snapshot"), + ("Shutdown", "Destroyed", "Crashed", "Migrated", "Saved", + "Failed", "Snapshot"), + ("Finished", ), + ("Memory", "Disk"), + ("Panicked")) + + data = {'domain': dom.name(), 'event': evStrings[event], + 'event_detail': evDetails[event][detail]} + _store_event('%s|%s' % (_get_next_event_id(), json.dumps(data))) + + def domain_event_reboot_cb(self, conn, dom, *args): + """ + Callback to handle Domain (VMs) events - VM Reboot. + """ + data = {'domain': dom.name(), 'event': 'Rebooted'} + _store_event('%s|%s' % (_get_next_event_id(), json.dumps(data))) + + @unittest.skipUnless(utils.running_as_root(), 'Must be run as root') + def test_events_vm_lifecycle(self): + inst = model.Model(objstore_loc=self.tmp_store) + self.objstore = inst.objstore + conn = inst.conn.get() + + # Create a template and VM to test, and start lifecycle tests + with RollbackContext() as rollback: + # Register the most common Libvirt domain events to be handled. + event_map = [(libvirt.VIR_DOMAIN_EVENT_ID_LIFECYCLE, + self.domain_event_lifecycle_cb), + (libvirt.VIR_DOMAIN_EVENT_ID_REBOOT, + self.domain_event_reboot_cb)] + + for event, event_cb in event_map: + ev_id = conn.domainEventRegisterAny(None, event, event_cb, + None) + rollback.prependDefer(conn.domainEventDeregisterAny, ev_id) + + # Create a template + template_params = {'name': 'ttest', + 'source_media': {'type': 'disk', + 'path': UBUNTU_ISO}} + + inst.templates_create(template_params) + rollback.prependDefer(inst.template_delete, 'ttest') + + # Create a VM (guest) + vm_params = {'name': 'kimchi-vm1', + 'template': '/plugins/kimchi/templates/ttest'} + task = inst.vms_create(vm_params) + inst.task_wait(task['id'], 10) + task = inst.task_lookup(task['id']) + self.assertEquals('finished', task['status']) + time.sleep(5) + # Check event of domain definition (addition) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Defined', res['event']) + self.assertEquals('Added', res['event_detail']) + + # Start the VM and check the event + inst.vm_start('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Started', res['event']) + self.assertEquals('Booted', res['event_detail']) + + # Suspend the VM and check the event + inst.vm_suspend('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Suspended', res['event']) + self.assertEquals('Paused', res['event_detail']) + + # Resume the VM and check the event + inst.vm_resume('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Resumed', res['event']) + self.assertEquals('Unpaused', res['event_detail']) + + # Reboot the VM and check the event + inst.vm_reset('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Rebooted', res['event']) + + # PowerOff (hard stop) the VM and check the event + inst.vm_poweroff('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Stopped', res['event']) + self.assertEquals('Destroyed', res['event_detail']) + + # Delete the VM and check the event + inst.vm_delete('kimchi-vm1') + time.sleep(5) + res = json.loads(_get_event(str(_get_event_id()))) + self.assertEquals('kimchi-vm1', res['domain']) + self.assertEquals('Undefined', res['event']) + self.assertEquals('Removed', res['event_detail']) -- 2.5.5

2 1

[PATCH] [Kimchi] Isolate unit tests execution.
by pvital＠linux.vnet.ibm.com 17 May '16

17 May '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> This patch isolates each unit test execution reducing the occurrences of tests using data from previous unit tests and making results not reliable. In addition, it also simplifies the output of tests execution, printing the tags PASSED and FAILED and the error/failed banners only when necessary. Signed-off-by: Paulo Vital <pvital(a)linux.vnet.ibm.com> --- tests/run_tests.sh.in | 53 +++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 41 insertions(+), 12 deletions(-) diff --git a/tests/run_tests.sh.in b/tests/run_tests.sh.in index 68dfa2e..d9c2661 100644 --- a/tests/run_tests.sh.in +++ b/tests/run_tests.sh.in @@ -21,6 +21,10 @@ HAVE_UNITTEST=@HAVE_PYMOD_UNITTEST@ PYTHON_VER=@PYTHON_VERSION@ +RED='\033[0;31m' +GREEN='\033[0;32m' +NC='\033[0m' # No Color + if [ "$1" = "-v" ]; then OPTS="-v" shift @@ -40,19 +44,44 @@ else CMD="python -m unittest" fi -LIST=($ARGS) -MODEL_LIST=() -MOCK_LIST=() -for ((i=0;i<${#LIST[@]};i++)); do - - if [[ ${LIST[$i]} == test_model* ]]; then - MODEL_LIST+=(${LIST[$i]}) +NUM_TESTS=0 +TIME=0 +declare -A FAILED_UT # dict to store failed unit tests and its OUTPUT_FILE +for UT in $ARGS; do + OUTPUT_FILE=$(mktemp) + echo -n "***** Running unit test: $UT... " + # ../../../../../ refers to the project root + # ../../../../ refers to wok directory + # ../../../ refers to plugins directory + PYTHONPATH=../../../../../:../../../../:../../../ \ + PYTHONWARNINGS="ignore:Unverified HTTPS request" \ + $CMD $OPTS $UT &> $OUTPUT_FILE + RES=$? + if [ $RES -ne 0 ]; then + # unit test has failed, so keep the OUTPUT_FILE and print the results + echo -e "\t ${RED}FAILED${NC}" + ERROR_LOG_BEGIN=$(grep -n "^\==*" $OUTPUT_FILE | head -n1 | cut -d":" -f1) + ERROR_LOG_END=$(cat $OUTPUT_FILE | wc -l) + tail -n $((${ERROR_LOG_END}-${ERROR_LOG_BEGIN}+1)) $OUTPUT_FILE + FAILED_UT+=([$UT]=$OUTPUT_FILE) + OUTPUT=$(grep "Ran" $OUTPUT_FILE) else - MOCK_LIST+=(${LIST[$i]}) + # unit test has passed, so print the results and delete the OUTPUT_FILE + OUTPUT=$(grep "Ran" $OUTPUT_FILE) + echo -e "\t ${GREEN}PASSED${NC} - $OUTPUT" + rm -rf $OUTPUT_FILE fi + TES=$(echo $OUTPUT | cut -d" " -f2) + NUM_TESTS=$(echo "$NUM_TESTS + $TES" | bc) + TES=$(echo $OUTPUT | cut -d" " -f5) + TIME=$(echo "$TIME + ${TES:0:-1}" | bc) done -# ../../../../../ refers to the project root -# ../../../../ refers to wok directory -# ../../../ refers to plugins directory -PYTHONPATH=../../../../../:../../../../:../../../ PYTHONWARNINGS="ignore:Unverified HTTPS request" $CMD $OPTS ${MODEL_LIST[@]} ${MOCK_LIST[@]} +# Print summary results +echo -e "======================================================================" +echo -e "===================== Kimchi Unit Tests Summary ======================" +echo -e "Ran $NUM_TESTS tests in $TIME seconds." +for i in "${!FAILED_UT[@]}"; do + FAIL_STATS=$(grep FAILED ${FAILED_UT[$i]} | cut -d" " -f2-4) + echo -e "$i FAILED: $FAIL_STATS - log available at ${FAILED_UT[$i]}" +done -- 2.5.5

1 0

[PATCH] [Kimchi] [RFC] Storave Volume management UI
by sguimaraes943＠gmail.com 16 May '16

16 May '16

From: Samuel Guimarães <sguimaraes943(a)gmail.com> This patch adds the UI for Storage Volume management action button, filter input, gallery view and gallery / list view toggle-switch button with multi-selection enabled. This is just the initial patch for the UI to get feedback, will add Storage Volume modal and confirm windows and map create, delete, resize, wipe and clone actions in the next commit. Samuel Guimarães (1): Storave Volume management UI ui/css/kimchi.css | 266 +++++++++++++++++++++++++++++------- ui/css/src/modules/_storage.scss | 287 +++++++++++++++++++++++++++++++++------ ui/js/src/kimchi.storage_main.js | 82 +++++------ ui/pages/tabs/storage.html.tmpl | 121 +++++++++++------ 4 files changed, 576 insertions(+), 180 deletions(-) -- 1.9.3

3 4

[RFC] [Kimchi] First pass at Edit Virtual Network UI
by Socorro Stoppler 16 May '16

16 May '16

- First attempt of Edit Virtual Network UI - Known UI Issues:s - after the update happens, the list of networks are not shown properly (i.e. rows are all bunched up and actions buttons are diagonal, but fixes itself after you move off the tab and come back to it - when edit panel first opens up, the value for the Destination selector (if applicable) is either showing 'Nothing selected' or it's showing the first item on the list rather than the value that came from backend - Bridged network has not been tested so there's bound to be issues there Proposal: Per discussion w/Lucio, with regards to vlan_id, I'd like to propose to have the backend show the vlan_id as a separate field. This came about when I couldn't find that field and as it turns out, it was because it was appended to the interface name.s Socorro Stoppler (1): First pass Edit Virtual Network ui/js/src/kimchi.api.js | 23 ++++ ui/js/src/kimchi.network.js | 14 +++ ui/js/src/kimchi.network_edit_main.js | 216 ++++++++++++++++++++++++++++++++++ ui/pages/network-edit.html.tmpl | 75 ++++++++++++ ui/pages/tabs/network.html.tmpl | 3 +- 5 files changed, 330 insertions(+), 1 deletion(-) create mode 100644 ui/js/src/kimchi.network_edit_main.js create mode 100644 ui/pages/network-edit.html.tmpl -- 2.5.0

2 4

[PATCH] [Kimchi] Fix issue on network update
by Lucio Correia 16 May '16

16 May '16

When network is not renamed, we need 'name' value in info dict, since name will not be returned by GET. Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- model/networks.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model/networks.py b/model/networks.py index 333ea6d..cc59ca8 100644 --- a/model/networks.py +++ b/model/networks.py @@ -504,8 +504,8 @@ class NetworkModel(object): def update(self, name, params): info = self.lookup(name) + info['name'] = name original = copy.deepcopy(info) - original['name'] = name # validate update parameters connection = info['connection'] -- 1.9.1

1 0

[PATCH] [Wok] Bug fix: Add space to separate class names
by Aline Manera 16 May '16

16 May '16

Commit d4b0c5, added the following: 'data-converter=' + fields[i]["converter"] : '' but as it is string concatenation, we need to add an space before "data-converter" to do not wrongly merge strings. ' data-converter=' + fields[i]["converter"] : '', This turns back the plugin color when displaying user log activity. Signed-off-by: Aline Manera <alinefm(a)linux.vnet.ibm.com> --- ui/js/wok.bootgrid.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/js/wok.bootgrid.js b/ui/js/wok.bootgrid.js index c4082dd..7d634bb 100644 --- a/ui/js/wok.bootgrid.js +++ b/ui/js/wok.bootgrid.js @@ -50,7 +50,7 @@ wok.createBootgrid = function(opts) { for (var i = 0; i < fields.length; i++) { var columnHtml = [ - '<th data-type="', fields[i]["type"], '" data-column-id="', fields[i]["column-id"], '"', (fields[i].identifier) ? 'data-identifier="true"' : '', ("header-class" in fields[i]) ? 'data-header-css-class="gridHeader ' + fields[i]["header-class"] + '"' : 'gridHeader', ("data-class" in fields[i]) ? ' data-align="' + fields[i]["data-class"] + '"' + ' headerAlign="center"' : ' data-align="left" headerAlign="center"', ("formatter" in fields[i]) ? 'data-formatter=' + fields[i]["formatter"] : '', (fields[i].width) ? (' data-width="' + fields[i].width + '"') : '', ("converter" in fields[i]) ? 'data-converter=' + fields[i]["converter"] : '', + '<th data-type="', fields[i]["type"], '" data-column-id="', fields[i]["column-id"], '"', (fields[i].identifier) ? 'data-identifier="true"' : '', ("header-class" in fields[i]) ? 'data-header-css-class="gridHeader ' + fields[i]["header-class"] + '"' : 'gridHeader', ("data-class" in fields[i]) ? ' data-align="' + fields[i]["data-class"] + '"' + ' headerAlign="center"' : ' data-align="left" headerAlign="center"', ("formatter" in fields[i]) ? 'data-formatter=' + fields[i]["formatter"] : '', (fields[i].width) ? (' data-width="' + fields[i].width + '"') : '', ("converter" in fields[i]) ? ' data-converter=' + fields[i]["converter"] : '', '>', ("title" in fields[i]) ? fields[i]["title"] : fields[i]["column-id"], '</th>' ].join(''); -- 2.5.5

2 2

[PATCH V2] [Kimchi 0/3] Issue #201: Handling libvirt connection failures.
by pvital＠linux.vnet.ibm.com 13 May '16

13 May '16

From: Paulo Vital <pvital(a)linux.vnet.ibm.com> V1 -> V2: * Adapted to use the latest notifications changes from Wok * Aesthetic changes V1: This is the backend part of the solution to solve issue #201. Frontend still needs some updates to provide more information to user. Paulo Vital (3): Update Kimchi config file for Systemd service Make Cheerypy up if not able to connect to libvirt Add support to check if libvirtd is running. contrib/kimchid.service.fedora | 3 ++- contrib/kimchid.service.ubuntu | 3 ++- i18n.py | 3 +++ model/config.py | 17 +++++++++++++++-- model/libvirtconnection.py | 13 +++++++++++-- model/templates.py | 5 ++++- utils.py | 16 +++++++++++++++- 7 files changed, 52 insertions(+), 8 deletions(-) -- 2.5.5

2 7

[PATCH] [Kimchi 2/2] Use verbs in the past
by Lucio Correia 13 May '16

13 May '16

Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- i18n.py | 86 ++++++++++++++++++++++++++++++++--------------------------------- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/i18n.py b/i18n.py index 7baa3b6..2b8c205 100644 --- a/i18n.py +++ b/i18n.py @@ -332,48 +332,48 @@ messages = { "KCHLVMS0001E": _("Invalid volume group name parameter: %(name)s."), # These messages (ending with L) are for user log purposes - "KCHNET0001L": _("Create %(connection)s virtual network '%(name)s'"), - "KCHNET0002L": _("Remove virtual network '%(ident)s'"), - "KCHNET0003L": _("Update virtual network '%(ident)s'"), - "KCHNET0004L": _("Activate virtual network '%(ident)s'"), - "KCHNET0005L": _("Deactivate virtual network '%(ident)s'"), - "KCHPOOL0001L": _("Create %(type)s storage pool '%(name)s'"), - "KCHPOOL0002L": _("Remove storage pool '%(ident)s'"), - "KCHPOOL0003L": _("Update storage pool '%(ident)s'"), - "KCHPOOL0004L": _("Activate storage pool '%(ident)s'"), - "KCHPOOL0005L": _("Deactivate storage pool '%(ident)s'"), - "KCHSNAP0001L": _("Create snapshot '%(name)s' at guest '%(vm)s'"), - "KCHSNAP0002L": _("Remove snapshot '%(ident)s' from guest '%(vm)s'"), - "KCHSNAP0003L": _("Revert guest '%(vm)s' to snapshot '%(ident)s'"), - "KCHTMPL0001L": _("Create template '%(name)s'"), - "KCHTMPL0002L": _("Remove template '%(ident)s'"), - "KCHTMPL0003L": _("Update template '%(ident)s'"), - "KCHTMPL0004L": _("Clone template '%(ident)s'"), - "KCHVM0001L": _("Create guest '%(name)s' from template '%(template)s'"), - "KCHVM0002L": _("Remove guest '%(ident)s'"), - "KCHVM0003L": _("Edit guest '%(ident)s'"), - "KCHVM0004L": _("Start guest '%(ident)s'"), - "KCHVM0005L": _("Power off guest '%(ident)s'"), + "KCHNET0001L": _("Created %(connection)s virtual network '%(name)s'"), + "KCHNET0002L": _("Removed virtual network '%(ident)s'"), + "KCHNET0003L": _("Updated virtual network '%(ident)s'"), + "KCHNET0004L": _("Activated virtual network '%(ident)s'"), + "KCHNET0005L": _("Deactivated virtual network '%(ident)s'"), + "KCHPOOL0001L": _("Created %(type)s storage pool '%(name)s'"), + "KCHPOOL0002L": _("Removed storage pool '%(ident)s'"), + "KCHPOOL0003L": _("Updated storage pool '%(ident)s'"), + "KCHPOOL0004L": _("Activated storage pool '%(ident)s'"), + "KCHPOOL0005L": _("Deactivated storage pool '%(ident)s'"), + "KCHSNAP0001L": _("Created snapshot '%(name)s' at guest '%(vm)s'"), + "KCHSNAP0002L": _("Removed snapshot '%(ident)s' from guest '%(vm)s'"), + "KCHSNAP0003L": _("Reverted guest '%(vm)s' to snapshot '%(ident)s'"), + "KCHTMPL0001L": _("Created template '%(name)s'"), + "KCHTMPL0002L": _("Removed template '%(ident)s'"), + "KCHTMPL0003L": _("Updated template '%(ident)s'"), + "KCHTMPL0004L": _("Cloned template '%(ident)s'"), + "KCHVM0001L": _("Created guest '%(name)s' from template '%(template)s'"), + "KCHVM0002L": _("Removed guest '%(ident)s'"), + "KCHVM0003L": _("Edited guest '%(ident)s'"), + "KCHVM0004L": _("Started guest '%(ident)s'"), + "KCHVM0005L": _("Powered off guest '%(ident)s'"), "KCHVM0006L": _("Shutdown guest '%(ident)s'"), - "KCHVM0007L": _("Restart guest '%(ident)s'"), - "KCHVM0008L": _("Connect to guest '%(ident)s' through novnc/spice"), - "KCHVM0009L": _("Clone guest '%(ident)s'"), - "KCHVM0010L": _("Migrate guest '%(ident)s' to '%(remote_host)s'"), - "KCHVM0011L": _("Suspend guest '%(ident)s'"), - "KCHVM0012L": _("Resume guest '%(ident)s'"), - "KCHVM0013L": _("Connect to guest '%(ident)s' through serial"), - "KCHVMHDEV0001L": _("Attach host device '%(name)s' to guest '%(vmid)s'"), - "KCHVMHDEV0002L": _("Detach host device '%(ident)s' from guest '%(vmid)s'"), - "KCHVMIF0001L": _("Attach network interface '%(network)s' to guest '%(vm)s'"), - "KCHVMIF0002L": _("Detach network interface '%(ident)s' from guest '%(vm)s'"), - "KCHVMIF0003L": _("Update network interface '%(ident)s' at guest '%(vm)s'"), - "KCHVMSTOR0001L": _("Attach %(type)s storage '%(path)s' to guest '%(vm)s'"), - "KCHVMSTOR0002L": _("Remove storage '%(ident)s' from guest '%(vm)s'"), - "KCHVMSTOR0003L": _("Update storage '%(ident)s' at guest '%(vm)s'"), - "KCHVOL0001L": _("Create storage volume '%(name)s' at pool '%(pool)s'"), - "KCHVOL0002L": _("Remove storage volume '%(ident)s' from pool '%(pool)s'"), - "KCHVOL0003L": _("Update storage volume '%(ident)s' at pool '%(pool)s'"), - "KCHVOL0004L": _("Wipe storage volume '%(ident)s' off pool '%(pool)s'"), - "KCHVOL0005L": _("Resize storage volume '%(ident)s' at pool '%(pool)s' with size %(size)s"), - "KCHVOL0006L": _("Clone storage volume '%(ident)s' at pool '%(pool)s'"), + "KCHVM0007L": _("Restarted guest '%(ident)s'"), + "KCHVM0008L": _("Connected to guest '%(ident)s' through novnc/spice"), + "KCHVM0009L": _("Cloned guest '%(ident)s'"), + "KCHVM0010L": _("Migrated guest '%(ident)s' to '%(remote_host)s'"), + "KCHVM0011L": _("Suspended guest '%(ident)s'"), + "KCHVM0012L": _("Resumed guest '%(ident)s'"), + "KCHVM0013L": _("Connected to guest '%(ident)s' through serial"), + "KCHVMHDEV0001L": _("Attached host device '%(name)s' to guest '%(vmid)s'"), + "KCHVMHDEV0002L": _("Detached host device '%(ident)s' from guest '%(vmid)s'"), + "KCHVMIF0001L": _("Attached network interface '%(network)s' to guest '%(vm)s'"), + "KCHVMIF0002L": _("Detached network interface '%(ident)s' from guest '%(vm)s'"), + "KCHVMIF0003L": _("Updated network interface '%(ident)s' at guest '%(vm)s'"), + "KCHVMSTOR0001L": _("Attached %(type)s storage '%(path)s' to guest '%(vm)s'"), + "KCHVMSTOR0002L": _("Removed storage '%(ident)s' from guest '%(vm)s'"), + "KCHVMSTOR0003L": _("Updated storage '%(ident)s' at guest '%(vm)s'"), + "KCHVOL0001L": _("Created storage volume '%(name)s' at pool '%(pool)s'"), + "KCHVOL0002L": _("Removed storage volume '%(ident)s' from pool '%(pool)s'"), + "KCHVOL0003L": _("Updated storage volume '%(ident)s' at pool '%(pool)s'"), + "KCHVOL0004L": _("Wiped storage volume '%(ident)s' off pool '%(pool)s'"), + "KCHVOL0005L": _("Resized storage volume '%(ident)s' at pool '%(pool)s' with size %(size)s"), + "KCHVOL0006L": _("Cloned storage volume '%(ident)s' at pool '%(pool)s'"), } -- 1.9.1

1 0

[PATCH] [Kimchi 1/2] Add translation to user log messages
by Lucio Correia 13 May '16

13 May '16

Signed-off-by: Lucio Correia <luciojhc(a)linux.vnet.ibm.com> --- control/networks.py | 10 +++++----- control/storagepools.py | 10 +++++----- control/storagevolumes.py | 14 ++++++-------- control/templates.py | 8 ++++---- control/vm/hostdevs.py | 4 ++-- control/vm/ifaces.py | 6 +++--- control/vm/snapshots.py | 6 +++--- control/vm/storages.py | 6 +++--- control/vms.py | 26 +++++++++++++------------- i18n.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 10 files changed, 89 insertions(+), 46 deletions(-) diff --git a/control/networks.py b/control/networks.py index c87b5a6..4b18638 100644 --- a/control/networks.py +++ b/control/networks.py @@ -22,15 +22,15 @@ from wok.control.utils import UrlSubNode NETWORKS_REQUESTS = { - 'POST': {'default': "Create %(connection)s virtual network '%(name)s'"}, + 'POST': {'default': "KCHNET0001L"}, } NETWORK_REQUESTS = { - 'DELETE': {'default': "Remove virtual network '%(ident)s'"}, - 'PUT': {'default': "Update virtual network '%(ident)s'"}, + 'DELETE': {'default': "KCHNET0002L"}, + 'PUT': {'default': "KCHNET0003L"}, 'POST': { - 'activate': "Activate virtual network '%(ident)s'", - 'deactivate': "Deactivate virtual network '%(ident)s'", + 'activate': "KCHNET0004L", + 'deactivate': "KCHNET0005L", }, } diff --git a/control/storagepools.py b/control/storagepools.py index 714f4bb..2f25746 100644 --- a/control/storagepools.py +++ b/control/storagepools.py @@ -30,15 +30,15 @@ from wok.plugins.kimchi.model.storagepools import ISO_POOL_NAME STORAGEPOOLS_REQUESTS = { - 'POST': {'default': "Create %(type)s storage pool '%(name)s'"}, + 'POST': {'default': "KCHPOOL0001L"}, } STORAGEPOOL_REQUESTS = { - 'DELETE': {'default': "Remove storage pool '%(ident)s'"}, - 'PUT': {'default': "Update storage pool '%(ident)s'"}, + 'DELETE': {'default': "KCHPOOL0002L"}, + 'PUT': {'default': "KCHPOOL0003L"}, 'POST': { - 'activate': "Activate storage pool '%(ident)s'", - 'deactivate': "Deactivate storage pool '%(ident)s'", + 'activate': "KCHPOOL0004L", + 'deactivate': "KCHPOOL0005L", }, } diff --git a/control/storagevolumes.py b/control/storagevolumes.py index a04ad35..351e4bd 100644 --- a/control/storagevolumes.py +++ b/control/storagevolumes.py @@ -23,18 +23,16 @@ from wok.control.utils import get_class_name, model_fn STORAGEVOLUMES_REQUESTS = { - 'POST': {'default': "Create storage volume '%(name)s' at pool '%(pool)s'"}, + 'POST': {'default': "KCHVOL0001L"}, } STORAGEVOLUME_REQUESTS = { - 'DELETE': {'default': "Remove storage volume '%(ident)s' from " - "pool '%(pool)s'"}, - 'PUT': {'default': "Update storage volume '%(ident)s' at pool '%(pool)s'"}, + 'DELETE': {'default': "KCHVOL0002L"}, + 'PUT': {'default': "KCHVOL0003L"}, 'POST': { - 'wipe': "Wipe storage volume '%(ident)s' off pool '%(pool)s'", - 'resize': "Resize storage volume '%(ident)s' at pool '%(pool)s' with " - "size %(size)s", - 'clone': "Clone storage volume '%(ident)s' at pool '%(pool)s'", + 'wipe': "KCHVOL0004L", + 'resize': "KCHVOL0005L", + 'clone': "KCHVOL0006L", }, } diff --git a/control/templates.py b/control/templates.py index 343ced1..82697d0 100644 --- a/control/templates.py +++ b/control/templates.py @@ -22,14 +22,14 @@ from wok.control.utils import UrlSubNode TEMPLATES_REQUESTS = { - 'POST': {'default': "Create template '%(name)s'"}, + 'POST': {'default': "KCHTMPL0001L"}, } TEMPLATE_REQUESTS = { - 'DELETE': {'default': "Remove template '%(ident)s'"}, - 'PUT': {'default': "Update template '%(ident)s'"}, + 'DELETE': {'default': "KCHTMPL0002L"}, + 'PUT': {'default': "KCHTMPL0003L"}, 'POST': { - 'clone': "Clone template '%(ident)s'", + 'clone': "KCHTMPL0004L", }, } diff --git a/control/vm/hostdevs.py b/control/vm/hostdevs.py index e9fd5dc..d21e19d 100644 --- a/control/vm/hostdevs.py +++ b/control/vm/hostdevs.py @@ -22,12 +22,12 @@ from wok.control.utils import UrlSubNode VMHOSTDEVS_REQUESTS = { - 'POST': {'default': "Attach host device '%(name)s' to guest '%(vmid)s'"}, + 'POST': {'default': "KCHVMHDEV0001L"}, } VMHOSTDEV_REQUESTS = { 'DELETE': { - 'default': "Detach host device '%(ident)s' from guest '%(vmid)s'", + 'default': "KCHVMHDEV0002L", }, } diff --git a/control/vm/ifaces.py b/control/vm/ifaces.py index 9ecfc8f..0cea8b5 100644 --- a/control/vm/ifaces.py +++ b/control/vm/ifaces.py @@ -23,16 +23,16 @@ from wok.control.utils import UrlSubNode VMIFACES_REQUESTS = { 'POST': { - 'default': "Attach network interface '%(network)s' to guest '%(vm)s'", + 'default': "KCHVMIF0001L", }, } VMIFACE_REQUESTS = { 'DELETE': { - 'default': "Detach network interface '%(ident)s' from guest '%(vm)s'", + 'default': "KCHVMIF0002L", }, 'PUT': { - 'default': "Update network interface '%(ident)s' at guest '%(vm)s'", + 'default': "KCHVMIF0003L", }, } diff --git a/control/vm/snapshots.py b/control/vm/snapshots.py index d8cccc1..20f07a7 100644 --- a/control/vm/snapshots.py +++ b/control/vm/snapshots.py @@ -22,13 +22,13 @@ from wok.control.utils import UrlSubNode VMSNAPSHOTS_REQUESTS = { - 'POST': {'default': "Create snapshot '%(name)s' at guest '%(vm)s'"}, + 'POST': {'default': "KCHSNAP0001L"}, } VMSNAPSHOT_REQUESTS = { - 'DELETE': {'default': "Remove snapshot '%(ident)s' from guest '%(vm)s'"}, + 'DELETE': {'default': "KCHSNAP0002L"}, 'POST': { - 'revert': "Revert guest '%(vm)s' to snapshot '%(ident)s'", + 'revert': "KCHSNAP0003L", }, } diff --git a/control/vm/storages.py b/control/vm/storages.py index 4a4c8d2..615074a 100644 --- a/control/vm/storages.py +++ b/control/vm/storages.py @@ -23,13 +23,13 @@ from wok.control.utils import UrlSubNode VMSTORAGES_REQUESTS = { 'POST': { - 'default': "Attach %(type)s storage '%(path)s' to guest '%(vm)s'", + 'default': "KCHVMSTOR0001L", }, } VMSTORAGE_REQUESTS = { - 'DELETE': {'default': "Remove storage '%(ident)s' from guest '%(vm)s'"}, - 'PUT': {'default': "Update storage '%(ident)s' at guest '%(vm)s'"}, + 'DELETE': {'default': "KCHVMSTOR0002L"}, + 'PUT': {'default': "KCHVMSTOR0003L"}, } diff --git a/control/vms.py b/control/vms.py index 64df00e..2339017 100644 --- a/control/vms.py +++ b/control/vms.py @@ -25,24 +25,24 @@ from wok.plugins.kimchi.control.vm import sub_nodes VMS_REQUESTS = { 'POST': { - 'default': "Create guest '%(name)s' from template '%(template)s'", + 'default': "KCHVM0001L", }, } VM_REQUESTS = { - 'DELETE': {'default': "Remove guest '%(ident)s'"}, - 'PUT': {'default': "Edit guest '%(ident)s'"}, + 'DELETE': {'default': "KCHVM0002L"}, + 'PUT': {'default': "KCHVM0003L"}, 'POST': { - 'start': "Start guest '%(ident)s'", - 'poweroff': "Power off guest '%(ident)s'", - 'shutdown': "Shutdown guest '%(ident)s'", - 'reset': "Restart guest '%(ident)s'", - 'connect': "Connect to guest '%(ident)s' through novnc/spice", - 'clone': "Clone guest '%(ident)s'", - 'migrate': "Migrate guest '%(ident)s' to '%(remote_host)s'", - 'suspend': "Suspend guest '%(ident)s'", - 'resume': "Resume guest '%(ident)s'", - 'serial': "Connect to guest '%(ident)s' through serial", + 'start': "KCHVM0004L", + 'poweroff': "KCHVM0005L", + 'shutdown': "KCHVM0006L", + 'reset': "KCHVM0007L", + 'connect': "KCHVM0008L", + 'clone': "KCHVM0009L", + 'migrate': "KCHVM0010L", + 'suspend': "KCHVM0011L", + 'resume': "KCHVM0012L", + 'serial': "KCHVM0013L", }, } diff --git a/i18n.py b/i18n.py index db245c0..7baa3b6 100644 --- a/i18n.py +++ b/i18n.py @@ -331,4 +331,49 @@ messages = { "KCHLVMS0001E": _("Invalid volume group name parameter: %(name)s."), + # These messages (ending with L) are for user log purposes + "KCHNET0001L": _("Create %(connection)s virtual network '%(name)s'"), + "KCHNET0002L": _("Remove virtual network '%(ident)s'"), + "KCHNET0003L": _("Update virtual network '%(ident)s'"), + "KCHNET0004L": _("Activate virtual network '%(ident)s'"), + "KCHNET0005L": _("Deactivate virtual network '%(ident)s'"), + "KCHPOOL0001L": _("Create %(type)s storage pool '%(name)s'"), + "KCHPOOL0002L": _("Remove storage pool '%(ident)s'"), + "KCHPOOL0003L": _("Update storage pool '%(ident)s'"), + "KCHPOOL0004L": _("Activate storage pool '%(ident)s'"), + "KCHPOOL0005L": _("Deactivate storage pool '%(ident)s'"), + "KCHSNAP0001L": _("Create snapshot '%(name)s' at guest '%(vm)s'"), + "KCHSNAP0002L": _("Remove snapshot '%(ident)s' from guest '%(vm)s'"), + "KCHSNAP0003L": _("Revert guest '%(vm)s' to snapshot '%(ident)s'"), + "KCHTMPL0001L": _("Create template '%(name)s'"), + "KCHTMPL0002L": _("Remove template '%(ident)s'"), + "KCHTMPL0003L": _("Update template '%(ident)s'"), + "KCHTMPL0004L": _("Clone template '%(ident)s'"), + "KCHVM0001L": _("Create guest '%(name)s' from template '%(template)s'"), + "KCHVM0002L": _("Remove guest '%(ident)s'"), + "KCHVM0003L": _("Edit guest '%(ident)s'"), + "KCHVM0004L": _("Start guest '%(ident)s'"), + "KCHVM0005L": _("Power off guest '%(ident)s'"), + "KCHVM0006L": _("Shutdown guest '%(ident)s'"), + "KCHVM0007L": _("Restart guest '%(ident)s'"), + "KCHVM0008L": _("Connect to guest '%(ident)s' through novnc/spice"), + "KCHVM0009L": _("Clone guest '%(ident)s'"), + "KCHVM0010L": _("Migrate guest '%(ident)s' to '%(remote_host)s'"), + "KCHVM0011L": _("Suspend guest '%(ident)s'"), + "KCHVM0012L": _("Resume guest '%(ident)s'"), + "KCHVM0013L": _("Connect to guest '%(ident)s' through serial"), + "KCHVMHDEV0001L": _("Attach host device '%(name)s' to guest '%(vmid)s'"), + "KCHVMHDEV0002L": _("Detach host device '%(ident)s' from guest '%(vmid)s'"), + "KCHVMIF0001L": _("Attach network interface '%(network)s' to guest '%(vm)s'"), + "KCHVMIF0002L": _("Detach network interface '%(ident)s' from guest '%(vm)s'"), + "KCHVMIF0003L": _("Update network interface '%(ident)s' at guest '%(vm)s'"), + "KCHVMSTOR0001L": _("Attach %(type)s storage '%(path)s' to guest '%(vm)s'"), + "KCHVMSTOR0002L": _("Remove storage '%(ident)s' from guest '%(vm)s'"), + "KCHVMSTOR0003L": _("Update storage '%(ident)s' at guest '%(vm)s'"), + "KCHVOL0001L": _("Create storage volume '%(name)s' at pool '%(pool)s'"), + "KCHVOL0002L": _("Remove storage volume '%(ident)s' from pool '%(pool)s'"), + "KCHVOL0003L": _("Update storage volume '%(ident)s' at pool '%(pool)s'"), + "KCHVOL0004L": _("Wipe storage volume '%(ident)s' off pool '%(pool)s'"), + "KCHVOL0005L": _("Resize storage volume '%(ident)s' at pool '%(pool)s' with size %(size)s"), + "KCHVOL0006L": _("Clone storage volume '%(ident)s' at pool '%(pool)s'"), } -- 1.9.1

1 0

[PATCH] [Kimchi 0/2] Add translation support to user log
by Lucio Correia 13 May '16

13 May '16

Lucio Correia (2): Add translation to user log messages Use verbs in the past control/networks.py | 10 +++++----- control/storagepools.py | 10 +++++----- control/storagevolumes.py | 14 ++++++-------- control/templates.py | 8 ++++---- control/vm/hostdevs.py | 4 ++-- control/vm/ifaces.py | 6 +++--- control/vm/snapshots.py | 6 +++--- control/vm/storages.py | 6 +++--- control/vms.py | 26 +++++++++++++------------- i18n.py | 45 +++++++++++++++++++++++++++++++++++++++++++++ 10 files changed, 89 insertions(+), 46 deletions(-) -- 1.9.1

1 0