October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Add checkbox to override NFS mount options
by mlipchuk＠redhat.com 31 Oct '12

31 Oct '12

Maor Lipchuk has submitted this change and it was merged. Change subject: webadmin: Add checkbox to override NFS mount options ...................................................................... webadmin: Add checkbox to override NFS mount options With the change to make nfs v3 the default, mounting any nfs domain with compatibility version 3.1+ will result in the engine sending a mount version to vdsm. This provides a way to specify that no options should be specified, which results in the values being null in the db and not sent to vdsm when connecting the storage. This allows vdsm.conf's nfs_mount_options to be processed properly as well (see bug 826921 for details). Bug-Url: https://bugzilla.redhat.com/871534 Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/NfsStorageView.ui.xml 5 files changed, 88 insertions(+), 19 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If01d7fefc392fd296838df5da9faa9b4157327cf Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: Use NFS v3 as default
by mlipchuk＠redhat.com 31 Oct '12

31 Oct '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core, webadmin: Use NFS v3 as default ...................................................................... core, webadmin: Use NFS v3 as default Change NFS version to v3 as default in UI, and add 'auto' param support to vdsm in ConnectStorageServerVDSCommand. This allows pre-3.1 storage pools to keep using v3 after upgrading (in which case protocol_version is not passed to vdsm), and gives the option of using NFS version auto negotiation for SDs in newer pools. Bug-Url: https://bugzilla.redhat.com/871534 Change-Id: I831ecc7050a5487d5365efb94342a3c170dddc6c Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/collections/DefaultValueMap.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 4 files changed, 41 insertions(+), 35 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8242 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I831ecc7050a5487d5365efb94342a3c170dddc6c Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, restapi: Convert NFS version to enum
by mlipchuk＠redhat.com 31 Oct '12

31 Oct '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core, restapi: Convert NFS version to enum ...................................................................... core, restapi: Convert NFS version to enum In order to support optional advanced nfs options, the "auto" version specifier must be distinct from "not set" in the database. Instead, "auto" will be explicit as a string, and "not set" will be null. This change requires the core and rest api to propagate non-numeric version values as well. This conversion will also help later when minor versions are specified in the mount options, e.g. "4.1". Bug-Url: https://bugzilla.redhat.com/871534 Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357 Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql A backend/manager/dbscripts/upgrade/03_01_1480_change_nfs_version_to_string.sql A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NfsVersion.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_server_connections.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageServerConnectionDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/NfsVersion.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/StorageDomainValidator.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StorageDomainMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/StorageDomainMapperTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ConnectStorageServerVDSCommand.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 19 files changed, 214 insertions(+), 28 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d82db7c0ec92135cae8935f013487e97b8f357 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added missed vdsm errors
by masayag＠redhat.com 31 Oct '12

31 Oct '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Added missed vdsm errors ...................................................................... engine: Added missed vdsm errors - vdsm error 4149 and 4154 are added. - Gluster Vdsm errors are sorted based on the error code Change-Id: I1aa48e756abe6b3c08b07da9417dbad9cef3ff32 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java 3 files changed, 29 insertions(+), 23 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1aa48e756abe6b3c08b07da9417dbad9cef3ff32 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout - Fit Cluster Networking for JP Locale - V2
by shavivi＠redhat.com 31 Oct '12

31 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Layout - Fit Cluster Networking for JP Locale - V2 ...................................................................... webadmin: Layout - Fit Cluster Networking for JP Locale - V2 V2: widen the dialog instead of narrowing the checkbox control. Change-Id: I8a5943dbbe6e38d213de6872ea9175fe77363b1c Bug-Id: https://bugzilla.redhat.com/870088 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8a5943dbbe6e38d213de6872ea9175fe77363b1c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmReplicateDiskTaskHandler wrong parameter
by derez＠redhat.com 31 Oct '12

31 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: VmReplicateDiskTaskHandler wrong parameter ...................................................................... core: VmReplicateDiskTaskHandler wrong parameter VmReplicateDiskFinishTaskHandler/VmReplicateDiskStartTaskHandler -> DeleteImageGroupVDSCommandParameters: DiskImage object should be fetched from DB according to DestinationImageId (instead of ImageGroupID). Change-Id: Id2e671021cf23aed59bedf27710fb78dc21b4606 Bug-Url: https://bugzilla.redhat.com/871607 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8942 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2e671021cf23aed59bedf27710fb78dc21b4606 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Exception rush
by mkublin＠redhat.com 31 Oct '12

31 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Exception rush ...................................................................... engine: Exception rush The following patch will remove all unused exceptions all over a code. The exception was not used, was not thrown but sometimes was catched. Also I removed some unused enum. Change-Id: Ic983626d48c6535eeaa23a9c858c20ed7fa86a2c Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ResourceManagerException.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DBFacadException.java D backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/RepositoryException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IRSErrorImageNotExistException.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/ImportEnumsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsErrorImportCandidateMissing.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsErrorIrsDbMissing.java 11 files changed, 17 insertions(+), 205 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8947 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic983626d48c6535eeaa23a9c858c20ed7fa86a2c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Layout: Fix JP Locale date string format
by shavivi＠redhat.com 31 Oct '12

31 Oct '12

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: Layout: Fix JP Locale date string format ...................................................................... webadmin: Layout: Fix JP Locale date string format Change-Id: I2374ec9cd97747646c3a94ad926b73e12f0746bd Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=870352 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/FullDateTimeRenderer.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/VmSnapshotListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/GeneralDateTimeRenderer.java 3 files changed, 22 insertions(+), 12 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8912 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2374ec9cd97747646c3a94ad926b73e12f0746bd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Stopped engine before restoring orig configuratio...
by juan.hernandez＠redhat.com 31 Oct '12

31 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Stopped engine before restoring orig configuration ...................................................................... packaging: Stopped engine before restoring orig configuration Added stopEngine call before we restore the original configuration of the JBoss. Otherwise DB calls will fails. Change-Id: I47acf36a819da2d431731828b6b85478325c0b4e Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8935 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47acf36a819da2d431731828b6b85478325c0b4e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fit New Storage Domain dialog for French locale
by derez＠redhat.com 30 Oct '12

30 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Fit New Storage Domain dialog for French locale ...................................................................... webadmin: Fit New Storage Domain dialog for French locale Bug-Id: https://bugzilla.redhat.com/867428 Change-Id: Id0b05f10c9bde9416fd6f2ce24bfc8573c3b5992 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0b05f10c9bde9416fd6f2ce24bfc8573c3b5992 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0