October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: #863277 - metadata missing for activate/deactivate ...
by oliel＠redhat.com 15 Oct '12

15 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #863277 - metadata missing for activate/deactivate nic ...................................................................... restapi: #863277 - metadata missing for activate/deactivate nic Specifically, awareness to existence of correlation-id missing. Change-Id: Ib81ba319cc8692945360bcbcb27dbca0b6796386 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib81ba319cc8692945360bcbcb27dbca0b6796386 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core, webadmin: new VM-Template - changeable disk alias
by derez＠redhat.com 15 Oct '12

15 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core,webadmin: new VM-Template - changeable disk alias ...................................................................... core,webadmin: new VM-Template - changeable disk alias Creation of a New Template / a VM from template: adding a support for modifying disks aliases. UI - disks aliases are changeable on: * New Template dialog. * New VM/Pool dialog - 'Resource Allocation' tab. Core: * Passing disk alias on the relevant commands. * Adding DiskAlias member/getter/setter to ImagesActionsParametersBase. Bug-Url: https://bugzilla.redhat.com/861728 Change-Id: I5a6a47d1ba77eed84fa5561db342e03ab6bac81a Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationItemView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/DisksAllocationView.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/DisksAllocationModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java 14 files changed, 56 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5a6a47d1ba77eed84fa5561db342e03ab6bac81a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: truncate white list upon upgrade
by yzaslavs＠redhat.com 15 Oct '12

15 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: truncate white list upon upgrade ...................................................................... core: truncate white list upon upgrade As white-list data is internal configuration and is not populated due to user activity, it is possible to truncate the object_column_white_list_table per upgrade (as post upgrade step). This fix was introduced due to a scneario in which sshFingerPrint key was added vds_static (and vds view) and due to the reentrant nature of add_object_colmn_white_list_table, it was not added to white list, as the check of "if exists" was done on the whole table. It is possible to perform "if exist" check per column, but it looks like an overhead , as explained above Change-Id: I94f3c474c0209a9049d1d32487d049e1e161214a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/upgrade/post_upgrade/0010_add_object_column_white_list_table.sql 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8272 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94f3c474c0209a9049d1d32487d049e1e161214a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 14 Oct '12

14 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - gluster action refactored to lowercase - added StorageDomainTemplate.delete() - added StorageDomainVM.delete() - template/vm.display.allow_reconnect renamed to template/vm.display.allow_override - added TemplateDisk.copy() - added template.cpu.cpu_tune.vcpu_pin: at Templates.add()/VMs.add() - added VmPool.allocatevm() - added size property to VmPools.add() Change-Id: Iec8097851e4d56ee9fe7db31cf17c967d27a10d6 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/xml/params.py 2 files changed, 128 insertions(+), 31 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8532 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec8097851e4d56ee9fe7db31cf17c967d27a10d6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: remove unused variable
by mpastern＠redhat.com 14 Oct '12

14 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: remove unused variable ...................................................................... restapi: remove unused variable Change-Id: Ic9a3dfd0a9830c132c6b9f01a19562e5d826fa32 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8526 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic9a3dfd0a9830c132c6b9f01a19562e5d826fa32 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: add disk.name property for disk.add() to ease < 3.1...
by mpastern＠redhat.com 14 Oct '12

14 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add disk.name property for disk.add() to ease < 3.1 clients migration ...................................................................... restapi: add disk.name property for disk.add() to ease < 3.1 clients migration disk.name deprecated in 3.1 (replaced with disk.alias), however it remains in the schema in sake of backward compatibility and user can assign it manually, however to ease working with BE < 3.1 in cli, this property added to parameters descriptor. Change-Id: I97fbdec4f50f17830511cb1b201965ed5f0f9755 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97fbdec4f50f17830511cb1b201965ed5f0f9755 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: Don't add the cdrom device if iso_path is empty
by emesika＠redhat.com 14 Oct '12

14 Oct '12

Eli Mesika has submitted this change and it was merged. Change subject: Don't add the cdrom device if iso_path is empty ...................................................................... Don't add the cdrom device if iso_path is empty Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=857690 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I8cb5631a16a322bda1e371efce5c318f666b1d0e --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8cb5631a16a322bda1e371efce5c318f666b1d0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removing all unneeded staff from VdsIdVDSCommandBase
by mkublin＠redhat.com 14 Oct '12

14 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing all unneeded staff from VdsIdVDSCommandBase ...................................................................... engine: Removing all unneeded staff from VdsIdVDSCommandBase 1. Removed garbage comments 2. Removed method which is creates quartz task for update vds dynamic data 3. Removed call for that method from CreateVmVDSCommand - call is unneeded similar update is done at next line The patch is not only cleans, it is also reduced unneeded update query and quartz task creation on every run vm Change-Id: Ida4f92f70d24634e3fb76d675ba81c936a487288 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsIdVDSCommandBase.java 2 files changed, 0 insertions(+), 58 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8496 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida4f92f70d24634e3fb76d675ba81c936a487288 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: user cannnot take a vm from pool via restapi #86443...
by mpastern＠redhat.com 11 Oct '12

11 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: user cannnot take a vm from pool via restapi #864438 ...................................................................... restapi: user cannnot take a vm from pool via restapi #864438 This patch implements new action /allocatevm in vmpool [1] for user to take vm from the pool, also this patche introduces new generic and type independent resolver pattern callback on the action, in this case BE action on vmpool returns vm id which is later transformed to vm ref in api action response. [1] POST /api/vmpools/{vmpool:id}/allocatevm https://bugzilla.redhat.com/show_bug.cgi?id=864438 Change-Id: Icdd917a5f443bd7e8d06b582ae4559bef90608e6 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmPoolResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmPoolResourceTest.java 6 files changed, 372 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8488 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icdd917a5f443bd7e8d06b582ae4559bef90608e6 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Allow copying template disks to another storage dom...
by mpastern＠redhat.com 11 Oct '12

11 Oct '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Allow copying template disks to another storage domain #851099 ...................................................................... restapi: Allow copying template disks to another storage domain #851099 https://bugzilla.redhat.com/show_bug.cgi?id=851099 Change-Id: Ic629b331e4753b24ef02612ff50cb6a4457cfd58 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDiskResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/TemplateDisksResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/AbstractBackendActionableResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDisksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendDisksResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplateDiskResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java 11 files changed, 306 insertions(+), 26 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/8428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic629b331e4753b24ef02612ff50cb6a4457cfd58 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0