October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: [SetupNetworks] bond is jumping on mouse hover
by alkaplan＠redhat.com 10 Oct '12

10 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] bond is jumping on mouse hover ...................................................................... webadmin: [SetupNetworks] bond is jumping on mouse hover https://bugzilla.redhat.com/862247 - Made the edit pencil's top-bottom padding smaller. Change-Id: I63d7f4d69ec8eb9f87f3d60610f13a67de797a8a Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/BondPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java 5 files changed, 10 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63d7f4d69ec8eb9f87f3d60610f13a67de797a8a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetworks] Unmanaged/Unsync should be cleared...
by alkaplan＠redhat.com 10 Oct '12

10 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] Unmanaged/Unsync should be cleared on detach ...................................................................... webadmin: [SetupNetworks] Unmanaged/Unsync should be cleared on detach https://bugzilla.redhat.com/863117 https://bugzilla.redhat.com/863130 1. bridge on LogicalNetworkModel changed to vlanNic. 2. On Detach - NetworkImplementationDetails should be cleaned. 3. DcNetworkParams should be initialized only after getting the Networks from the backend and not after each operation on SetupNetworks. Change-Id: I2530ad068e2742006019fa9630a024a3ad6c9e5b Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java 3 files changed, 19 insertions(+), 12 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2530ad068e2742006019fa9630a024a3ad6c9e5b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [SetupNetworks] Cannot detach unsynced VLAN interf...
by alkaplan＠redhat.com 10 Oct '12

10 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface from nic ...................................................................... webadmin: [SetupNetworks] Cannot detach unsynced VLAN interface from nic https://bugzilla.redhat.com/863109 When there is unsynced network with VLAN (on rhevm the network is with VLAN and on the host the network is without VLAN) it is impossible to detach the network from the nic using SetupNetworks. Change-Id: Ibb0d9e6d4f3316300633eaa4602f50c9a16fe53f Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb0d9e6d4f3316300633eaa4602f50c9a16fe53f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Setupnetwork doesn't recognize logical network wit...
by alkaplan＠redhat.com 10 Oct '12

10 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setupnetwork doesn't recognize logical network with vlan id 0 ...................................................................... webadmin: Setupnetwork doesn't recognize logical network with vlan id 0 https://bugzilla.redhat.com/863072 Setupnetworks can't handle vlan id 0 because it is not recognized as vlan interface. Change-Id: I4ac58f425a48c15ec72844855f4ecaa744c9b242 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8358 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ac58f425a48c15ec72844855f4ecaa744c9b242 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Extracted VmValidator
by rgolan＠redhat.com 10 Oct '12

10 Oct '12

Roy Golan has submitted this change and it was merged. Change subject: core: Extracted VmValidator ...................................................................... core: Extracted VmValidator Extracted several VM validation utils from CreateAllSnapshotsFromVmCommand to a VmValidator class (similar to the SnapshotValidator design) in order to share its code with other commands (that will be introduced in subsequent patches). Change-Id: I6c76d242d7722f7271ead094e0cc936588db22d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidator.java 2 files changed, 42 insertions(+), 24 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c76d242d7722f7271ead094e0cc936588db22d1 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: allow customize bridge name for standard sequence
by yzaslavs＠redhat.com 10 Oct '12

10 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: allow customize bridge name for standard sequence ...................................................................... bootstrap: allow customize bridge name for standard sequence For gluster integration, we need bootstrap to be able to accept management bridge name within bootstrap and not relay on vdsm build time settings. As gluster only performs standard host bootstrap (as opposed to registration), the customization will be available only for this sequence. In future the registration sequence will be altered to match the standard sequence. Change-Id: I373d921fbecbd2fee79c5a430b428f7f20246055 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=863718 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I373d921fbecbd2fee79c5a430b428f7f20246055 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: upgrade.sh for upgrading multiple DBs
by yzaslavs＠redhat.com 10 Oct '12

10 Oct '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: engine: upgrade.sh for upgrading multiple DBs ...................................................................... engine: upgrade.sh for upgrading multiple DBs Currently, the upgrade.sh script creates a md5sum file, which is used for comparing with md5sum of latest files to identify whether an upgrade is required. However this file name is not db-specific, and hence upgrading one DB makes it think that all other DBs are also upgraded. Modified the script to create the md5sum file with a DB-specific name so that all DBs can be upgraded by passing the -d option to the script. Since the name of the md5sum file is changed now, and it can be different for different databases, updated the .gitignore file to ignore all such files. Change-Id: I63f3c34a822508d266a4b3e1582d7e9539d08c39 Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/dbscripts/.gitignore M backend/manager/dbscripts/create_db.sh M backend/manager/dbscripts/dbfunctions.sh 3 files changed, 8 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I63f3c34a822508d266a4b3e1582d7e9539d08c39 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: FB: Clean up JobWrapper's method cache
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: FB: Clean up JobWrapper's method cache ...................................................................... core: FB: Clean up JobWrapper's method cache Cleaned up JobWrapper.execute()'s work with the method cache. Since the statement "if (cachedMethods.containsKey(methodToRun))" always evaluates to false the method cache was NEVER used. This patch enables the use of the cache and solves the NP_LOAD_OF_KNOWN_NULL_VALUE error detected by FindBugs. Change-Id: I2e6e3ae5bba5f543f7dab11309c2f7dd8d67bc00 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/beans/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/JobWrapper.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e6e3ae5bba5f543f7dab11309c2f7dd8d67bc00 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: log should be final in VdsSelector
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: log should be final in VdsSelector ...................................................................... core: log should be final in VdsSelector - in general it is recommended to declare the logger as private static final Change-Id: Iaec293a36d1920be5439278150533bbe8b12e71d Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaec293a36d1920be5439278150533bbe8b12e71d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: camel-case methods in VdsSelector
by lhornyak＠redhat.com 09 Oct '12

09 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: camel-case methods in VdsSelector ...................................................................... core: camel-case methods in VdsSelector - renamed the methods to conform to java naming standards Change-Id: I9cfa7353fb5879593f34d90d51441008604dcb1a Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerClientMigrateOnConnectCheckCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 6 files changed, 24 insertions(+), 24 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9cfa7353fb5879593f34d90d51441008604dcb1a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0