October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: avoid NullPointerException in SpmStartVDSCommand
by derez＠redhat.com 02 Oct '12

02 Oct '12

Daniel Erez has submitted this change and it was merged. Change subject: core: avoid NullPointerException in SpmStartVDSCommand ...................................................................... core: avoid NullPointerException in SpmStartVDSCommand When the getSpmStatus command fails we cannot log the SpmStatusResult content (NullPointerException). Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=853747 Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com> Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: "Fully configured" message for guide me dialogs (#...
by achub＠redhat.com 02 Oct '12

02 Oct '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: "Fully configured" message for guide me dialogs (#850439) ...................................................................... webadmin: "Fully configured" message for guide me dialogs (#850439) http://bugzilla.redhat.com/850439 Change-Id: I594e6721ea114560784152dcdd5d85910f50b34e Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractUiCommandButton.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/guide/GuidePopupView.java 4 files changed, 66 insertions(+), 30 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I594e6721ea114560784152dcdd5d85910f50b34e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: update order of db backup
by juan.hernandez＠redhat.com 02 Oct '12

02 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: update order of db backup ...................................................................... packaging: update order of db backup Change-Id: Ide1d9635ec51d30b6a508b5319fc6c4f399cb44f Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Alex Lourie: Verified Juan Hernandez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide1d9635ec51d30b6a508b5319fc6c4f399cb44f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: rollback database if only pki upgrade took place
by juan.hernandez＠redhat.com 02 Oct '12

02 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: rollback database if only pki upgrade took place ...................................................................... packaging: rollback database if only pki upgrade took place Currently if database packages is not upgraded the changes of pki will not be rolled backed. This change performs database backup/restore if pki is to be changed. Change-Id: Iae1f7ee7d0136922ca929f755f326acda77bbb7e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 16 insertions(+), 3 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8276 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae1f7ee7d0136922ca929f755f326acda77bbb7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: disable Ctrl-C during setup/upgrade
by juan.hernandez＠redhat.com 02 Oct '12

02 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: disable Ctrl-C during setup/upgrade ...................................................................... packaging: disable Ctrl-C during setup/upgrade Not healthy for state management. Change-Id: I4988c7159c45b9b286c48d7085257ad131eebb90 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4988c7159c45b9b286c48d7085257ad131eebb90 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Make DB connection pool configurable
by juan.hernandez＠redhat.com 02 Oct '12

02 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Make DB connection pool configurable ...................................................................... packaging: Make DB connection pool configurable Currently the only way to change the database connections pool size is to modify the /usr/share/ovirt-engine/service/engine-service.xml.in file. But that file is not marked as configuration so changes are lost when the package containing it is updated. This patch introduces two new optional parameters in /etc/sysconfig/ovirt-engine to control the size of the pool: ENGINE_DB_MIN_CONNECTIONS=1 ENGINE_DB_MAX_CONNECTIONS=100 The default values are 1 and 100 as shown above. Bug-Url: https://bugzilla.redhat.com/856273 Change-Id: I607e74df406128c7fd9b2e1496b3efa08e11fbac Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/conf/engine.conf.defaults M packaging/fedora/engine-service.xml.in 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8216 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I607e74df406128c7fd9b2e1496b3efa08e11fbac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Time zones contained couple of empty lines (#85069...
by tjelinek＠redhat.com 02 Oct '12

02 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Time zones contained couple of empty lines (#850696) ...................................................................... webadmin: Time zones contained couple of empty lines (#850696) https://bugzilla.redhat.com/850696 The probelm was that the selected item was set up like this: ... new KeyValuePairCompat<String, String>(...gettime_zone(), "") UpdateTimeZone() Where the UpdateTimeZone was an asynchronous request to get the time zones and set them up and select the correct one. Changed in a way, that the UpdateTimeZone now gets as an argument the time zone to set the selected item to, and after it fetches the values, it sets the selected time zone in this way: - if the argument is provided, set the selected time zone to it - if the argument is not provided, checks if something has already been selected, and if yes, selects it again - if none of the above is true, then selects the first of the time zones Change-Id: Iad95c26566a0e846f6f7712ce122210e7fc758b9 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 7 files changed, 37 insertions(+), 41 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad95c26566a0e846f6f7712ce122210e7fc758b9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: vm doesn't boot from cd when CD set in "edit" (#8568...
by tjelinek＠redhat.com 02 Oct '12

02 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: vm doesn't boot from cd when CD set in "edit" (#856806) ...................................................................... engine: vm doesn't boot from cd when CD set in "edit" (#856806) https://bugzilla.redhat.com/856806 Virtual Machines tab -> select VM -> Edit -> Boot Options -> select CD Than setup boot order to First device: CD, second NONE. The result is, that the VM will not boot from the CD attached. The problem was in RunVmCommand.AttachCd() which did set up the correct CD path only, when the getVm().getboot_sequence() == BootSequence.CD The problem is, that this condition is only true, when the boot sequence is first the Hard Disk (C), than the CD (D). The condition should be, that when it contains CD (D). Solved by adding the BootSequence.containsSubsequence method (the tests in BootSequenceTest) which checks if the specific sequence is a subsequence of the sequence. Change-Id: I61d39f8559bcffdc154b0b2c01d5303cf2ff1e1a Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BootSequence.java A backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/BootSequenceTest.java 3 files changed, 115 insertions(+), 17 deletions(-) Approvals: Tomas Jelinek: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61d39f8559bcffdc154b0b2c01d5303cf2ff1e1a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: several multiple RemoveVmCommand get java.lang.Runtime...
by mkublin＠redhat.com 02 Oct '12

02 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine ...................................................................... core: several multiple RemoveVmCommand get java.lang.RuntimeException when restarting engine The bug was caused because of unneeded update at CommandBase of parameters of async tasks, during update were passed parameters of parent command, the update is unneeded because of parameters are passed during creation of task, because of update was done partitial we got java.lang.RuntimeException. Solution: to remove unneded update, also we will have additional benefit: reduced at least two updates query on every task Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85 Bug-Url: https://bugzilla.redhat.com/861154 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java 2 files changed, 6 insertions(+), 8 deletions(-) Approvals: Michael Kublin: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie885b5d069abf0592454f6834466d3fcb5a47c85 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup VMCommand
by lhornyak＠redhat.com 01 Oct '12

01 Oct '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup VMCommand ...................................................................... core: Cleanup VMCommand Renamed methods to conform to camelcase convention. Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java 8 files changed, 16 insertions(+), 16 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6750a6bf6bac763a73f5e7eb9912acf7bd0c50e0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0