November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: use String instead of StringBuilder in SysprepHandler ...
by ofrenkel＠redhat.com 07 Nov '12

07 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: use String instead of StringBuilder in SysprepHandler (#873742) ...................................................................... core: use String instead of StringBuilder in SysprepHandler (#873742) SysprepHandler uses StringBuilder as it is a string: it creates new instances for replacements. this patch changes StringBuilder to String to make it clear to the user it is regular string that need to be set. also added return value to populateSysPrepDomainProperties as it manipulates the string inside it as well, caused changes to domain, user and pass in the sysprep file to be lost. Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=873742 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandler.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java 2 files changed, 27 insertions(+), 32 deletions(-) Approvals: Omer Frenkel: Verified Maor Lipchuk: Looks good to me, approved Arik Hadas: Looks good to me, but someone else must approve Moti Asayag: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie447c30759d19e4d42a722deb550a6233becb490 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix fixtures.xml
by yzaslavs＠redhat.com 07 Nov '12

07 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: fix fixtures.xml ...................................................................... core: fix fixtures.xml Removed the hypervisor_type column from fixtures.xml to fix the DAO tests. Change-Id: I237ffd0eaebc6dffb90571ddcc8d702e4003ab3f Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/dal/src/test/resources/fixtures.xml 1 file changed, 0 insertions(+), 23 deletions(-) Approvals: Laszlo Hornyak: Verified Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9099 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I237ffd0eaebc6dffb90571ddcc8d702e4003ab3f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Gluster Volume Brick - Advanced Details
by gchaplik＠redhat.com 07 Nov '12

07 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Gluster Volume Brick - Advanced Details ...................................................................... webadmin: Gluster Volume Brick - Advanced Details A new action 'Advanced Details' is added to the Bricks sub tab of volume, which will open Brick Advanced Details dialog when the user clicks. Brick Details dialog contains 4 sections named General, Clients, Memory Statistics and Memory Pools. General section will show the basic information about the selected brick. Clients section will list all the clients which are exchanged data with the brick. Change-Id: I6571020ed3a17df21eef40acf4cda2bbf4fb2374 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/BrickAdvancedDetailsModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/BrickPropertiesModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/MemoryStatisticsModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/VolumeModule.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/BrickAdvancedDetailsPopupPresenterWidget.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/BrickAdvancedDetailsPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/gluster/SubTabVolumeBrickView.java 13 files changed, 978 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6571020ed3a17df21eef40acf4cda2bbf4fb2374 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Adding Gluster Services Sub Tab to Cluster
by gchaplik＠redhat.com 07 Nov '12

07 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Adding Gluster Services Sub Tab to Cluster ...................................................................... webadmin: Adding Gluster Services Sub Tab to Cluster A new sub tab named 'Services' is added to the Cluster Tab. This sub tab will be shown only if the cluster supports Gluster. NFS, SHD are the two different type of services. Hosts in the Cluster will have NFS, SHD services running. A filter panel is added to filter the results based on Service Type and host address. Change-Id: Iea624f12a07f4aa9b1c6ffa1548aaafb16a00a7a Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterServiceModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/ManagedComponents.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/PresenterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/gin/uicommon/ClusterModule.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/place/ApplicationPlaces.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterPermissionPresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterServicePresenter.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.ui.xml 16 files changed, 557 insertions(+), 1 deletion(-) Approvals: Kanagaraj M: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8460 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea624f12a07f4aa9b1c6ffa1548aaafb16a00a7a Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: import cleanup in AlertDirector.java
by mkublin＠redhat.com 07 Nov '12

07 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: import cleanup in AlertDirector.java ...................................................................... core: import cleanup in AlertDirector.java Use fully qualified imports. Change-Id: If0c2a9f699b4b5e9227aeb9b6ef102ccfad72b0c Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AlertDirector.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0c2a9f699b4b5e9227aeb9b6ef102ccfad72b0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

1 0

Change in ovirt-engine[master]: core: Fix attach/detach message
by mkublin＠redhat.com 07 Nov '12

07 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fix attach/detach message ...................................................................... core: Fix attach/detach message Fix VAR__ACTION__ATTACH_ACTION_TO: action substitution was faulty, and now is "attach". VAR__ACTION__DETACH_ACTION_TO: action substitution + fix "dettach" typo (detach). VAR__ACTION__ATTACHE_DESKTOP_TO changed to VAR__ACTION__ATTACH_DESKTOP_TO, as well as the action - attach instead of attache. Change-Id: If91484360ffa35b3c044695a8277cda491f37b3e Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolCommandBase.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_de.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_it.properties M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_nl.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors_de.properties M backend/manager/modules/utils/src/test/resources/AppErrors_it.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties 22 files changed, 25 insertions(+), 25 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If91484360ffa35b3c044695a8277cda491f37b3e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Don't use PostgreSQL UUID extension
by emesika＠redhat.com 06 Nov '12

06 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Don't use PostgreSQL UUID extension ...................................................................... core: Don't use PostgreSQL UUID extension Replace the uuid_generate_v1 function from the uuid-ossp extension with a custom function that generates UUIDs from a sequence. That way we don't need the extension any longer. Note that this is the first step to remove completely the generation of UUIDs in the database, as they should be generated by the engine. Change-Id: I819e37224288b202d2126cec475ee1d97f83a925 Bug-Url: https://bugzilla.redhat.com/870056 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/create_db.sh M backend/manager/dbscripts/create_db_devel.sh M backend/manager/dbscripts/create_functions.sql M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/engine-db-install.sh M packaging/fedora/setup/engine_validators.py M packaging/fedora/spec/ovirt-engine.spec.in 7 files changed, 43 insertions(+), 101 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8955 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I819e37224288b202d2126cec475ee1d97f83a925 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed unnecessary 'continue' statements
by lhornyak＠redhat.com 06 Nov '12

06 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: Removed unnecessary 'continue' statements ...................................................................... engine: Removed unnecessary 'continue' statements Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff Signed-off-by: Shireesh Anjal <sanjal(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeAdvancedDetails.java 2 files changed, 20 insertions(+), 33 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I98b93b739db7d41384cf6455e43e0b4f3182d2ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: SEAT - call startPollingAsyncTasks on revert
by derez＠redhat.com 06 Nov '12

06 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: SEAT - call startPollingAsyncTasks on revert ...................................................................... core: SEAT - call startPollingAsyncTasks on revert Calling startPollingAsyncTasks on internalEndWithFailure (needed for rollback when executing SEAT). Change-Id: I7c8fb8fdbf2b89eb6d3949c0eec233d9dc3535dc Bug-Url: https://bugzilla.redhat.com/872316 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9040 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c8fb8fdbf2b89eb6d3949c0eec233d9dc3535dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: localize number of VMs for Hosts Load
by ecohen＠redhat.com 06 Nov '12

06 Nov '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: localize number of VMs for Hosts Load ...................................................................... webadmin: localize number of VMs for Hosts Load In the Hosts grid (both in Hosts main tab and Hosts sub-tab in Clusters main tab), changed the string concatenation of "[x] VMs" to a localized full phrase, to ease localization of this phrase. Change-Id: I0c9e1a6115bf7a3ab7a8a018015335c6d87d3e24 Bug-Url: https://bugzilla.redhat.com/871293 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterHostView.java 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9082 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c9e1a6115bf7a3ab7a8a018015335c6d87d3e24 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0