December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fix empty quota in updateVM pass
by dfediuck＠redhat.com 04 Dec '12

04 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix empty quota in updateVM pass ...................................................................... core: Fix empty quota in updateVM pass When vm is running and have no quota, updateVM does not check quota validity for empty quota. The rule for adding quotaConsumptionParameter was changed so that null or empty quota would be passed to the QuotaManager for validation. Change-Id: I5b4c782c7c2dd3a70a19e8ed82ab5e180495eb6d Bug-Url: https://bugzilla.redhat.com/882809 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9654 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b4c782c7c2dd3a70a19e8ed82ab5e180495eb6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: remove python syntax checks
by Alon Bar-Lev 04 Dec '12

04 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: remove python syntax checks ...................................................................... packaging: remove python syntax checks Change-Id: Ief73920695726f31cb62fd6d7212b0a8d58c4f4f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9697 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief73920695726f31cb62fd6d7212b0a8d58c4f4f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: packaging: remove python syntax checks
by Alon Bar-Lev 04 Dec '12

04 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: remove python syntax checks ...................................................................... packaging: remove python syntax checks Change-Id: I77a7a9d2fd57b7d8a82282e5874699e6871c4055 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M otopi.spec.in 1 file changed, 1 insertion(+), 7 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77a7a9d2fd57b7d8a82282e5874699e6871c4055 Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core:encrypt vds_static pm_password field on ..."
by emesika＠redhat.com 04 Dec '12

04 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: Revert "core:encrypt vds_static pm_password field on ..." ...................................................................... Revert "core:encrypt vds_static pm_password field on ..." This reverts commit 4f1e4704c169664bde1c128e718dbdc4a94a99a3 This change was supposed to be d/s Only and was pushed upstream as a result of misunderstanding between me & Moran G --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/tools/engine-config/src/main/resources/engine-config.properties 2 files changed, 9 insertions(+), 10 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifebdee1ea19cbfa8ef1a28ace77c33ef81c39372 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: switch tab with space key
by tjelinek＠redhat.com 04 Dec '12

04 Dec '12

Tomas Jelinek has submitted this change and it was merged. Change subject: userportal,webadmin: switch tab with space key ...................................................................... userportal,webadmin: switch tab with space key It is now possible to switch tab in a dialog that contains multiple tabs by pressing the space key when the header of the tab we want to switch to is focused Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTab.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9637 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Ordering Networks by Name
by msalem＠redhat.com 04 Dec '12

04 Dec '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Ordering Networks by Name ...................................................................... engine: Ordering Networks by Name This patch changes the underlying query of NetworkDAO.getAllForCluster to return a list ordered by network name, to be presented that way in the client. Change-Id: I309c66afb9785226c9cbb9d753175504fd3203fe Bug-Url: https://bugzilla.redhat.com/855886 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/NetworkDAOTest.java 2 files changed, 18 insertions(+), 6 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9573 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I309c66afb9785226c9cbb9d753175504fd3203fe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing adding/editting domains bug
by yzaslavs＠redhat.com 04 Dec '12

04 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing adding/editting domains bug ...................................................................... tools: Fixing adding/editting domains bug Due to fix of https://bugzilla.redhat.com/show_bug.cgi?id=871591 a regression was introduced. There was an attempt to read the domain from an improper place, thus ending in DNS srv queries to an "empty domain" Bug-Url: https://bugzilla.redhat.com/883074 Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd87 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/DomainsConfigurationEntry.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java 2 files changed, 17 insertions(+), 38 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9683 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iebfc85569ba1aa8bd840f7239f83b7f921a4bd87 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Bump package version to 3.2.0
by juan.hernandez＠redhat.com 04 Dec '12

04 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Bump package version to 3.2.0 ...................................................................... packaging: Bump package version to 3.2.0 This patch changes the version number in the POMs and in the spec of the RPMs to 3.2.0. Change-Id: Id39be86095362259e2e44aba1517fe9564dea956 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile M backend/manager/dbscripts/pom.xml M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/beans/pom.xml M backend/manager/modules/beans/scheduler/pom.xml M backend/manager/modules/bll/pom.xml M backend/manager/modules/common/pom.xml M backend/manager/modules/compat/pom.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/engineencryptutils/pom.xml M backend/manager/modules/pom.xml M backend/manager/modules/restapi/interface/common/jaxrs/pom.xml M backend/manager/modules/restapi/interface/common/pom.xml M backend/manager/modules/restapi/interface/definition/pom.xml M backend/manager/modules/restapi/interface/pom.xml M backend/manager/modules/restapi/jaxrs/pom.xml M backend/manager/modules/restapi/pom.xml M backend/manager/modules/restapi/types/pom.xml M backend/manager/modules/restapi/webapp/pom.xml M backend/manager/modules/root/pom.xml M backend/manager/modules/searchbackend/pom.xml M backend/manager/modules/utils/pom.xml M backend/manager/modules/vdsbroker/pom.xml M backend/manager/pom.xml M backend/manager/tools/engine-config/pom.xml M backend/manager/tools/engine-notifier/engine-notifier-resources/pom.xml M backend/manager/tools/engine-notifier/engine-notifier-service/pom.xml M backend/manager/tools/engine-notifier/pom.xml M backend/manager/tools/engine-tools-common/pom.xml M backend/manager/tools/pom.xml M backend/pom.xml M build-tools-root/checkstyles/pom.xml M build-tools-root/ovirt-checkstyle-extension/pom.xml M build-tools-root/pom.xml M ear/pom.xml M frontend/api/genericapi/pom.xml M frontend/api/pom.xml M frontend/pom.xml M frontend/wars/pom.xml M frontend/wars/rmw-war/pom.xml M frontend/webadmin/modules/frontend/pom.xml M frontend/webadmin/modules/gwt-common/pom.xml M frontend/webadmin/modules/gwt-extension/pom.xml M frontend/webadmin/modules/pom.xml M frontend/webadmin/modules/uicommonweb/pom.xml M frontend/webadmin/modules/uicompat/pom.xml M frontend/webadmin/modules/userportal-gwtp/pom.xml M frontend/webadmin/modules/webadmin/pom.xml M frontend/webadmin/pom.xml M packaging/engine-setup.8 M packaging/engine-upgrade.8 M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 53 files changed, 59 insertions(+), 56 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id39be86095362259e2e44aba1517fe9564dea956 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Fixing engine-config install properties for fc18
by juan.hernandez＠redhat.com 04 Dec '12

04 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Fixing engine-config install properties for fc18 ...................................................................... packaging: Fixing engine-config install properties for fc18 The following patch is required after upgrade in apache-commons-configurtion from version 1.6 (fc17) to 1.8 (fc18) Looks like this framework is more restrictive on the properties file format. The suggested patch works also for apache-commons-configuration-1.6 Bug-Id: https://bugzilla.redhat.com/879916 Change-Id: I52c53990fa7440107ddc14ceba58b1971340a818 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M packaging/fedora/setup/engine-config-install.properties 1 file changed, 30 insertions(+), 30 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52c53990fa7440107ddc14ceba58b1971340a818 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: packages: reconfigure vdsm using the old method
by Alon Bar-Lev 03 Dec '12

03 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: packages: reconfigure vdsm using the old method ...................................................................... vdsm: packages: reconfigure vdsm using the old method Temporary workaround for old vdsm for libvirt reconfigure trigger. Change-Id: I64ae3f38707fffb5815dd014ed40ee84798ceb5e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=881611 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/packages.py 1 file changed, 20 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9685 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64ae3f38707fffb5815dd014ed40ee84798ceb5e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0