December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core:Power Management: restart operatio..(#865385)
by emesika＠redhat.com 05 Dec '12

05 Dec '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Power Management: restart operatio..(#865385) ...................................................................... core:Power Management: restart operatio..(#865385) core:Power Management: restart operation fails occasionally Currently we are performing the following in the Restart command 1) send Stop command to the fence agent 2) wait for 'off' status by sampling the agent status command 3) send Start command to the fence agent 4) wait for 'on' status by sampling the agent status command There are some cases in which the Start command can fail but the engine will still try to get the 'on' status and give up after the configured retries. The reason is that the Start & Stop command are async and we only get success for the fence script invocation. In the case that the Agent & Host uses the same power supply the Start may fail, therefor we had decided that in any case that we fail to Start the Host after the configurable retries, we will send additional Start command to cover such a case. Change-Id: I1e6a515fb246d86778d359f26ce26eae8e52ebc5 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 45 insertions(+), 20 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e6a515fb246d86778d359f26ce26eae8e52ebc5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix for cpuPinning
by dfediuck＠redhat.com 05 Dec '12

05 Dec '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: fix for cpuPinning ...................................................................... core: fix for cpuPinning vcpu number was matched only as single decimal limit, so if you have more than 10 vcpus, pinning vcpus numbered over 9 always produced a validation error Change-Id: I8d2f7a01baebdbfb86a6de01dd1017c2d56a6285 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/VmManagementCommandBaseTest.java 2 files changed, 23 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8d2f7a01baebdbfb86a6de01dd1017c2d56a6285 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: Fixing npe at notification service log
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: Fixing npe at notification service log ...................................................................... tools: Fixing npe at notification service log Both MAIL_FORM and MAIL_USER are not mandatory to send a notification, but if a notification sending has failed the log message uses the from object (which is set either by using MAIL_FROM if exists at the configuration , or by MAIL_USER if MAIL_FROM doesn't exist in the configuration). The log is fixed to handle possible NPEs Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880597 Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9726 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup on notification service resource closing
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Cleanup on notification service resource closing ...................................................................... core: Cleanup on notification service resource closing This patch introduces DbUtils for DB-related helper methods. It uses these methods to perform quiet resource closing at the NotificationService Bug-Id: https://bugzilla.redhat.com/882847 Change-Id: I54fb540ee52255f017933b000b9b509c4e156123 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/db/DbUtils.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 3 files changed, 65 insertions(+), 74 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9740 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c4e156123 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: tools: DB connections improvement at notifier
by yzaslavs＠redhat.com 05 Dec '12

05 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: tools: DB connections improvement at notifier ...................................................................... tools: DB connections improvement at notifier A performance issue (and maybe not the only one) exists at NotificationService: There is a loop over the result-set representing the event subscrirbers. As long as the result-set object is active the connection is held. in each iteration there is an attempt to send mail - this operation may take time. The patch seperates the DB extraction of subscribers from the logic that is done with each one of them. This patch also adds a close to a connection at the method updateAuditLogEventProcessed Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=882847 Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Signed-off-by: Yair Zaslasky <yzaslavs(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/NotificationService.java 1 file changed, 34 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9735 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54fb540ee52255f017933b000b9b509c2e056122 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Packaging: remove CABaseDirectory from engine-config-install...
by juan.hernandez＠redhat.com 05 Dec '12

05 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: Packaging: remove CABaseDirectory from engine-config-install.properties ...................................................................... Packaging: remove CABaseDirectory from engine-config-install.properties The parameter CABaseDirectory in engine-config-install.properties is not being used anymore and can no longer by updated with engine-config tool and as such should be removed from the setup. Bug-URL : https://bugzilla.redhat.com/show_bug.cgi?id=882874 Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 Signed-off-by: Ohad Basan <obasan(a)redhat.com> --- M packaging/fedora/setup/engine-setup.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <obasan(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Martin Pavlik <xpavli44(a)gmail.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin, userportal: fix LoginPopupView style in IE9
by derez＠redhat.com 05 Dec '12

05 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin,userportal: fix LoginPopupView style in IE9 ...................................................................... webadmin,userportal: fix LoginPopupView style in IE9 Editors labels must be manually hidden only for IE9 (IE8 behaves correctly). Change-Id: I1a8648db21b32c58cc63ed0d00735fcd4148f7ad Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/login/view/LoginPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/login/view/LoginPopupView.java 2 files changed, 15 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9652 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1a8648db21b32c58cc63ed0d00735fcd4148f7ad Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: update internal keys of manage-domains
by rgolan＠redhat.com 05 Dec '12

05 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: update internal keys of manage-domains ...................................................................... core: update internal keys of manage-domains due to latest commons-configuration update a key in property file must contain an equal sign otherwise its ignored. see also http://gerrit.ovirt.org/#/c/9504/ and https://bugzilla.redhat.com/879916 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=883846 Change-Id: I00266bfb81b7fe3bd0ad707dc2f8fa536b966f2c Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/conf/kerberos/engine-manage-domains 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I00266bfb81b7fe3bd0ad707dc2f8fa536b966f2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: bridge: support bridge over bond interface
by Alon Bar-Lev 05 Dec '12

05 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: bridge: support bridge over bond interface ...................................................................... vdsm: bridge: support bridge over bond interface Change-Id: Iace6ca78e494811f91b9df94b5312a0518cfcf78 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M src/plugins/ovirt-host-deploy/vdsm/bridge.py 2 files changed, 33 insertions(+), 19 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iace6ca78e494811f91b9df94b5312a0518cfcf78 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Use .pgpass from home in dev env
by juan.hernandez＠redhat.com 05 Dec '12

05 Dec '12

Juan Hernandez has submitted this change and it was merged. Change subject: core: Use .pgpass from home in dev env ...................................................................... core: Use .pgpass from home in dev env We use the .pgpass file from /etc/ovirt-engine in production environments, but this doesn't exist or is not available in most development environments, so we should try to use the file from user's home directory. If we don't do that the create_db_devel.sh script keeps asking for the database password for ever. Change-Id: I87e36c169dcf3a0aa1914ed46ccea068231d6b6d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/dbcustomfunctions.sh 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I87e36c169dcf3a0aa1914ed46ccea068231d6b6d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0